=== harlowja_away is now known as harlowja | ||
=== alexpilotti_ is now known as alexpilotti | ||
spandhe | mhayden: hey! I made a few changes to the IPv6 commit.. saw some issues earlier with a scenario with multiple NICs.. fixed that and updated the unittests.. http://bazaar.launchpad.net/~shraddha-pandhe/cloud-init/cloud-init-ipv6-support/revision/1036 and http://bazaar.launchpad.net/~shraddha-pandhe/cloud-init/cloud-init-ipv6-support/revision/1037 | 19:58 |
---|---|---|
harlowja | more easily reviewable @ | 19:59 |
harlowja | https://code.launchpad.net/~shraddha-pandhe/cloud-init/cloud-init-ipv6-support/+merge/242547 | 19:59 |
* mhayden ganders | 20:00 | |
harlowja | damn ubuntu format! | 20:00 |
harlowja | lol | 20:00 |
harlowja | someday we'll get off that | 20:00 |
* mhayden crosses fingers for github one day ;) | 20:01 | |
mhayden | spandhe: i can't see anything problematic in those commits | 20:01 |
mhayden | thanks for working on those | 20:02 |
spandhe | mhayden: in rev 1035, on lines 87 and 88, there was an issue | 20:03 |
spandhe | dev_name was used outside of the loop.. and that loop iterates over the interfaces.. | 20:04 |
spandhe | actually, not outside of the loop, but it wasn’t initialized.. | 20:04 |
mhayden | ah okay | 20:05 |
=== harlowja is now known as harlowja_away | ||
=== harlowja_away is now known as harlowja |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!