jw4 | Unit tests enhancement by monkey patching utils.NewUUID : PTAL http://reviews.vapour.ws/r/537/ | 00:04 |
---|---|---|
axw | jogging with god, that's deep | 01:02 |
axw | wallyworld_: get me to look at what? | 01:02 |
wallyworld_ | axw: thumper fixed it, the previous fix for tools symlinks broke upgrades from 1.20 | 01:03 |
axw | oh :/ I'll take a look to see what I did wrong... | 01:03 |
wallyworld_ | https://github.com/juju/juju/pull/1226 | 01:03 |
axw | thanks | 01:03 |
wallyworld_ | axw: see comment on https://bugs.launchpad.net/bugs/1396792 | 01:04 |
mup | Bug #1396792: jujuc symlink creation broken on upgrade to 1.21.beta4 <regression> <tools> <juju-core:Triaged by waigani> <juju-core 1.21:Triaged> <https://launchpad.net/bugs/1396792> | 01:04 |
axw | ah, I see. | 01:05 |
=== menn0_ is now known as menn0 | ||
=== _thumper_ is now known as thumper | ||
=== kadams54 is now known as kadams54-away | ||
thumper | wallyworld_: FWIW upgrading from 1.21 -> 1.22 has the tools with their full paths, so the current code works... | 02:17 |
wallyworld_ | ok, ta | 02:19 |
wallyworld_ | it's just 1.20 then | 02:19 |
thumper | wallyworld_: just 1.21 | 02:20 |
thumper | which has landed | 02:20 |
thumper | it was the 1.20 -> 1.21 upgrade that was buggered | 02:20 |
wallyworld_ | yeah, that's what i meant | 02:20 |
thumper | so we should be good now | 02:21 |
wallyworld_ | great, ty | 02:21 |
thumper | although I think I'd like some tests added to ensure that the symlinks are absolute rather than relative | 02:21 |
axw | wallyworld_ anastasiamac_: FYI ericsnow is doing some work to do with exposing AZs to units. this will be relevant for zone constraints | 02:44 |
wallyworld_ | ok, ta | 02:44 |
axw | as his work will require that we store the zone in state | 02:44 |
wallyworld_ | axw: is there a spec for his work do you know? | 02:45 |
axw | wallyworld_: I think it's https://docs.google.com/a/canonical.com/document/d/1yVlzgKqfhKccUbm3WcZBq7WnzglBygknscr_I_u4bUg/edit# | 02:46 |
axw | not sure if there's anything else | 02:46 |
wallyworld_ | i'll read, thanks | 02:46 |
=== kadams54 is now known as kadams54-away | ||
=== kadams54-away is now known as kadams54 | ||
menn0 | review for fix of bug 1396796 please: http://reviews.vapour.ws/r/538/ | 03:08 |
mup | Bug #1396796: local provider all-machines.log has only machine-0 <local-provider> <regression> <juju-core:In Progress by menno.smits> <juju-core 1.21:In Progress by menno.smits> <https://launchpad.net/bugs/1396796> | 03:08 |
menn0 | thumper: ^^^ | 03:08 |
=== kadams54 is now known as kadams54-away | ||
* thumper looks | 03:10 | |
=== kadams54-away is now known as kadams54 | ||
=== kadams54 is now known as kadams54-away | ||
=== kadams54-away is now known as kadams54 | ||
=== kadams54 is now known as kadams54-away | ||
menn0 | wallyworld_: I this today while investigating other issues: bug 1396862 | 04:04 |
mup | Bug #1396862: Panic when deploying to the bootstrap node <juju-core:New> <https://launchpad.net/bugs/1396862> | 04:04 |
wallyworld_ | oh joy | 04:05 |
menn0 | yeah, and I can't make it happen again | 04:05 |
wallyworld_ | Fix Committed :-) | 04:06 |
menn0 | wallyworld_: so that's how you guys get so many bugs fixed.... | 04:07 |
wallyworld_ | :-D | 04:07 |
=== TheRealMue is now known as TheMue | ||
wallyworld_ | axw: this wget certificate stuff is giving me the shits. i've tried several ways to get it to work. i even tried extracting the certificate from the running web server (in case I was using the wrong pem on disk) as per these instructions http://lnotestoself.blogspot.com.au/2011/02/wget-and-ssl-certificates.html | 04:10 |
wallyworld_ | so far i've had no luck without the --no-check-certificate | 04:11 |
axw | wallyworld_: I'll have a play | 04:12 |
axw | right after I have some lunch | 04:12 |
wallyworld_ | axw: ok. i had to generate the pem file as we weren't writing out the one for the state server from what i could see | 04:13 |
wallyworld_ | i could have cut and pasted from env-get also | 04:13 |
wallyworld_ | but writing it out on state server startup work, generating the same data as I got from using firefox to get the cert | 04:14 |
* wallyworld_ bbiab | 04:16 | |
* thumper EODs | 04:30 | |
menn0 | anyone seen "inconsistent definition for func" errors? | 04:31 |
menn0 | this happen during a merge attempt in Jenkins: http://paste.ubuntu.com/9261637/ | 04:32 |
menn0 | i can't see how it relates to the branch | 04:32 |
axw | wallyworld_: this works for me: juju get-env ca-cert > /tmp/ca-cert.pem && wget --ca-certificate=/tmp/ca-cert.pem https://localhost:17070/tools/1.22-alpha1.1-utopic-amd64 | 04:37 |
axw | menn0: weird. looks like a tooling issue | 04:39 |
wallyworld_ | axw: that seems to work for me also, yet the cert extracted using firefox is different. no idea why | 05:11 |
wallyworld_ | axw: and confusingly, it's not the same cert that's in StateServingInfo | 05:19 |
axw | wallyworld_: StateServingInfo has the server's certificate, not the CA certificate | 05:19 |
axw | the CA certificate signs the server cert; given the CA cert you can prove that the server is trusted by the CA | 05:20 |
wallyworld_ | that makes sense, i know little about ssl sadly | 05:20 |
wallyworld_ | axw: so to make it easy for wget i could do what rsyslog worker does and write out the cert when the state server starts up, or will that be a security issue? | 05:21 |
wallyworld_ | i guess that ingo is already in env-get so no | 05:22 |
axw | wallyworld_: you shouldn't need to do that | 05:22 |
axw | CA cert is in the env config, you should just write it out as a temporary file when you write the wget wrapper | 05:22 |
wallyworld_ | i didn't want to have to invoke juju get-env each time | 05:23 |
wallyworld_ | but i guess i coud | 05:23 |
axw | wallyworld_: hold on, let me refresh my memory about your branch | 05:23 |
wallyworld_ | right now i generate the wget wrapper each time | 05:24 |
wallyworld_ | but i could do it once somewhere | 05:24 |
axw | I think this is happening infrequently enough that that is fine | 05:24 |
wallyworld_ | ok | 05:26 |
axw | wallyworld_: if you have the ImageURLGetter return a CA certificate as well, it can use that. the API client already has the CA certificate in memory | 05:26 |
wallyworld_ | yeah, i'll look into how to make it as nice as possible | 05:27 |
wallyworld_ | first gotta read the news - Phillip Hughes died :-( | 05:27 |
axw | ah :/ | 05:28 |
=== kadams54 is now known as kadams54-away | ||
TheMue | morning | 08:44 |
wallyworld_ | jamespage: you ok for juju status meeting in 10 minutes? hopefully you got the invite | 08:51 |
wallyworld_ | dimitern: can you take a look over bug 1395908? might be related to bug 1345433 which was fixed | 08:52 |
mup | Bug #1395908: LXC containers in pending state but no error message <lxc> <oil> <juju-core:Triaged> <https://launchpad.net/bugs/1395908> | 08:52 |
mup | Bug #1345433: cloud-init network error when using MAAS/juju <cloud-init> <juju> <maas> <network> <cloud-init:Confirmed for smoser> <juju-core:Fix Released by dimitern> <https://launchpad.net/bugs/1345433> | 08:52 |
wallyworld_ | lxc containers that came up got no ip address | 08:53 |
dimitern | wallyworld_, sure, will have a look | 08:53 |
wallyworld_ | hence they stayed in pending | 08:53 |
wallyworld_ | ty | 08:53 |
dimitern | wallyworld_, is it reproducible ? | 08:53 |
wallyworld_ | dimitern: not sure, happened obviously for that maas deployment, not sure if they tried again | 08:54 |
wallyworld_ | i would have said it was fixed, so might be something new | 08:54 |
dimitern | wallyworld_, hmm.. I really like those bug reports :) | 08:54 |
wallyworld_ | yeah | 08:54 |
wallyworld_ | fwereade_: not sure if jamespage is around for juju status meeting | 08:57 |
fwereade_ | wallyworld_, it's 9am in the uk I think? worth waiting around a little | 08:58 |
wallyworld_ | rightio | 08:58 |
wallyworld_ | fwereade_: i won't log in to hangout until he pings back | 08:59 |
axw | fwereade_: (how/where) does juju prevent upgrading a charm when metadata changes incompatibly between revs? | 09:02 |
fwereade_ | axw, inside state, we check for... | 09:02 |
fwereade_ | axw, active relations that have changed or disappeared | 09:02 |
fwereade_ | axw, change in subordinacy | 09:02 |
fwereade_ | axw, not sure about anything else | 09:03 |
axw | fwereade_: cool, that's where I want to look. thanks | 09:03 |
fwereade_ | axw, Service.SetCharm(URL?) I think | 09:03 |
axw | yep | 09:04 |
=== liam_ is now known as Guest33558 | ||
jamespage | wallyworld_, just coming - was travelling | 09:12 |
wallyworld_ | sure, np | 09:12 |
wallyworld_ | gnuoy: are you around for a juju status meeting? | 09:14 |
gnuoy | wallyworld_, sorry, yes. Bad nights sleep last night and I'm still catching up | 09:15 |
wallyworld_ | gnuoy: np at all, we're running alte, just joined the hangout ourselves | 09:15 |
mattyw | morning all | 09:32 |
* fwereade_ going for a walk and a think | 09:51 | |
voidspace | dimitern: I guess most of the Americans are off work today... | 10:01 |
dimitern | voidspace, thanksgiving? right | 10:03 |
dimitern | jam, are you around? | 10:04 |
fwereade_ | dimitern, jam thanksgiving I think | 10:20 |
dimitern | fwereade_, I suspected that, but then again - do they celebrate it in dubai ? :) | 10:24 |
fwereade_ | dimitern, probably not, but he does with his family (and I think he's marked as on holiday) | 10:24 |
dimitern | fwereade_, right, I've missed that | 10:25 |
voidspace | dimitern: ah, panic because I did "if err != nil" where I meant "if err == nil"... | 10:25 |
voidspace | dimitern: :-) | 10:25 |
voidspace | dimitern: so I was returning a nil subnet | 10:25 |
dimitern | voidspace, :) ah, there it is | 10:26 |
voidspace | rerunning the test... | 10:26 |
voidspace | dimitern: and now the test I marked with "XXX this should fail" | 10:26 |
voidspace | dimitern: now it fails | 10:26 |
dimitern | voidspace, \o/ | 10:27 |
voidspace | dimitern: so you were correct - the unique index *was* working, just failing silently | 10:27 |
dimitern | voidspace, good; sorry I didn't mention this earlier | 10:27 |
dimitern | voidspace, it took me a day to discover it initially :) | 10:28 |
voidspace | dimitern: well remembered | 10:28 |
voidspace | dimitern: sounds like a fun day | 10:28 |
dimitern | voidspace, to put it mildly, yeah :) | 10:28 |
voidspace | dimitern: the bad news is that the non-unique provider id triggering the failure is "" | 10:31 |
voidspace | dimitern: so I have to fix that... | 10:32 |
voidspace | dimitern: trying sparse | 10:32 |
voidspace | dimitern: currently indexes doesn't support sparse - I'll have to add it | 10:34 |
dimitern | voidspace, good to know unique indexes do not work with null values out of the box | 10:34 |
dimitern | voidspace, to mgo? | 10:34 |
voidspace | dimitern: no, just our code | 10:34 |
voidspace | dimitern: I have to add a new column to all the index definitions | 10:34 |
dimitern | voidspace, sparse: false ? | 10:35 |
voidspace | dimitern: yep, effectively | 10:36 |
voidspace | dimitern: I have to add a new sparse entry in the index struct - make it false for all the existing ones and true for the new one (subnetsC) | 10:36 |
voidspace | done it, just running the test now | 10:36 |
voidspace | field not column | 10:37 |
dimitern | voidspace, sgtm | 10:37 |
voidspace | dimitern: works | 10:38 |
voidspace | dimitern: I'll need to run the full test suite to make sure I didn't break anything else | 10:38 |
voidspace | I shouldn't have done though - I've just made what was the default before (Sparse: false) explicit | 10:38 |
voidspace | I'll run the whole test suite while I make coffee | 10:39 |
dimitern | voidspace, cheers | 10:40 |
=== mgz is now known as mgz_ | ||
wallyworld_ | jam: in an ec2 environment, i'm trying to connect to the state server using https. but the certificate common name set to "*" causes it to fail | 11:40 |
wallyworld_ | ERROR: certificate common name ''*'' doesn''t match requested host name ''10.73.184.8'' | 11:40 |
wallyworld_ | why do we use "*", and is there a way around it do you know? | 11:40 |
mgz | fwereade_: not that you don't have enough to deal with, but is it possible your last branch (uniter-extract-operations) borked upgrades? | 11:43 |
mgz | fwereade_: http://reports.vapour.ws/releases/2120 | 11:44 |
fwereade_ | mgz, well, I'm certainly not going to say it's impossible, and I admit I didn't try an upgrade with the final version of the code | 11:47 |
fwereade_ | mgz, will investigate | 11:47 |
mgz | fwereade_: thanks, given all the jobs failed I'm pretty certain upgrade is unhappy, but haven't tracked down the whys yet | 11:48 |
fwereade_ | mgz, I see this in the logs: machine-0: 2014-11-26 23:34:18 ERROR juju.worker.upgrader upgrader.go:157 failed to fetch tools from "http://juju-dist.s3.amazonaws.com/testing/tools/releases/juju-1.22-alpha1-precise-amd64.tgz": cannot unpack tools: tarball sha256 mismatch, expected 1d45ea821ab50e719df68d7a887449ff5f63f7d3347b665f2e522a99703a2577, got 00c0b630d88383bf0866a5a9846b1b945cac1936b88242a163d2d84a6eed83aa | 11:49 |
mgz | right, that's what I'm looking at | 11:50 |
fwereade_ | mgz, I don't believe I touched any related code | 11:51 |
mgz | that feels like it should be a non-code issue... but it's only getting generated on the fly in the testing, so am not sure what's changed | 11:51 |
mgz | it must be a fiddling in the simplestreams output in a change somewhere | 11:51 |
fwereade_ | mgz, if I'd broken it I'm 99% sure it would be the uniter failing to come up and complaining about an invalid state file | 11:51 |
fwereade_ | mgz, (which should not happen, and did not happen at least once, fwiw, but if you see it you should certainly blame me) | 11:52 |
mgz | I'll file a bug with no specific blame and we can go from there, I'll also requeue the run to be sure | 11:52 |
fwereade_ | mgz, cheers | 11:52 |
mgz | fwereade_: thanks | 11:52 |
mgz | https://bugs.launchpad.net/juju-core/+bug/1396981 | 12:07 |
mup | Bug #1396981: Upgrade fails with tools sha mismatch <ci> <regression> <upgrade-juju> <juju-core:Triaged> <https://launchpad.net/bugs/1396981> | 12:07 |
dimitern | mgz, rogpeppe1, if any of you is around, can you have a look at this MP for goamz please? https://code.launchpad.net/~dimitern/goamz/update-aws-api-version-to-latest/+merge/243057 | 15:30 |
mgz | dimitern: sure | 15:30 |
dimitern | mgz, ta! | 15:31 |
rogpeppe1 | dimitern: i'm +1 in principle but i'd like assurance that that API version works across all the likely endpoints that people are using goamz for | 15:32 |
dimitern | rogpeppe1, how do you suggest to guarantee that? :) | 15:32 |
rogpeppe1 | dimitern: as a start, i know that aws has different behaviour in different regions, so it would be good to test that that version is available in all aws regions | 15:32 |
rogpeppe1 | dimitern: i've no idea, but i believe that amazon isn't the only provider that people use goamz with | 15:33 |
dimitern | rogpeppe1, the api version is the same for all regions | 15:33 |
rogpeppe1 | dimitern: ok | 15:33 |
rogpeppe1 | dimitern: i'd like to get it ok'd with gustavo before landing it. | 15:33 |
dimitern | rogpeppe1, true, but also there are a lot of forks of goamz for various reasons - not keeping up with the api version changes for now | 15:34 |
dimitern | s/for now/for one/ | 15:34 |
dimitern | rogpeppe1, sure, I intend to | 15:34 |
rogpeppe1 | dimitern: busy now, but i'll take a proper look at some point | 15:34 |
dimitern | rogpeppe1, np, when you can, cheers | 15:35 |
mgz | dimitern: have you tested this on a non-default-vpc account? I guess we're fine in that case the way amazon do their api versioning, but would be nce to check :) | 15:46 |
mgz | actually changing juju to use this goamz ver has some risk, but the change in this codebase would be fine... the complication being that there are also github versions | 15:47 |
voidspace | dimitern: ready for re-review: http://reviews.vapour.ws/r/534/ | 15:53 |
dimitern | voidspace, looking | 15:54 |
dimitern | mgz, I have no access to such an account | 15:55 |
dimitern | mgz, but you're right - it should work just as well | 15:55 |
dimitern | mgz, I did test it on a vpc-only region (us-east-1) though | 15:55 |
dimitern | oh ffs! my full-stop key stopped working | 15:57 |
voidspace | dimitern: restrict yourself to one sentence at a time and you'll be find | 15:57 |
voidspace | *fine | 15:58 |
voidspace | dimitern: and avoid attribute access / method calls | 15:58 |
dimitern | voidspace, :D and don't bother trying to type and struct fields | 15:58 |
dimitern | yeah :) | 15:59 |
voidspace | ... | 15:59 |
voidspace | sorry, just showing off | 15:59 |
mgz | dimitern: reviewed | 16:00 |
dimitern | mgz, thank you | 16:01 |
dimitern | voidspace, reviewed | 16:08 |
voidspace | dimitern: thanks | 16:10 |
voidspace | dimitern: CheckValid was jam's name | 16:10 |
voidspace | dimitern: I'm happy with Validate - don't mind | 16:10 |
dimitern | voidspace, yeah, I'll leave the decision whether to rename it to you, I don't really mind | 16:11 |
voidspace | dimitern: thanks! | 16:12 |
dimitern | voidspace, I do mind about adding isAliveDoc assert in EnsureDead though :) | 16:12 |
voidspace | dimitern: fixing the other two, will make a decision on the third | 16:12 |
voidspace | dimitern: done, just running tests... | 16:12 |
dimitern | voidspace, cheers | 16:12 |
voidspace | and then I'll merge the bugger | 16:12 |
dimitern | voidspace, as you were testing with goamz recently, would you like to have a look at my branch at some point? https://code.launchpad.net/~dimitern/goamz/update-aws-api-version-to-latest/+merge/243057 | 16:13 |
voidspace | dimitern: sure | 16:14 |
dimitern | voidspace, ta! | 16:14 |
voidspace | dimitern: 1025 lines!! | 16:14 |
dimitern | voidspace, yeah, but most of them are simple renames | 16:15 |
voidspace | ah right | 16:15 |
voidspace | :-) | 16:15 |
voidspace | EOD | 18:20 |
voidspace | g'night | 18:20 |
hatch | anyone here able to tell me where on the launchpad website I can find lp:charms/juju-gui ? | 18:44 |
hatch | so confused by it haha | 18:44 |
hatch | oop found it :) | 18:46 |
hatch | ask for help and you find it :D always happens haha | 18:46 |
=== kadams54 is now known as kadams54-away | ||
=== kadams54 is now known as kadams54-away | ||
waigani | menn0: I caught the tail end of what sounded like an interesting bug you hit? | 20:22 |
menn0 | waigani: the one that happened during a merge attempt? | 20:22 |
menn0 | http://paste.ubuntu.com/9261637/ | 20:23 |
menn0 | it only happened once and the next attempt succeeded | 20:23 |
menn0 | and as mwhudson also found, Google has nothing on it | 20:23 |
waigani | hmph, interesting | 20:24 |
=== benonsoftware is now known as \b | ||
=== \b is now known as benonsoftware | ||
waigani | menn0: adds env-uuids to statusDoc: http://reviews.vapour.ws/r/543/ | 20:56 |
menn0 | waigani: sorry... I need to get this CI blocker sorted. I might be a little while. | 20:59 |
waigani | menn0: np | 20:59 |
=== mup_ is now known as mup | ||
=== kadams54 is now known as kadams54-away | ||
menn0 | This is the fix for the CI blocker: http://reviews.vapour.ws/r/544/ | 23:17 |
menn0 | review please | 23:17 |
menn0 | thumper or wallyworld_: can you have a look at review 544 pls? | 23:31 |
wallyworld_ | sure | 23:31 |
menn0 | wallyworld_: thanks | 23:31 |
wallyworld_ | menn0: sorry, just got off phone, looking now | 23:40 |
menn0 | wallyworld_: np | 23:50 |
menn0 | wallyworld_: good catch re the error message. that needs to change with this change in behaviour | 23:53 |
wallyworld_ | yeah, great, i thought so | 23:53 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!