| === urulama_ is now known as urulama | ||
| frankban | rogpeppe1, mhilton : do you have time to take another look at https://github.com/juju/charmstore/pull/233 ? | 09:33 |
|---|---|---|
| rogpeppe1 | frankban: gimme 10 minutes :) | 09:33 |
| frankban | rogpeppe1: sure thanks | 09:33 |
| mhilton | frankban: I'm just trying to QA it now. | 09:34 |
| === rogpeppe1 is now known as rogpeppe | ||
| rogpeppe | frankban: sorry, a very long 10 minutes. now looking :) | 11:30 |
| frankban | :-) | 11:30 |
| rogpeppe | mhilton, frankban: the review for my xml changes is now at https://codereview.appspot.com/179540043/ as requested by brad fitz. | 11:31 |
| frankban | rogpeppe: great, thanks for the link | 11:31 |
| rogpeppe | now with much better testing coverage and a fix resulting from that | 11:31 |
| rogpeppe | frankban: reviewed | 12:02 |
| frankban | rogpeppe: thanks | 12:03 |
| * frankban lunches | 12:14 | |
| === kadams54 is now known as kadams54-away | ||
| === kadams54-away is now known as kadams54 | ||
| === kadams54 is now known as kadams54-away | ||
| === kadams54-away is now known as kadams54 | ||
| === fabrice is now known as fabrice|family | ||
| === fabrice is now known as fabrice|family | ||
| === kadams54 is now known as kadams54-away | ||
| === kadams54 is now known as kadams54-away | ||
| === kadams54-away is now known as kadams54 | ||
| === kadams54 is now known as kadams54-away | ||
| === kadams54 is now known as kadams54-away | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!