[00:07] hatch: sure [00:07] hatch: is this one done/ready for review? [00:07] ah, I see it is in there now [00:07] hatch: maybe try to get one review from Makyo or huwshimi while they're around (not sure how much longer that's true) [00:12] rick_h_: yep it's all ready now [00:13] ok will do [00:28] Can't get selenium tests to even run, much less pass >:/ [00:28] Seems selenium can't find firefox or something. [00:28] that's odd...any errors? [00:29] * hatch__ is trying out this terminal irc thingy (weechat) :) [00:29] Yeah, it can't load the firefox profile anymore. [00:29] hmm I've never seen that error before [00:29] http://paste.ubuntu.com/9374600/ [00:30] apparently I have to hold ctrl to click links in this thing :) [00:31] hatch: middle-click ftw [00:31] :) [00:31] Makyo: is this locally? [00:31] Makyo: or on CI? [00:31] apparently I don't have a middle click....clicking the scroll wheel does not appear to work [00:32] rick_h_, locally. The one on CI I got around by `make clean-all && make build` [00:32] hatch: well then you need a better mouse [00:32] Or...that was two of them ago. [00:32] hatch: so sucks if the one I got you doesn't have middle-click [00:32] Either way, it's an environment problem, not a test problem (so far) [00:33] rick_h_: haha well we'll see - I just got weechat running so I may be doing something wrong [00:34] initially however I'm really liking it [00:34] can bomb around the controls pretty fast [00:34] need to see if I can see all the channels/servers in a list somwhere though.. [00:35] oh they call them 'buffers' [00:35] at least now I know what to search for :D [00:36] /whois hatch_ [00:37] hmm [00:38] niiice now I have that working [00:38] /ghost hatch [00:38] haha [00:38] says hatch_ is taken, but whois returns nothing [00:38] No, srsly, that's how you boot your dead selfs [00:38] Huh [00:39] oh there it is [00:39] must have been a typo or something [00:39] yup someone else is hatch_ :/ [00:39] You put a space in front of it. [00:39] lame sauces [00:40] * hatch__ <--- real slim shady [00:40] Best stand up, then [00:40] that's funnier to me because you're like... super-canadian. [00:40] hahahaha [00:40] wha my name is, who my name is, wha my name is, chicka chicka slim shady! [00:41] Oy gevalt [00:41] well so far I'm digging weechat [00:41] now if only I could make vim be sublime then I'd only need chrome and terminal :) [00:42] And your journey to the nerd side will be complete. [00:42] Actually, that journey's end is when you can make vim into chrome. [00:43] lol does links count? [00:43] I used to use links. [00:44] I just can't figure out why sublime and terminal use the identical font but render it totally different [00:44] it's irritating me because I want terminal to look like sublime :) [00:44] In OSX? Good luck. [00:45] no I'm all Ubuntu now [00:45] Ubumini IS ALIVE! [00:45] Oh, well then you just need to alter your /etc/cfg/nobody-gaf.conf [00:45] (trollface) [00:45] rofl! [00:46] I gotta ressurect my gaming machine. It was running ubuntu, but the graphics card *hates* the nouveau drivers. [00:46] And ununtu hates my mouse. It's a lot of hate in that family of silicon. [00:46] haha [00:48] it takes something like 25s longer to run lint on ubumini than on my MBP [00:48] *sadface* [00:49] they put some fast stuff in there [00:49] What's an ubumini? [00:49] macmini with ubuntu on it :P [00:49] Sounds like a kind of dog. [00:49] it's actually an old mini, probably 2011 era [00:51] Reminder: Mac Minis are basically Macbook Air's with a fatter hard drive. [00:51] this true [00:53] it's actually a pretty smart piece of hardware [00:53] when I put more ram and a SSD in it, I was impressed by how it all fits together [00:53] It is. I really like the Mac Mini. [00:53] unfortunately now they are all soldered/glued [00:53] The new ones are? That's too bad. [00:53] yeah :/ [00:54] Seems like a double-helping of "missing the point" [01:04] huwshimi: think you'll have time today to do that review? [01:16] hatch: Yep, probably won't get to it till after lunch though [01:16] If that's OK [01:17] hatch: It's not a small review... [01:19] haha no, no it's not [01:19] anytime is fine - I'm not going to need it again until the morning :) [01:20] Great :) [01:49] is it correct to state there is no 1.5 quickstart love for OSX? [01:49] it is looking like brew is only finding 1.4 :-/ [01:49] https://code.launchpad.net/~bac/juju-quickstart/brew-commands looks last updated back in may [01:52] arosales_: that's an oversight on our part if there's no 1.5. [01:52] rick_h_: I am checking . . . [01:53] I may have a cached .rb on this OSX machine [01:53] looks like brew search finds it [01:54] arosales_: yea, the formula is 1.5 https://github.com/Homebrew/homebrew/blob/9b63c2864d890a137e0e841ea043a0aad58cc20a/Library/Formula/juju-quickstart.rb [01:54] in brew trunk [01:54] rick_h_: ok, thanks for verifying [01:54] np, thanks for mentioning it. I know I forget about brew sometimes [02:00] rick_h_: ok 1.5 looks to be downloaded [02:00] rick_h_: sorry for the false alarm [02:01] * arosales_ grabs some dinner [02:16] teslanick: you're back - did ya rage quit? :D [02:17] No, I decided to eat something === kadams54 is now known as kadams54-away [02:56] hmm being connected to two servers is confusing - I can easily see myself accidentally typing in the wrong channel...wonder if there is a way to better separate them === kadams54 is now known as kadams54-away === kadams54-away is now known as kadams54 [04:28] huwshimi: I'm looking at your branch right now [04:29] hatch: Ah thanks. It's horrible, I wouldn't look at it if I were you [04:30] where are these remove/addClass methods defined? [04:31] hatch: Just to remove the duplication of having to do that same thing five times [04:31] hatch: YUI is not available. [04:31] hatch: As I say, it's horrible. [04:32] ohh ok [04:32] I'm guessing you didn't know about element.classList.add() and .remove() :) [04:32] ... [04:32] Can I just finish for the day then? [04:32] lol [04:32] I'll comment in the PR [04:33] hey, at least I stopped in to take a peek haha [04:33] hatch: Thank you :) [04:37] huwshimi: ok done reviewing [04:37] hatch: Thanks! [04:39] :) np [04:49] huwshimi: mind sending me a PM? I'd like to see how weechat handles it === kadams54 is now known as kadams54-away [05:10] yes [05:10] lol [05:10] I thought for a second there I screwed something up [05:10] * hatch is trying to figure out weechat :) [05:10] ok so why do you have to mock it out? [05:11] hatch: My irc client defaults to #juju-dev when it opens up [05:11] I thought that you were passing the element in ? [05:11] for some reason [05:11] oh hhah [05:11] hatch: I am, only so that in the test I can pass in a mock (I assume that's why it has been set up that way) [05:11] oh, why don't you pass in an element? [05:12] hatch: I assume because the dom is not ready when we execute this js [05:12] it doesn't need to be https://developer.mozilla.org/en-US/docs/Web/API/document.createElement [05:13] element.classList.... is a JS representation of the DOM element (JSDOM) so as long as you pass in something similar it won't care if the dom is ready or not [05:13] Or I could do that... [05:13] :) [05:14] with that said however....the DOM should be available in that test [05:15] but if you're just unit testing it then yeah might as well just use the above method [05:15] method above* [05:16] hatch: Oh, I might have been having issues as I was trying to use our getDocument() method [05:16] which obviously wouldn't work there [05:17] But neither is this :( [05:17] is it throwing an error? [05:18] Error: INVALID_CHARACTER_ERR: DOM Exception 5 [05:18] oo fun [05:18] Might be that we're overwriting it var document = getDocument(); [05:19] and then getDocument = function() { [05:19] what do you have for your createElement line? [05:19] that error is usually because of that [05:19] the arguments passed to that method [05:19] var logoutMock = document.createElement('

'); [05:20] document.createElement('div') [05:20] createElement takes a 'tagName' as it's first argument [05:21] Ah [05:21] yeah the YUI wrapper hides all that stuff away in the background [05:21] it essentially takes a string and creates the respective commands [05:28] huwshimi: got it all working? [05:28] hatch: Yep, all good, thanks for that [05:28] np I'm off, have a good weekend! [05:29] hatch: Thanks have a good one! [09:17] uiteam: morning [09:17] morning [09:17] a change of servers? :) [09:20] mhilton: hiya [09:21] uiteam: Could I get a second review of https://github.com/juju/charmstore/pull/248 please? and a QA [09:42] mhilton: looking [12:49] hatch: external links please :P === kadams54 is now known as kadams54-away === kadams54-away is now known as kadams54 [15:13] rick_h_: oops sorry [15:13] I just figured out scrollback :) [15:13] huh? [15:13] in weechat [15:13] I didn't see your msg [15:13] which one? [15:13] * rick_h_ is lost/confused [15:13] external links [15:13] still confused [15:14] about 3h ago you said "external links please :P" [15:15] hatch: in another channel [15:15] ? [15:15] * rick_h_ is so confused [15:15] hmm [15:16] 06:49:15 rick_h_ | hatch: external links please :P [15:17] maybe mentions from all channels go into this window? Now I'm wondering if I broke something setting this up lol [15:32] rick_h_: I would like to land that branch today just in case the api release gets delayed :) [15:32] unless you're pretty confident that's not going to happen [15:32] hatch: understand, I've ok'd it as is [15:32] thnks [15:50] uiteam call in 10 kanban please [15:57] sheesh I ordered some boots which had overnight shipping 6 days ago - they are being delivered today [15:58] so much for under promise over deliver [17:39] I think I'm going to run for an early lunch === kadams54 is now known as kadams54-away === kadams54-away is now known as kadams54 [19:14] Makyo: any luck with your functional tests? [19:15] rick_h_, no luck yet. Trying to get sauce connect up and running so I can run them locally. === kadams54 is now known as kadams54-away [20:03] uiteam running up against a wall with sauceconnect, keep getting 502 Bad Gateway. Anyone have luck running selenium tests locally? [20:04] Makyo: can sauce reach your machine from outside? [20:05] Makyo: I usually do 'local' sauce tests on ec2 or the like [20:05] because I've had issues with incoming requests on my network [20:05] oh, that makes sense. Probably easier than screwing with my netowkr. [20:05] Or network, for that matter. [20:05] :) hope it helps! [20:05] can someone mention me? I want to see if dings are working now [20:06] Makyo: just claim CI [20:06] Makyo: ssh to it, start the server, run it from there and you know sauce can talk to it [20:06] hatch ping [20:06] rick_h_, ah, alright, will do [20:07] it is not working :/ well I'll have to investigate after eod === kadams54 is now known as kadams54-away [20:58] Hmm, I'm wondering if fetching charms and bundles should always return a promise... [20:58] or remove the promise bit entirely === kadams54-away is now known as kadams54 [20:58] ^ Makyo you probably have some input in this :) [20:58] :T [20:59] I really like the idea of promises, just not the implementation. [20:59] I'd say move away from promises, hatch. [20:59] If we're looking at moving away from YUI, I suggest as few little bits of it in place as possible. [21:00] I'd be ok with that - I just don't want to have to implement both like the current charmworld api [21:00] makes it confusing to work with [21:00] Ahh, yeah [21:00] promiseBundle isn't actually ever used [21:00] lol [21:01] Oy [21:01] actually tbh I don't see why we need a bundle and charm charmworld api endpoint now that they are on equal footing [21:02] If there [21:03] 's a way to simplify, great [21:03] yeah this saves probably 50+ loc's from the charmstore api [22:18] Makyo: better progress on CI? [22:19] hatch: as for the two endpoings, we can simplify but we have to note the diff in charm vs bundle metadata [22:20] rick_h_: well the client will request data from the endpoint and then the supplied callbacks will handle what's returned [22:20] hatch: sure, just saying there's still a little diff in the two things that needs some <3 [22:21] oh yeah for sure [22:21] maybe I'll run into an issue when I pass the details into the tesseract === kadams54 is now known as kadams54-away