| === kadams54-away is now known as kadams54 | ||
| hatch | hey Makyo you around? | 02:20 |
|---|---|---|
| rick_h_ | hatch: no, not looked at that | 03:34 |
| hatch | alright | 03:36 |
| hatch | I'm tracking down a failure who's traceback is in yui and mocha lol | 03:39 |
| hatch | yep a test failure...getting caught by a promise :/ | 03:44 |
| rick_h_ | hatch: you shouldn't be looking at that :P | 03:44 |
| hatch | haha I want to try and start tomorrow with a clean slate | 03:44 |
| hatch | ok down to 14 failing tests | 04:32 |
| hatch | clean enough slate | 04:32 |
| hatch | unfortunately some metadata files needed to be changed - and even more will need to be changed to do the charm page | 04:33 |
| hatch | Showing 20 changed files with 739 additions and 357 deletions. | 04:33 |
| hatch | bleh | 04:33 |
| huwshimi | ouch | 04:36 |
| hatch | heh more tomorrow :) | 04:38 |
| hatch | I might be done with debugging promises though | 04:38 |
| hatch | so that's nice | 04:38 |
| hatch | lol | 04:38 |
| === kadams54 is now known as kadams54-away | ||
| === kadams54-away is now known as kadams54 | ||
| === kadams54 is now known as kadams54-away | ||
| hatch | hmm looks like I have https://bugs.launchpad.net/ubuntu/+source/compiz/+bug/969860 which has either been fixed or invalid :/ | 14:34 |
| mup | Bug #969860: fglrx uses 100% CPU when screen turns off (spinning in glXWaitVideoSyncSGI or glXSwapBuffers) <amd64> <apport-bug> <battery-power-consumption> <compiz-0.9> <precise> <qa-manual-testing> <quantal> <reproducible> <rls-mgr-p-tracking> <ubuntu> <Compiz:Invalid> <Compiz 0.9.8:Invalid> | 14:34 |
| mup | <Compiz Core:Invalid> <fglrx:Confirmed> <The Ubuntu Power Consumption Project:Fix Released> <compiz (Ubuntu):Invalid by canonical-dx-team> <fglrx-installer (Ubuntu):Fix Released> <fglrx-installer-updates (Ubuntu):Fix Released> <gnome-shell (Ubuntu):Invalid> <https://launchpad.net/bugs/969860> | 14:34 |
| urulama | hatch: on mac? | 14:54 |
| hatch | urulama: mac hardware | 15:09 |
| hatch | urulama: I'm running ubuntu on metal on the mini | 15:09 |
| urulama | hatch: i know, that's why i'm asking. is it intel or radeon graphics card? | 15:10 |
| hatch | the only other problem i've found is the bluetooth finds things but won't connect to them (the internal bluetooth) | 15:10 |
| hatch | urulama: it's the intel one | 15:10 |
| hatch | I don't think you can get a mini with a discrete gpu | 15:10 |
| hatch | at least you couldn't back when this was made | 15:11 |
| urulama | hah, right, mixed it up with old macbooks | 15:12 |
| hatch | oh these test failures are here because they require a 'basket' | 15:34 |
| hatch | maybe I should have just started with charms lol | 15:34 |
| hatch | somehow I had 14 failing tests, fixed 3 and now I have 13 | 15:51 |
| hatch | what kind of black magic is this | 15:52 |
| frankban | uiteam call in 7 kanban now | 15:53 |
| hatch | now up to 19 failures | 15:59 |
| hatch | lol | 15:59 |
| Makyo | uiteam network problems again, trying to get in the call - if I can't make it in: nothing to note on my cards, nothing to note for the day | 16:06 |
| frankban | Makyo: ok thanks | 16:06 |
| === kadams54 is now known as kadams54-away | ||
| hatch | google play does a pretty good job picking songs that I like | 16:37 |
| hatch | need to save a large data structure for tests? JSON.stringify(results).replace(/\"/g, "'"); | 16:40 |
| hatch | save so much time :) | 16:40 |
| === kadams54 is now known as kadams54-away | ||
| === kadams54-away is now known as kadams54 | ||
| hatch | Nirvana - Smells like teen spirit :) | 16:58 |
| hatch | what a blast from the past | 16:58 |
| urulama | hatch: followed by Enter Sandman? :) | 17:05 |
| hatch | haha no another Nirvana song | 17:05 |
| hatch | but I'm sure that's in the queue | 17:05 |
| urulama | i had the same LOL moment yesterday with itunes "genious" ... during the "nothing works" part of release, it picked up jay-z's 99 problems :) | 17:07 |
| urulama | sometimes i wish i had google glasses just to record those ... | 17:07 |
| hatch | haha | 17:07 |
| hatch | aww yeah 0 test failures | 18:09 |
| hatch | now the question is...does the app still work :P | 18:10 |
| urulama | hatch: the tests never lie! :D | 18:59 |
| hatch | no - but they might not have all the correct information :D | 19:00 |
| hatch | so this branch introduces some more regressions when not using search results because more things are converted to apiv4 from v3 | 19:27 |
| hatch | which will mean that until this conversion is done we likely can't push another gui release | 19:27 |
| urulama | so the search works, but the tests need to adapt fully, if i understand correctly? | 19:28 |
| hatch | well tbh I'm not sure what's going on - the GUI is now getting featured results in the 'interesting' query which don't even exist | 19:29 |
| hatch | so I have no idea if this is something broken from the conversion or broken because apiv3 is broken | 19:29 |
| urulama | can you paste me the qeuries you're using? | 19:30 |
| hatch | I've also had to modify the tokens so that they work with apiv4 so that's likely causing some issiues with apiv3 data | 19:30 |
| hatch | ok one sec | 19:30 |
| hatch | https://manage.jujucharms.com/api/3/charm/elasticsearch/15/cluster | 19:30 |
| hatch | is one of the charms returned by the list | 19:30 |
| hatch | returned by the v3 query | 19:30 |
| * urulama starts listening Zelda music, feels like being on a quest :) | 19:31 | |
| hatch | I'd be ok with just saying we can't make a release but would like at least one more +1 :) | 19:31 |
| urulama | ;) | 19:32 |
| urulama | elasticsearch bundle does not exist in new CS due to clash in name | 19:33 |
| hatch | ok sounds like we just can't get around this | 19:34 |
| urulama | which i now think might be an error, as we can call it elasticsearch-cluster (looking at the name and bucket) | 19:34 |
| hatch | oh ok | 19:34 |
| urulama | but it is currently rejected by ingestion | 19:35 |
| hatch | yeah and there are others - I don't htink that there is going to be any way around this | 19:36 |
| hatch | the bundles detail pages use apiv4 but the non-search results are from apiv3 | 19:36 |
| === kadams54 is now known as kadams54-away | ||
| hatch | so the id's are different, content is different | 19:36 |
| hatch | etc | 19:36 |
| hatch | next step is either to fix those results or do the charm details page - either one will have the cart/horse issue | 19:37 |
| urulama | why not use details from v4 all the time? | 19:38 |
| hatch | it took me 5 days to convert the bundle details page from apiv3 to 4 | 19:39 |
| hatch | :) | 19:39 |
| hatch | that's why | 19:39 |
| hatch | lol | 19:39 |
| urulama | but you're an expert now, surely you can do it in 2 days now :D | 19:39 |
| hatch | haha maybe | 19:39 |
| hatch | actually I think I'm going to do the landing-page results first | 19:40 |
| urulama | yeah, until you mix v3 and v4 there will be problems | 19:40 |
| hatch | urulama: is there an api endpoint for 'most popular' or something like that? | 19:40 |
| urulama | i believe that you'll spend more time patching the difference in bundle syntax then doing full v4 switch | 19:40 |
| urulama | lemme check | 19:40 |
| hatch | urulama: right - that's what I was doing the past 5 days | 19:41 |
| hatch | but the default landing results are from v3 which is totally different than what the bundle details page expects | 19:41 |
| hatch | so I'll do that next | 19:41 |
| urulama | hatch: we order things by download (trusty & bundles first) | 19:41 |
| hatch | the charms at least keep the id's the same | 19:41 |
| urulama | so you can do https://api.jujucharms.com/v4/search?text=&owner=&limit=10 and get 10 most popular | 19:41 |
| hatch | works for me thanks | 19:42 |
| urulama | or https://api.jujucharms.com/v4/search?series=bundle&text=&owner=&limit=3 and get 3 top bundles | 19:42 |
| hatch | honestly - atm I just want something to put there, we can tweak it later :) | 19:42 |
| urulama | hatch: note that this is for latest series, if you want precise then https://api.jujucharms.com/v4/search?series=precise&text=&owner=&limit=3 | 19:42 |
| hatch | we'll probably want some kind of a 'consolidated most popular' endpoint for this | 19:43 |
| urulama | adding &include=stats would give you the numbers as well | 19:43 |
| hatch | can eco feature things in apiv4? | 19:43 |
| urulama | and that means ... ? :) | 19:43 |
| hatch | https://demo.jujucharms.com/ the top section :) | 19:44 |
| hatch | 5 featured | 19:44 |
| urulama | ok, lemme try | 19:44 |
| hatch | in last discussed we were going to only list the most popular or something along those lines but I figure that we should probably also maintain the ability to feature things | 19:45 |
| urulama | https://api.jujucharms.com/v4/search?series=precise&text=&owner=&limit=3&sort=-downloads&include=stats | 19:45 |
| urulama | there you go | 19:45 |
| urulama | omit include=stats if numbers are not needed | 19:46 |
| urulama | ah, sorry, wrong | 19:46 |
| urulama | https://api.jujucharms.com/v4/search?text=&owner=&limit=3&sort=-downloads&include=stats | 19:46 |
| urulama | this one | 19:46 |
| urulama | sorts by downloads | 19:46 |
| === kadams54-away is now known as kadams54 | ||
| hatch | ok so no more 'featured' ? | 19:46 |
| urulama | not for now | 19:47 |
| hatch | ok no problem | 19:47 |
| hatch | thanks for the help | 19:47 |
| urulama | it's planned for v5 | 19:47 |
| urulama | np, just ask, i was just starting to get into "bring it on" zone :D | 19:47 |
| hatch | haha nah I just want this conversion done then we can revisit stuff to add features back | 19:50 |
| hatch | uiteam I need two reviews and qa's on https://github.com/juju/juju-gui/pull/676 plz and thx | 19:52 |
| Makyo | hatch, looking. | 19:52 |
| hatch | yes it's massive | 19:52 |
| hatch | sorry | 19:52 |
| hatch | :) | 19:52 |
| hatch | I've got to step away for a big | 19:53 |
| hatch | bit | 19:53 |
| hatch | bbiab | 19:53 |
| === kadams54 is now known as kadams54-away | ||
| hatch | Makyo: how goes? Any issues so far? | 20:24 |
| Makyo | hatch, just trying to pick what's just a name change and what's a functionality change. Haven't QAd yet | 20:24 |
| hatch | ok np - it did take me forever to do it so don't worry if it take some time to go through | 20:25 |
| hatch | lemme know if you have any questions | 20:25 |
| Makyo | damnit, running into CORS problems again. | 20:36 |
| Makyo | Chrome seems to remember if there was EVER a CORS issue in the past, then NEVER fixes it. | 20:37 |
| hatch | lol! | 20:37 |
| Makyo | Er, never allows from that domain. | 20:37 |
| Makyo | Huh. Guess that means the GUI will never work for me outside an incognito window. | 20:42 |
| hatch | that's very odd | 20:43 |
| hatch | can't clear the cache or anything? | 20:43 |
| Makyo | I have, no luck. | 20:44 |
| Makyo | Haven't tried clearing all browser data, though. | 20:44 |
| Makyo | Will do that in a bit. | 20:44 |
| Makyo | hatch, QA looks okay, but I'm going to have to go back over the code at least once more. | 20:57 |
| hatch | sure thanks | 20:58 |
| hatch | uiteam, anyone else around for another review? | 21:04 |
| rick_h_ | hatch might look tomorrow we'll see | 23:55 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!