=== kadams54-away is now known as kadams54 [02:20] hey Makyo you around? [03:34] hatch: no, not looked at that [03:36] alright [03:39] I'm tracking down a failure who's traceback is in yui and mocha lol [03:44] yep a test failure...getting caught by a promise :/ [03:44] hatch: you shouldn't be looking at that :P [03:44] haha I want to try and start tomorrow with a clean slate [04:32] ok down to 14 failing tests [04:32] clean enough slate [04:33] unfortunately some metadata files needed to be changed - and even more will need to be changed to do the charm page [04:33] Showing 20 changed files with 739 additions and 357 deletions. [04:33] bleh [04:36] ouch [04:38] heh more tomorrow :) [04:38] I might be done with debugging promises though [04:38] so that's nice [04:38] lol === kadams54 is now known as kadams54-away === kadams54-away is now known as kadams54 === kadams54 is now known as kadams54-away [14:34] hmm looks like I have https://bugs.launchpad.net/ubuntu/+source/compiz/+bug/969860 which has either been fixed or invalid :/ [14:34] Bug #969860: fglrx uses 100% CPU when screen turns off (spinning in glXWaitVideoSyncSGI or glXSwapBuffers)

[14:34]

[14:54] hatch: on mac? [15:09] urulama: mac hardware [15:09] urulama: I'm running ubuntu on metal on the mini [15:10] hatch: i know, that's why i'm asking. is it intel or radeon graphics card? [15:10] the only other problem i've found is the bluetooth finds things but won't connect to them (the internal bluetooth) [15:10] urulama: it's the intel one [15:10] I don't think you can get a mini with a discrete gpu [15:11] at least you couldn't back when this was made [15:12] hah, right, mixed it up with old macbooks [15:34] oh these test failures are here because they require a 'basket' [15:34] maybe I should have just started with charms lol [15:51] somehow I had 14 failing tests, fixed 3 and now I have 13 [15:52] what kind of black magic is this [15:53] uiteam call in 7 kanban now [15:59] now up to 19 failures [15:59] lol [16:06] uiteam network problems again, trying to get in the call - if I can't make it in: nothing to note on my cards, nothing to note for the day [16:06] Makyo: ok thanks === kadams54 is now known as kadams54-away [16:37] google play does a pretty good job picking songs that I like [16:40] need to save a large data structure for tests? JSON.stringify(results).replace(/\"/g, "'"); [16:40] save so much time :) === kadams54 is now known as kadams54-away === kadams54-away is now known as kadams54 [16:58] Nirvana - Smells like teen spirit :) [16:58] what a blast from the past [17:05] hatch: followed by Enter Sandman? :) [17:05] haha no another Nirvana song [17:05] but I'm sure that's in the queue [17:07] i had the same LOL moment yesterday with itunes "genious" ... during the "nothing works" part of release, it picked up jay-z's 99 problems :) [17:07] sometimes i wish i had google glasses just to record those ... [17:07] haha [18:09] aww yeah 0 test failures [18:10] now the question is...does the app still work :P [18:59] hatch: the tests never lie! :D [19:00] no - but they might not have all the correct information :D [19:27] so this branch introduces some more regressions when not using search results because more things are converted to apiv4 from v3 [19:27] which will mean that until this conversion is done we likely can't push another gui release [19:28] so the search works, but the tests need to adapt fully, if i understand correctly? [19:29] well tbh I'm not sure what's going on - the GUI is now getting featured results in the 'interesting' query which don't even exist [19:29] so I have no idea if this is something broken from the conversion or broken because apiv3 is broken [19:30] can you paste me the qeuries you're using? [19:30] I've also had to modify the tokens so that they work with apiv4 so that's likely causing some issiues with apiv3 data [19:30] ok one sec [19:30] https://manage.jujucharms.com/api/3/charm/elasticsearch/15/cluster [19:30] is one of the charms returned by the list [19:30] returned by the v3 query [19:31] * urulama starts listening Zelda music, feels like being on a quest :) [19:31] I'd be ok with just saying we can't make a release but would like at least one more +1 :) [19:32] ;) [19:33] elasticsearch bundle does not exist in new CS due to clash in name [19:34] ok sounds like we just can't get around this [19:34] which i now think might be an error, as we can call it elasticsearch-cluster (looking at the name and bucket) [19:34] oh ok [19:35] but it is currently rejected by ingestion [19:36] yeah and there are others - I don't htink that there is going to be any way around this [19:36] the bundles detail pages use apiv4 but the non-search results are from apiv3 === kadams54 is now known as kadams54-away [19:36] so the id's are different, content is different [19:36] etc [19:37] next step is either to fix those results or do the charm details page - either one will have the cart/horse issue [19:38] why not use details from v4 all the time? [19:39] it took me 5 days to convert the bundle details page from apiv3 to 4 [19:39] :) [19:39] that's why [19:39] lol [19:39] but you're an expert now, surely you can do it in 2 days now :D [19:39] haha maybe [19:40] actually I think I'm going to do the landing-page results first [19:40] yeah, until you mix v3 and v4 there will be problems [19:40] urulama: is there an api endpoint for 'most popular' or something like that? [19:40] i believe that you'll spend more time patching the difference in bundle syntax then doing full v4 switch [19:40] lemme check [19:41] urulama: right - that's what I was doing the past 5 days [19:41] but the default landing results are from v3 which is totally different than what the bundle details page expects [19:41] so I'll do that next [19:41] hatch: we order things by download (trusty & bundles first) [19:41] the charms at least keep the id's the same [19:41] so you can do https://api.jujucharms.com/v4/search?text=&owner=&limit=10 and get 10 most popular [19:42] works for me thanks [19:42] or https://api.jujucharms.com/v4/search?series=bundle&text=&owner=&limit=3 and get 3 top bundles [19:42] honestly - atm I just want something to put there, we can tweak it later :) [19:42] hatch: note that this is for latest series, if you want precise then https://api.jujucharms.com/v4/search?series=precise&text=&owner=&limit=3 [19:43] we'll probably want some kind of a 'consolidated most popular' endpoint for this [19:43] adding &include=stats would give you the numbers as well [19:43] can eco feature things in apiv4? [19:43] and that means ... ? :) [19:44] https://demo.jujucharms.com/ the top section :) [19:44] 5 featured [19:44] ok, lemme try [19:45] in last discussed we were going to only list the most popular or something along those lines but I figure that we should probably also maintain the ability to feature things [19:45] https://api.jujucharms.com/v4/search?series=precise&text=&owner=&limit=3&sort=-downloads&include=stats [19:45] there you go [19:46] omit include=stats if numbers are not needed [19:46] ah, sorry, wrong [19:46] https://api.jujucharms.com/v4/search?text=&owner=&limit=3&sort=-downloads&include=stats [19:46] this one [19:46] sorts by downloads === kadams54-away is now known as kadams54 [19:46] ok so no more 'featured' ? [19:47] not for now [19:47] ok no problem [19:47] thanks for the help [19:47] it's planned for v5 [19:47] np, just ask, i was just starting to get into "bring it on" zone :D [19:50] haha nah I just want this conversion done then we can revisit stuff to add features back [19:52] uiteam I need two reviews and qa's on https://github.com/juju/juju-gui/pull/676 plz and thx [19:52] hatch, looking. [19:52] yes it's massive [19:52] sorry [19:52] :) [19:53] I've got to step away for a big [19:53] bit [19:53] bbiab === kadams54 is now known as kadams54-away [20:24] Makyo: how goes? Any issues so far? [20:24] hatch, just trying to pick what's just a name change and what's a functionality change. Haven't QAd yet [20:25] ok np - it did take me forever to do it so don't worry if it take some time to go through [20:25] lemme know if you have any questions [20:36] damnit, running into CORS problems again. [20:37] Chrome seems to remember if there was EVER a CORS issue in the past, then NEVER fixes it. [20:37] lol! [20:37] Er, never allows from that domain. [20:42] Huh. Guess that means the GUI will never work for me outside an incognito window. [20:43] that's very odd [20:43] can't clear the cache or anything? [20:44] I have, no luck. [20:44] Haven't tried clearing all browser data, though. [20:44] Will do that in a bit. [20:57] hatch, QA looks okay, but I'm going to have to go back over the code at least once more. [20:58] sure thanks [21:04] uiteam, anyone else around for another review? [23:55] hatch might look tomorrow we'll see