| === kadams54 is now known as kadams54-away | ||
| === kadams54 is now known as kadams54-away | ||
| === kadams54-away is now known as kadams54 | ||
| === kadams54 is now known as kadams54-away | ||
| jrwren | kadams54: would you take py3 compat pr's on switchboardpy? again, for my own time, not work time :) | 14:25 |
|---|---|---|
| kadams54 | jrwren: yup | 14:26 |
| urulama | jrwren: why your own time? this helps, so it's UI time :) | 14:27 |
| jrwren | urulama: *shrug* itty bitty side project. I don't think we run python3 in our web apps. | 14:31 |
| hatch | uiteam need one more review and qa https://github.com/juju/juju-gui/pull/676 | 15:12 |
| kadams54 | hatch: looking | 15:12 |
| hatch | thanks - grab a coffee | 15:12 |
| hatch | it's big | 15:12 |
| hatch | :) | 15:12 |
| hatch | uiteam call in 8 | 15:52 |
| urulama | frankban, jcsackett call | 16:00 |
| hatch | urulama: I have a working version of the 'featured' results lists and it all works so it won't block release once this lands | 17:23 |
| hatch | just fyi | 17:23 |
| hatch | (even if the results are a little suspect :) | 17:23 |
| urulama | hatch: big difference? | 17:24 |
| hatch | huge heh | 17:25 |
| hatch | speed is super nice though :) | 17:25 |
| hatch | urulama: it'll be fine for now - but there are certain 'top' results that don't make any sense | 17:25 |
| hatch | like why do you need to see the gui charm in the gui :) | 17:25 |
| urulama | hatch: like? | 17:25 |
| hatch | it'll always be on the top | 17:25 |
| hatch | _always_ | 17:25 |
| hatch | :) | 17:25 |
| urulama | shameless self-promotion? | 17:26 |
| urulama | :) | 17:26 |
| hatch | haha | 17:26 |
| urulama | but, yeah, it's not "featured" | 17:26 |
| hatch | yeah, and some will always be on top so I'm not sure how much I like the results...but whatever it's fast and works for now | 17:26 |
| urulama | i expect to have that solved by mid-January. and i guess that search is more important than just featured. we can do that if it is really really needed | 17:29 |
| urulama | (the featured) | 17:29 |
| hatch | yeah I think that sidebar is still in a bit of flux right now as to what should be the default view and whatnot so it'll be fine until we resolve what we want it to do | 17:30 |
| hatch | urulama: do we have an eta on the removal of the duplicate results of promulgated charms/bundles? I just added the filter in the FE but would like to make a note as to when this may be removed | 17:58 |
| urulama | hatch: same 2nd half of Jan | 17:59 |
| hatch | got it thx | 17:59 |
| hatch | urulama: featured results list is done, just writing/fixing tests now :) looks like I did something correct when writing the new api :D | 18:02 |
| urulama | accidents happen :) | 18:03 |
| hatch | lol | 18:03 |
| hatch | got to reboot - something is holding on to ports | 18:04 |
| rick_h_ | hatch just manually filter the gui out. It's specific to the client in this case | 18:09 |
| rick_h_ | the client can be smart asbout stuff | 18:09 |
| urulama | rick_h_: http://25.media.tumblr.com/tumblr_ly977cNcFM1qg6fobo1_500.jpg | 18:12 |
| urulama | :) | 18:12 |
| rick_h_ | I cant get link out of mt tablet irc client :P | 18:12 |
| hatch | urulama: lol! | 18:12 |
| rick_h_ | well ssh to irssi client I think it haytes either tmux or irssi | 18:13 |
| rick_h_ | so :P | 18:13 |
| hatch | so pumped that this conversion of the featured list was so easy | 18:14 |
| rick_h_ | :) | 18:14 |
| hatch | love it when things work out like planned | 18:14 |
| hatch | stepping away for lunch | 18:16 |
| === kadams54 is now known as kadams54-away | ||
| hatch | lazyPower: mbruzek looks like the version of Ghost with the email provider support has made it through review https://jujucharms.com/ghost/precise/2 | 20:36 |
| lazyPower | hatch: bazinga | 20:37 |
| mbruzek | booyah | 20:37 |
| mbruzek | Nice job hatch | 20:37 |
| hatch | now I just have to get on that darn haproxy redirect | 20:37 |
| hatch | haproxy docs suck the big one lol | 20:37 |
| === kadams54-away is now known as kadams54 | ||
| mbruzek | rick_h_: Are you there? | 21:10 |
| hatch | uiteam lf two reviews and a qa on https://github.com/juju/juju-gui/pull/677 | 21:12 |
| hatch | mbruzek: he is gone | 21:12 |
| mbruzek | hatch: OK thanks | 21:12 |
| hatch | anything I can help with? | 21:12 |
| mbruzek | hatch: why does the juju-gui charm fail proof? | 21:12 |
| mbruzek | not proof, automated testing | 21:12 |
| kadams54 | hatch: 677 is the one you wanted me to QA? | 21:12 |
| hatch | kadams54: yup plz | 21:12 |
| hatch | mbruzek: can you point me to the log? | 21:13 |
| hatch | aiui it should pass | 21:13 |
| mbruzek | http://reports.vapour.ws/charm-tests-by-charm | 21:13 |
| mbruzek | hatch http://reports.vapour.ws/charm-tests/charm-bundle-test-10545-results | 21:14 |
| hatch | mbruzek: juju-test CRITICAL: /var/lib/jenkins/.juju/environments.yaml file does not exist | 21:15 |
| hatch | and that one you linked looks like it was abandoned? | 21:16 |
| mbruzek | hatch I can re-run the tests, but the critical one looks like the test is not compatible with the way CI runs tests | 21:20 |
| hatch | hmm that's possible - if you wouldn't mind re-running just to be sure | 21:22 |
| hatch | kadams54: lots of removed code in this branch to accomplish almost the identical functionality :) | 21:29 |
| kadams54 | yay | 21:33 |
| kadams54 | hatch: in the charmbrowser I see "Recommended" and "Other" | 21:36 |
| kadams54 | hatch: is that correct? I was expecting "Recommended" to be gone and "Other" to be "Popular" or something similar | 21:39 |
| hatch | nope they are just ones which are promulgated and ones which aren't | 21:39 |
| kadams54 | hatch: here's the recommended I see: http://cl.ly/image/2c2P3b1G221Y | 21:40 |
| hatch | yeah | 21:40 |
| kadams54 | And here are the others: http://cl.ly/image/0w0d351V1E0C | 21:40 |
| kadams54 | I realize mysql is precise for recommended and trusty for others, but it seems potentially confusing | 21:41 |
| hatch | very | 21:41 |
| hatch | :) | 21:41 |
| hatch | not much else we can do until we get better endpoints to work with unfortunately | 21:41 |
| kadams54 | And juju-gui/precise is actually duplicated between recommended and others | 21:41 |
| hatch | oh it is isn't it | 21:41 |
| hatch | that's odd... | 21:41 |
| hatch | ohh right | 21:41 |
| hatch | gui isn't owned by charmers | 21:42 |
| kadams54 | I know there's some dupe removal code in there… wasn't sure if it was supposed to be catching that | 21:42 |
| hatch | ok that's a bug | 21:42 |
| hatch | I'll remove the gui entirely from the search results | 21:42 |
| hatch | well... | 21:42 |
| hatch | nah | 21:42 |
| hatch | i'll just remove the duplication | 21:42 |
| kadams54 | OK, commented in the PR | 21:43 |
| hatch | thank yas | 21:44 |
| hatch | uiteam anyone else still around able to do the other review? | 21:45 |
| kadams54 | hatch: Gotta run now. Once that dupe bug is fixed, I'm fine with landing. | 21:46 |
| hatch | thanks | 21:46 |
| === kadams54 is now known as kadams54-away | ||
| rick_h_ | hatch: we have denormalized api data now right? | 22:44 |
| rick_h_ | hatch: and I vote we only pull the promulgated most popular, and we talked at one point of pulling extra so we could randomize them a bit? | 22:47 |
| hatch | rick_h_: oh is there a promulgated flag? | 22:55 |
| hatch | I guess I could do 'owner charmers' | 22:55 |
| hatch | rick_h_: https://api.jujucharms.com/charmstore/v4/search?limit=10&sort=-downloads&owner=charmers&limit=30&include=charm-metadata&include=bundle-metadata&include=extra-info&include=stats | 22:56 |
| hatch | that seems like a pretty reasonable result set | 22:58 |
| rick_h_ | hatch use owners= | 23:01 |
| rick_h_ | (blank) | 23:01 |
| rick_h_ | that'll only get promulgated | 23:01 |
| hatch | oh? | 23:01 |
| hatch | ahh | 23:01 |
| rick_h_ | it's what we use for the /solutions page | 23:01 |
| rick_h_ | hatch standup real quick? | 23:01 |
| hatch | sure | 23:02 |
| hatch | doing this will result in a little more work because I'll need a new template but no biggy | 23:03 |
| rick_h_ | daily ot friday? | 23:03 |
| hatch | i'm in daily now | 23:03 |
| rick_h_ | k sec | 23:03 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
