/srv/irclogs.ubuntu.com/2014/12/16/#juju-gui.txt

=== kadams54-away is now known as kadams54
=== kadams54 is now known as kadams54-away
=== kadams54-away is now known as kadams54
rick_h_hatch: miss another reviewq/qa before landing?02:27
=== kadams54_ is now known as kadams54-away
=== kadams54-away is now known as kadams54_
hatchoh yeah woops :/ I think I got the two mixed up 03:50
hatchalthough 677 still needs that final qa03:50
rick_h_hatch: k, can try tomorrow03:57
rick_h_hatch: don't forget you had a review today too04:06
rick_h_first thing04:06
rick_h_hatch: and we can check with frankban but I think the charm is fine and we can start the gui release first thing tomorrow04:06
rick_h_just so you're not bored tomorrow04:07
rick_h_:)04:07
* rick_h_ considers caught up enough for tonight04:08
hatchhaha 04:34
=== kadams54_ is now known as kadams54-away
=== nottrobin__ is now known as nottrobin_
=== nottrobin_ is now known as nottrobin
=== alexpilotti_ is now known as alexpilotti
hatchkadams54: can you do another review of 677 so I can land it?14:44
kadams54hatch: Sure, taking a look14:45
kadams54hatch: is the juju-gui charm supposed to be filtered out?15:03
hatchkadams54: I didn't because it only shows up sometimes now15:05
kadams54k15:05
hatchooo ghost added xml sitemaps15:05
kadams54QA is OK15:06
hatchthanks15:07
hatchrick_h_: hey you mentioned that I should start looking at doing a gui release? 15:20
hatchstill looking like that's good?15:20
rick_h_hatch: let's verify with frankban but last I recall we don't need gui charm changes so release is unblocked15:20
frankbanrick_h_: confirmed15:21
hatchoh? none of the quickstart changes effect the gui?15:21
hatchnice15:21
hatchok I'll start qa'ing15:21
hatchthe related charms section in charm details page has all the icons broken 15:49
hatchwill need to fix that15:50
rick_h_hatch: rgr15:52
rick_h_hatch: can you add a card please?15:52
hatchalready done :)15:52
rick_h_ty15:52
rick_h_uiteam call in 10 kanban please15:52
hatchhttps://api.jujucharms.com/charmstore/v4/yui_3_11_0_1_1418744920875_6993/icon.svg15:53
hatchheh nope that's not right15:53
hatch:)15:53
hatchboom fixed!15:58
hatchI still think this page makes no sense15:58
hatchlol15:58
hatchanother time!15:58
frankbanuiteam: I need reviews/QA for https://codereview.appspot.com/188300043 (quickstart / python). anyone available?16:34
=== kadams54 is now known as kadams54-away
hatchuiteam I need a review and qa for a small bug fix (release blocker)16:46
hatchhttps://github.com/juju/juju-gui/pull/67916:46
hatchok just need qa now 16:47
hatchnow this next bug is interesting....quite interesting indeed16:47
=== kadams54-away is now known as kadams54
hatchuiteam ok I now need reviews on #679 and #680 both release blockers17:12
hatchnow onto flag removal17:13
hatchrick_h_: do we have mockups for the login stuff? The markup that the 'showGetJujuButton' references is no longer there17:17
rick_h_hatch: kadams54 jcsackett ^17:19
kadams54hatch: Looking at both.17:20
hatchwe'll need to update the gui charm to not set that config value17:20
hatchthere is some conflicting comments in the code around the logout-trigger button too17:21
hatchsome areas say it can be removed but it's actually being used17:21
hatchkadams54: ok I'm ready to push the removal of this flags stuff - any word on the mockups?17:25
kadams54hatch: I'm very confused at this point. Do you mean mockups for login work in GUI or blues browser?17:26
hatchgui17:26
hatchthis is the gui channel afterall :)17:26
hatchI just can't find anything searching in the drive17:26
kadams54hatch: Not that I've seen.17:26
kadams54Or can remember ;-)17:27
hatchhaha hmm17:27
hatchmaybe it's in the email somewhere17:27
hatchyup email hah17:28
hatchman we need to make a rule that this stuff needs to go in one spot17:28
hatchrick_h_: ok yeah so it looks like the charm will need to be updated to not set this flag 'showGetJujuButton'17:28
hatchcard created17:30
hatchwill get on that next17:30
hatchuiteam reviews and qa's on #680 #681 :D 17:34
kadams54Looking17:34
kadams54Just out of curiosity, how many more of these we got left?17:34
hatch0 for the GUI, 1 for the charm17:34
hatchbut of course I still need to do another round of qa17:35
hatchso....TBD :P17:35
hatchkadams54: fyi you were sent the email with the logout dropdown :P17:35
hatchforgot - new computer, no guicharm branches locally17:47
hatchcya in 2 weeks :P17:47
hatchuiteam I need one more review on #68017:50
hatchkadams54: will you be able to review/qa 681 as well?17:54
kadams54hatch: In progress17:54
hatchthanks17:54
hatchrick_h_: changes to the charm get done in lp:~juju-gui/charms/trusty/juju-gui/trunk/ then merged into precise?17:57
hatchIt's been a while since I've done charm work 17:57
rick_h_hatch: yes 17:57
* rick_h_ has to get food finally off calls17:58
hatchthanks17:58
hatch:)17:58
kadams54hatch: Done on 681.18:01
hatchkadams54: thanks18:04
hatchkadams54: turns out the test failure is because the new logout button is hidden so I need to update the selenium test to open the dropdown first18:07
rick_h_hatch: have reviews?18:11
rick_h_hatch: no pr link in the card in review18:11
hatchdoh did I miss one18:12
hatchupdating18:12
hatchupdated18:12
hatch680 is in need of another review18:13
hatch681 has a selenium failure which I'm fixing18:13
rick_h_k18:13
hatchso a review can hold off on that18:13
hatchok pushed the fix for the selenium tests, hope it works ;)18:18
rick_h_:)18:19
hatchreplied18:19
hatchannnd charm modified18:49
hatchbleh selenium test changes didn't work - looks like I'll have to set it up locally and test18:53
hatchbut first, lunch18:57
=== kadams54 is now known as kadams54-away
=== kadams54-away is now known as kadams54
=== kadams54 is now known as kadams54-away
=== kadams54-away is now known as kadams54
hatchuiteam lf reviews and qa on https://github.com/juju/juju-gui/pull/68222:40
hatchthx22:40
hatch^ rick_h_ the fruits of our discussion (from the GUI side)22:40
=== kadams54 is now known as kadams54-away
=== kadams54-away is now known as kadams54
=== kadams54 is now known as kadams54-away
rick_h_hatch: ty will look23:26
=== kadams54 is now known as kadams54-away

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!