[06:55] <dholbach> good morning
[06:59] <dholbach> dpm, yo yo yo
[07:00] <dholbach> dpm, can you take a look at https://code.launchpad.net/~dholbach/developer-ubuntu-com/1402692/+merge/244773? I'll take a look at importing the templates/translations after that
[07:02] <dholbach> daker, thanks a lot for your help! شكرا بزاف
[07:04] <dpm> morning dholbach, on it
[07:18] <dholbach> hey elfy
[07:20] <dholbach> dpm, you are going to need both ~dholbach/developer-ubuntu-com/1402692 and lp:~dpm/developer-ubuntu-com/django-cms-load-translations
[07:22] <elfy> morning dholbach
[07:24] <dpm> dholbach, sorry, still on it, trying to get some translations for some pages which weren't translated at the same time
[07:24] <dholbach> right right :)
[07:43] <dpm> dholbach, tested and pushed, thanks!
[07:44] <dholbach> yeehaw
[08:35] <dholbach> dpm, part 2: https://code.launchpad.net/~dholbach/developer-ubuntu-com/1402692-part2/+merge/244829
[08:35] <dholbach> dpm, you have to export a tarball from LP
[08:35] <dholbach> then run    manage.py import-translations ~/launchpad-export.tar.gz
[08:35] <dholbach> or wherever you saved the file
[08:36] <dpm> dholbach, the latest trunk already has a translations export, can we not use that?
[08:36] <dholbach> dpm, to me it looks like the files were put in the wrong place
[08:36] <dholbach> locale/de.po
[08:36] <dholbach> vs locale/de/LC_MESSAGES/django.po
[08:37] <dpm> dholbach, yeah, that's what I meant with us having to move things around. LP supports the gettext layout, but django has a bit of a strange mixture layout
[08:37] <dpm> let me look at the MP and comment there
[08:37] <dholbach> ok
[08:38] <dpm> I'd like to remove the manual step of having to request an export from Launchpad, waiting for an e-mail, fix the filenames and paths and commit
[08:40] <dholbach> ok
[08:40] <dholbach> let me know if you found how to do it
[08:40] <dholbach> theoretically there could be a "clean up" script being part of the deployment?
[08:41] <dholbach> but with pofile autocommit we are probably always going to have both locale/de.po and locale/de/LC_MESSAGES/django.po in the branch
[08:41] <dholbach> dpm, symlinks?
[08:42] <dpm> dholbach, yeah, perhaps
[08:53] <dpm> dholbach, I've added my suggestions on the comments. For me the main point is not to use manual launchpad exports
[08:53] <dholbach> right, understood
[08:53] <dpm> let me know if that makes sense
[08:54] <dholbach> that's what we used in the past and I thought here was no way around it, but I think symlinks will work just as wlel
[08:54] <dholbach> I'm working on it
[08:54] <dpm> great
[08:54] <dpm> dholbach, do you know what creates locale/de/LC_MESSAGES/django.po?
[08:55] <dpm> rather than cleaning it up, could we stop them being created?
[08:55] <dholbach> that's where django expects the the .po file for processing it into a .mo file
[08:56] <dpm> dholbach, so it's compilemessages that expects that location? Could we have a custom compilemessages, then?
[08:57] <dholbach> my suggestion would be to create a management command which does everything translations-related: 1) update .pot file, 2) create symlinks from de.po to de/LC_MESSAGES/django.po, 3) run compilemessages, 4) potential cleanup
[08:57] <dholbach> that could then be made part of the deployment charm
[08:57] <dholbach> that way we could just let Launchpad and Django have its way
[08:59] <dholbach> dpm, what do you think? ^
[09:00] <dpm> dholbach, sounds good, but some comments:
[09:01] <dpm> - I think we should still separate it into one command to update the template (which we don't need a full build for, or deployment) and one to do the rest required for the build
[09:01] <dholbach> full build?
[09:02] <dpm> sorry, I meant just build
[09:02] <dholbach> I'm not sure I understand... which build?
[09:02] <dpm> compilemessages, i.e. converting .po files into .mo files
[09:03] <dholbach> hum, ok
[09:03]  * dpm thinks again for a sec
[09:04] <dholbach> in most cases 2)-4) are going to be noops
[09:04] <dholbach> but sure
[09:04] <dholbach> I can make it separate commands
[09:04] <dholbach> that's no problem
[09:04] <dholbach> brb, need another coffee
[09:04] <dpm> My point was that if there are new messages in the app, and we want to expose them to LP, we only need to generate the .pot file, but I see your point too
[09:05] <dpm> so thinking again, your approach sounds great, it could simplify things to have a single translations command
[09:06] <dpm> the last thing I'm not sure about are the symlinks, or whether a custom compilemessages command that moves files around is a better approach. But it's an implementation detail, I'll leave it up to you :)
[09:07] <dholbach> the reason I chose symlinks was that there's little chance they'll get out of date, you create them once and you're done :)
[09:09] <dholbach> and the reason I thought having one translations command would make sense was that I thought, that in eg: a month of development on a branch you have changes to the code, which result in template changes, but you also often have people working on translations, so you might have to add a symlink for a new translation, or run compilemessages again because the .mo files might be out of date, so my thinking was "let's have a deal-with-
[09:09] <dholbach> translations" command :)
[09:10] <dholbach> but it's easy enought to have one command re-use the other
[10:10] <daker> dholbach: yw :)
[10:13]  * dholbach hugs daker
[10:14] <dholbach> dpm, https://code.launchpad.net/~dholbach/developer-ubuntu-com/1402692-take3/+merge/244840
[10:14] <dholbach> let me know what you think
[10:15] <dholbach> I also added a check if a given locale has already been added to settings.LANGUAGES
[10:17] <dpm> nice
[10:17]  * dpm tests
[10:26]  * dholbach watches the building go up in flames
[10:27] <dpm> :)
[10:27] <dpm> dholbach, reviewed, left a couple of comments
[10:28] <dholbach> thank you
[10:31] <dholbach> dpm, on it
[10:40] <dholbach> dpm, updated
[10:49] <dpm> dholbach, looking
[10:53] <dholbach> .
[11:00]  * dholbach lunches
[11:04] <dpm> dholbach, ok, tested it, it seems the symlinks still need fixing
[11:15] <dholbach> dpm, oh?
[11:15] <dholbach> dpm, can you remove the file?
[11:16] <dholbach> dpm, I think it's leftover from the previous attempt
[11:18] <dpm> dholbach, ok, trying on a clean checkout
[11:19] <dholbach> thanks
[11:27] <dpm> dholbach, approved, thanks! Would you mind pushing to the django-cms branch yourself?
[11:27] <dholbach> yeeehaw
[11:27] <dholbach> champagne
[11:27] <dpm> :)
[11:28] <dholbach> sure, will do
[11:28] <dpm> dholbach, while at it, could you review the other MP in pending?
[11:28] <dholbach> yep
[11:28] <dpm> great
[11:37] <dholbach> dpm, good work!
[11:38] <dholbach> dpm, I had to resolve a conflict in .pot (expected) and one in README.md
[11:38] <dholbach> it was just small things
[11:38] <dholbach> so I'll just go ahead and push it
[11:38] <dpm> dholbach, that'd be excellent, thanks
[11:40] <dholbach> done
[11:42] <dholbach> dpm, there are a couple of imports needing review - are they still required? https://translations.launchpad.net/developer-ubuntu-com/+imports
[11:42] <dpm> dholbach, ah, that's probably because we've renamed the template
[11:43]  * dpm fixes
[11:43] <dholbach> all hail the translations overlord!
[11:46] <dholbach> is Ubuntu Mono now used in the code snippets?
[11:47] <dholbach> looks like it
[11:52] <dpm> I think so
[11:58] <dholbach> I was just looking through the developer-ubuntu-com bugs again to see if any of them can be closed with 2.0
[12:19] <dpm> nice, thanks
[12:19] <dpm> dholbach, do you have time for a quick call in 5-10 mins?
[12:19]  * dpm belatedly hugs daker too
[12:21]  * dpm gets something to drink
[12:35] <dholbach> dpm, sure
[12:48] <dholbach> dpm, will /snappy have to be copied as well? (I guess?)
[12:49] <dpm> dholbach, I think I did it already
[12:50] <dholbach> nevermind... you did - I just didn't see it in the spreadsheet
[13:05] <dholbach> jose, dpm and I had a chat and were thinking of moving the Q&A to Friday - mhall119: what do you think?
[13:40] <mhall119> dholbach: that sounds good to me
[13:40] <dholbach> \o/
[15:17] <jose> dholbach: good for me, just let me know so I can move it in the calendar
[15:17] <dholbach> mhall119, dpm: Q&A same time on Friday?
[15:21] <dpm> dholbach, sounds good
[15:21] <dholbach> jose, Friday 16 UTC then, please :)
[15:32] <jose> dholbach: ack! since when?
[15:32] <jose> or just for this week?
[15:32] <dholbach> just for this week
[15:32] <jose> ok!
[15:32] <jose> moved!
[15:35] <dholbach> rock on!
[15:36] <mhall119> dholbach: works for me
[15:36] <dholbach> brb