[06:55] good morning [06:59] dpm, yo yo yo [07:00] dpm, can you take a look at https://code.launchpad.net/~dholbach/developer-ubuntu-com/1402692/+merge/244773? I'll take a look at importing the templates/translations after that [07:02] daker, thanks a lot for your help! شكرا بزاف [07:04] morning dholbach, on it [07:18] hey elfy [07:20] dpm, you are going to need both ~dholbach/developer-ubuntu-com/1402692 and lp:~dpm/developer-ubuntu-com/django-cms-load-translations [07:22] morning dholbach [07:24] dholbach, sorry, still on it, trying to get some translations for some pages which weren't translated at the same time [07:24] right right :) [07:43] dholbach, tested and pushed, thanks! [07:44] yeehaw [08:35] dpm, part 2: https://code.launchpad.net/~dholbach/developer-ubuntu-com/1402692-part2/+merge/244829 [08:35] dpm, you have to export a tarball from LP [08:35] then run manage.py import-translations ~/launchpad-export.tar.gz [08:35] or wherever you saved the file [08:36] dholbach, the latest trunk already has a translations export, can we not use that? [08:36] dpm, to me it looks like the files were put in the wrong place [08:36] locale/de.po [08:36] vs locale/de/LC_MESSAGES/django.po [08:37] dholbach, yeah, that's what I meant with us having to move things around. LP supports the gettext layout, but django has a bit of a strange mixture layout [08:37] let me look at the MP and comment there [08:37] ok [08:38] I'd like to remove the manual step of having to request an export from Launchpad, waiting for an e-mail, fix the filenames and paths and commit [08:40] ok [08:40] let me know if you found how to do it [08:40] theoretically there could be a "clean up" script being part of the deployment? [08:41] but with pofile autocommit we are probably always going to have both locale/de.po and locale/de/LC_MESSAGES/django.po in the branch [08:41] dpm, symlinks? [08:42] dholbach, yeah, perhaps [08:53] dholbach, I've added my suggestions on the comments. For me the main point is not to use manual launchpad exports [08:53] right, understood [08:53] let me know if that makes sense [08:54] that's what we used in the past and I thought here was no way around it, but I think symlinks will work just as wlel [08:54] I'm working on it [08:54] great [08:54] dholbach, do you know what creates locale/de/LC_MESSAGES/django.po? [08:55] rather than cleaning it up, could we stop them being created? [08:55] that's where django expects the the .po file for processing it into a .mo file [08:56] dholbach, so it's compilemessages that expects that location? Could we have a custom compilemessages, then? [08:57] my suggestion would be to create a management command which does everything translations-related: 1) update .pot file, 2) create symlinks from de.po to de/LC_MESSAGES/django.po, 3) run compilemessages, 4) potential cleanup [08:57] that could then be made part of the deployment charm [08:57] that way we could just let Launchpad and Django have its way [08:59] dpm, what do you think? ^ [09:00] dholbach, sounds good, but some comments: [09:01] - I think we should still separate it into one command to update the template (which we don't need a full build for, or deployment) and one to do the rest required for the build [09:01] full build? [09:02] sorry, I meant just build [09:02] I'm not sure I understand... which build? [09:02] compilemessages, i.e. converting .po files into .mo files [09:03] hum, ok [09:03] * dpm thinks again for a sec [09:04] in most cases 2)-4) are going to be noops [09:04] but sure [09:04] I can make it separate commands [09:04] that's no problem [09:04] brb, need another coffee [09:04] My point was that if there are new messages in the app, and we want to expose them to LP, we only need to generate the .pot file, but I see your point too [09:05] so thinking again, your approach sounds great, it could simplify things to have a single translations command [09:06] the last thing I'm not sure about are the symlinks, or whether a custom compilemessages command that moves files around is a better approach. But it's an implementation detail, I'll leave it up to you :) [09:07] the reason I chose symlinks was that there's little chance they'll get out of date, you create them once and you're done :) [09:09] and the reason I thought having one translations command would make sense was that I thought, that in eg: a month of development on a branch you have changes to the code, which result in template changes, but you also often have people working on translations, so you might have to add a symlink for a new translation, or run compilemessages again because the .mo files might be out of date, so my thinking was "let's have a deal-with- [09:09] translations" command :) [09:10] but it's easy enought to have one command re-use the other [10:10] dholbach: yw :) [10:13] * dholbach hugs daker [10:14] dpm, https://code.launchpad.net/~dholbach/developer-ubuntu-com/1402692-take3/+merge/244840 [10:14] let me know what you think [10:15] I also added a check if a given locale has already been added to settings.LANGUAGES [10:17] nice [10:17] * dpm tests [10:26] * dholbach watches the building go up in flames [10:27] :) [10:27] dholbach, reviewed, left a couple of comments [10:28] thank you [10:31] dpm, on it [10:40] dpm, updated [10:49] dholbach, looking [10:53] . [11:00] * dholbach lunches [11:04] dholbach, ok, tested it, it seems the symlinks still need fixing [11:15] dpm, oh? [11:15] dpm, can you remove the file? [11:16] dpm, I think it's leftover from the previous attempt [11:18] dholbach, ok, trying on a clean checkout [11:19] thanks [11:27] dholbach, approved, thanks! Would you mind pushing to the django-cms branch yourself? [11:27] yeeehaw [11:27] champagne [11:27] :) [11:28] sure, will do [11:28] dholbach, while at it, could you review the other MP in pending? [11:28] yep [11:28] great [11:37] dpm, good work! [11:38] dpm, I had to resolve a conflict in .pot (expected) and one in README.md [11:38] it was just small things [11:38] so I'll just go ahead and push it [11:38] dholbach, that'd be excellent, thanks [11:40] done [11:42] dpm, there are a couple of imports needing review - are they still required? https://translations.launchpad.net/developer-ubuntu-com/+imports [11:42] dholbach, ah, that's probably because we've renamed the template [11:43] * dpm fixes [11:43] all hail the translations overlord! [11:46] is Ubuntu Mono now used in the code snippets? [11:47] looks like it [11:52] I think so [11:58] I was just looking through the developer-ubuntu-com bugs again to see if any of them can be closed with 2.0 [12:19] nice, thanks [12:19] dholbach, do you have time for a quick call in 5-10 mins? [12:19] * dpm belatedly hugs daker too [12:21] * dpm gets something to drink === meetingology` is now known as meetingology [12:35] dpm, sure [12:48] dpm, will /snappy have to be copied as well? (I guess?) [12:49] dholbach, I think I did it already [12:50] nevermind... you did - I just didn't see it in the spreadsheet [13:05] jose, dpm and I had a chat and were thinking of moving the Q&A to Friday - mhall119: what do you think? [13:40] dholbach: that sounds good to me [13:40] \o/ [15:17] dholbach: good for me, just let me know so I can move it in the calendar [15:17] mhall119, dpm: Q&A same time on Friday? [15:21] dholbach, sounds good [15:21] jose, Friday 16 UTC then, please :) [15:32] dholbach: ack! since when? [15:32] or just for this week? [15:32] just for this week [15:32] ok! [15:32] moved! [15:35] rock on! [15:36] dholbach: works for me [15:36] brb