[04:31] <pitti> Good morning
[06:48] <didrocks> morning
[06:53] <pitti> bonjour didrocks
[07:00] <didrocks> ça va pitti ?
[07:00]  * didrocks digs into ubuntu archives about the hibernate removal discussion :p
[07:01] <pitti> didrocks: ça va bien, et toi ?
[07:01] <didrocks> pitti: ça va bien ! Il fait encore un peu trop nuit pour aller faire du vélo avant la pluie :)
[07:02] <pitti> oui, c'est encore sombre ici aussi
[07:34] <mlankhorst> Hello, world!
[07:37] <didrocks> hey mlankhorst!
[07:39] <mlankhorst> bonjour
[07:40] <mlankhorst> ca va?
[07:43] <didrocks> ça va bien ! et toi ? :)
[07:43] <mlankhorst> ca va :p
[07:47] <pitti> hmm, did anyone try ubuntu-desktop-next? I just tried the amd64 one on my thinkpad, and I don't get very far
[07:48] <pitti> I see the "welcome to your phone" wizard coming up (using only a small part of my external screen, and only rendering halfway on the internal one)
[07:48] <pitti> I can move the mouse cursor, but that's it -- no clicking, no "continue", no changing lanugage, keyboard doesn't do anything, etc.
[07:48] <pitti> Laney: ^
[07:51] <didrocks> pitti: did you try only with one monitor?
[07:51] <didrocks> I know multiple monitors are not supported yet, so maybe that's what puzzle Mir?
[07:52] <pitti> only external one would be ok too :)
[07:52] <pitti> no, I didn't try yet, I'll do now
[07:53] <didrocks> pitti: maybe it can't just decide between your two shiny monitors ;)
[08:03] <pitti> didrocks, Laney: ok, with just the internal monitor it worked better
[08:04] <pitti> the terminal app doesn't install, though :/
[08:04] <pitti> (install button doesn't do anything)
[08:04] <pitti> anyway, I could do what I wanted on VT1 after finding out how to log in :)
[08:07] <pitti> can we pretty please pre-install terminal-app?
[08:07] <didrocks> pitti: that would be for Laney's seed I guess, but yeah :)
[08:07] <didrocks> pitti: did you log in to sso by any chance?
[08:07] <pitti> didrocks: yes, I had to
[08:07] <pitti> otherwise you can't install apps
[08:07] <didrocks> ok, so termina app doesn't install? weird
[08:08] <didrocks> terminal*
[08:08] <didrocks> ok, going for some cycling before the rain
[08:08] <didrocks> ttyl guys :)
[08:08] <mlankhorst> have fun
[08:08] <didrocks> thx
[08:41] <mlankhorst> cold cold cold
[08:47] <willcooke> morning
[09:04] <Laney> pitti: it's click only and we can't/don't install them
[09:04] <Laney> and it's not "my" seed
[09:04] <Laney> also hi
[09:05] <willcooke> :)
[09:24] <mlankhorst> ooh, greece spam
[09:25] <mlankhorst> helpfully with a english translation below it
[10:12] <willcooke> didrocks, thank you for you email re: hibernate - very interesting
[10:12] <willcooke> I agree, we shouldn't/couldn't use it
[10:18] <didrocks> willcooke: yeah, the feature is great under really specific circumstances
[10:18] <didrocks> but not widely applicable unfortunately
[10:18] <willcooke> yeah
[12:04] <pitti> Laney: https://jenkins.qa.ubuntu.com/job/vivid-adt-glib2.0/28 regression (email notifications are still broken)
[12:04] <pitti> it also seems to have regressed deja-dup
[12:08] <Laney> pitti: blag, ok
[12:09] <Laney> Test glib/network-monitor.test failed: Child process killed by signal 11
[12:11] <Laney> interesting that it worked at build time
[12:11] <Laney> let's see
[12:12] <pitti> Laney: I can retry the glib one
[12:12] <Laney> it's probably real
[12:14] <Laney> well bah, it works in a chroot
[12:14]  * Laney does the adt dance
[12:26] <Laney> oh man, accidentally hit ctrl-c after it failed
[12:26] <Laney> at least it did fail
[13:25] <Laney> larsu: gdbus question
[13:25] <Laney> It's possible to create a GDBusProxy for any name if you give G_DBUS_PROXY_FLAGS_DO_NOT_AUTOSTART isn't it?
[13:27] <larsu> Laney: you can also create it for any name if you don't pass that flag :)
[13:27] <Laney> won't it try to start it and give an error then?
[13:28] <Laney> I mean a name which you don't have a .service for on the system
[13:28] <larsu> right, it will error out with "no such name"
[13:28] <ochosi> larsu: not sure whether you're seeing this in unity too, but indicator sound's scale is reacting a bit odd to click-events with gtk3.14
[13:29] <larsu> Laney: but the same happens if the name doesn't exist and you pass DO_NOT_AUTOSTART
[13:29] <Laney> run this test program
[13:29] <larsu> ochosi: indeed...
[13:30] <Laney> http://paste.ubuntu.com/9550482/
[13:30] <ochosi> larsu: ok, good to know. i was afraid it would only be in xubuntu...
[13:30] <larsu> ochosi: thanks for pointing it out :)
[13:31] <Laney> I get "yes"
[13:31] <ochosi> larsu: no worries, i guess that's the whole point of testing the gtk3.14 PPA ;)
[13:35] <larsu> Laney: not sure right now what the semantics are. The proxy definitely calls GetNameOwner(), so "g-name-owner" should be NULL for you
[13:35] <larsu> Laney: but it doesn't seem to watch the name. Strange.
[13:35] <Laney> right I'm wondering if you need to do a test like this before using it
[13:35] <Laney> this is coming from glib itself https://git.gnome.org/browse/glib/tree/gio/gnetworkmonitornm.c#n248
[13:36] <Laney> this code crashes if nm isn't installed
[13:36] <larsu> wow
[13:36] <larsu> do you have a bt?
[13:36] <Laney> over there ->
[13:36] <Laney> line 222 props is NULL
[13:36] <Laney> from line 260
[13:36] <larsu> it should definitely not crash, even if you call a method on a non-connected proxy
[13:37] <Laney> I think 256 probably just wants to check the owner as well?
[13:37] <larsu> Laney: g_dbus_proxy_get_cached_property_names() is documented to return NULL in some cases
[13:38] <larsu> so that code should check for that
[13:38] <larsu> Laney: not sure, let me check when this even happens
[13:39] <Laney> and probably check for NULL there too I guess, for safety's sake
[13:39] <larsu> Laney: ah, it only returns NULL if it cannot connect to the bus at all
[13:39] <Laney> nod
[13:40] <larsu> it should probably check for name-owner
[13:40] <larsu> and also for NULL in 222
[13:40] <larsu> but that won't ever be a problem I think: properties are always loaded when the name exists
[13:41] <Laney> might as well, or an assert ...
[13:41] <larsu> right
[13:42] <larsu> this code also doesn't deal with nm restarting
[13:42] <larsu> not sure if that is ever an issue though
[14:02] <Laney> larsu: https://bugzilla.gnome.org/show_bug.cgi?id=741653
[14:03] <Laney> something weird happened to the bt
[14:07]  * Laney lunch
[14:12] <Sweet5hark> soo, people onboard UAL28 seem to be doing sightseeing over the Isle of Wright and the Channel for 2-3 hours now ... thats not exactly on the way from Heathrow to NY.
[14:53] <willcooke> didrocks, qengho, bregma - got a familly emergency, have to cancel our meetings.  WIll catch up with you later.
[14:53] <willcooke> mlankhorst, ^
[14:54] <qengho> rgr
[15:05] <mlankhorst> ok bb
[15:09] <mlankhorst> good luck
[15:14] <tkamppeter> Laney, hi
[15:18] <tkamppeter> Laney, about the syncing of cups-filters, I asked OdyX already some weeks ago and there he already told me that he had started on the ippusbxd package and so I did not do the same, already done work. He told me that he will put the ippusbxd package into experimental for now, due to the Debian freeze.
[15:20] <larsu> Laney: just pushed two commits which to ~larsu/ubuntu-themes/gtk-314 which fix all button issues I was aware of
[15:21] <larsu> and updated the pad
[15:29] <Laney> tkamppeter: I see some recent commits there actually, would be nice to find out what's left to do and get it uploaded :)
[15:29] <Laney> larsu: cool, care to make a MP?
[15:30] <larsu> Laney: sure
[15:30] <Laney> does anyone normally review those?
[15:31] <larsu> https://code.launchpad.net/~larsu/ubuntu-themes/gtk-314/+merge/245004
[15:31] <larsu> Laney: seb does
[15:31] <larsu> when I ask him too :)
[15:32] <Laney> cheers
[15:48] <larsu> Laney: are you subscribed to unity-control-center MRs?
[15:49] <Laney> nope
[15:49] <larsu> Laney: this trivial fix would be nice-to-have: https://code.launchpad.net/~larsu/unity-control-center/primary-toolbar/+merge/245005
[15:50] <Laney> I joined the team but it's not enough to get notifications
[15:51] <Laney> yeah looks good, thanks
[15:52] <larsu> can you approve though?
[15:52] <Laney> yep
[15:52] <larsu> thanks
[15:52] <Laney> trade for a review of my glib patch
[15:54] <larsu> deal
[15:55] <Mirv> is it just me having funny issue logging in vivid/lightdm today? it claims I can just "log in" (no password), but it fails to do so (obviously). if I login from tty1 and press enter in lightdm, it logs in..
[16:00] <larsu> Laney: bah, that g_free() in the middle of the function is quite ugly
[16:00] <larsu> I see why you did that though
[16:01] <larsu> desrt: do you have a strong policy for this? https://bugzilla.gnome.org/show_bug.cgi?id=741653
[16:01] <larsu> man, why does _get_name_owner() even return a copy?
[16:01] <larsu> oh, threading
[16:02] <desrt> larsu: looks like a danw bug
[16:02] <desrt> (this is where the "Dan W." problem gets extra confusing)
[16:03] <larsu> mh?
[16:03] <desrt> Dan Williams = NetworkManager maintainer
[16:03] <desrt> Dan Winship = GIO Networking maintainer
[16:03] <larsu> desrt: I asked if Laney's patch is ok for you (g_free() in the middle of the function)
[16:03] <desrt> NetworkManager issues in GIO = probably you want Dan Winship
[16:04] <larsu> this is more a gdbusproxy issue
[16:04] <desrt> the patch appears to be in gnetworkmonitornm.c
[16:04] <larsu> which I hear is maintained by you now :P
[16:05] <larsu> true, but that part of the question was more general
[16:05] <larsu> meh, whatever. I won't accept_commit-now for this part anyway
[16:05] <desrt> imho the correct thing to do here is to create the proxy with only unique names
[16:05] <desrt> proxies on well-known names have always been a mistake in my opinion
[16:06] <larsu> and deprecate g-name-owner?
[16:06] <desrt> the trouble is that david one thought it would be reasonable to try to support this..
[16:06] <desrt> *once
[16:06] <desrt> but seriously... what do you do when people query properties on a dead service?
[16:06] <larsu> ya, clearly
[16:07] <larsu> but you could still create a proxy for a non-existent unique name
[16:07] <larsu> or the unique name you created it for disappears
[16:07] <desrt> lame
[16:07] <larsu> why? Same problem, no?
[16:07] <desrt> the idea is that you'd use watch_name_owner() to uncreate the proxy as soon as the name vanishes
[16:08] <larsu> of course, but you'd still need to return something from _get_properties()
[16:08] <desrt> well, the thing is... with the unique-name-disappears case we can reasonably assume that someone will be cleaning up the mess soon
[16:08] <desrt> so we can just return the old values
[16:09] <larsu> GetProperties() call might not succeed when you first create the object
[16:09] <desrt> with the well-known name, we need to pretend
[16:09] <desrt> larsu: isn't GDBusProxy init failable?
[16:09] <desrt> i think that's what happens in that case
[16:09] <larsu> no, it only fails when it can't connect to the bus
[16:09] <larsu> aka never
[16:09] <desrt> i'm pretty sure you're wrong
[16:10] <desrt> g_dbus_proxy_new_sync() takes a GDBusConnection and returns GError
[16:10] <larsu> I checked earlier - but maybe I missed something
[16:10] <larsu> that file is a bit convoluted
[16:10] <desrt> ya....
[16:10] <desrt> i really hate that class
[16:10] <desrt> never use it myself
[16:10]  * didrocks should stop writing g_debug in systemd code…
[16:10] <larsu> deprecate it!
[16:10] <larsu> didrocks: s_debug!
[16:10] <desrt> "just use gdbusconnection, you wimps"
[16:10] <larsu> right
[16:11] <didrocks> larsu: almost, log_debug ;)
[16:11] <larsu> desrt: anyhow, is danw actively reviewing patches?
[16:11] <desrt> larsu: trouble is that we can't really change this code to introduce new ways to fail
[16:11] <desrt> larsu: on this sort of stuff?  yes.
[16:11] <larsu> ok, I'll wait for him to comment then
[16:11] <larsu> Laney: sorry :/
[16:12] <larsu> desrt: why not?
[16:12] <Laney> shrug
[16:12] <Laney> separately, want to push https://bugzilla.gnome.org/show_bug.cgi?id=741259 ?
[16:12]  * Laney will cherry-pick it for the upload
[16:12] <larsu> Laney: ah, mclasen ok'ed it. I missed that. I'll push it when I'm back home
[16:13] <desrt> larsu: this code makes me want to cry
[16:13] <larsu> desrt: stop reading it ;)
[16:13] <desrt> but anyway you're right
[16:13] <desrt> explicitly:
[16:13] <desrt>   if (result == NULL)
[16:13] <desrt>     {
[16:13] <desrt>       /* We just ignore if GetAll() is failing. Because this might happen
[16:14] <larsu> :(
[16:15] <desrt> is gdbusproxy actually crashing, or what?
[16:16] <desrt> or just returning null strings?
[16:16] <larsu> no, gnetworkmonitornm is, because it doesn't check the return value of get_cached_properties() for NULL
[16:16] <desrt> because unless gdbusproxy is crashing in response to relatively innocent outside uses, i'm not inclined to change anything inside of it
[16:16] <larsu> I wonder if NULL is correct there, or if { NULL } would be better
[16:16] <desrt> right.  so we need to fix the nm code
[16:17] <desrt> NULL is better
[16:17] <larsu> this is what Laney's patch does
[16:17] <larsu> does it return NULL when the name disappeared, too?
[16:17] <desrt> { NULL } means "i'm connected and i see that there are exactly 0 properties"
[16:17] <larsu> I agree
[16:17] <larsu> something like _is_connected() might be nice to have
[16:18] <larsu> so that you don't need to make a copy of the name owner
[16:18] <desrt> you have it.  it's called g-name-owner.
[16:18] <desrt> ahb
[16:18] <desrt> this shouldn't make a copy.
[16:18] <larsu> yay threads
[16:18] <desrt> no.
[16:18] <desrt> yay bad api design
[16:18] <desrt> the proxy belongs to a particular context.  it receives all notifications through dispatches on that context
[16:19] <desrt> if you're querying it from that context (as you must) then there is no way that it can see changes from the bus while you're querying it
[16:19] <desrt> you have to return to the mainloop
[16:19] <desrt> it's just plain old bad api
[16:19] <larsu> you must?
[16:19] <desrt> oh please tell me you must...
[16:19] <larsu> otherwise why would it need the property_lock?
[16:20] <desrt> oh.  you not must.
[16:20] <desrt> head → desk
[16:20] <desrt> THIS OBJECT IS TERRIBLE
[16:20] <larsu> right. I had the same reaction earlier today
[16:21] <desrt> and here i am in kdbus land figuring out a way to forbid even touching the _connection_ from the wrong thread
[16:21] <desrt> and we have proxies taking locks all over the place
[16:22] <desrt> i can't even imagine what horror show awaits me when i try to get gdbusproxy working on a kdbus gdbusconnection
[16:23] <desrt> i particularly love how they use code locking here and not even data locking
[16:24] <desrt> larsu: my suggestion is to slowly back away from GDBusProxy and fix things in the nm code (as the patch does).  danw is your go-to for that, though.
[16:28] <larsu> desrt: backing away from GDBusProxy towards subscribing to property change notifications manually?
[16:28] <desrt> backing away as in typing ":q" into any relevent vim windows
[16:28] <larsu> lol
[16:28] <larsu> done.
[16:28] <desrt> :)
[16:32]  * desrt is having lots of fun in kdbus land this morning
[16:33] <desrt> it turns out that pretty much everything is racy
[16:34] <larsu> uh oh
[16:35] <desrt> the cookie-based approach turns out to be kinda bad -- so we're trying futexes instead :)
[16:35] <larsu> uhm, yay!?
[16:36] <desrt> ya.  i love futexes.
[16:52] <larsu> Laney: pushed the patch to bug 741259
[16:52] <larsu> (gnome bug)
[16:53] <Laney> thanks!
[16:54]  * Laney screams
[16:54] <Laney> ci traiiinnnnn
[16:55] <didrocks> choooo choooo
[16:55] <Laney> https://ci-train.ubuntu.com/job/prepare-silo/3548/console
[16:57] <didrocks> Laney: not sure how they handle the REQUEST_ID nowdays
[16:57] <Laney> yeah pinged in the channel
[16:58] <didrocks> waow, they reintroduced all the variable in prepare-silo?
[16:59] <didrocks> instead of having to click in the spreadsheet, filing the REQUEST_ID and fetching the info from there?
[16:59] <didrocks> (this was still available manually in the prepare-silo-manual beforehand, but that was for emergency)
[18:02] <Laney> right then, climbing time
[18:02] <Laney> see you!
[18:02] <Laney> larsu (everyone): gtk is in ppa:ci-train-ppa-service/landing-008
[18:02] <Laney> I think it's ready to go and will do that first thing tomorrow
[18:02] <Laney> it's there with theme and u-c-c
[18:02] <Laney> there's an alpha freeze so now/then doesn't matter much anyway
[18:02] <Laney> darkxst: ^^^^^^^^^^^^^^ fyi
[18:03]  * Laney waves
[18:08] <larsu> Laney: neat, thanks!
[18:08] <Laney> I shit myself because all of the theme fixes went away
[18:09] <Laney> luckily it had been downgraded by mistake :)
[18:10] <larsu> haha
[18:13]  * didrocks waves too
[20:35] <darkxst> Laney, Great!