=== kadams54 is now known as kadams54-away === kadams54 is now known as kadams54-away === urulama|out is now known as urulama === rogpeppe3 is now known as rogpeppe [14:50] uiteam still need 2 for https://github.com/juju/juju-gui/pull/683 thx [14:51] uiteam ok now I just need a qa [14:51] hatch: try to get Makyo to qa please [14:52] I need a wall of clocks to know when people get in every day [14:52] hatch: I can also QA. [14:52] kadams54: thanks [14:52] new startup idea - company that doesn't do timezones [14:52] hatch: isn't Makyo in your timezone? ;-) [14:52] kadams54: only part of the year :) [14:52] but I don't know which part lol [14:52] Gah! You don't do DST? [14:53] nope GMT-6 year round [14:53] it's dark when we go to work and come home from work so DST wouldn't help haha [14:54] kadams54: downside is we can't say we forgot about the tz change and skip the first hour of work for a week [14:54] haha [14:55] I hate DST, so more power to ya. [14:56] does anyone know how to get `bzr grep` to have colour output like `git grep` ? [14:57] bzr grep | grep [14:57] my grep has color [14:59] pipe the grep to grep? [15:00] grep has color :) [15:00] haha [15:12] ohh functional charm tests [15:12] you take so long [15:39] rick_h_: when you ran the functional charm tests did you get a few which had the following error: skipped 'admin secret was not found' [15:40] hatch: don't reca;; check with frankban please otp [15:40] hatch: looking [15:41] the env it's deploying to is aws if that matters [15:42] hatch: ok so the charm skips tests requiring authentication if the environment you use to run the tests does not have an admin-secret defined in ~/.juju/environments.yaml [15:43] doh! I wrote this config manually [15:43] so I missed that [15:43] hatch: this can be improved instructing the charm to retrieve the password from the jenv file, but there where no jenv files at the time those tests where initially written [15:43] I guess I'll need to restart this now [15:44] thanks === kadams54 is now known as kadams54-away === kadams54-away is now known as kadams54 [16:43] ok I've got the changes to the charm made and the tests/lint pass [16:43] hatch: just +1'd https://github.com/juju/juju-gui/pull/683 [16:44] kadams54: thanks [16:44] frankban: so now that I have these changes made and committed how do I get it up for review without lbox? :) [16:44] push to my 'branch' and make a merge on LP? [16:45] hatch: you can propose it in launchpad [16:46] hatch: against lp:~juju-gui/charms/trusty/juju-gui/trunk [16:46] hatch: reviewers should run make unittest and make lint since that's what usually lbox run [16:47] ok thanks [16:48] frankban: this done properly? https://code.launchpad.net/~hatch/charms/trusty/juju-gui/hide-login-button/+merge/245137 [16:49] hatch: the target should be lp:~juju-gui/charms/trusty/juju-gui/trunk [16:50] trying again https://code.launchpad.net/~hatch/charms/trusty/juju-gui/hide-login-button/+merge/245138 [16:50] :) [16:51] hatch: better :-) just set a commit message and a description please [16:54] cool [16:54] uiteam lf review and qa on my guicharm changes https://code.launchpad.net/~hatch/charms/trusty/juju-gui/hide-login-button/+merge/245138 [16:56] Makyo: should I move the bundle yaml card into coding with your head on it? [16:57] hatch, I don't think they should be separate cards. One card per branch is my preference. [16:57] cool, updated your card and deleted the old one [17:08] back to queue eh! [17:11] ^ british canadian version of qa [17:16] there is a weird bug in the guicharm where if you change the source before it's deployed it'll fail to build the source [17:16] but it appears to be random as to when the bug happens === kadams54 is now known as kadams54-away [17:43] hatch: never encountered that [17:44] after logging in using the latest charm and gui I get an http auth popup? [17:45] https://admin:@10.0.3.10/juju-core/charms?url=local:trusty/juju-gui-0&file=icon.svg [17:45] because of this request [17:45] any ideas? [17:47] hmm the code that's generating that icon path is definitely not right [17:49] hatch: why it isn't? [17:49] hatch: and shouldn't the user in basic http auth be user-admin rather than just admin? [17:49] frankban: well it needs to be able to make the request without the extra http auth [17:50] hatch: you are requesting the local charm icon from juju-core, and that requires auth [17:50] so I don't recall any of that code being changed [17:51] hatch: perhaps I am wrong, but the user there should be user-admin. could you try? maybe Makyo can help with the user stuff in the GUI [17:52] oh maybe that was changed with the login stuff [17:52] if it's supposed to be user-admin [17:52] that's somewhere to start [17:52] thanks [17:53] np [18:01] frankban: yes it's that it should be user-admin [18:01] frankban: so for all users should it be prefixed with 'user-' ? [18:01] or only admin [18:01] hatch: cool, all users [18:01] thanks [18:02] done for the day, good night all! [18:02] night frankban [19:44] it's interesting how the terminal and sublime are using the same fonts at the same size but they look completely different [19:59] we should find some time to go through the entire test suit and remove the foo.should.equal() stuff === kadams54-away is now known as kadams54 === kadams54_ is now known as kadams54-away === kadams54-away is now known as kadams54_ === kadams54_ is now known as kadams54-away [21:03] uiteam lf 2x review and a qa for https://github.com/juju/juju-gui/pull/684 [21:04] ok here is to hoping that's all the bugs heh [21:04] uiteam I also still need one qa on https://code.launchpad.net/~hatch/charms/trusty/juju-gui/hide-login-button/+merge/245138 [21:05] guicharm change [21:30] I think that that's all the gui bugs [21:30] besides the ones we already know about it seems pretty stable [21:31] update your gits https://github.com/blog/1938-vulnerability-announced-update-your-git-clients [22:36] anyone use an apple 'magicpad' with ubuntu? It seems to fail the sync [22:44] bleh I had to install blueman - apparently the default ubuntu bluetooth software is no good