| === mup_ is now known as mup | ||
| === mup_ is now known as mup | ||
| === mup_ is now known as mup | ||
| katco | wallyworld___: ping | 04:08 |
|---|---|---|
| wallyworld___ | hi | 04:08 |
| katco | wallyworld___: hey thanks for trying to land that change. sorry we couldn't get it fixed | 04:08 |
| katco | wallyworld___: i saw that the changeCertListener methods were operating on copies of the structs, which means the mutexes in the struct won't work | 04:08 |
| wallyworld___ | no problem, it is shit i didn't get it fixed properly. i'm landing now but bot keeps fsiling on a couple of dumb tests | 04:09 |
| katco | doh | 04:09 |
| wallyworld___ | i'll check the struct issue, thanks | 04:09 |
| wallyworld___ | hmmm, you're right. bullocks, i'll fix | 04:11 |
| wallyworld___ | sigh | 04:11 |
| katco | you're almost there! :) | 04:11 |
| wallyworld___ | if the bot passes, yes | 04:13 |
| katco | i know the feeling | 04:13 |
| katco | to prove it to myself: http://play.golang.org/p/By4lI7Du_9 | 04:14 |
| katco | and then correct: http://play.golang.org/p/tNgAoKznSC | 04:15 |
| katco | that's a sneaky bug. | 04:15 |
| wallyworld___ | yeah, i meant to use a pointer but clearly my stupid fingers didn't type the * | 04:18 |
| wallyworld___ | good pickup | 04:18 |
| wallyworld___ | hopefully bot will pass this time, we'll see | 04:19 |
| * katco crosses fingers | 04:19 | |
| katco | alright i'm off to bed | 04:20 |
| katco | happy holidays! | 04:20 |
| wallyworld___ | you too, thans again | 04:20 |
| ericsnow | wallyworld___: you are my hero | 05:43 |
| wallyworld___ | oh? | 05:43 |
| ericsnow | the test you just fixed :) | 05:43 |
| wallyworld___ | well, it was originally my crappy assumption that led to the issue, so i had better fix it | 05:44 |
| ericsnow | regardless, I'm glad you stuck with it! | 05:45 |
| wallyworld___ | yeah, hated to see it hanging aound | 05:45 |
| ericsnow | so you waiting for other CI tests to run before marking if fix released? | 05:55 |
| === kadams54 is now known as kadams54-away | ||
| === Tribaal_ is now known as Tribaal | ||
| === mup_ is now known as mup | ||
| === bodie__ is now known as bodie_ | ||
| === Ursinha is now known as Ursinha_ | ||
| === kadams54 is now known as kadams54-away | ||
| === kadams54 is now known as kadams54-away | ||
| === kadams54-away is now known as kadams54 | ||
| === kadams54 is now known as kadams54-away | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!