=== mup_ is now known as mup === mup_ is now known as mup === mup_ is now known as mup [04:08] wallyworld___: ping [04:08] hi [04:08] wallyworld___: hey thanks for trying to land that change. sorry we couldn't get it fixed [04:08] wallyworld___: i saw that the changeCertListener methods were operating on copies of the structs, which means the mutexes in the struct won't work [04:09] no problem, it is shit i didn't get it fixed properly. i'm landing now but bot keeps fsiling on a couple of dumb tests [04:09] doh [04:09] i'll check the struct issue, thanks [04:11] hmmm, you're right. bullocks, i'll fix [04:11] sigh [04:11] you're almost there! :) [04:13] if the bot passes, yes [04:13] i know the feeling [04:14] to prove it to myself: http://play.golang.org/p/By4lI7Du_9 [04:15] and then correct: http://play.golang.org/p/tNgAoKznSC [04:15] that's a sneaky bug. [04:18] yeah, i meant to use a pointer but clearly my stupid fingers didn't type the * [04:18] good pickup [04:19] hopefully bot will pass this time, we'll see [04:19] * katco crosses fingers [04:20] alright i'm off to bed [04:20] happy holidays! [04:20] you too, thans again [05:43] wallyworld___: you are my hero [05:43] oh? [05:43] the test you just fixed :) [05:44] well, it was originally my crappy assumption that led to the issue, so i had better fix it [05:45] regardless, I'm glad you stuck with it! [05:45] yeah, hated to see it hanging aound [05:55] so you waiting for other CI tests to run before marking if fix released? === kadams54 is now known as kadams54-away === Tribaal_ is now known as Tribaal === mup_ is now known as mup === bodie__ is now known as bodie_ === Ursinha is now known as Ursinha_ === kadams54 is now known as kadams54-away === kadams54 is now known as kadams54-away === kadams54-away is now known as kadams54 === kadams54 is now known as kadams54-away