| axw | ericsnow: correct, new providers need not use storage. they *can* if it's beneficial, but from what hazmat described to me it didn't sound like it would be | 00:49 |
|---|---|---|
| ericsnow | axw: just what I wanted to hear :) | 00:50 |
| === negronjl is now known as negronjl-afk | ||
| menn0 | anastasiamac: you win for providing the most useful PR description I've seen in a while | 02:57 |
| anastasiamac | menn0: thank you ;-) | 02:58 |
| anastasiamac | menn0: i was apprehensive of submitting another big change... was hoping to make it easier for u :) | 02:58 |
| anastasiamac | menn0: i always appreceate ur feedback :) | 02:59 |
| wallyworld_ | menn0: hopefully the tweaks to the unit agent status pr are ok - i added a Stopping state for unit agents (machines continue to use Stopped) | 03:26 |
| menn0 | wallyworld_: ok, i'll take a look after i've finished with anastasiamac's PR | 03:27 |
| wallyworld_ | sure, no hurry, ty | 03:27 |
| thumper | menn0: I've updated http://reviews.vapour.ws/r/676/diff/# to add an additional test with multiple environments | 03:36 |
| menn0 | anastasiamac: regarding the first question in your PR - about a follow up PR to remove the embedded style annotation support | 03:40 |
| menn0 | anastasiamac: you're just going to change the underlying implementation right? | 03:40 |
| menn0 | anastasiamac: the old style API will need to hang around for a while to support older clients won't it? | 03:41 |
| anastasiamac | menn0: yes, removing embedded annotator and tweak old client to not use it | 03:41 |
| anastasiamac | menn0: yes, API will stay ;-) as deprecated... | 03:41 |
| menn0 | anastasiamac: good. in that case I don't there's a need to increment the API version number. | 03:43 |
| menn0 | anastasiamac: the external API stays the same after all. | 03:43 |
| anastasiamac | menn0: that was my hope ;-) thnx for confirmation! | 03:43 |
| menn0 | anastasiamac: cool. | 03:44 |
| wwitzel3 | ericsnow: ping | 03:44 |
| menn0 | anastasiamac: I'm almost done with the review (looking good). just trying to answer your other questions on the review. | 03:44 |
| anastasiamac | menn0: u r almost done? amazing!!! thnk u ;-) | 03:45 |
| anastasiamac | menn0: m pondering if it's worthwhile adding a test to explicitely annotate a local charm... current test creates a "cs" charm... | 03:47 |
| anastasiamac | menn0: it's just couple of lines of code but will be explicit and closely aligned to the concern in the bug... | 03:48 |
| * wwitzel3 dances a jig | 03:54 | |
| menn0 | anastasiamac: hmmm not sure. what's different about a local charm in terms of this code? | 03:57 |
| menn0 | anastasiamac: regarding your last question, what do you mean by "stuttering" in the tests? | 03:57 |
| menn0 | thumper: newEnvAsUser? shouldn't that be newEnvWithUser or something? | 04:00 |
| thumper | menn0: I suppose | 04:00 |
| menn0 | thumper: not a biggie | 04:00 |
| menn0 | thumper: those changes look good | 04:02 |
| thumper | cool | 04:02 |
| thumper | menn0: if I change the name, good to land? | 04:05 |
| menn0 | thumper: even if you don't (and I had already said ship it :) ) | 04:05 |
| thumper | menn0: I don't hold those as binding if the coder does lots of changes | 04:06 |
| thumper | :) | 04:06 |
| menn0 | wallyworld_: have you pushed the latest version of status branch? RB doesn't have it. | 04:06 |
| wallyworld_ | menn0: i thought so, let me check | 04:06 |
| wallyworld_ | menn0: the github pr has been updated,but rb appears not for some reason | 04:09 |
| menn0 | anastasiamac: i've published the review, leaving your last question unanswered. | 04:09 |
| menn0 | thumper: fair enough. well it look good regardless :) | 04:10 |
| thumper | menn0: landing now | 04:10 |
| thumper | ok, I'm off, back later tonight hopefully for meeting | 04:13 |
| anastasiamac | menn0: sorry - was with kids ;-( | 04:14 |
| anastasiamac | menn0: thnx for review - will look now-ish | 04:14 |
| menn0 | axw: question about your disk PR: how will a user specify the desired disks via the GUI or command line client? Or is this a charm level thing? | 04:15 |
| anastasiamac | menn0: re: stuttering - result.Error.Error.Error() ;P | 04:15 |
| menn0 | anastasiamac: no problems. if you can explain the 4th question some more I can try and answer that one too. | 04:15 |
| menn0 | wallyworld_: sometime the RB or GH API chokes on large diffs I believe (not sure which side is the issue) | 04:16 |
| anastasiamac | menn0: q4... for eg, in apiserver/annotations/client_test.go, l. 131 | 04:17 |
| menn0 | there's certainly something to be said for the extra efficiency that IRC style communication gives you. I was having 3 conversations at once for a while there :) | 04:17 |
| anastasiamac | menn0: m impressed with everyone's multi-tasking ;-) | 04:18 |
| menn0 | :) | 04:18 |
| anastasiamac | menn0: from annotations perspective, there is no difference btw local vs non-local charm... i'll leave th test out ;) thnx for the listening ear :0 | 04:19 |
| menn0 | anastasiamac: so by "stuttering" are you referring to to the repeated code snippets? | 04:19 |
| anastasiamac | menn0: m using Jesse's jargon :p but yes | 04:20 |
| menn0 | anastasiamac: I guess it might be nice to have methods for the most commonly used bits: makeWordpressCharm(), makeMachine() seem like the biggest wins | 04:23 |
| axw | menn0: "juju deploy --storage <storage>=<constraints>", and (at least while prototyping), "juju machine add --disks <constraints>" | 04:23 |
| menn0 | axw: cool. I was just curious. | 04:23 |
| axw | menn0: those constraints will be combined with charm-level properties in the former case | 04:23 |
| wallyworld_ | axw: the Disks param to StartInstance - is that still determined from constraints which specify minimum and preferred values? | 04:24 |
| axw | wallyworld_: there's no preferred anymore, but yes. on the CLI the user specifies constraints which may include size, count and a storage pool. those are converted to one or more DiskParams by looking up the pool, and (later) combining with charm storage metadata | 04:26 |
| axw | wallyworld_: the pool lookup bit will not be in the MVP though; I'm assuming a single, unconfigurable pool for now | 04:27 |
| wallyworld_ | axw: right. so the code comment just needs tweaking to remove "preferred" | 04:27 |
| axw | wallyworld_: ah yeah, thanks. | 04:28 |
| wallyworld_ | menn0: are you ok just to look at the github commit diffs for that pr? | 04:28 |
| menn0 | wallyworld_: yep, will do | 04:29 |
| wallyworld_ | ta | 04:29 |
| menn0 | wallyworld_: ok done. my comments are probably more due to my lack of understanding than anything wrong with the PR. | 04:44 |
| wallyworld_ | menn0: great, thank you, looking | 04:45 |
| menn0 | wallyworld_: i've got to stop for a bit now but will check back in again later on | 04:45 |
| wallyworld_ | sure | 04:45 |
| menn0 | wallyworld_: if my comments are silly, please feel free to merge | 04:45 |
| anastasiamac | ericsnow: ping?.. | 05:20 |
| dimitern | morning all | 06:14 |
| axw | morning dimitern | 06:14 |
| dimitern | axw, \o | 06:15 |
| axw | dimitern: what's the plan for switching juju over to github/go-amz/goamz? | 06:16 |
| dimitern | axw, right, so I'm having a call with gustavo at 16 utc to discuss this and other related stuff, like collaboration and integration with other forks, maintenance, etc. | 06:17 |
| axw | dimitern: ok, cool | 06:18 |
| dimitern | axw, my plan is to do it sooner, even if that means using the "unstable" v2-dev branch for a while | 06:18 |
| axw | dimitern: I have a couple of minor changes I need to make to goamz, I'm holding off until that's sorted out | 06:18 |
| axw | ok | 06:18 |
| dimitern | sure | 06:19 |
| anastasiamac | dimitern: o/ | 06:19 |
| dimitern | anastasiamac, hey there | 06:19 |
| anastasiamac | dimitern: how r u? happy ny | 06:20 |
| dimitern | anastasiamac, cheers :) great to be back to work, eh? | 06:24 |
| anastasiamac | dimitern: dfinitely :p | 06:25 |
| dimitern | seriously, sometimes holidays seems a wee bit too long | 06:25 |
| anastasiamac | dimitern: i actuually need a holiday form my holiday ;) | 06:26 |
| anastasiamac | dimitern: as far as celebrations r concerned, we r still in Xmas mode here - today is Russian Xmas, 13th is Russian old NY, etc... | 06:27 |
| dimitern | :) | 06:27 |
| dimitern | anastasiamac, oh right - until 14th? | 06:27 |
| dimitern | yeah | 06:27 |
| anastasiamac | dimitern: m working and celebrating ;) | 06:28 |
| dimitern | anastasiamac, that's a nice excuse for a double ny/xmas celebrations | 06:28 |
| anastasiamac | dimitern: any excuse to celebrate anything ;-P life is a long party in my books :) | 06:29 |
| dimitern | anastasiamac, awesome | 06:30 |
| dimitern | :D | 06:30 |
| dimitern | ah, axw - do you mind if I suggest you as a (candidate) maintainer for goamz as well? | 06:35 |
| axw | dimitern: sure | 06:36 |
| dimitern | axw, cheers | 06:36 |
| menn0 | anastasiamac: looks like the annotations PR needs rebasing or something... | 08:12 |
| menn0 | anastasiamac: look at all the commits listed for it on Github. Most aren't yours. | 08:12 |
| wallyworld_ | thanks menn0 :-) | 08:13 |
| menn0 | anastasiamac: Reviewboard is also not happy about it | 08:13 |
| anastasiamac | menn0: i've rebased, resolved conflicts and got this ;-( | 08:13 |
| menn0 | wallyworld_: np | 08:13 |
| anastasiamac | menn0: that's why i've added a list of files that I have actually touched into the awesome commit comment ;-) | 08:13 |
| menn0 | anastasiamac: it's almost like you rebased onto the wrong branch or something | 08:13 |
| menn0 | anastasiamac: i'm a little worried that if you try to merge what's there now something bad is going to happen | 08:14 |
| anastasiamac | menn0: m considering to start another branch and move all my stuff there | 08:14 |
| menn0 | anastasiamac: you might not need to do that | 08:14 |
| menn0 | anastasiamac: are your commits all at the top of your branch? | 08:14 |
| anastasiamac | menno: k. i'll do this either later or tomorrow | 08:15 |
| anastasiamac | menn0: looks like they are all the bottom of the list... | 08:15 |
| menn0 | anastasiamac: I was going to suggest that you use "git rebase --onto ..." but that won't work | 08:15 |
| anastasiamac | menn0: i'll start another branch ;( | 08:16 |
| menn0 | anastasiamac: I see annotations related commits mixed in with other people's ones when I look at Github | 08:16 |
| anastasiamac | menn0: most of it additons anyway... ;) | 08:16 |
| menn0 | anastasiamac: a rebase onto master *should* sort it out | 08:16 |
| menn0 | anastasiamac: how are you rebasing? | 08:16 |
| anastasiamac | menn0: when m on my branch 'git rebase master' | 08:16 |
| anastasiamac | menn0: once master is synced... | 08:17 |
| anastasiamac | menn0: have to go... i'll do another branch | 08:17 |
| menn0 | anastasiamac: ok | 08:17 |
| menn0 | anastasiamac: I'll send you an email with a suggestion | 08:18 |
| anastasiamac | menn0: sounds awesome ;-) | 08:21 |
| anastasiamac | menn0: thnx! | 08:21 |
| anastasiamac | menn0: branch fixed as per ur suggestion! tyvm!!! scotch was ur price, wasn't it?.. | 08:37 |
| TheMue | morning | 08:45 |
| menn0 | anastasiamac: yep :) | 08:50 |
| fwereade | sorry, freenode seems to keep falling over for me for some reason | 10:46 |
| fwereade | I'm in the canonical ones too though if this falls over again | 10:46 |
| perrito666 | morning | 11:42 |
| perrito666 | fwereade: I addressed some of your concerns regarding my restore patch and made some action plan for the others since they require more in depth changes of the whole mechanism | 11:43 |
| === frankban__ is now known as frankban | ||
| dimitern | TheMue, katco, voidspace, can any of you have a look at this http://reviews.vapour.ws/r/686/ please? If fixes bug 1355813 | 11:52 |
| mup | Bug #1355813: Interface MTU management across MAAS/juju <add-unit> <amd64> <apport-bug> <canonical-bootstack> <cts> <cts-cloud-review> <landscape> <network> <placement> | 11:53 |
| mup | <smoosh> <trusty> <uec-images> <juju-core:In Progress by dimitern> <MAAS:New> <juju-core (Ubuntu):Triaged> <lxc (Ubuntu):Invalid> <https://launchpad.net/bugs/1355813> | 11:53 |
| TheMue | dimitern: *click* | 11:54 |
| voidspace | dimitern: I can do, but will have to be after lunch | 11:54 |
| dimitern | TheMue, ta! | 11:54 |
| dimitern | voidspace, no worries | 11:54 |
| TheMue | dimitern: done | 12:00 |
| dimitern | TheMue, thanks! | 12:43 |
| TheMue | so, bfl | 12:44 |
| TheMue | dimitern: yw | 12:44 |
| dimitern | mgz, hey, do you have 5m? | 13:15 |
| mgz | dimitern: hey, was at lunch, what do you need? | 14:07 |
| dimitern | mgz, i wanted to ask if you're willing to lend a hand from time to time with goamz reviews and generally helping with maintenance/collaboration | 14:08 |
| dimitern | it's going to get more active soon, and there are ideas to merge the existing forks into it gradually over time | 14:09 |
| mgz | dimitern: yeah, saw you'd been busy over the holiday sorting that all out | 14:09 |
| mgz | I'll try and jump in on reviews on github | 14:10 |
| dimitern | mgz, yeah, it was surprising how much attention it managed to gather in a short time | 14:10 |
| dimitern | mgz, sweet! thank you! | 14:10 |
| === kadams54 is now known as kadams54-away | ||
| === negronjl-afk is now known as negronjl | ||
| === kadams54-away is now known as kadams54 | ||
| ericsnow | dimitern: (in case you haven't been asked yet) what is the priority on implementing networking for the GCE provider? | 14:49 |
| ericsnow | dimitern: Basically none of the other providers implement it at present. | 14:50 |
| dimitern | ericsnow, heh :) for gce - i'd say very low | 14:50 |
| ericsnow | dimitern: k, cool | 14:50 |
| dimitern | ericsnow, we're concentrating on ec2 and maas until 15.04, then openstack will be next most likely | 14:50 |
| ericsnow | dimitern: FWIW, the GCE API makes the networking stuff pretty straightforward so adding it later shouldn't be a big deal | 14:51 |
| === kadams54 is now known as kadams54-away | ||
| dimitern | ericsnow, that's great to hear! | 14:52 |
| ericsnow | mgz, abentley, sinzui: could any of you take a look at http://juju-ci.vapour.ws:8080/job/github-merge-juju/1729/console? | 14:56 |
| ericsnow | mgz, abentley, sinzui: it is not clear to me why it can't find the dependency | 14:56 |
| === kadams54-away is now known as kadams54 | ||
| mgz | ericsnow: will in just a sec | 15:01 |
| ericsnow | mgz: ta | 15:01 |
| wwitzel3 | ericsnow: you see my commits for gce? | 15:03 |
| wwitzel3 | ericsnow: was able to fully bootstrap and deploy mysql/wordpress last night. | 15:03 |
| bodie_ | is there a way to get a charm of a unit without the charm url on state? | 15:09 |
| mgz | ericsnow: golang.org/x/crypto is explictly exclused in the build script - if I recall corerctly it had licensing issues | 15:11 |
| mgz | or that might have been one of the other ones, and it was just pulled in by mistake, and can now be removed if you actually need to use it | 15:12 |
| mgz | I'll find out | 15:12 |
| sinzui | mgz, ericsnow. The x/crypto lib was purged because it first appeared in the tree, but wasn't in deps. It appeared there because a subdep pulled it in, but the version of the dep we used did not use it | 15:13 |
| ericsnow | wwitzel3: awesome! | 15:14 |
| sinzui | mgz, ericsnow (my recollection). I f the license is good, we can remove the line that purges it now that juju's dependencies state it is wanted | 15:14 |
| mgz | ericsnow: it looks like you're not actually adding it as a dep in your new code? | 15:14 |
| mgz | ericsnow: so, probably just the mechanism you used to update dependencies.tsv wasn't right? | 15:15 |
| ericsnow | sinzui, mgz: well, the utils repo depends on x/crypto as of a couple revisions | 15:15 |
| ericsnow | sinzui, mgz: so it was added as a dep when I updated the rev for utils | 15:16 |
| mgz | okay, I'll need to update the script to try to produce a sane tarball when deps get pulled in by mistake then, that will mean I can drop my other hack | 15:17 |
| ericsnow | mgz: cool | 15:17 |
| sinzui | ericsnow, good. so if the lib's licence is god we can rm the line | 15:18 |
| * mgz giggles at god | 15:18 | |
| ericsnow | mgz: do you recall what the licensing issue was? | 15:18 |
| === kadams54 is now known as kadams54-away | ||
| mgz | ericsnow: I think that was the go.net package test data | 15:19 |
| === kadams54-away is now known as kadams54 | ||
| mgz | so, not this one | 15:19 |
| ericsnow | mgz: oh good, so once the deps mechanism is fixed in CI I should be able to try merging again :) | 15:20 |
| ericsnow | mgz: what is the ETA on that? I recognize you probably have higher priorities. :) | 15:24 |
| mgz | ericsnow: I'll try to do it before your eod so you can try again | 15:25 |
| sinzui | ericsnow, just a few minutes to remove a line and update the machine | 15:25 |
| ericsnow | mgz: thanks! | 15:25 |
| mgz | ah, yeah, and the unblocking of you r branhc is even easier, because it doesn't need the script fix | 15:25 |
| mgz | just hte blacklist remove | 15:25 |
| mgz | sinzui: shall I do it, or are you? | 15:26 |
| sinzui | I will. I have it open | 15:26 |
| katco | cherylj: ping | 15:34 |
| cherylj | katco: pong | 15:35 |
| katco | cherylj: got a few minutes to chat? i would love to meet you | 15:35 |
| cherylj | Give me just a minute | 15:35 |
| katco | cherylj: no rush at all | 15:35 |
| wwitzel3 | ericsnow: did you see smosers response in cloud-init? | 15:57 |
| wwitzel3 | ericsnow: I'm going to add that information to the doc | 15:57 |
| ericsnow | wwitzel3: not yet :) | 15:57 |
| dimitern | niemeyer, hey, just a reminder - I'm in the hangout now :) | 16:07 |
| ericsnow | perrito666, wwitzel3: standup? | 16:09 |
| dimitern | katco, hey, as you've contributed to goamz in the past, are you willing to give a hand from time to time with reviews and maintenance? | 16:09 |
| sinzui | ericsnow, I let you down. I got distracted and didn't complete the deployment to the server. I am doing it now. poke in 15 minutes if I haven't confirmed it is in place | 16:11 |
| ericsnow | sinzui: no worries; I'm itching to land the patch, but the only thing it blocks is the new GCE provider (which won't be landing yet) :) | 16:12 |
| ericsnow | sinzui: thanks for taking the time to sort this out | 16:12 |
| perrito666 | ericsnow: wwitzel3 having some connectivity issues, sorry Ill be there in 10 mins | 16:13 |
| ericsnow | perrito666: k | 16:13 |
| sinzui | ericsnow, you can resubmit | 16:19 |
| ericsnow | sinzui: thanks! | 16:19 |
| perrito666 | ericsnow: wwitzel3 I need to sort a couple of things before the standup, can we do-it in half an hour? | 16:21 |
| ericsnow | perrito666: fine with me | 16:21 |
| perrito666 | thanks a lot | 16:21 |
| perrito666 | wwitzel3: ? | 16:21 |
| wwitzel3 | I wasn't even paying attention, sure | 16:22 |
| perrito666 | lol | 16:22 |
| wwitzel3 | :) | 16:22 |
| wwitzel3 | I'm in deep thought, I will be in seclusion in the west wing | 16:22 |
| bodie_ | I'm having some trouble with state/ConnSuite. it seems that the charm URL isn't found on the testing units of a testing service | 16:36 |
| bodie_ | if anyone can enlighten me, it would be much appreciated! | 16:36 |
| katco | dimitern: hey sorry i was on a call. certainly i can, as long as i'm not too pressed for time with other juju priorities :) | 16:42 |
| dimitern | katco, awesome, will send you an invite to join! I promise not to pester you too much :) | 16:45 |
| katco | dimitern: :) | 16:45 |
| perrito666 | ericsnow: I can see you | 16:56 |
| perrito666 | :p | 16:56 |
| ericsnow | perrito666: haha | 16:56 |
| perrito666 | wwitzel3: can I get you to surface from the depth of your thoughts for a moment? | 16:57 |
| perrito666 | fwereade: ping me when you have a moment please :p | 17:21 |
| fwereade | bodie_, a unit's charm url gets set by the uniter when it's actually downloaded a charm, it doesn't otherwise have one | 17:24 |
| fwereade | bodie_, what were you expecting to use it for? | 17:24 |
| bodie_ | fwereade, I'm set. didn't realize units weren't created with the charm URL of the parent service | 17:25 |
| bodie_ | fwereade, was just discovering that for myself :) | 17:25 |
| fwereade | bodie_, what would you be using it for? | 17:26 |
| katco | fwereade: hey when you have a moment, do you have time for a hangout? | 17:26 |
| fwereade | katco, might be able to manage one later, it's a bit loud and approaching-suppery here at the moment | 17:26 |
| katco | fwereade: no worries. it can be tomorrow as well... i think i'll likely spend the day doing reviews | 17:27 |
| fwereade | katco, I'll ping you if/when I'm free later, otherwise grab me tomorrow :) | 17:27 |
| katco | fwereade: sounds like a plan, and happy new years :) | 17:27 |
| bodie_ | fwereade, when an Action is enqueued on a unit, it should validate the params before enqueuing (sp?) it. that way the user immediately gets an error when invoking it via `juju do`. | 17:29 |
| bodie_ | s/enqueuing it/adding it to the actual queue on state/ | 17:29 |
| bodie_ | otherwise, the user must discover ID10T error via `juju fetch` | 17:30 |
| bodie_ | fwereade, if a unit doesn't have a charm URL, then the unit's charm can't be found, AFAICT, meaning it can't validate Actions passed to it | 17:30 |
| fwereade | bodie_, it's certainly rational to fall back to the service's charm | 17:31 |
| fwereade | bodie_, might even be sane to just always validate against the service charm url | 17:31 |
| fwereade | bodie_, not clear which approach will fail more often | 17:33 |
| fwereade | bodie_, but it's also important to keep perspective, the window is fairly narrow: running actions on a service while upgrading that service | 17:34 |
| bodie_ | fwereade, seems like if a unit is in the process of being added, it would be better to validate against the service at time of enqueueing | 17:34 |
| fwereade | bodie_, certainly it's a good fallback when no charm url has been set | 17:34 |
| bodie_ | fwereade, I think the worker will catch the case you sketched up | 17:35 |
| bodie_ | so, the action would be enqueued but fail | 17:35 |
| fwereade | bodie_, yeah, that's fine | 17:35 |
| bodie_ | fwereade, thanks :) | 17:37 |
| === kadams54 is now known as kadams54-away | ||
| === kadams54-away is now known as kadams54 | ||
| voidspace | g'night all | 18:46 |
| voidspace | EOD | 18:46 |
| === kadams54_ is now known as kadams54-away | ||
| === kadams54-away is now known as kadams54_ | ||
| === kadams54_ is now known as kadams54-away | ||
| thumper | I feel that today is one of those "start the day with two coffees" types of day | 20:21 |
| LinstatSDR | thumper: I feel you on that. I had to start the day off with a 4 pack of Monster Energy drinks. | 20:24 |
| wwitzel3 | ericsnow: I am going to take some time to review the cloudsigma stuff and then I'll join you back on GCE stuff. | 20:27 |
| ericsnow | wwitzel3: sounds good | 20:27 |
| wwitzel3 | ericsnow: feel free to start on any TODOs or refactors or whatever and we can just review | 20:27 |
| wwitzel3 | ericsnow: I feel much better after eating ;) | 20:27 |
| ericsnow | wwitzel3: I landed the PortSet patch so now I'm working on merging our branch with master | 20:28 |
| === kadams54-away is now known as kadams54_ | ||
| ericsnow | wwitzel3: :) | 20:28 |
| wwitzel3 | ericsnow: ahh, ok, good idea, been a while since we did that | 20:28 |
| ericsnow | wwitzel3: I'm doing a merge instead of a rebase since I think the history is worth keeping | 20:29 |
| wwitzel3 | ericsnow: +1 | 20:29 |
| bodie_ | hmm | 20:43 |
| menn0 | anastasiamac: how close are you to landing your annotations work? | 21:27 |
| menn0 | anastasiamac: I have to make some changes which will conflict with yours | 21:27 |
| anastasiamac | menn0: hopefully in the next 4-5 hrs? | 21:28 |
| menn0 | anastasiamac: hmmm... mine might be quicker than that (and certainly a lot smaller) | 21:28 |
| menn0 | anastasiamac: let's keep each other updated I guess | 21:28 |
| anastasiamac | menn0: k. thnx | 21:29 |
| perrito666 | wallyworld: ill walk my dog and then be back so we can call | 21:34 |
| wallyworld | perrito666: great, thanks, was about to ping you | 21:35 |
| perrito666 | I could do now but my dog seems to be much more urged than you and is more likely to express her unhappiness with bites :p | 21:35 |
| wallyworld | sure :-) | 21:35 |
| wwitzel3 | katco: nice review on the cloudsigma stuff, thank you | 21:44 |
| katco | wwitzel3: oh no problem | 21:44 |
| katco | wwitzel3: i had to stop part-way through though; that was going to take all day | 21:44 |
| wwitzel3 | katco: yep, I'm picking up where you left off :) | 21:45 |
| katco | wwitzel3: oh, thanks :) i thought maybe they could extrapolate a little | 21:46 |
| wwitzel3 | katco: I've never successfully done a full review of this code in a single day .. week | 21:46 |
| katco | wwitzel3: wow yipes | 21:46 |
| wwitzel3 | katco: yeah, there are some branches that are broken out, but their latest updates touched all of them | 21:47 |
| wwitzel3 | katco: so it ended up with a big single patch on reviewboard | 21:47 |
| katco | wwitzel3: ah i see | 21:47 |
| katco | wwitzel3: i'm happy for their contribution, just needs a bit of standards compliance | 21:47 |
| wwitzel3 | katco: ericsnow and I are going to have the same issue when we propose GCE .. figuring out how to make it not a huge monolithic review | 21:48 |
| katco | wwitzel3: i think it's a real challenge | 21:48 |
| katco | wwitzel3: i always like to have everything working before i submit anything | 21:48 |
| wwitzel3 | katco: you want to give enough context to the review .. but then how much is too much | 21:49 |
| katco | wwitzel3: right | 21:49 |
| wwitzel3 | katco: we've tried to learn from some of the abstraction leaks of other providers so that we cen propose it in useful pieces, but it is still hard. | 21:49 |
| katco | wwitzel3: i would be really interested if someone wanted to do a hangout or writeup where they demonstrate a methodology for pipelining changes; i.e.: finish everything up, and then break it up after the fact | 21:50 |
| wwitzel3 | katco: yeah, that would be useful. Maybe eric and I can do something like that if we manage to do it successfully :) | 21:51 |
| katco | wwitzel3: i have faith! :) | 21:51 |
| wwitzel3 | ericsnow: took your idea and sent a mail to dev, linked our branch too .. figure that way if though it isn't up for review yet, people can start poking around. | 22:20 |
| wwitzel3 | ericsnow: also you want help with the merge? how is that going? | 22:20 |
| ericsnow | wwitzel3: it was surprisingly easy | 22:21 |
| wwitzel3 | ericsnow: well thats good :) | 22:21 |
| wwitzel3 | ericsnow: I like that rename of gce -> raw | 22:25 |
| ericsnow | wwitzel3: :) | 22:25 |
| ericsnow | wwitzel3: I'm trying out moving gce.go into it's own package ("gceapi") | 22:26 |
| ericsnow | wwitzel3: so far it makes for a clearer picture | 22:26 |
| wwitzel3 | ericsnow: slightly confusing, but yeah, worth try | 22:27 |
| wwitzel3 | ericsnow: since, google-api-go-client is the gceapi | 22:27 |
| wwitzel3 | ericsnow: our's is the juju-gce-api .. | 22:27 |
| ericsnow | wwitzel3: I'm almost done; we can look it over when you're free | 22:28 |
| wwitzel3 | ericsnow: sounds good | 22:28 |
| wwitzel3 | ericsnow: now is good :) | 22:28 |
| ericsnow | wwitzel3: brt | 22:28 |
| menn0 | anastasiamac: it turns out those annotation changes I was going to make probably aren't necessary | 22:41 |
| menn0 | anastasiamac: no need to worry about conflicts | 22:41 |
| === kadams54 is now known as kadams54-away | ||
| perrito666 | wallyworld: sorry for the delay, I am back | 23:12 |
| wallyworld | perrito666: np, i have ameeting in15 mins, let's have a quick chat, i'll set up a hangout | 23:13 |
| katco | davecheney: ping | 23:13 |
| wallyworld | perrito666: https://plus.google.com/hangouts/_/canonical.com/tanzanite-stand | 23:13 |
| anastasiamac | menn0: that's gr8 news! thnx ;-) | 23:28 |
| === marcoceppi_ is now known as marcoceppi | ||
| davecheney | katco: ack | 23:44 |
| cmars | wwitzel3, ericsnow kudos on the gce provider. i've got some gce credits to burn, looking forward to trying it out! | 23:50 |
| ericsnow | cmars: yeah, we're pretty excited with it :) | 23:50 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!