[00:03] <wwitzel3> cmars: thanks, it has been fun, hopefully the finishing touches won't take too long
[00:19] <katco> davecheney: hey sorry, wifey and kiddo are home
[00:19] <katco> davecheney: but rq, i was wondering if you had time to look at my PR again, i was wondering why the name feature_tests was dangerous?
[00:24] <davecheney> katco: _test as a package name is reserved for external tests
[00:24] <davecheney> the tool will probably let you get away with it
[00:24] <davecheney> but it'll bite us (just like testing in package main did)
[00:24] <katco> davecheney: these are external tests though, correct?
[00:24] <davecheney> also, package names should be alphas only
[00:24] <davecheney> pacakge foo_test is synthesised by the test runner
[00:25] <davecheney> so it's a good idea to stay away from that special cased behaviour
[00:25] <katco> davecheney: feature_testS is as well?
[00:25] <davecheney> katco: please don't use underscores in package names
[00:25] <katco> davecheney: do you have a suggestion?
[00:25] <davecheney> the name of the package should describe what it does, not its contents
[00:26] <davecheney> as a stop gap
[00:26] <davecheney> package featuretests
[00:26] <katco> davecheney: so, something that describes the fact that it runs functional/feature tests
[00:26] <katco> davecheney: i honestly can't think of anything better than featuretests if you don't want an underscore/hyphen
[00:27] <davecheney> i don't have any comment apart from please don't use underscores, or any other punctuation in pacakge names
[00:27] <davecheney> and don't call a package _test
[00:27] <davecheney> 'cos the go tool will end up barfing and we'll hve to back it out
[00:28] <katco> davecheney: so if i were to rename the package, you would lgtm?
[00:28] <davecheney> katco: i guess so
[00:28] <davecheney> does this need to live in the juju repository ?
[00:29] <katco> davecheney: that depends; i think the intent was for developers to have the option of running it, but by virtue of the fact that it is intended for external tests only, it could certainly be external
[00:30] <katco> davecheney: sinzui, wallyworld, and axw all gave verbal agreement on name/location
[00:30] <katco> davecheney: perhaps they could weigh in further
[00:33] <katco> davecheney: as a point of intellectual curiosity, i still don't understand why the go tool will at some future point reject _test packages
[00:38] <wallyworld> katco: what about "featuretests". i really don't care about the _
[00:38] <davecheney> katco: _test is a majic package
[00:38] <davecheney> it never exists on disk
[00:39] <davecheney> is is only syntehsised for external tests by the test runner
[00:39] <davecheney> this magic will bite us
[00:39] <davecheney> please don't anger it
[00:53] <katco> davecheney: wallyworld: sorry, brushing the little one's teeth for the first time :)
[00:53] <wallyworld> \o/
[00:53] <katco> davecheney: interesting, look at how it laid it out on disk: > pwd
[00:53] <katco> /tmp/go-build388828020/github.com/juju/juju/feature_tests/_test/github.com/juju/juju
[00:54] <katco> feature_tests.test binary is in /tmp/go-build388828020/github.com/juju/juju/feature_tests/_test
[00:54] <katco> so it looks like it generated a blank _test directory within feature_tests
[00:54] <davecheney> katco: i'm not sure what you want me to say
[00:54] <davecheney> i gave you my advice
[00:55] <katco> davecheney: sorry, i thought you'd be interested. i'm not looking for you to say anything. thanks for the input.
[00:56] <davecheney> i just know this will blow up
[00:56] <davecheney> remembver we have to support Go all the way back to 1.2 shipped in a 3 year old operating system
[00:56] <davecheney> the possiblilities of backporting fixes to those old distros, after two bitter years of trying, is exactly 0%
[01:02] <mattyw> morning all
[01:02] <mattyw> hope everyone had a good holiday
[01:02] <katco> mattyw: happy new years to you sir!
[01:02] <perrito666> mattyw: morning, happy new year
[01:13] <anastasiamac> mattyw: morning! and a Happy 2015 :)
[01:14] <mattyw> katco, perrito666 anastasiamac happy new year all
[01:16] <wallyworld> katco: standup?
[01:16] <katco> wallyworld: shoot brt
[01:18] <perrito666> ohno dying pixel
[01:19] <katco> perrito666: #nopixelleftbehind
[01:19] <perrito666> katco: I discovered today that dell announced my next machine :p now I just need a way to get one of those
[01:20] <katco> perrito666: sweet :)
[01:20] <perrito666> none of you want to visit .ar and save me of customs hell?
[01:40] <katco> axw: package name has been updated; ready for review whenever you're ready
[01:40] <axw> katco: cool, looking now
[02:01] <axw> katco: sorry to be a pain in the butt, but I have a question before I can LGTM
[02:01] <katco> axw: not at all, what's up?
[02:01] <axw> katco: published
[02:01] <katco> axw: k looking
[02:10] <katco> bleh i fail at review board
[02:17] <axw> katco: so my concern is there's nothing stopping unit X from requesting leadership for unit Y, but from your response that's what William wants? what are the access controls *meant* to be? I don't think there's any precedent for a free-for-all
[02:18] <katco> axw: it's an excellent point. again he brought up several examples wherein the unit getting leadership might not be the unit requesting it. i believe they were hypotheticals.
[02:19] <katco> axw: i think in general, he is trying to be sensitive to bulk-first architecture, but the cross section of that and leadership is interesting to say the least
[02:19] <thumper> menn0: yep, there was a problem with the creation of the environments, test and patch coming
[02:19] <thumper> menn0: just running all the tests to catch bad tests
[02:19] <katco> axw: and just for fun i'll throw the fact in that i could have misinterpreted :)
[02:20] <axw> katco: can that particular change be reverted, and moved to a separate PR that fwereade can take a look at?
[02:20] <axw> katco: I'm not comfortable with it, but I don't want to block the rest
[02:21] <katco> axw: i'm due to talk with him tomorrow about leadership, why don't i just bring it up there and see what he has to say
[02:21] <axw> katco: okey dokey
[02:21] <axw> thanks
[02:21] <katco> axw: thanks for the review :)
[02:21] <axw> nps
[02:21] <katco> axw: 10 points!
[02:25] <ericsnow> wwitzel3: FYI, I've updated the branch with the gceapi commit
[02:25] <ericsnow> wwitzel3: I've broken some tests but wanted to get up what I had before calling it a night
[02:26] <ericsnow> wwitzel3: we can change the name too
[02:26] <ericsnow> wwitzel3: I may check back in later, but maybe not :)
[02:36] <menn0> menn0: ok. want me to review when it's ready?
[02:37] <menn0> thumper: ^^ :)
[02:37] <wwitzel3> ericsnow: sounds good, thanks :)
[02:38] <thumper> menn0: http://reviews.vapour.ws/r/690/
[02:38] <thumper> menn0: full test run is still going
[02:38] <thumper> but I expect it to finish shortly
[02:38] <thumper> (running again)
[02:38] <thumper> first run found one other place in the code where we were doing it wrong
[02:39] <thumper> just finished, all tests pass locally
[02:40]  * menn0 looks
[02:44] <menn0> thumper: is that factory change supposed to be there?
[02:45] <menn0> thumper: it appears like you intend the type of factory.EnvParams.Owner to change but I don't see that
[02:45] <menn0> thumper: never mind
[02:45] <menn0> thumper: i'm being stoopid
[02:45] <menn0> thumper: ship it
[02:45] <thumper> :)
[02:46] <thumper> ta
[02:46] <menn0> thumper: just a typo in that test name
[02:46] <thumper> fixing
[02:48] <thumper> menn0: and thanks
[02:55] <anastasiamac> axw: about facade version numbering...
[02:56] <anastasiamac> axw: should they start at 0 or 1?
[02:56] <anastasiamac> axw: i have seen a few 0s when I was adding mine...
[02:58] <thumper> ah fark.....
[02:58]  * thumper headdesks
[02:59] <anastasiamac> thumper: again?..
[02:59] <axw> anastasiamac: sorry, was afk
[02:59] <axw> anastasiamac: new ones should be 1
[02:59] <thumper> anastasiamac: nothing to do with you
[03:00] <axw> anastasiamac: 0 is for the facades that existed before we had versioning
[03:00] <axw> or something like that
[03:02] <anastasiamac> axw: oh! thnx - that makes sense ;)
[03:02] <anastasiamac> thumper: i was not expecting it to do with me
[03:03] <anastasiamac> thumper: but ur desk must be very sturdy with all this stress relief :p
[03:24] <anastasiamac> axw: I'll add this explanation to api/facadeversions.go for future references :0
[03:24] <axw> anastasiamac: SGTM, thanks
[03:25] <axw> anastasiamac: I think jam would be able to clarify the rationale, maybe ask him to review
[03:26] <anastasiamac> jam, ping :)
[03:26] <anastasiamac> axw: thnx ;-)
[03:26] <axw> a bit early I think
[03:26] <jam> axw: anastasiamac: I'm up, but currently in leads meeting
[03:27] <axw> no rest for the wicked/leads :)
[03:29] <anastasiamac> axw: :) or OCRs
[03:30] <anastasiamac> axw: could u plz cast ur eyes on my annotations PR when u get a chance?
[03:30] <axw> anastasiamac: yup, just finishing up with another
[03:31] <anastasiamac> axw: tyvm :p
[03:51] <anastasiamac> m trying to update dependencies.tv with newer version of names... i get the commit hash, I get the date but what is the date suffixed with? for eg. what's T02:50:22Z?
[03:51] <anastasiamac> axw: ^^?
[03:52] <axw> anastasiamac: just use godeps to get the correct values
[03:52] <anastasiamac> how?
[03:52] <axw> anastasiamac: godeps ./... | grep names >> dependencies.tsv
[03:52] <axw> then fix up by hand
[03:52] <axw> that's how I do it anyway. there's probably a smarter way
[03:54] <ericsnow> axw: this (from Nate) works for me: "GOOS=windows godeps -t ./... > dependencies.tsv"
[03:54] <anastasiamac> axw: i know what names commit i want dependencies.tsv to contain
[03:55] <anastasiamac> axw: ericsnow: i know what date to put as well, i just don't get the last charas?..
[03:55] <anastasiamac> chars even
[03:55] <axw> anastasiamac: not sure what date you're talking about?
[03:55] <ericsnow> anastasiamac: just set your names repo to that commit and then let godeps sort it out for you
[03:55] <axw> anastasiamac: ah, the date at the end of the git lines - that's from a newer version of godeps I believe
[03:55] <ericsnow> axw: newer versions of godeps put a date along with some of the revisions
[03:55] <anastasiamac> ericsnow: axw: I have updated names repo and need juju dependencies.tsv to have my commit in it
[03:56] <ericsnow> anastasiamac: with the names repo set to the revision you want, run the command I listed and see what it writes to dependencies.tsv
[03:58] <anastasiamac> ericsnow: this removed all dates
[03:58] <ericsnow> anastasiamac: I'm guessing your godeps is older then
[03:59] <ericsnow> anastasiamac: try "go get -u launchpad.net/godeps && go install launchpad.net/godeps" or something like that
[04:01]  * anastasiamac updating godeps
[04:01] <anastasiamac> ericsnow: thnx :) got it ;-0
[04:01] <ericsnow> anastasiamac: :)
[04:06] <jam> anastasiamac: so pong now, in case there is something you still need clarity on
[04:07] <anastasiamac> jam: just to confirm - axw's understnading of facade versioning:
[04:08] <anastasiamac> jam: initial numbering - 1 for new facades, 0 for facades that existed before versioning
[04:08] <anastasiamac> jam: ?
[04:09] <thumper> night all
[04:09]  * thumper goes to walk dogs
[04:09] <axw> night
[04:09] <jam> anastasiamac: the "0" version is for things that were in 1.18 (pre-versioning), yes
[04:10] <anastasiamac> jam: axw: thnx for clarification. I'll add it as a comment to facadeversions on my brnach :-)
[04:11] <anastasiamac> branch*
[04:16] <axw> anastasiamac: did you just rename annotator.go to annotations.go, or are there other changes in that file?
[04:17] <axw> oh it's not renamed at all, just extracted
[04:17] <anastasiamac> axw: there r other changes... like GlobalEnitty
[04:17] <axw> anastasiamac: I meant annotator.go specifically
[04:17] <anastasiamac> axw: m going to remove annotator.go in the next PR
[04:17] <axw> oh I see
[04:18] <anastasiamac> axw: also state is now passed in
[04:18] <anastasiamac> axw: current annottor is written with embedding into entities in mind
[04:19] <anastasiamac> axw: my implementation ensures that the new annotations does not need to b embedded
[04:19] <axw> right
[04:19] <axw> so I see
[04:19] <axw> sgtm
[04:20] <anastasiamac> axw: :)
[04:22] <axw> anastasiamac: reviewed
[04:22]  * axw disappears for lunch
[06:01] <anastasiamac> fwereade: ping
[07:15] <fwereade> anastasiamac, pong
[07:15] <fwereade> anastasiamac, getting rid of that embedding sounds like a good thing to me, that always felt like a timebomb
[07:16] <anastasiamac> fwereade: about bulk annotation calls, i've sent u an email. Just thought i'd give u a heads-up ;-)
[07:16] <fwereade> anastasiamac, ty
[07:16] <anastasiamac> fwereade: m glad u feel this way about embedding ;)
[07:30] <anastasiamac> axw: r u k to drop annotation bulk call review comments until I get confirmation from intrested parties? I'd love to land what I have so far and address the rest in separate PR...
[07:30] <anastasiamac> axw: pretty plz? :)
[07:31] <jam> fwereade: ping for status chat
[07:31] <axw> anastasiamac: not really, because 1.22 is about to go out and then this is set in stone...
[07:32] <axw> anastasiamac: if you go with my suggestion then everybody should be happy because it can handle any combination in one bulk call
[08:30] <TheMue> morning
[08:30] <axw> morning
[08:39] <dimitern> wallyworld_, still around?
[08:45] <anastasiamac> axw: addressed :) when u get a chance, could u plz inspect? :P
[08:52] <axw> anastasiamac: looking
[08:59] <axw> anastasiamac: reviewed
[09:24] <anastasiamac> axw: thnx!
[09:25] <axw> nps
[09:58] <voidspace> dimitern: TheMue: I'll be a couple of minutes late to standup
[09:58] <voidspace> see you soon, sorry!
[09:58] <dimitern> voidspace, ok, no
[09:58] <dimitern> np even :)
[10:02] <voidspace> dimitern: omw
[11:03] <wallyworld_> dimitern: hi, was away for a bit
[11:04] <wallyworld_> voidspace: i think you're ocr? if you get a chance, i'd love to be able to land http://reviews.vapour.ws/r/692/
[11:04] <dimitern> wallyworld_, hey, I wanted to ask are you willing to help now and then with goamz reviews/maintenance on github, as you've contributed in the past
[11:04] <wallyworld_> sure
[11:04] <wallyworld_> i'm not an expert but happy to help
[11:04] <dimitern> wallyworld_, ok, you have an invite already :)
[11:05] <wallyworld_> ok, will look, probably tomorrow, am tired tonight
[11:05] <dimitern> wallyworld_, no worries, we'll get community members to help as well
[11:05] <dimitern> wallyworld_, sure, have a good one :)
[11:05] <wallyworld_> will do
[12:03] <voidspace> wallyworld_: nope, ericsnow and axw
[12:03] <voidspace> wallyworld_: I can look in a bit if they don't get to it
[12:05] <wallyworld_> voidspace: ah, oh, sorry, i'm a day out. i can wait till tomorrow
[12:09] <voidspace> wallyworld_: looking at it now
[12:10] <wallyworld_> i owe you one, thanks
[12:15] <frankban> katco, wallyworld_ : thank you both for the reviews! I replied to some of your comments and I have some questions, (however I am not sure I understand how review board works with comments). could you please take another look when you have time?
[12:15] <wallyworld_> frankban: will do
[12:15] <frankban> ty
[12:28] <voidspace> wallyworld_: so imagemanager and the Client, with DeleteImage method, is pre-existing
[12:29] <voidspace> wallyworld_: this is just the command to expose it
[12:29] <wallyworld_> voidspace: yeah, all the api and apiserver stuff landed in a previous branch. this is just to add a juju command it use it
[12:29] <wallyworld_> yep
[12:29] <voidspace> wallyworld_: LGTM
[12:29] <wallyworld_> voidspace: you rock, tyvm
[12:30] <voidspace> wallyworld_: a disturbing amount of boilerplate required just for TestDeleteImage though
[12:30] <voidspace> wallyworld_: the mocking, the patching, the fakes
[12:30] <voidspace> wallyworld_: not that I see a better way
[12:30] <wallyworld_> yeah. i find i complain about biolerplate in general with go
[12:30] <wallyworld_> lack of generics etc makes it unavoidable
[12:30] <voidspace> wallyworld_: and as a result of it, you don't actually test that the delete command calls the DeleteImage client method
[12:31] <voidspace> right
[12:31] <voidspace> you check the api method is called - but that is mocked out, so it's not tested
[12:31] <wallyworld_> true, i think you are right, i'm more or less following established patterns
[12:32] <voidspace> yeah, effectively we test the layers but don't test through all the boundaries
[12:32] <wallyworld_> we are introducing a featuretests package for integration tests
[12:32] <voidspace> cool
[12:32] <voidspace> anyway, I added my ShipIt
[12:32] <wallyworld_> the first cab off the rank is katherine's leadership service tests
[12:33] <wallyworld_> so with featuretests, we can add a tests to check the end-end wiring
[12:33] <voidspace> great
[12:33] <wallyworld_> so we have a mix of fast *unit* tests and fewer slower intergration tests
[12:34] <wallyworld_> work in progress
[12:34] <wallyworld_> thanks for lgtm, i can now land this to meet the 1.22 deadline
[12:42] <rick_h_> jam: still around?
[13:23]  * perrito666 reads a little wtf in a review answer and gets a small brain freeze like sensation
[13:48] <jam> rick_h_: hey
[13:49] <rick_h_> jam: howdy, got a few min I can steal sorry for the post-hours?
[13:49] <jam> rick_h_: calling you now https://plus.google.com/hangouts/_/guyjqtpuoh55ecfsilhje5smdia
[14:58] <ericsnow> wwitzel3: ping
[15:02] <wwitzel3> oh right
[15:07] <wwitzel3> ericsnow: no one is here ..
[15:10] <katco> fwereade: ping
[16:44] <ericsnow> jw4: ping
[16:57] <ericsnow> fwereade: you still around?
[17:21] <frankban> wallyworld_: I updated my branch to reuse the code in envcmd for the default environment. I'll wait for Tim about naming issues
[17:46] <gsamfira_> hello folks
[17:46] <gsamfira_> I was doing a deploy of juju 1.21  beta5 on MaaS and noticed that the --constraints argument is ignored
[17:47] <gsamfira_> looking at: https://github.com/juju/juju/blob/1.21/provider/maas/environ.go#L781 , it seams that the Constraints field is missing
[17:47] <gsamfira_> is this by design?
[18:03] <perrito666> ericsnow: wwitzel3 ?
[18:03] <perrito666> weekly random time meeting?
[18:03] <wwitzel3> perrito666: omw
[18:04] <voidspace> rebooting and then coming (weird unity freeze thing I need to get rid of to use the browser)
[18:05] <dimitern> TheMue, are you around for the team meeting?
[18:05] <perrito666> cmars: ?
[18:08] <voidspace> dimitern: as you're still around...
[18:08] <voidspace> dimitern: https://code.launchpad.net/~mfoord/gomaasapi/nodegroupsinterfaces/+merge/245891
[18:08] <dimitern> voidspace, sure, will have a look
[18:41] <voidspace> g'night all
[18:41] <wwitzel3> nn voidspace
[18:41] <dimitern> voidspace, i'm reviewing your MP and will send a review
[18:41] <voidspace> wwitzel3: o/
[18:41] <voidspace> dimitern: cool, thanks
[18:41] <dimitern> voidspace, have a good one ;)
[18:41] <alexisb> o yeah, there is totally uber in tokyo:
[18:41] <alexisb> http://www.bloomberg.com/news/2014-08-05/uber-expands-tokyo-service-to-include-taxi-booking.html
[18:42] <katco> i forgot to mention for anyone who was interested in the spec: it also generates the interfaces for all of the code to ensure parity
[18:42] <katco> so what you see in the spec is directly in the codebase
[18:42] <alexisb> katco, have you and jam talked about your spec format before?
[18:42] <alexisb> if not we should make that happen
[18:43] <katco> alexisb: i have not
[18:44] <katco> alexisb: i have something regarding leadership to discuss with him as well. it's low-priority, but we could definitely fill a meeting with the 2 topics
[18:45] <alexisb> katco, you should get on his calendar
[18:45] <katco> alexisb: will do, i'll send him an email
[18:45] <alexisb> I would offer to set if up but with your earlier timezone you have a better chance of getting on the calendar solo
[18:45] <katco> what tz is he?
[18:46] <katco> why am i asking, it's right here lol
[18:47] <katco> so 10h difference
[18:47] <dimitern> alexisb, yeah, uber started in sofia recently as well
[18:48] <alexisb> dimitern, cool
[18:48] <alexisb> katco, keep in mind he has his son in the afternoon after school
[18:49] <katco> alexisb: ok ty for the info
[18:49] <dimitern> katco, i can't wait for that blog post :)
[18:50] <katco> dimitern: i'm about halfway done, i will let you know :)
[18:50] <dimitern> katco, my org mode skills so far include only storing my emacs conf in org babel source blocks and some todo lists :)
[18:50] <dimitern> awesome
[18:50] <katco> dimitern: this is even easier; it's basically a plain-text outline that you just export
[18:50] <katco> dimitern: if you can write markdown, you can do this just as easily
[18:51] <dimitern> katco, cool! i suppose it goes via latex to generate the pdf
[18:51] <katco> dimitern: yes, exactly
[18:51] <katco> dimitern: i also got it to export and odf, but it's not nearly as nice
[18:52] <katco> dimitern: but i suppose the important thing is that you don't need to know latex or anything to produce one, just how to write an outline in org mode
[18:53] <dimitern> katco, that's way better!
[18:53] <katco> dimitern: yeah, essentially these things just fall out of the notes i take when i'm gathering requirements. it's so easy
[18:54] <perrito666> dimitern: I wonder, do you know the answer to gsamfira_ question??
[18:54] <katco> well, for me. but i don't think it should be hard for the uninitiated either
[18:54]  * katco goes to grab lunch
[18:54] <dimitern> katco, +1
[18:54] <dimitern> perrito666, hmmm - what's that?
 hello folks
 I was doing a deploy of juju 1.21  beta5 on MaaS and noticed that the --constraints argument is ignored
 looking at: https://github.com/juju/juju/blob/1.21/provider/maas/environ.go#L781 , it seams that the Constraints field is missing
 is this by design?
[18:56] <dimitern> perrito666, gsamfira_ it is by design because constraints are processed earlier
[18:56] <gsamfira_> dimitern: then something happens, because acquireNode never sends tags to maas
[18:56] <gsamfira_> so you get a random node
[18:56] <dimitern> gsamfira_, ah, wait .. that's total bs
[18:56] <gsamfira_> if you have a maas install handy, give it a shot
[18:57] <dimitern> gsamfira_, it seems they need to be there as an arg
[18:57] <dimitern> gsamfira_, that has changed recently, I guess with the AZ distribution logic
[18:57] <dimitern> gsamfira_, *please* file a bug about it
[18:58] <gsamfira_> sure thing
[18:59] <dimitern> gsamfira_, thanks! I'll have a look in the morning
[18:59] <gsamfira_> sure. The fix is easy. Just add Constraints field :). Not sure if its correct, but it works :)
[19:01] <gsamfira_> dimitern: https://bugs.launchpad.net/juju-core/+bug/1408762
[19:01] <mup> Bug #1408762: --constraints option is ignored on MaaS provider <juju-core:New> <https://launchpad.net/bugs/1408762>
[19:02] <dimitern> gsamfira_, cheers!
[19:43] <perrito666> sometimes I feel we use the word status a bit too much
[19:45] <wwitzel3> need a status update on the status of health status
[19:45] <alexisb> :)
[19:49] <perrito666> wwitzel3: I am dealing with the status of the entity, which is analog to going to a toolshop asking the thing to put the thiguie in there
[20:25] <bac> hi marcoceppi, recently you fixed the install hook on squid-reverseproxy for precise.  could you make that fix for the trusty version too