| stub | wgrant: https://code.launchpad.net/~stub/launchpad/trivial/+merge/245822 | 08:52 |
|---|---|---|
| stub | wgrant: I also notice we currently have requests 1.2, but latest is 2.5.1. Worth updating that too do you think? | 08:53 |
| wgrant | stub: If it doesn't break the test suite, why not. | 08:53 |
| stub | I won't know that until buildbot tells me. I've only run the swift tests. | 08:54 |
| wgrant | I don't think we use requests for anything else. | 08:54 |
| stub | I'll give it a shot, see if there is fallout | 08:54 |
| stub | We must be using it for something else, as I don't think the previous swiftclient version used it | 08:58 |
| stub | swift tests pass with updated requests, so pushing that. | 09:00 |
| stub | If this doesn't close the leak, then the next step is to override the default HTTPConnection class and give it a close() method | 09:01 |
| stub | Beyond that, I think we would need instrumentation on your test case. Track down which of the dozen layers is actually holding things open. | 09:03 |
| wgrant | Yeah, I was doing that but then production caught on fire. | 09:05 |
| cjwatson | wgrant: Yep, plugging through getting the plugin tests working but making good progress now. | 10:16 |
| cjwatson | Finally, got past the "I'm in a maze of Twisted and nothing works" stage with txpkgupload, so now just converting tests one by one to the new world order. | 18:03 |
| wgrant | cjwatson: Sounds like you're just about there. Good news, I expected learning Twisted server bits would take longer :) | 23:16 |
| cjwatson | The hard bits turned out to be sorting out the clients for the tests. | 23:18 |
| cjwatson | Not least because fixtures and Deferreds are not quite totally friends in all the necessary ways. | 23:19 |
| cjwatson | I think the biggest piece that's left is putting together a mock object to pretend to be the LP xmlrpc authserver thingy. | 23:23 |
| cjwatson | Hm, maybe I can get most of that from lazr.sshserver though. Tomorrow ... | 23:24 |
| wgrant | That's a single XML-RPC method, though. | 23:34 |
| wgrant | There's another nearby codebase you can look at that has an example of a single-method Twisted XML-RPC server emulating Launchpad./ | 23:34 |
| cjwatson | Sounds like a test. Um, bzr? | 23:38 |
| cjwatson | No, wait, no Twisted there. | 23:38 |
| wgrant | Not a test, just something that isn't public yet. | 23:38 |
| cjwatson | Oh *that* one. | 23:38 |
| cjwatson | Ta, I see it now :) | 23:39 |
| wgrant | Not dreadfully difficult, fortunately. | 23:42 |
| cjwatson | No, quite. | 23:43 |
| wgrant | Oh how I enjoy Python garbage collection internals. | 23:45 |
| cjwatson | Hm, Launchpad uses ssh-vulnkey. Does it have to keep doing so? | 23:47 |
| wgrant | What's it been? 6.5 yaers? | 23:48 |
| cjwatson | Since I dropped that in openssh 1:6.5p1-1, so it's not in trusty. | 23:48 |
| wgrant | Yeah, probably worth killing. | 23:48 |
| cjwatson | About that, yes. | 23:48 |
| cjwatson | I'll stick it in asana | 23:49 |
| wgrant | blr, cjwatson: We should arrange a meeting time on Monday/Tuesday. I guess UK Monday evening, APAC Tuesday morning is probably best? | 23:54 |
| wgrant | Oh, Kit's not here. | 23:54 |
| cjwatson | Hm, I'd slightly planned to go out and see some humans on Monday evening | 23:56 |
| cjwatson | Depends on the time | 23:57 |
| cjwatson | (because I had to miss my pub night tonight because children) | 23:57 |
| wgrant | Oh, sure. | 23:57 |
| cjwatson | Is UK Tuesday evening / APAC Wednesday morning possible? | 23:57 |
| wgrant | That's fine with me. | 23:58 |
| cjwatson | I should check with Kirsten if it's going to be a routine thing, but I'm sure we can work something out | 23:58 |
| cjwatson | (and I guess it should be a routine thing) | 23:59 |
| wgrant | Right, I want to fix a meeting time early in the week. | 23:59 |
| wgrant | I'm very flexible. | 23:59 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!