| tsdgeos | Saviq: so i found why the dash tests were failing | 08:57 |
|---|---|---|
| tsdgeos | and it sucks :D | 08:57 |
| Saviq | tsdgeos, hit me | 08:57 |
| tsdgeos | basically the precission of some widths goes crazy and since we're clicking on 0x0 after the million transformations of pos into pos into pos | 08:57 |
| tsdgeos | we end up clicking on 0, -0,0000somthing | 08:57 |
| tsdgeos | i.e. out of the area | 08:58 |
| Saviq | .. | 08:58 |
| Saviq | doesn't our mouseClick default to the middle these days? | 08:58 |
| tsdgeos | yeah | 08:58 |
| tsdgeos | nope | 08:58 |
| tsdgeos | it does with http://paste.ubuntu.com/9697260/ | 08:58 |
| Saviq | well, yeah, that's what I meant | 08:58 |
| tsdgeos | and i'll be proposing the change upstream too | 08:58 |
| Saviq | yeah, makes total sense | 08:58 |
| tsdgeos | so we don't need the overrides of mouseClick on UnityTestCase | 08:59 |
| tsdgeos | it's actually a bug in somewhere | 08:59 |
| Saviq | right | 08:59 |
| tsdgeos | since printing widths | 08:59 |
| tsdgeos | some has with 640 | 08:59 |
| tsdgeos | and the child has 639.999999999999 | 08:59 |
| tsdgeos | which is what starts all the crap | 08:59 |
| tsdgeos | but to be honest it's not like a user will notice | 08:59 |
| tsdgeos | because if he's clicking *so* into the border | 08:59 |
| tsdgeos | he'll expect it to fail if the click doesn't register | 09:00 |
| tsdgeos | so i'd say click on the middle and carry on | 09:00 |
| Saviq | +1 | 09:06 |
| Saviq | tsdgeos, are you proposing that change? I just rebuilt our vivid silo but could just as well wait for that | 09:08 |
| tsdgeos | Saviq: i am if you give me 10 mins | 09:08 |
| Saviq | kk | 09:08 |
| tsdgeos | i'm also changing all those that had width/2, height/2 to have nothing | 09:08 |
| tsdgeos | looks much cleaner | 09:08 |
| tsdgeos | when reading | 09:08 |
| Saviq | agreed | 09:08 |
| tsdgeos | Saviq: and if you can get someone to review https://code.launchpad.net/~aacid/unity8/enterSpreadTest/+merge/245928 we'll get rid of the other flacky test | 09:10 |
| tsdgeos | mzanetti: ↑ ? | 09:10 |
| mzanetti | ack | 09:10 |
| Saviq | tsdgeos, mzanetti, already done | 09:11 |
| tsdgeos | Saviq: https://code.launchpad.net/~aacid/unity8/mouseClickMiddle/+merge/245932 | 09:20 |
| Saviq | tsdgeos, o/ | 09:20 |
| tsdgeos | hmmm | 09:22 |
| tsdgeos | wot, lots of tests failing now | 09:22 |
| tsdgeos | give me a sec :D | 09:22 |
| Saviq | tsdgeos, yeah, fails here, too | 09:23 |
| tsdgeos | i think i copy pasted something wrong | 09:23 |
| Saviq | tsdgeos, but actually, trunk fails for me too, at least in PreviewActions | 09:24 |
| Saviq | hmm no | 09:25 |
| Saviq | ah, | 09:25 |
| Saviq | make install | 09:25 |
| Saviq | or well, make | 09:25 |
| tsdgeos | oh lol | 09:28 |
| tsdgeos | somehow i dropped the ! from | 09:28 |
| tsdgeos | if (qtest_events.mouseClick(item, x, y, button, modifiers, delay)) | 09:28 |
| tsdgeos | Saviq: ok, should be fine now | 09:45 |
| Saviq | tsdgeos, tx, testing | 09:45 |
| Saviq | tsdgeos, now, are you venturing into the AP test flakiness at all? | 09:59 |
| tsdgeos | Saviq: i'll give it a go yeah | 10:04 |
| Saviq | thanks | 10:04 |
| Saviq | mzanetti, btw, did LP notify you about bug #1408819 ? | 10:08 |
| ubot5 | Error: Launchpad bug 1408819 could not be found | 10:08 |
| Saviq | https://bugs.launchpad.net/ubuntu-rtm/+source/unity8/+bug/1408819 | 10:08 |
| mzanetti | nope | 10:08 |
| Saviq | mzanetti, crash when tapping on the top quicklist item in rtm | 10:08 |
| Saviq | mzanetti, has there been changes to launcher backend in vivid that are not in rtm? | 10:08 |
| mzanetti | ack, fixing | 10:08 |
| mzanetti | not that I know of | 10:08 |
| === karni is now known as karni-away | ||
| mzanetti | investigating | 10:09 |
| Saviq | mzanetti, yeah, that's what I thought, so not even sure we're to blame, hopefully the stacktrace will help | 10:09 |
| Saviq | it basically crashes in url-dispatcher | 10:09 |
| mzanetti | if it's 100 reproducible it should be clear soon | 10:09 |
| Saviq | in utf8 encoding/decoding... but not every time ¿? | 10:10 |
| Saviq | it is | 10:10 |
| Saviq | but only rtm | 10:10 |
| Saviq | can get you a set of dbgsym packages if you want | 10:10 |
| mzanetti | let me see | 10:11 |
| Saviq | url = 0x281ceb0 "tu.calculator/calculator/current-useA" | 10:12 |
| Saviq | mzanetti, looks suspicious ↑ | 10:12 |
| mzanetti | it does :) | 10:12 |
| mzanetti | but it doesn't happen if you just normally click the icon? | 10:13 |
| mzanetti | (battery won't let me turn on my rtm device yet) | 10:13 |
| Saviq | mzanetti, yeah, does not | 10:14 |
| Saviq | mzanetti, and actually for me it only happens the second time I try | 10:14 |
| mzanetti | hmm... for me it doesn't happen at all :/ | 10:14 |
| mzanetti | nope... not happening | 10:17 |
| mzanetti | meh | 10:17 |
| mzanetti | hah. got it reproduced on krillin. not on mako with rtm though... strange | 10:21 |
| tsdgeos | Saviq: i've updated the MR a bit | 10:25 |
| Saviq | mzanetti, right, yeah, it seems to be krillin specific indeed | 10:26 |
| Saviq | heh, /me just understood what's happening... my touchpad does kinetic scrolling *internally* | 10:27 |
| mzanetti | Saviq: ? | 10:28 |
| Saviq | which means that if I scroll in one window and move with the mouse (not touchpad) or something changes under the cursor... the scrolling happens on whatever is currently under the cursor | 10:28 |
| mzanetti | oh yeah... have that too | 10:28 |
| mzanetti | esp. alt+tab goes crazy :D | 10:29 |
| Saviq | right, like WTF | 10:29 |
| Saviq | it actually generates events for *multiple seconds* after I stopped touching it | 10:30 |
| mzanetti | ýep | 10:30 |
| Saviq | who thought of that ;/ | 10:30 |
| mzanetti | depends on how strong you flick | 10:30 |
| Saviq | wouldn't think Apple did that | 10:31 |
| mzanetti | hmm... tbh I haven't had this in KDE with same hardware | 10:31 |
| === karni-away is now known as karni | ||
| Saviq | mzanetti, doubt that, you must've just not noticed it, it's definitely hw (well, driver) | 10:37 |
| mzanetti | hmm... hard to believe too... because atm I scale my qtcreator font like twice a day because of this | 10:39 |
| mzanetti | it might be that the driver didn't do it back then | 10:39 |
| Saviq | yeah, it's probably a change between utopic and vivid or something | 10:40 |
| mzanetti | happened already in utopic for me | 10:40 |
| mzanetti | not sure about trusty - but that's the time I switched to unity | 10:40 |
| Saviq | mzanetti, when https://ci-train.ubuntu.com/job/ubuntu-landing-024-1-build/29/console completes, it'll be ready for testing | 10:43 |
| mzanetti | ack | 10:43 |
| MacSlow | Why can't I call a public Q_INVOKABLE method from an object returned by ListModel.get(i) like someListModel.get(i).method(), but only directly from the object itself myObject.method(), which was added to the ListModel with someListModel.append(myObject)? | 10:45 |
| MacSlow | I can easily access and change regular/public properties via someListModel.get(i).property | 10:46 |
| MacSlow | Saviq, mzanetti, tsdgeos: ^ any idea? | 10:50 |
| tsdgeos | MacSlow: are you registering the object metatye? | 10:51 |
| tsdgeos | metatype | 10:51 |
| MacSlow | tsdgeos, in my mock's plugin I do the usual qmlRegisterType<MockNotification>(...) if that's what you mean | 10:52 |
| tsdgeos | can't think of a reason really | 10:54 |
| MacSlow | tsdgeos, I don't use Q_DECLARE_METATYPE in my mock and thus follow the real implementation, which also does not use it for the Notification object/class. | 10:57 |
| MacSlow | making this qmltest work with the mocked Notification is a real pain | 11:00 |
| Saviq | MacSlow, prolly best to push some code | 11:00 |
| MacSlow | tsdgeos, Saviq: just pushed the current state... if some one can help out... I'm basically lost and don't know why it's not working | 11:04 |
| MacSlow | that's the branch lp:~macslow/unity8/swipe-dismiss-snap-decisions | 11:04 |
| Cimi | mzanetti, got my launcher stuck 2 px on screen when hidden, is it something you think can happen with current code or was due to mterry's refactor for the edge demo? | 11:04 |
| mzanetti | Cimi: hmm... haven't seen it before | 11:05 |
| Cimi | might be his branch then | 11:05 |
| Cimi | mzanetti, http://paste.ubuntu.com/9697734/ | 11:06 |
| Cimi | mzanetti, unless you can quickly spot an issue here, I will ask him | 11:07 |
| mzanetti | looking | 11:07 |
| Saviq | MacSlow, tests/mocks/Unity/Notifications/MockNotificationTypes.h:41: Warning: Property declaration rawActions has no READ accessor function or associated MEMBER variable. The property will be invalid. | 11:07 |
| mzanetti | Cimi: hmm... might well be this, yes, but can't tell where. line 71/72 from the paste look suspicious as it influences the move delta below | 11:08 |
| Saviq | MacSlow, tryNotifications doesn't work btw | 11:09 |
| Cimi | mzanetti, ok, will ask him | 11:09 |
| Cimi | thanks | 11:09 |
| MacSlow | Saviq, I know... that's what I'm trying to fix | 11:09 |
| MacSlow | Saviq, the split between rawActions and actions is because of the way actions have to be passed in via the qmltest | 11:10 |
| Saviq | MacSlow, you're using a ListModel, that's why | 11:11 |
| Saviq | MacSlow, ListModel really isn't geared towards storing objects, it basically is a proxy to properties | 11:12 |
| Cimi | mzanetti, shall we use 0 in the test comparison? https://code.launchpad.net/~mzanetti/unity8/fix-left-edge-on-spread/+merge/243400 | 11:13 |
| Saviq | getRaw isn't even documented | 11:13 |
| MacSlow | Saviq, getRaw() is needed/used because QML can't deal with QSharedPointers directly | 11:15 |
| Saviq | MacSlow, I know, but ListModel does not have a getRaw method | 11:15 |
| Saviq | at least not one that would do what you expect it to | 11:15 |
| MacSlow | Saviq, so I've to change from ListModel to ListView?! | 11:16 |
| Saviq | MacSlow, no, you need a custom mock Model | 11:16 |
| MacSlow | Saviq, *sigh* yet more mocking... all that code just to get close() to work | 11:17 |
| Saviq | MacSlow, ListModel is a very dumb thing | 11:17 |
| * MacSlow goes in a corner and cries | 11:17 | |
| mzanetti | Cimi: whatever :) | 11:18 |
| Saviq | MacSlow, as you're just reusing the same Notification objects, you can probably just reference them directly | 11:18 |
| * davmor2 throws wet sponges at macslow to hide his tears......don't let the code see it is destroying your soul ;) | 11:20 | |
| Saviq | MacSlow, but I imagine sooner or later you'll want your mock model to be smarter, so you'll need an actual mock model at some point anyway | 11:20 |
| facubatista | Holas | 11:20 |
| MacSlow | davmor2, :) | 11:21 |
| MacSlow | Saviq, I wouldn't mind the amount of work, if the cost-benefit relation was reasonable... but in this particular case (for the swipe-to-dismis qmltest) it's appallingly bad | 11:22 |
| Saviq | MacSlow, that's why I'm saying - go for a shortcut | 11:23 |
| Saviq | MacSlow, you have static Notification objects on which the .close() method is called | 11:24 |
| Saviq | aah wait | 11:24 |
| Saviq | now I get it | 11:24 |
| Saviq | it's the real implementation that requires getRaw to work | 11:24 |
| MacSlow | yes | 11:24 |
| Saviq | MacSlow, still, put all the Notification objects in a list | 11:24 |
| Saviq | MacSlow, and in getRaw | 11:24 |
| Saviq | MacSlow, iterate over that, and find the one with the right nid | 11:25 |
| Saviq | instead of trying to pull it out of the ListMoel | 11:25 |
| Saviq | Model, even | 11:25 |
| Saviq | tsdgeos, hum, mouseClickMiddle got a segfault | 11:25 |
| tsdgeos | yeah, but it's old code i guess something got weird | 11:26 |
| tsdgeos | let the new code run | 11:26 |
| Saviq | ah | 11:26 |
| Saviq | ok let's see | 11:26 |
| tsdgeos | actually i'm not sure it's a segfault | 11:27 |
| tsdgeos | when we get segfaults the log says "Segmentation Fault" usually | 11:27 |
| tsdgeos | in this case it's "killed" | 11:27 |
| Saviq | actually not segfault | 11:27 |
| Saviq | wth | 11:27 |
| tsdgeos | no idea who killed it | 11:27 |
| Saviq | there was a test failure too | 11:27 |
| tsdgeos | yep | 11:27 |
| tsdgeos | that's what the other change fixes | 11:27 |
| Saviq | but yeah, let's see the new run | 11:27 |
| Saviq | kk | 11:27 |
| Saviq | MacSlow, see what I mean? | 11:27 |
| tsdgeos | we're clicking exactly in the middle of the two buttons of the categories | 11:27 |
| tsdgeos | and once in a while it goes to "the other" button | 11:28 |
| tsdgeos | that was a valid 0,0 that should not have been blindly replaced :D | 11:28 |
| Saviq | :) | 11:28 |
| MacSlow | Saviq, hm... not really sure... first I'd like to actually see the notifications being added in the tryNotification part | 11:28 |
| MacSlow | Saviq, getting the methods (close() and invokeAciton()) to work would come second then | 11:29 |
| Saviq | MacSlow, your getRaw implementation depends on ListModel to give the model up, but it's not possible | 11:29 |
| Saviq | MacSlow, so put all the Notification { } declarations you have in a list | 11:29 |
| Saviq | or an object so you can reference them by name and not by id | 11:29 |
| MacSlow | Saviq, ok | 11:30 |
| Saviq | and then in getRaw you just go: return dataDict[mockModel.get(id).nid] | 11:30 |
| Saviq | assuming that your keys will be nid | 11:30 |
| MacSlow | Saviq, I see | 11:30 |
| Saviq | or well, nid is integer, so a list would work, too | 11:31 |
| mzanetti | re | 11:44 |
| mzanetti | Cimi: ok, pushed (sorry, my internet connection broke down for the last 10 minutes) | 11:45 |
| mzanetti | Saviq: ok, added some debug stuff. the line that crashes is: | 11:45 |
| mzanetti | QDesktopServices::openUrl(getUrlForAppId(appId)); | 11:45 |
| mzanetti | whereas the passed argument is always: "appid://com.ubuntu.calculator/calculator/current-user-version" | 11:46 |
| Saviq | mzanetti, so it looks like we need to push the bug down to qtubuntu? | 11:49 |
| mzanetti | I'd say so... | 11:49 |
| mzanetti | intersting thing though: | 11:49 |
| mzanetti | I installed url-dispatcher-tools and tried to do "url-dispatcher appid://com.ubuntu.calculator/calculator/current-user-version" | 11:50 |
| mzanetti | now I can't repro any more | 11:50 |
| Saviq | right | 11:53 |
| Saviq | still, please comment on your findings and bump to qtubuntu, maybe add a url-dispatcher task to boot | 11:53 |
| mzanetti | Saviq: done. why is this private? | 11:58 |
| === MacSlow is now known as MacSlow|lunch | ||
| greyback | dednick: could you please merge qtmir trunk into 1355173.trust-prompt-suspend | 12:22 |
| greyback | mzanetti: busy? Could I add a review to your plate: https://code.launchpad.net/~gerboland/qtmir/acquire-wakelock/+merge/245942 | 12:53 |
| mzanetti | greyback: ack | 13:15 |
| greyback | mzanetti: thanks! | 13:15 |
| Saviq | mzanetti, coredump | 13:23 |
| mzanetti | Saviq: ? | 13:25 |
| === MacSlow|lunch is now known as MacSlow | ||
| Saviq | mzanetti, coredumps potentially include private data | 13:25 |
| mzanetti | ah | 13:25 |
| mzanetti | I lost the connection to my question | 13:25 |
| Saviq | mzanetti, so bugs are created private by default | 13:25 |
| mzanetti | ack | 13:25 |
| Saviq | mzanetti, I usually un-private them after they're retraced and the coredump removed, but the retracer doesn't seem to be keen on getting there | 13:27 |
| Saviq | ah actually it's done now | 13:28 |
| mzanetti | yep, a minute ago | 13:28 |
| Saviq | more like over an hour, but yeah | 13:29 |
| Saviq | (private→public is manual) | 13:29 |
| Saviq | greyback, deeep sleep | 13:56 |
| greyback | :D oopsie | 13:56 |
| Saviq | greyback, and missing c in checkDashFocusDoesNotAquireWakeLock | 13:57 |
| greyback | thank you typobot | 13:58 |
| Saviq | nw | 13:58 |
| tsdgeos | can't we run autopilot tests on the destktop anymore? | 13:58 |
| tsdgeos | i get to run them fine on the phone | 13:58 |
| tsdgeos | but desktop | 13:58 |
| tsdgeos | PYTHONPATH=../tests/autopilot autopilot run unity8.indicators.tests.test_indicators.IndicatorPageTitleMatchesWidgetTestCase.test_indicator_page_title_matches_widget | 13:58 |
| Saviq | tsdgeos, https://code.launchpad.net/~saviq/unity8/no-sigstop-main/+merge/245758 | 13:58 |
| tsdgeos | Ran 14 tests in 0.007s | 13:58 |
| tsdgeos | OK | 13:58 |
| tsdgeos | ah that makes sense | 13:58 |
| Saviq | tsdgeos, ah those | 13:58 |
| Saviq | tsdgeos, those never ran on X11 | 13:58 |
| tsdgeos | really? | 13:59 |
| Saviq | tsdgeos, they only have phone scenarios | 13:59 |
| tsdgeos | oh | 13:59 |
| Saviq | tsdgeos, FWIW, those are integration tests, so shoulnd't even live in unity8 | 14:03 |
| Cimi | mterry, did you see my comment? | 14:14 |
| Cimi | oh yes | 14:14 |
| Cimi | just saw mail | 14:14 |
| mterry | :) | 14:16 |
| tsdgeos | it's amazing how often these autopilot tests fail in CI | 14:17 |
| tsdgeos | but running on my phone that is exactly the same setup as CI | 14:17 |
| tsdgeos | can't reproduce :/ | 14:17 |
| davmor2 | tsdgeos: I bet it is not the exact same setup though | 14:24 |
| tsdgeos | davmor2: well i'd like to know what CI does other than flashing and running autopilot that may make it break | 14:25 |
| greyback | tsdgeos: how about if some background process is using lots of CPU (e.g. apport/whoopsie) - maybe that destabilizes the AP test run? | 14:25 |
| tsdgeos | greyback: but why those would be running in CI? | 14:26 |
| greyback | tsdgeos: dunno, just hypothesizing | 14:26 |
| tsdgeos | sure :) | 14:26 |
| davmor2 | tsdgeos: network setup, initial flashing, password and developer mode, the fact that it's behind a restrictive firewall, no cellular except through mocking etc etc | 14:27 |
| Saviq | Cimi, hey, got an update on bug #1363400 ? | 14:27 |
| ubot5 | bug 1363400 in ubuntu-system-settings (Ubuntu RTM) "[wizard] allows to "Continue" without connecting to network" [High,Triaged] https://launchpad.net/bugs/1363400 | 14:27 |
| Saviq | dednick, and for you - update on bug #1372061 ? | 14:28 |
| ubot5 | bug 1372061 in unity8 (Ubuntu) "SMS notification: time format not translatable" [High,In progress] https://launchpad.net/bugs/1372061 | 14:28 |
| davmor2 | Saviq: what happens if you are not at home when you setup the wifi and you don't want to connect? | 14:29 |
| Saviq | davmor2, you skip ;) | 14:29 |
| davmor2 | Saviq: and is that not what the continue does is you don't select a network? | 14:30 |
| Saviq | davmor2, continue != skip | 14:30 |
| Saviq | davmor2, but the actual issue is that you get a popup for the password, but still can press continue | 14:31 |
| davmor2 | Saviq: fair enough :) Skip is an odd term when there is a continue button too, yes I want to continue, I don't want to skip the phone setup | 14:32 |
| Saviq | davmor2, you're on a page to set up your wifi, not the whole phone | 14:32 |
| davmor2 | Saviq: :) | 14:33 |
| mzanetti | dednick: where can I find the messages.py mentioned in the comments here? https://code.launchpad.net/~nick-dedekind/unity8/lp1385331.led/+merge/241417 | 14:54 |
| mzanetti | tsdgeos: do you know? ^ | 14:57 |
| tsdgeos | pfff | 14:57 |
| tsdgeos | it was in a pastebin | 14:57 |
| mzanetti | :D | 14:57 |
| tsdgeos | and in my phone but i think i deleted it | 14:57 |
| tsdgeos | let me check | 14:57 |
| tsdgeos | mzanetti: i *think* it's this one http://paste.ubuntu.com/9530101/ | 14:59 |
| mzanetti | I'll just run it. what can possibly go wrong :D | 15:00 |
| tsdgeos | you need some extra python stuff though | 15:00 |
| tsdgeos | well the imports | 15:00 |
| tsdgeos | python will complain if you don't have them | 15:00 |
| mzanetti | right... it's python2 and we only have 3 on the phone it seems | 15:02 |
| Saviq | mzanetti, 2to3 should help here | 15:03 |
| mzanetti | oh, nice | 15:03 |
| mzanetti | it wasn't much though, already adjusted | 15:03 |
| mzanetti | still a useful hint :) | 15:03 |
| mzanetti | I fail to find this one: cannot import name MessagingMenu, introspection typelib not found | 15:08 |
| tsdgeos | gir1.2-messagingmenu-1.0 | 15:08 |
| tsdgeos | i think | 15:08 |
| tsdgeos | mzanetti: ↑ | 15:08 |
| mzanetti | thanks! working now | 15:12 |
| dednick | mzanetti: https://dl.dropboxusercontent.com/u/85539674/messaging_menu.py | 15:16 |
| dednick | ah. bit late! | 15:16 |
| mzanetti | :) | 15:16 |
| Saviq | dednick, if you missed my question, any update on bug #1372061 ? | 15:19 |
| ubot5 | bug 1372061 in unity8 (Ubuntu) "SMS notification: time format not translatable" [High,In progress] https://launchpad.net/bugs/1372061 | 15:19 |
| dednick | Saviq: woops. forgot about that one :/ code is ready. testing did not go well. | 15:20 |
| Saviq | dednick, any case, lower prio than the prompt one | 15:20 |
| Saviq | dednick, let's get back to it later | 15:21 |
| dednick | Saviq: since the translations are moving to the sdk now i had to fudge them in to test it, but couldnt get it to pick up. | 15:21 |
| dednick | but technically it should work! think it's just my knowledge of the translation system failing me. | 15:22 |
| Saviq | dednick, I could help if you linked a branch to the bug :) | 15:23 |
| dednick | Saviq: give me a sec. | 15:24 |
| Saviq | sure | 15:24 |
| Cimi | Saviq, I cannot fix it on my side... | 15:24 |
| Cimi | Saviq, requires changes in network manager side I think | 15:25 |
| Saviq | Cimi, is anyone looking at it? | 15:25 |
| Cimi | Saviq, nope | 15:26 |
| Cimi | Saviq, we can chase again Wellark but he said is not doable... | 15:26 |
| Cimi | in the timeframe | 15:26 |
| Saviq | Wellark, Cimi, can you please update the bug with any status/findings | 15:27 |
| dednick | Saviq: https://code.launchpad.net/~nick-dedekind/ubuntu-ui-toolkit/lp1378821.time-translation | 15:27 |
| dednick | https://code.launchpad.net/~nick-dedekind/ubuntu-settings-components/lp1378821.time-translation | 15:27 |
| Saviq | dednick, thanks | 15:27 |
| dednick | https://code.launchpad.net/~nick-dedekind/unity8/lp1378821.time-translation | 15:27 |
| dednick | Saviq: the ubuntu-settings-components is just a fix for text alignment. since it's a bit screwed when things get translated these days | 15:28 |
| Saviq | kk | 15:28 |
| mterry | Cimi, I already fixed the launcher-2px thing, you can continue that review if you like | 15:34 |
| greyback | dednick: note, menus may have been bolted into indicators, so that HUD would index both? | 15:39 |
| Cimi | mterry, cool thx! | 15:39 |
| dednick | greyback: not sure about that. but it doesn't seem like the right approach to me. | 15:41 |
| greyback | dednick: was just a thought. But agreed it's a weird design | 15:41 |
| dednick | greyback: yeah, i mean inicators are just essentially menus so i guess it makes some logical sense. in the world of the "global menu" anyway. | 15:43 |
| greyback | dednick: true | 15:45 |
| mzanetti | elopio: hey | 16:52 |
| elopio | mzanetti: hello. | 16:52 |
| mzanetti | I'm testing a silo with your branch and I'm getting this error: http://paste.ubuntu.com/9699519/ | 16:52 |
| mzanetti | am I doing something wrong? | 16:52 |
| mzanetti | seeing that it passed in jenkins | 16:52 |
| elopio | mzanetti: let me see the code. | 16:54 |
| elopio | mzanetti: probably you should do autopilot3 run. | 16:54 |
| elopio | but unity8 helpers still need to be compatible with python2, so I probably forgot that part. | 16:54 |
| mzanetti | elopio: oh, that looks better | 16:54 |
| mzanetti | elopio: what does that mean? you want to fix it or should we merge it (the test passes with python3)? | 16:55 |
| elopio | mzanetti: I just need to add the stupid super parameters that py2 needs. Give me a minute. | 16:56 |
| elopio | that's a good catch, and I better fix it before you merge it. | 16:56 |
| mzanetti | elopio: wait a second | 16:56 |
| mzanetti | Saviq: this is the only issue I found with the silo ^^ | 16:56 |
| mzanetti | wanna do another rebuild? | 16:56 |
| mzanetti | elopio: or well, if we break something we have to fix it anyways... | 16:57 |
| mzanetti | elopio: ok... Saviq seems to be away. I'll do the rebuilding then. feel free to fix&push | 16:59 |
| Saviq | mzanetti, elopio I'd rather land it and re-merge next week, nothing's using it, it's a new helper etc. | 16:59 |
| mzanetti | ah, there he is :) | 16:59 |
| mzanetti | ack. works for me | 16:59 |
| elopio | mzanetti: Saviq: ok. works for me too. | 16:59 |
| elopio | I'll push it to a new branch. | 16:59 |
| elopio | mzanetti: Saviq: I've already pushed it to my branch. Should I revert it, or it won't cause any problems? | 17:00 |
| mzanetti | I don't think it will. the silos keep a copy | 17:00 |
| Saviq | elopio, it's fine, leave it there | 17:00 |
| Saviq | elopio, we'll just do another MP from the same branch | 17:00 |
| Saviq | elopio, or well, land the same MP again, actually | 17:00 |
| elopio | Saviq: ok then. It's ready. | 17:01 |
| elopio | mzanetti: thanks for checking it. | 17:01 |
| mzanetti | Saviq: done. spreadsheet updated | 17:02 |
| Saviq | mzanetti, thanks | 17:02 |
| mzanetti | elopio: no worries | 17:02 |
| Cimi | mzanetti, for monday https://code.launchpad.net/~mzanetti/unity8/fix-left-edge-on-spread/+merge/243400 | 17:18 |
| Cimi | mzanetti, the enterSpread test fails | 17:19 |
| mzanetti | Cimi: ack, thanks | 17:19 |
| === alan_g is now known as alan_g|EOW | ||
| Saviq | greyback, still around? | 18:52 |
| greyback | Saviq: back now | 22:57 |
| Saviq | greyback, nothing pressing, when you want to just tell me if I'm talking bullshit in https://code.launchpad.net/~saviq/qtmir/openurl-keep-bytearray/+merge/246017 | 22:58 |
| greyback | Saviq: ok | 22:58 |
| greyback | Saviq: that makes the crash go away? | 22:59 |
| Saviq | greyback, couldn't reproduce with that, and debugs as per https://bugs.launchpad.net/ubuntu-rtm/+source/qtmir/+bug/1408819/comments/10 confirm it's ok | 23:00 |
| ubot5 | Launchpad bug 1408819 in qtmir (Ubuntu RTM) "unity8 crashed with SIGABRT in g_assertion_message() when launching calculator from quicklist" [Critical,In progress] | 23:00 |
| Saviq | greyback, and it kinda makes sense, the QByteArray from encoded() can be deleted as soon as you take the constData() out of it | 23:01 |
| Saviq | greyback, qtubuntu seems to have avoided that by just putting url.encoded().constData() directly in the call to urld | 23:01 |
| Saviq | so there's no way the QBA would be deleted before it returns | 23:01 |
| greyback | Saviq: I see your point. Was pondering if the temporary QByreArray could really be deleted by then - and probably yeah, since it's a temporary | 23:02 |
| Saviq | yeah exactly | 23:03 |
| Saviq | now it'd be interesting to find out a way to unit-test this... | 23:04 |
| greyback | unit testing C++ object lifetimes? Have fun with that | 23:11 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!