| thumper | menn0: ok | 00:16 |
|---|---|---|
| menn0 | thumper: thanks for the review! | 00:22 |
| menn0 | thumper: another one for you: http://reviews.vapour.ws/r/707/ | 00:38 |
| anastasiamac | thumper: thnx for reviewing my doc :-) | 00:38 |
| thumper | menn0: ack, doing another right now | 00:39 |
| menn0 | thumper: np. | 00:39 |
| axw | wallyworld_ thumper: responded to http://reviews.vapour.ws/r/699/, PTAL when you can | 02:12 |
| wallyworld_ | sure, looking | 02:12 |
| mattyw | morning all | 02:56 |
| mattyw | thumper, morning/ afternoon, you still around? | 02:57 |
| thumper | axw: done | 03:08 |
| thumper | mattyw: yep, and reviewed | 03:08 |
| axw | cheers | 03:08 |
| axw | trunk is blocked again :~( | 03:09 |
| mattyw | thumper, cool - is that an LGTM or a vote of confidence? | 03:09 |
| thumper | :) | 03:09 |
| thumper | merge it | 03:09 |
| mattyw | thumper, I don't have permission - but if you do you're welcome to | 03:09 |
| thumper | ah, ok | 03:09 |
| thumper | mattyw: done | 03:10 |
| mattyw | thumper, that's great service | 03:10 |
| mattyw | thumper, thanks very much | 03:10 |
| wallyworld_ | axw: i think i may be running into an issue with maas 1.7 - the node is green/ready, and i try and bootstrap. i expect it to go blue/allocated and then i can use the virsh console to start manually. however, juju bootstrap exits with an error FORBIDDEN (You are not allowed to start up this node.) | 03:14 |
| wallyworld_ | maybe maas is complaining there's no power mgmt options set | 03:15 |
| axw | wallyworld_: I don't think I've used 1.7, only 1.6... | 03:16 |
| axw | can't say that error sounds familiar | 03:16 |
| wallyworld_ | bollocks | 03:16 |
| wallyworld_ | i have a look at the python used to control the virsh console and it appears deficient in that it neglects to pass the --quite flag, so login is deemed to fail | 03:17 |
| wallyworld_ | so there's clearly some things they need to fix to get start/stop working | 03:17 |
| thumper | axw: rereviewed the storage branch | 03:19 |
| axw | thumper: thanks | 03:19 |
| rick_h_ | thumper: got a sec to chat? | 03:21 |
| thumper | rick_h_: sure | 03:21 |
| rick_h_ | thumper: https://plus.google.com/hangouts/_/canonical.com/daily-standup?authuser=1 | 03:21 |
| === kadams54 is now known as kadams54-away | ||
| wallyworld | rvba: hi there, did you have a few minutes for a question or 2 about maas? | 07:09 |
| axw | wallyworld: how are you going with maas? | 08:13 |
| axw | need a hand with anything? | 08:13 |
| wallyworld | axw: well, tl;dr; it kinda sucks. there's a gomaasapi commit after the lastest one in dependencies.tsv that fails unit tests in juju. so i have to get that fixed prior to being able to land my gomaas mods to then propose my juju fix. i have also reverse engineered the api somewhat to figure out how to fix the deployment status issue, but need to confirm a couple of things as the doco is lacking. i'm just finishing adding the new api | 08:16 |
| wallyworld | to the gomaas testserver so i can then use that in juju unit tests | 08:16 |
| wallyworld | and maas plus kvm in 1.7 is broken | 08:16 |
| wallyworld | so hard to test live | 08:16 |
| axw | oy :( | 08:16 |
| wallyworld | thanks for asking :-) | 08:17 |
| wallyworld | axw: also, the testserver was somewhat, shall we say, retarded in how it was written wrt handing constraints, so i had to fix that also | 08:18 |
| dimitern | axw, wallyworld, rogpeppe1, mgz, hey guys do you mind going here https://github.com/orgs/go-amz/people and setting yourself as publicly visible? | 08:35 |
| dimitern | davecheney, ^^ | 08:36 |
| rogpeppe1 | dimitern: done | 08:36 |
| dimitern | rogpeppe1, cheers! | 08:36 |
| davecheney | dimitern: done | 08:37 |
| dimitern | axw, btw you should be unblocked now wrt storage work on goamz - api version upgraded to latest, so if you import gopkg.in/amz.v2 you should be all set | 08:38 |
| dimitern | davecheney, thanks! | 08:38 |
| axw | dimitern: I noticed, thank you | 08:57 |
| jamespage | alexisb, fwereade: just bringing this feature bug to your attention - https://bugs.launchpad.net/juju-core/+bug/1409639 - hopefully that's not to much of a surprise | 09:14 |
| mup | Bug #1409639: juju needs to support systemd for >= vivid <juju-core:New> <https://launchpad.net/bugs/1409639> | 09:14 |
| fwereade | jamespage, ha, yes | 09:14 |
| voidspace | dimitern: I don't know if you want to have a look at this http://reviews.vapour.ws/r/704/ | 09:21 |
| dimitern | voidspace, sure, I'll have a look in a bit | 09:22 |
| dimitern | voidspace, reviewed | 09:50 |
| voidspace | dimitern: thanks | 09:50 |
| wallyworld | voidspace: hey there | 10:23 |
| voidspace | wallyworld: hey, hi | 10:24 |
| wallyworld | voidspace: quick one - the last comment to gomaasapi (rev 59) doesn't work with juju unit tests. i have changes i need to make to gomaasapi but can't until those issues are fixed. related to nodegroup changes | 10:25 |
| wallyworld | juju deps still refers to rev 58 so juju is not broken at this stage | 10:25 |
| voidspace | wallyworld: right, I have a branch that fixes the maas test that is broken | 10:26 |
| voidspace | wallyworld: I think the code is actually broken | 10:26 |
| wallyworld | \o/ | 10:26 |
| voidspace | wallyworld: http://reviews.vapour.ws/r/704/ | 10:26 |
| wallyworld | oh, great, a pr already | 10:26 |
| wallyworld | and you have a ship it | 10:27 |
| wallyworld | that will unblock me tomorrow, so i'm happy | 10:27 |
| voidspace | cool :-) | 10:27 |
| voidspace | wallyworld: branch ready to land, but trunk blocked... | 12:33 |
| wallyworld | voidspace: ah, :-( | 12:34 |
| voidspace | wallyworld: the fix you need to get tests passing with latest gomaasapi is change line 183 of maas/environ.go to | 12:34 |
| voidspace | if err != nil || len(bootImages) == 0 { | 12:34 |
| voidspace | (add a check for empty bootImages) | 12:34 |
| wallyworld | voidspace: i made that same change locally | 12:34 |
| voidspace | cool | 12:34 |
| wallyworld | so it must be right :-) | 12:34 |
| voidspace | I'll try and land this asap | 12:34 |
| voidspace | hah | 12:34 |
| voidspace | I defer to your wisdom | 12:35 |
| voidspace | as always | 12:35 |
| wallyworld | barf | 12:35 |
| wallyworld | voidspace: i checked critical bug from irc topic, fix for regression was committed over w/e so hopefully it will be verified soon as fix released to unblock | 12:37 |
| voidspace | wallyworld: great, thanks | 12:37 |
| mgz | the fix is in, last run over the weekend failed on maas, I triggered a rebuild in case it's happy now | 12:38 |
| voidspace | hmmm | 12:39 |
| mgz | wallyworld: I'm not sure about the fix though, only changes the test, so the api still returns stuff in an undefined order? would prefer if the api return was just sorted | 12:40 |
| anastasiamac | mgz: why would u prefer to see return sorted? | 12:43 |
| mgz | anastasiamac: because it's an api - I like having stuff we're exposing for other people deterministic, just so they can't also make a mistake in their code and assume that it's in insert-order or whatever | 12:43 |
| mgz | there are places where that's quite important, and many more where it's really not | 12:45 |
| anastasiamac | fwereade: wallyworld: ^^ would the order of returned annotations from bulk call matter (on get)? | 12:48 |
| fwereade | anastasiamac, yes please, preserve the order they were sent in | 12:48 |
| fwereade | anastasiamac, * the requests were sent in | 12:49 |
| anastasiamac | mgz: the test was failing not on returned order. it was setting annotations and m checking if the collection that m about to throw over the wire contains elements I was after | 12:49 |
| anastasiamac | fwereade: mgz: will duble check that m returning collection from get in the same order as the request :) | 12:50 |
| anastasiamac | mgz: thnx for pick up | 12:50 |
| fwereade | anastasiamac, doh, I see, I think; so no, I don't think that order matters, users that need to sort results by alpha or something can do so trivially, it's not necessary that we do that sort of work | 12:53 |
| mgz | anastasiamac: fair enough | 12:53 |
| perrito666 | good morning everyone, sorry for the lateness | 12:55 |
| === ChanServ changed the topic of #juju-dev to: https://juju.ubuntu.com | On-call reviewer: see calendar | Open critical bugs: None | ||
| dimitern | trunk is unblocked | 14:27 |
| perrito666 | dimitern: how did you fix it_ | 14:36 |
| perrito666 | ? | 14:36 |
| dimitern | perrito666, anastasiamac fixed it | 14:37 |
| dimitern | perrito666, see https://github.com/juju/juju/commit/66bf4163b9580a1052193bbe8934dc21a4384f11 | 14:38 |
| perrito666 | dimitern: ah I saw that on friday | 14:38 |
| perrito666 | I though thi was about abentley mail (or perhas his mail was about this)? | 14:39 |
| dimitern | perrito666, ah, the uniter one - no, no fix for that yet - it's intermittent | 14:39 |
| wwitzel3 | ericsnow: ping | 15:01 |
| perrito666 | hey wwitzel3 still of for the standup right? | 15:03 |
| wwitzel3 | perrito666: ping | 15:03 |
| perrito666 | wwitzel3: pong | 15:03 |
| wwitzel3 | perrito666: just checking if you're coming for standup? | 15:03 |
| perrito666 | wwitzel3: I thought I got an email from you saying no standup | 15:04 |
| perrito666 | :p | 15:04 |
| perrito666 | brt | 15:04 |
| dimitern | voidspace, https://github.com/juju/juju/pull/1382 got merged already btw :) | 15:31 |
| voidspace | dimitern: yeah, I saw | 15:34 |
| voidspace | dimitern: thanks :-) | 15:34 |
| dimitern | voidspace, np | 15:34 |
| voidspace | dimitern: I only saw *after* I tried to merge again of course... | 15:34 |
| dimitern | voidspace, I thought so yeah :) | 15:34 |
| ericsnow | wwitzel3: you back? | 15:56 |
| === kadams54 is now known as kadams54-away | ||
| jam | wwitzel3: as OCR, can you try to make sure someone is at least investigating Aaron's 2 reported bugs about CI cursing current trunk? | 18:00 |
| jam | (it doesn't have to be you, I just want to make sure someone is following up on it) | 18:00 |
| wwitzel3 | jam: will do, thanks for the ping | 18:09 |
| voidspace | g'night all | 18:32 |
| voidspace | EOD | 18:32 |
| === ChanServ changed the topic of #juju-dev to: https://juju.ubuntu.com | On-call reviewer: see calendar | Open critical bugs: 1409827 | ||
| thumper | morning | 19:35 |
| perrito666 | hi thumper | 19:37 |
| thumper | hey perrito666 | 19:37 |
| thumper | perrito666: all good in your neck of the woods? | 19:37 |
| perrito666 | thumper: sure, we seem to be doing better than most parts of the world accoding to the official news, albeit a bit more hot :p | 19:38 |
| thumper | :) | 19:39 |
| === urulama__ is now known as urulama | ||
| perrito666 | abentley: do we know when did this break? #1409827 that is | 19:47 |
| mup | Bug #1409827: TestSetMembersErrorIsNotFatal fails on ppc <ci> <regression> <test-failure> <juju-core:Triaged> <https://launchpad.net/bugs/1409827> | 19:47 |
| abentley | perrito666: 66bf4163b9580a1052193bbe8934dc21a4384f11 did not exhibit the issue: http://reports.vapour.ws/releases/2219 | 19:49 |
| perrito666 | abentley: tx | 19:49 |
| perrito666 | bbl | 20:33 |
| wwitzel3 | ericsnow: I'm back, looking at the regression | 20:33 |
| rick_h_ | thumper: ping, we're trying to get a backport of frankban's polish into 1.22, we've filed a bug and need a review on a backport PR I'm told? https://github.com/juju/juju/pull/1388 | 20:34 |
| ericsnow | wwitzel3: k | 20:41 |
| wwitzel3 | thumper: ping, noticed your comment on the regression are you running the PPC test suite? | 20:43 |
| wwitzel3 | thumper: I'm trying to debug that issue now, but not sure how to run the tests. | 20:43 |
| wwitzel3 | ahh nice, I can just use a ppc vm on qemu .. that seems to work | 20:46 |
| anastasiamac | wwitzel3: thnx for the review!! | 20:49 |
| wwitzel3 | anastasiamac: np | 20:49 |
| anastasiamac | wwitzel3: I have a question - PTAL if u get a chance b4 :) | 20:49 |
| anastasiamac | wwitzel3: b4 eod even :) | 20:53 |
| wwitzel3 | anastasiamac: yep, you have a response, let me know if that makes sense | 20:55 |
| anastasiamac | wwitzel3: i do? :) sorry i must be looking in the wrong place - where can I find it? | 20:58 |
| wwitzel3 | anastasiamac: oops, sorry, was still a draft .. my fault | 20:59 |
| katco | how are unit tags generally marshalled/unmarshalled? | 20:59 |
| katco | service tags are handled automatically because their member-variables are public; unit has a private member-variable | 21:00 |
| anastasiamac | wwitzel3: yep. thnx :) that's what I thought I understood :P | 21:00 |
| anastasiamac | wwitzel3: really appreciate ur thoughts and input! thnx | 21:01 |
| wwitzel3 | anastasiamac: you're welcome | 21:01 |
| thumper | wwitzel3: do you get the same issue just running with the gccgo compiler on the local machine? | 21:05 |
| === urulama is now known as urulama__ | ||
| thumper | wwitzel3: I'm fairly sure it is a timing problem | 21:05 |
| thumper | wwitzel3: and I think the test should be rewritten to not need time.Sleep | 21:06 |
| thumper | cherylj: I'm back if you have time to talk now | 21:06 |
| wwitzel3 | thumper: ok, let me try compiling with gccgo. | 21:07 |
| wwitzel3 | thumper: thanks for the hints | 21:07 |
| cherylj | thumper, now works for me | 21:10 |
| thumper | cherylj: we'll just use the standup hangout | 21:11 |
| cherylj | ok | 21:11 |
| === kadams54-away is now known as kadams54 | ||
| wwitzel3 | thumper: it passes locally for me when using gccgo | 21:14 |
| thumper | wwitzel3: otp now | 21:15 |
| menn0 | thumper, waigani: environments watcher here: http://reviews.vapour.ws/r/711/ | 21:32 |
| === kadams54 is now known as kadams54-away | ||
| waigani | menn0: lgtm | 21:41 |
| menn0 | waigani: cheers | 21:41 |
| === kadams54-away is now known as kadams54 | ||
| === kadams54 is now known as kadams54-away | ||
| === kadams54-away is now known as kadams54 | ||
| === kadams54 is now known as kadams54-away | ||
| === kadams54-away is now known as kadams54 | ||
| menn0 | thumper: when you have a moment can we discuss the machine agent worker stuff? | 22:45 |
| thumper | menn0: in 10 minutes? | 22:45 |
| menn0 | thumper: sounds good | 22:46 |
| === kadams54 is now known as kadams54-away | ||
| === kadams54-away is now known as kadams54 | ||
| === kadams54 is now known as kadams54-away | ||
| === kadams54-away is now known as kadams54 | ||
| === kadams54 is now known as kadams54-away | ||
| === kadams54-away is now known as kadams54 | ||
| === kadams54 is now known as kadams54-away | ||
| === whit is now known as whit|dinner | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!