thumper | anastasiamac: yes | 00:00 |
---|---|---|
thumper | anastasiamac: we are moving everything that way | 00:00 |
anastasiamac | thumper: i know of one level of super commands | 00:01 |
anastasiamac | thumper: e.g. juju machine add | 00:01 |
anastasiamac | thumper: could u point me to an example with 2 level super | 00:01 |
anastasiamac | thumper: ? | 00:01 |
thumper | well, juju is a super, so juju machine is super of super | 00:02 |
thumper | which is what I thought you ment | 00:02 |
anastasiamac | thumper: i want (! :-D) `juju <1-super command> <2-super command> subcommand | 00:03 |
anastasiamac | thumper: juju storage volume list | 00:03 |
anastasiamac | thumper: params and options after `list` | 00:03 |
anastasiamac | thumper: possible? | 00:03 |
thumper | sure, don't see why not | 00:05 |
thumper | menn0: is there a reason that the StateSuite doesn't have a factory? | 00:20 |
* thumper wants one there | 00:20 | |
* thumper adds one and runs all the tests | 00:25 | |
axw | menn0: thanks very much for wading through all that code | 00:50 |
menn0 | axw: no worries. It was all pretty easy to follow so thanks for writing clear code. | 00:57 |
menn0 | thumper: there was a reason I didn't add the factory to state suite but that reason might not be valid now | 00:58 |
menn0 | thumper: I think it was due to circular imports in some places | 00:58 |
thumper | menn0: everything passes with me adding one | 00:58 |
thumper | so I'll keep it there :) | 00:58 |
menn0 | thumper: yeah, I think that i rearranged things so it wasn't a problem | 00:59 |
thumper | menn0: slowly working my way through all this crap | 00:59 |
menn0 | thumper: certainly happy to have the factory there | 00:59 |
thumper | wallyworld_: hey | 00:59 |
wallyworld_ | yo | 00:59 |
thumper | wallyworld_: I have some questions about the image cache thing | 00:59 |
thumper | got 5 minutes for a hangout? | 00:59 |
wallyworld_ | shoot | 00:59 |
wallyworld_ | sure | 00:59 |
menn0 | thumper: maybe change the various StateSuite users that are creating their own factory to use the one from StateSuite? | 00:59 |
thumper | menn0: maybe... :) | 01:00 |
thumper | wallyworld_: just use our 11! hangout | 01:00 |
thumper | 1:1 | 01:00 |
menn0 | thumper: there aren't many :) | 01:01 |
katco | wallyworld_: i'm in the hangout early if you want to chat | 01:05 |
wallyworld_ | katco: just talking to tim. be there soon | 01:05 |
katco | wallyworld_: no worries | 01:05 |
thumper | wallyworld_: although... | 01:07 |
thumper | wallyworld_: any reason we should server /images from the root of the API? | 01:07 |
thumper | oh... | 01:07 |
thumper | s'ok | 01:08 |
thumper | I know | 01:08 |
wallyworld_ | ok | 01:08 |
thumper | before the patch I landed just the other day | 01:08 |
thumper | all agents would come in to the root | 01:08 |
thumper | nm | 01:08 |
thumper | all good | 01:08 |
thumper | um... | 01:50 |
thumper | wallyworld_: | 01:50 |
thumper | wallyworld_: the image stuff isn't being used yet is it? | 01:50 |
wallyworld_ | thumper: otp. sec | 01:51 |
thumper | wallyworld_: because before two days ago, none of the agents would have been able to access the api | 01:51 |
wallyworld_ | thumper: it worked for me | 01:53 |
wallyworld_ | i tested live with local and ec2 | 01:53 |
thumper | ?? | 01:53 |
wallyworld_ | it doesn't work on upgraded environments because of the cert issue | 01:53 |
wallyworld_ | but a fresh trunk install worked | 01:54 |
thumper | oh... I know why... but it is truly horrid | 01:54 |
thumper | you were serving the following url: | 01:54 |
wallyworld_ | thumper: what happens from the node is that wget is used | 01:54 |
thumper | /environment//images/... | 01:54 |
wallyworld_ | it nakes a https get call | 01:54 |
thumper | with an empty :envuuid | 01:54 |
wallyworld_ | ah could be, can't recall now | 01:55 |
thumper | it is | 01:55 |
* thumper tweaks | 01:55 | |
wallyworld_ | ok :-) | 01:55 |
axw | wallyworld_: can you please review my responses to your comments when you're free? | 02:09 |
wallyworld_ | axw: sure, i'll just finish this current review | 02:09 |
thumper | menn0: that's the rest of the apiserver fixed | 02:38 |
* thumper writes the merge description | 02:38 | |
thumper | menn0: http://reviews.vapour.ws/r/776/ | 02:44 |
menn0 | thumper: looking | 02:45 |
wallyworld | axw: just a question about machine vs machineid for index | 02:49 |
wallyworld | i'm not sure why not machineid | 02:49 |
axw | wallyworld_: I can change both to machineid now, I was thinking of doing that anyway | 02:53 |
wallyworld_ | stupid freenode :0( | 02:53 |
wallyworld_ | ok, machineid sounds good | 02:53 |
axw | wallyworld_: I'll change storageinstance to storageinstanceid too ? | 02:54 |
wallyworld_ | i think so please, is consistent and arguably more accurate | 02:54 |
axw | wallyworld_: fixed | 03:02 |
wallyworld_ | ty | 03:02 |
wallyworld_ | land that sucker | 03:02 |
axw | cool | 03:02 |
menn0 | axw: man! every time wallyworld_ reviews something that i've already reviewed he always find a bunch of good stuff I didn't notice :) | 03:03 |
wallyworld_ | menn0: well, this is an area where our team knows the domain a bit better | 03:04 |
axw | menn0: that's cool, you raised good points too :) | 03:04 |
menn0 | wallyworld_: I suspect domain knowledge is part of it, but also that you're really good at reviewing | 03:05 |
wallyworld_ | sometimes, i miss stuff myself | 03:05 |
wallyworld_ | especially when i'm trying to race through 3 big reviews this morning :-) | 03:06 |
=== lp|outy5000 is now known as lazyPower | ||
wallyworld_ | axw: when you had time, could we have a hangout about the registry? | 03:30 |
axw | wallyworld_: sure, now's fine | 03:32 |
axw | see you in 1:1 | 03:32 |
katco | wallyworld_: axw: would i be intruding if i joined? | 03:33 |
wallyworld_ | course not | 03:33 |
axw | katco: fine by me, let's make it standup then | 03:33 |
katco | cool, tanzanite? | 03:33 |
axw | yep, I'm there | 03:33 |
=== kadams54 is now known as kadams54-away | ||
menn0 | thumper: so you didn't end up using StateSuite in this PR, even though you added Factory to it? | 03:38 |
thumper | menn0: I forgot to add the utils_test.go file | 03:39 |
thumper | just pushed it up | 03:39 |
thumper | sorry | 03:39 |
menn0 | thumper: no worries | 03:41 |
menn0 | thumper: review done | 03:43 |
thumper | menn0: ta | 03:44 |
=== kadams54-away is now known as kadams54 | ||
* thumper waits to see if this branch will merge or not | 04:22 | |
thumper | ... | 04:22 |
thumper | it has been about 13 minutes... | 04:23 |
thumper | should be done soon | 04:23 |
* thumper sighs | 04:29 | |
thumper | another intermittent test failure | 04:29 |
thumper | bug 1413067 if anyone wants to fix it... | 04:32 |
mup | Bug #1413067: Intermittent test failure FilterSuite.TestConfigAndAddressEventsDiscarded <intermittent-failure> <juju-core:Triaged> <https://launchpad.net/bugs/1413067> | 04:32 |
wallyworld_ | axw: sadly, doing this: VolumeSource(environs.Environ, *Config) (VolumeSource, error) - creates an import loop as apiserver/params references back to storage | 04:55 |
axw | wallyworld_: how about just *environs/config.Config | 04:56 |
axw | wallyworld_: alternatively we could duplicate the storage structures in apiserver/params ... | 04:56 |
wallyworld_ | i was leaning towards the latter | 04:56 |
wallyworld_ | but hadn't considered the former | 04:57 |
wallyworld_ | less work right now to do the former | 04:57 |
axw | wallyworld_: I'm fine with either. we'll probably want to duplicate eventually, but it can wait | 04:58 |
wallyworld_ | yeah | 04:59 |
anastasiamac | wallyworld_: axw: if u putting some things in apiserver/params | 05:09 |
anastasiamac | axw: wallyworld_: i'd like to know... | 05:10 |
anastasiamac | axw: wallyworld_::D | 05:10 |
wallyworld_ | anastasiamac: nothing at the moment | 05:10 |
anastasiamac | wallyworld_: \o/ | 05:10 |
=== kadams54 is now known as kadams54-away | ||
wallyworld_ | axw: no rush. when you get a chance, http://reviews.vapour.ws/r/777/. | 07:04 |
dimitern | morning all | 07:25 |
wallyworld_ | o/ | 07:28 |
dimitern | hey everyone, fwereade just texted me to let you know he has problems with the internet connection | 07:44 |
dimitern | he's not sure when he'll be back online, but working on it | 07:44 |
wallyworld_ | axw: i have another branch ready to land once the registry one goes in - it sets up registration of default pools and provides the skeleton loop volume source for katherine | 09:28 |
axw | wallyworld_: sweet. sorry, I'll take a look now. been trying to plough through the formatter | 09:28 |
wallyworld_ | np | 09:28 |
axw | wallyworld_: why do we need to record a default storage provider if we're also going to have default pools? | 09:32 |
axw | pool tells you what the provider type is, so... seems redundant | 09:33 |
wallyworld_ | axw: good question, i don't think we do | 09:33 |
axw | ok | 09:33 |
wallyworld_ | i'll remove the default business | 09:33 |
wallyworld_ | i'll make it record pool name instead | 09:34 |
axw | wallyworld_: reviewed | 09:40 |
wallyworld_ | ty | 09:40 |
axw | ah, I think you updated while I was looking... | 09:41 |
wallyworld_ | yeah | 09:42 |
wallyworld_ | axw: IsProviderSupported - use case is when specifying pool name when deploying, get provider type from pool and then see if it is a valid type for the environment | 09:45 |
axw | wallyworld_: ok | 09:45 |
axw | wallyworld_: hmm. not sure it should be possible to create a pool that is invalid for the environment though... | 09:46 |
axw | that seems like asking for trouble | 09:46 |
wallyworld_ | axw: true, so you'd use the check when creating | 09:46 |
axw | wallyworld_: true :) | 09:46 |
wallyworld_ | sorry, i'm speaing conceptually :-) | 09:47 |
wallyworld_ | speaking | 09:47 |
axw | sure, I get it - we still need it but in another spot | 09:47 |
wallyworld_ | yeah. ok, so landing now, then i can propose the next one | 09:48 |
dimitern | wallyworld_, axw, PTAL http://reviews.vapour.ws/r/778/ - updates deps for goamz | 09:52 |
axw | dimitern: looking | 09:52 |
axw | dimitern: LGTM | 09:52 |
axw | that was a hard one | 09:52 |
dimitern | axw, thanks! :) | 09:53 |
axw | woop | 10:19 |
axw | wallyworld_: 2015-01-21 10:18:43 INFO juju.worker.diskformatter diskformatter.go:157 created filesystem on "/dev/xvdf1" | 10:19 |
wallyworld_ | whoot :-) | 10:20 |
axw | no tests yet, but should be ready soonish | 10:20 |
wallyworld_ | great | 10:20 |
wallyworld_ | axw: this hopefully will allow katherine to get stuck into loop provider, plus there's the ability to register out of the box pools http://reviews.vapour.ws/r/779/. maybe take a look after you finish your fs one | 10:28 |
axw | wallyworld_: cool. I need to go get dinner on, should be able to take a look later on | 10:29 |
wallyworld_ | ok, ty | 10:29 |
perrito666 | morning | 10:32 |
voidspace | interesting | 10:46 |
voidspace | MaaS has an api call for getting mac addresses - it takes a mac address as a parameter | 10:47 |
voidspace | so given a mac address you can get the mac address back! | 10:47 |
voidspace | useful | 10:47 |
perrito666 | lol | 10:48 |
voidspace | perrito666: o/ morning | 10:48 |
dimitern | voidspace, or for fun and games you can implement "guess my mac" game via the maas api :D | 11:03 |
voidspace | dimitern: hah, yeah - I hadn't thought of that | 11:03 |
voidspace | dimitern: I should implement that | 11:03 |
dimitern | *lol* | 11:07 |
* perrito666 hates mornings | 11:21 | |
dimitern | holy sh*t! need to reboot - uptime: 13:25:03 up 3:08, 2 users, load average: 21,34, 21,33, 21,13 | 11:25 |
* dimitern needs to step out - back in ~1h | 11:45 | |
=== Tribaal_ is now known as Tribaal | ||
voidspace | dimitern: ping | 12:50 |
voidspace | dimitern: question, if a network interface is *not* associated with a network should I leave those details blank in the returned InterfaceInfo | 12:51 |
voidspace | dimitern: or should I skip that interface? | 12:51 |
dimitern | voidspace, hmm.. let me think | 12:59 |
dimitern | voidspace, leave them out - it's a possibly valid case for maas | 12:59 |
voidspace | dimitern: when you say "leave them out" | 13:01 |
voidspace | dimitern: which of my two options do you mean? | 13:01 |
voidspace | dimitern: as both options involve leaving something out... | 13:01 |
voidspace | and my mind reading skills are sadly lacking today I'm afraid :-( | 13:01 |
voidspace | although I could deduce that the use of "them" (plural) indicates leaving out the missing details, but leaving the interface | 13:02 |
voidspace | did I get it right? | 13:02 |
voidspace | *leaving the interface in | 13:02 |
dimitern | voidspace, :) ah, sorry - I meant keep the interfaces in the result, but leave the fields empty | 13:03 |
voidspace | dimitern: cool, will do | 13:03 |
voidspace | that's how I've coded it anyway as it happens :-) | 13:03 |
dimitern | voidspace, thanks! :) | 13:03 |
mgz | gsamfira: bug 1398415 | 13:04 |
mup | Bug #1398415: TestAddRemoveSet fails intermittently <ci> <intermittent-failure> <test-failure> <juju-core:Triaged> <https://launchpad.net/bugs/1398415> | 13:04 |
gsamfira | mgz: thanks! :) | 13:05 |
mgz | try it again, maybe... fifth time... lucky? | 13:05 |
voidspace | right, lunch | 13:07 |
voidspace | so NetworkInterfaces is kinda done, just need to test it | 13:08 |
voidspace | which probably means extending the gomaasapi test server I bet... | 13:08 |
voidspace | :-/ | 13:08 |
voidspace | maybe not though | 13:08 |
dimitern | voidspace, enjoy! I'm mostly done with mine, so I'll help you if I can | 13:11 |
voidspace | dimitern: will do | 13:18 |
voidspace | dimitern: I'm wondering if the test server will support the "list_connected_macs" op and I'm assuming it probably won't... | 13:18 |
voidspace | dimitern: hopefully I'm wrong | 13:19 |
gsamfira | mgz: worked on the 3rd :) | 13:19 |
voidspace | anyway, really going on lunch | 13:19 |
dimitern | voidspace, thankfully it does - I added it at some point - ConnectNodeToNetworkWithMACAddress() :) | 13:22 |
=== axw_ is now known as axw | ||
dimitern | voidspace, menn0, katco (if around, as OCRs): please take a look http://reviews.vapour.ws/r/780/ | 13:55 |
perrito666 | is anyone already using vivid here? | 14:17 |
jamespage | perrito666, I'm trying to | 14:32 |
jamespage | invalid series "vivid" | 14:32 |
jamespage | hmm | 14:32 |
perrito666 | jamespage: I meant as a desktop :p | 14:33 |
jamespage | perrito666, well I'm doing that as well | 14:33 |
perrito666 | I am thinking on moving to and fear to break my work env | 14:33 |
* perrito666 tries to trigger update | 14:36 | |
jamespage | perrito666, well I've been running vivid since a week into the cycle with systemd as default :-) | 15:07 |
jamespage | only minor niggles so far | 15:07 |
perrito666 | well in 10mins 7s Ill tell you how well it works on my laptop :p | 15:07 |
jamespage | perrito666, awesome | 15:08 |
* perrito666 prepares the tablet for the standup just in case is not all that awesome :p | 15:09 | |
wwitzel3 | ericsnow: I just finished the base tests for GetDisks and GetHardwareCharacteristics | 15:12 |
=== kadams54 is now known as kadams54-away | ||
=== kadams54-away is now known as kadams54 | ||
ericsnow | wwitzel3: sweet! | 15:39 |
ericsnow | katco: PTAL https://github.com/juju/testing/pull/48 | 15:40 |
katco | ericsnow: ty, will try and get to it. just preparing for a meeting | 15:40 |
wwitzel3 | ericsnow: just wrapping up the last base test now | 15:40 |
ericsnow | katco: no worries :) | 15:40 |
ericsnow | wwitzel3: you rock! | 15:40 |
katco | ericsnow: wwitzel3: looking forward to reading through the GCE code | 15:40 |
ericsnow | katco: best consumed one bite at a time ;) | 15:41 |
* katco secretly uses Amazon's mechanical turk to farm out code reviews | 15:41 | |
ericsnow | katco: lol great idea | 15:42 |
wwitzel3 | ericsnow: pushed | 15:44 |
=== kadams54 is now known as kadams54-away | ||
=== kadams54-away is now known as kadams54 | ||
voidspace | dimitern: have you actually done the live tests? | 15:55 |
dimitern | voidspace, still doing them :) and it turned out more stuff will be needed | 15:55 |
voidspace | dimitern: shall I review this PR as is, or wait? | 15:55 |
dimitern | voidspace, but even if it lands as is there won't be any harm | 15:55 |
voidspace | right, as it's not used yet... | 15:55 |
dimitern | voidspace, please do, i'll prepare follow-ups for what I found | 15:56 |
dimitern | voidspace, yes - not used yet, but once we start I found out some curious interactions between lxc-create, lxc-clone, and lxc-start wrt the generated lxc.conf | 15:57 |
voidspace | dimitern: ah right | 15:58 |
voidspace | sounds like fun | 15:58 |
* perrito666 has an epyphany and suddenly fixes his computers external microphone | 15:59 | |
dimitern | voidspace, :D that's an understatement | 15:59 |
voidspace | :-) | 15:59 |
dimitern | voidspace, so.. live tests on local at least show no regressions - bootstrapping on ec2 and maas now | 16:06 |
dimitern | voidspace, unfortunately all this is *not* enough to make the generated lxc conf take effect always | 16:08 |
dimitern | voidspace, e.g. with pre-existing lxc template (which is then cloned), with no template - getting/caching the template works fine, the config is there, but once you clone off that - no joy | 16:09 |
voidspace | yeah right, I wondered about cloning | 16:09 |
dimitern | voidspace, I was actually *quite* surprised lxc-clone does not allow you to pass new config | 16:09 |
voidspace | dimitern: doesn't it mean we have to stop cloning | 16:09 |
dimitern | voidspace, oh, no :) i'm not giving up so easy | 16:10 |
voidspace | haha, ok | 16:10 |
dimitern | voidspace, already have a couple of pointers how it might work | 16:10 |
voidspace | I just assumed we'd have to stop cloning | 16:10 |
dimitern | voidspace, the benefits of cloning are too great - mostly performance-wise, but also disk footprint (with snapshots) | 16:11 |
voidspace | right | 16:11 |
voidspace | so clone and then reconfigure | 16:11 |
dimitern | voidspace, yep, something like that - I have to consult the lxc guys though | 16:11 |
perrito666 | wwitzel3: you laughed so you either where paying attention or became very good at the simulation thing | 16:14 |
wwitzel3 | perrito666: :) | 16:16 |
voidspace | dimitern: container/lxc/lxc.go lines 605-618 | 16:26 |
voidspace | dimitern: why wouldn't the cidr already be in the expected format? | 16:26 |
voidspace | dimitern: and why couldn't you use ipNet.String() to produce it? | 16:27 |
dimitern | voidspace, it might be empty or invalid - I'm being extra cautions there | 16:28 |
voidspace | dimitern: can you adjust the comment to make it clear that you're just validating rather than actually changing format as the current comment implies | 16:29 |
dimitern | voidspace, good point about ipNet.String() - I can parse the cidr, then replace the ip part | 16:29 |
voidspace | yep | 16:29 |
dimitern | voidspace, ah, sure | 16:29 |
voidspace | ah, the IPV4Address needs to be a CIDR | 16:29 |
voidspace | so you want to take the mask from the cidr and append it to the address | 16:30 |
dimitern | voidspace, yeah | 16:30 |
voidspace | so you really are extracting the mask | 16:30 |
voidspace | now I understand | 16:30 |
voidspace | seems odd that you go from a CIDR to a CIDR, seemed unnecessary | 16:30 |
voidspace | makes more sense now | 16:30 |
dimitern | voidspace, I'd appreciate suggestions for better comments there :) | 16:30 |
voidspace | slightly more anyway | 16:30 |
voidspace | maybe - LXC expects the IPv4 address formatted as a CIDR (e.g. 1.2.3.4/5) | 16:31 |
dimitern | voidspace, i'm not sure whether the cidr will be like x.y.z.0/M or x.y.z.t/M | 16:31 |
voidspace | and then the rest of your comment makes sense (so extract the mask from the cidr | 16:31 |
voidspace | right | 16:31 |
voidspace | and you need the actual address, not the 0 | 16:31 |
dimitern | voidspace, I'd *expect* it to have 0-s at the end, but then that's not really a hard rule it seems | 16:32 |
dimitern | voidspace, yeah | 16:32 |
voidspace | dimitern: it all looks good, including the tests | 16:38 |
voidspace | dimitern: modulo the fact that it doesn't actually work... | 16:38 |
dimitern | voidspace, not yet at least :/ | 16:39 |
voidspace | sure | 16:39 |
voidspace | a good basis to iterate on | 16:39 |
dimitern | voidspace, cheers! live tests just finished ok on maas, ec2, and local | 16:39 |
voidspace | cool | 16:42 |
dimitern | voidspace, thanks! no suggestions at all? :) | 16:45 |
voidspace | dimitern: well only the comment change | 16:47 |
voidspace | dimitern: you're taking a new parameter and rendering text templates from them | 16:47 |
voidspace | dimitern: it's not rocket science | 16:47 |
dimitern | voidspace, ok, will change to clarify about the cidr | 16:48 |
dimitern | voidspace, i'll step away for a while now, but will have a look a bit later | 16:58 |
voidspace | dimitern: ok chap, see you later | 16:58 |
voidspace | dimitern: have a good evening. | 16:58 |
dimitern | voidspace, you too :) | 16:59 |
bodie_ | I have a very redundant method which I've now defined three times in different packages. (it inserts new values in maps at arbitrary keys.) Is there a common place such things should go? | 17:54 |
=== kadams54 is now known as kadams54-away | ||
=== kadams54-away is now known as kadams54 | ||
voidspace | g'night all | 18:47 |
perrito666 | nite | 18:47 |
voidspace | EOD | 18:47 |
voidspace | bodie_: juju/utils | 18:47 |
=== kadams54 is now known as kadams54-away | ||
=== kadams54-away is now known as kadams54 | ||
sinzui | natefinch, can you ask someone to look into bug 1413245 found in rc1? I think I identified the issue with vivd | 19:26 |
mup | Bug #1413245: 1.21-rc1 does not support vivid <juju-core:Triaged> <juju-core 1.21:Triaged> <juju-core 1.22:Triaged> <https://launchpad.net/bugs/1413245> | 19:26 |
sinzui | vivid | 19:26 |
natefinch | sinzui: ok | 19:29 |
=== kadams54 is now known as kadams54-away | ||
=== kadams54-away is now known as kadams54 | ||
alexisb | sinzui, is systemd on by default on vivid? | 20:14 |
* sinzui looks at his instance | 20:14 | |
* perrito666 notices he would not know how to figure that out | 20:15 | |
sinzui | alexisb, yes it is there | 20:15 |
perrito666 | sinzui: how do you tell/ | 20:15 |
perrito666 | ? | 20:15 |
alexisb | then juju wont support it without tweaking until 1.23 | 20:15 |
sinzui | perrito666, apt-cache policy systemd shows it was installed | 20:16 |
sinzui | perrito666, and I can see most of the system is using upstart still | 20:16 |
perrito666 | sinzui: says the same for upstart | 20:16 |
sinzui | perrito666, I can see a lot installed /etc/systemd on my instance has only a few core services in it | 20:19 |
=== alexisb is now known as alexisb_bbl | ||
thumper | o/ | 20:21 |
perrito666 | thumper: morning | 20:22 |
katco | hey hey thumper | 20:24 |
=== abentley_ is now known as abentley | ||
=== kadams54 is now known as kadams54-away | ||
=== kadams54-away is now known as kadams54 | ||
freyes | hi there | 21:24 |
menn0 | thumper: so to open an API connection for another env I take the agent's APIInfo, set a new environ UUID in it and pass that to api.Open? | 21:37 |
thumper | menn0: not quite | 21:56 |
thumper | well... hmm... | 21:56 |
thumper | ghit | 21:56 |
thumper | shit | 21:56 |
thumper | menn0: we need to talk | 21:56 |
menn0 | thumper: yeah we do. i'm seeing other things that worry me. | 21:57 |
menn0 | standup hangout? | 21:57 |
thumper | standup hangout? | 21:57 |
thumper | snap | 21:57 |
=== kadams54 is now known as kadams54-away | ||
thumper | menn0: heh, just noticed that we pretty much ignore bad credentials | 22:18 |
thumper | menn0: that is pretty bad | 22:19 |
* thumper writes a test... | 22:19 | |
thumper | oh good, it does fail | 22:21 |
* thumper reads more to work out why he thought it didn't | 22:21 | |
* thumper misread != as == | 22:22 | |
menn0 | thumper: :) | 22:22 |
anastasiamac | should I worry too much? godeps: cannot update "...github.com/juju/names": fatal: reference is not a tree: f2761fa05db34fb5b4ceb44721a067ffd22d5956 | 22:52 |
katco | anastasiamac: i've never looked too much into why that happens; i just do a go get -u <package> and re-run godeps | 22:53 |
thumper | menn0: do you know off the top of your head if the JujuConnSuite has a machine in it by default? | 22:54 |
anastasiamac | katco: thnx! | 22:55 |
anastasiamac | katco: i've ran go get -u github.com/juju/names | 22:56 |
anastasiamac | katco: then godeps | 22:56 |
anastasiamac | katco: but it still has the same issue | 22:56 |
thumper | make godeps | 22:56 |
thumper | anastasiamac: do this... | 22:56 |
anastasiamac | thumper: make godeps? | 22:56 |
thumper | in the juju/names tree | 22:56 |
thumper | git checkout master | 22:56 |
jw4 | anastasiamac: I ran into that when my origin was my own fork of the repo | 22:56 |
thumper | git branch -u upstream/master | 22:56 |
katco | ah | 22:57 |
thumper | anastasiamac: then the default will work | 22:57 |
katco | ty thumper | 22:57 |
thumper | anastasiamac: I added make godeps when I got sick of it not working | 22:57 |
thumper | you need to make sure you have an environment variable set | 22:57 |
katco | nice | 22:57 |
thumper | export JUJU_MAKE_GODEPS=true | 22:57 |
thumper | then 'make check' does godeps first, then runs all the tests | 22:58 |
menn0 | thumper: sorry I don't know ... haven't used JujuConnSuite much | 22:58 |
thumper | anastasiamac: the git commands are assuming you have origin set to your repo, and upstream set to the juju repo | 22:58 |
thumper | menn0: nm | 22:58 |
thumper | menn0: I'll find out :) | 22:58 |
anastasiamac | katco: j4w: thnx for ur help!!! | 23:02 |
jw4 | anastasiamac: yw :) | 23:02 |
menn0 | thumper: I have the provisioner worker under EnvWorkerManager | 23:02 |
anastasiamac | thumper: u r awesome -all works :D | 23:02 |
menn0 | thumper: but man do I have a lot of XXX's in this branch | 23:03 |
thumper | menn0: heh | 23:03 |
thumper | menn0: I have the check creds bit done, just writing extra tests now | 23:03 |
menn0 | thumper: cool | 23:04 |
anastasiamac | jw4: katco: u r awesome 2 - m astonished with fast response. | 23:04 |
jw4 | anastasiamac: lol | 23:04 |
anastasiamac | menn0: u have XXX's in the branch?.. | 23:05 |
wallyworld_ | thumper: 3 line review please for 1.21 release http://reviews.vapour.ws/r/783/ | 23:06 |
* thumper looks | 23:07 | |
thumper | done | 23:07 |
wallyworld_ | tyvm | 23:07 |
* thumper interrupts current branch for a different one | 23:08 | |
thumper | menn0: I have a branch I'm just proposing that has factory.MakeMachine return the password so we don't have to keep making known ones in tests when we need to know what it is | 23:30 |
thumper | just running all the tests now | 23:30 |
=== alexisb_bbl is now known as alexisb | ||
thumper | menn0: http://reviews.vapour.ws/r/784/ | 23:37 |
thumper | or wallyworld_ | 23:37 |
* thumper goes to lunch | 23:38 | |
alexisb | thumper, wallyworld_ is busy for the next hour | 23:38 |
menn0 | thumper: looking | 23:49 |
sinzui | wallyworld_, alexisb, thumper, oil reported bug 1413424 we need to understand why they cannot use rc1 | 23:56 |
mup | Bug #1413424: ERROR failed to bootstrap environment: cannot start bootstrap instance: no matching tools available <oil> <juju-core:New> <https://launchpad.net/bugs/1413424> | 23:56 |
wallyworld_ | sinzui: on a call with alexisb, will talk soon | 23:56 |
thumper | menn0: all tests pass | 23:58 |
menn0 | thumper: review done | 23:59 |
thumper | menn0: ta | 23:59 |
menn0 | thumper: I've suggested another approach but I'm not wedded to it. | 23:59 |
thumper | hmm... | 23:59 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!