| === RAOF is now known as tmpRAOF | ||
| === ssweeny` is now known as ssweeny | ||
| === dandrader is now known as dandrader|afk | ||
| === dandrader|afk is now known as dandrader | ||
| dandrader | tsdgeos, got time for reviewing a small and simple MP? | 10:20 |
|---|---|---|
| tsdgeos | dandrader: sure | 10:20 |
| dandrader | tsdgeos, https://code.launchpad.net/~dandrader/unity8/keepGreeterPwdUncovered/+merge/247475 | 10:20 |
| dandrader | tsdgeos, thanks! you're the most active reviewer in the team :) | 10:20 |
| tsdgeos | dandrader: that's because i'm easy | 10:21 |
| tsdgeos | shhhhhhh | 10:21 |
| tsdgeos | damn i need to find out there the tablet is and charge it D: | 10:26 |
| dandrader | sorry for that | 10:30 |
| Saviq | tsdgeos, about time, you need to bring them to BRU, too ;) | 10:33 |
| tsdgeos | Saviq: tablet? what for? | 10:33 |
| tsdgeos | i'm not part of the sprint | 10:33 |
| Saviq | tsdgeos, ah right, you're there with your K hat on ;) | 10:34 |
| Cimi | Saviq, calling this close scope isn't working well.. http://paste.ubuntu.com/9915513/ | 11:04 |
| Cimi | Saviq, seems like the close calls are async | 11:04 |
| Saviq | Cimi, this snippet doesn't say much | 11:05 |
| Cimi | Saviq, http://paste.ubuntu.com/9915536/ | 11:06 |
| Cimi | Saviq, closing scope makes dash crash | 11:07 |
| Saviq | Cimi, trace? | 11:07 |
| Cimi | Saviq, I think I have to run dash with gdb | 11:07 |
| Cimi | Saviq, how can I? | 11:07 |
| Saviq | Cimi, generally when things crash, that's the way to go | 11:08 |
| Saviq | Cimi, gdb builddir/src/Dash/unity8-dash -mousetouch | 11:08 |
| Saviq | gdb -args | 11:08 |
| facubatista | Hola! | 11:08 |
| Saviq | sry | 11:08 |
| Cimi | Saviq, I need from the phone | 11:08 |
| Saviq | Cimi, sudo gdb program `pidof unity8-dash` | 11:09 |
| Saviq | Cimi, or just analyze the .crash file | 11:09 |
| tsdgeos | dandrader: so that MR | 11:15 |
| tsdgeos | dandrader: is for when there's multiple users on the tablet? | 11:15 |
| tsdgeos | because with a single user i don't get the keyboard over the password | 11:15 |
| dandrader | tsdgeos, no. see "make tryMultiGreeter". The vkb covers the password if you use the shellRotation branch (in https://launchpad.net/~unity-team/+archive/ubuntu/demo-stuff) | 11:17 |
| dandrader | tsdgeos, shellRotation branch has the code from this MP | 11:17 |
| dandrader | tsdgeos, maybe ubuntu-keyboard from trunk (as opposed to the one from this ppa) is shorter in tablets | 11:18 |
| tsdgeos | dandrader: remove the console.log("loginListRect.y " + loginListRect.y); from the test? | 11:21 |
| Cimi | Saviq, looks like I should connect the close of the scope when the new scope finished loading | 11:21 |
| Cimi | http://paste.ubuntu.com/9915707/ | 11:21 |
| Cimi | cannot read much more... | 11:22 |
| Cimi | there is this activate | 11:22 |
| Cimi | don't know | 11:23 |
| Saviq | Cimi, you need to get symbols | 11:23 |
| Cimi | yeah | 11:23 |
| Saviq | https://wiki.ubuntu.com/DebuggingProgramCrash | 11:23 |
| Saviq | Cimi, for rtm the dbgsym packages are in http://ddebs.ubuntu.com/ubuntu-rtm/ | 11:23 |
| dandrader | tsdgeos, oh, right. done | 11:23 |
| Cimi | installing | 11:25 |
| === dandrader is now known as dandrader|afk | ||
| Saviq | mzanetti, just noticed authenticator app is mostly flat black, that on purpose? | 12:12 |
| mzanetti | yes | 12:12 |
| mzanetti | Saviq: I've asked mivoligo to redesign it | 12:12 |
| mzanetti | (the guy that designed machines vs machines) | 12:12 |
| Saviq | mzanetti, you should update the screenshots | 12:12 |
| Saviq | it looks slightly as if it lost the background or something | 12:13 |
| mzanetti | ack. will do once the redesign is done | 12:13 |
| mzanetti | actually I'd need to update screenshots for nearly all of my apps | 12:13 |
| === MacSlow is now known as MacSlow|lunch | ||
| tsdgeos | sil2100: can you trigger rebuilds for stuff that's "old" in https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/landing-005 ? | 12:29 |
| sil2100 | tsdgeos: ah, once again rebuilds needed, sure | 12:29 |
| tsdgeos | tx | 12:31 |
| Cimi | Saviq, http://paste.ubuntu.com/9916639/ | 12:40 |
| Saviq | pstolowski, can you have a look with Cimi why the shell plugin crashes for him ↑? | 12:41 |
| Saviq | Cimi, what's the bug# you're working on again? | 12:42 |
| Cimi | 1410337 | 12:42 |
| Cimi | Saviq, what I am trying to do is closing the store scope after launching the new scope | 12:43 |
| pstolowski | Cimi, Saviq looking | 12:46 |
| Saviq | Cimi, yeah, and that sounds right | 12:46 |
| Saviq | pstolowski, but it might be that it's destroyed by the time you try to close it (but that would be weird) | 12:46 |
| Saviq | bug #1410337 | 12:46 |
| ubot5 | bug 1410337 in Ubuntu UX "Launching a scope once installed is broken" [High,Triaged] https://launchpad.net/bugs/1410337 | 12:46 |
| === dandrader|afk is now known as dandrader | ||
| Cimi | Saviq, pstolowski this is another I get | 12:49 |
| Cimi | http://paste.ubuntu.com/9916749/ | 12:49 |
| Cimi | so, http://paste.ubuntu.com/9916773/ gives http://paste.ubuntu.com/9916749/ | 12:49 |
| Saviq | /food | 12:50 |
| dandrader | tsdgeos, thanks for the review | 12:50 |
| Cimi | http://paste.ubuntu.com/9916777/ gives http://paste.ubuntu.com/9916639/ | 12:50 |
| pstolowski | Cimi, Saviq from a quick look i think the problem is that closeScope just deletes the scope object you pass, instead of calling deleteLater on it | 12:54 |
| pstolowski | this is almost always a bad idea in qt... | 12:55 |
| pstolowski | Cimi, shall I prepare a quick fix to try out? | 13:02 |
| === MacSlow|lunch is now known as MacSlow | ||
| Saviq | pstolowski, yeah, please do | 13:50 |
| pstolowski | otp | 13:51 |
| dandrader | mzanetti, would you have time this week to review this? https://code.launchpad.net/~dandrader/unity8/fixSurfaceActiveFocus/+merge/247836 | 14:04 |
| dandrader | mzanetti, this is already in the shellRotation branch. | 14:05 |
| mzanetti | dandrader: ack, will try to get to it | 14:06 |
| dandrader | mzanetti, thanks. this should also affect the desktop mode | 14:07 |
| mzanetti | you mean the windowed mode? :P | 14:07 |
| * mzanetti needs to rename *Stage.qml files | 14:08 | |
| dandrader | s/affect/help with | 14:08 |
| dandrader | mzanetti, yeah, right :) | 14:08 |
| mzanetti | O_o | 14:09 |
| * mzanetti lost irc history | 14:09 | |
| mzanetti | dandrader: https://code.launchpad.net/~mzanetti/unity8/saveRestoreWindowSizePosition/+merge/247840 | 14:19 |
| dandrader | mzanetti, I'm not a big fan of singletons | 14:27 |
| dandrader | mzanetti, makes it harder to fake them in tests | 14:27 |
| pstolowski | Cimi, let me know if it helps: https://code.launchpad.net/~stolowski/unity-scopes-shell/delete-later-on-close/+merge/247842 | 14:28 |
| pstolowski | Saviq, ^ | 14:28 |
| Cimi | pstolowski, ok | 14:28 |
| === artmello_ is now known as artmello | ||
| === dandrader is now known as dandrader|afk | ||
| mzanetti | dandrader|afk: the testing/mocking argument is a valid one... not sure in this case as we either want the stuff to be the proper thing in the settings too, or we just ignore it (like the init() in the tests does) | 14:53 |
| mzanetti | so in here I guess it just keeps the code cleaner without hurting testability | 14:54 |
| mzanetti | but in general, you have a point | 14:54 |
| mzanetti | I was thinking, it could make sense if we set up some import paths in main.cpp, and then import singletons via their name instead of absolute path | 14:54 |
| mzanetti | then a test could easily override by just shipping it's own singleton implementation | 14:55 |
| mzanetti | because other than your issue, singletons in qml are quite handy to keep things clean | 14:55 |
| mzanetti | imo | 14:55 |
| === dandrader|afk is now known as dandrader | ||
| Cimi | can we trigger a jenkins of https://code.launchpad.net/~stolowski/unity-scopes-shell/delete-later-on-close/+merge/247842 ? | 15:48 |
| Saviq | Cimi, not while it's WiP | 15:58 |
| Saviq | Cimi, just x-build it :P | 15:58 |
| Saviq | Cimi, kicked a build here anyway http://s-jenkins.ubuntu-ci:8080/job/unity-scopes-shell-ci/284/console | 15:59 |
| mzanetti | Saviq: hey, about having issues with mocking singletons for testing as Daniel pointed out. wdyt of this: http://paste.ubuntu.com/9920590/ | 17:11 |
| Saviq | mzanetti, doubt it should be _SOURCE_ | 17:16 |
| mzanetti | why not? | 17:16 |
| mzanetti | for the not installed case only. the installed case would need INSTALL_SHELL_QML/Components or something | 17:17 |
| mzanetti | this diff is just for making it work... | 17:17 |
| mzanetti | for mocking we'd still need to add the mock dir too | 17:18 |
| Saviq | mzanetti, well, we have plugins/ for things that actually have qmldir files | 17:18 |
| mzanetti | ah ok | 17:18 |
| mzanetti | fair point | 17:18 |
| mzanetti | I could move it over there as a qml plugin, yes | 17:18 |
| mzanetti | qml-only | 17:18 |
| Saviq | yup | 17:18 |
| mzanetti | ok. will do that | 17:18 |
| mzanetti | thanks | 17:18 |
| === ljp is now known as lpotter | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!