[02:24] <elopio> veebers: (and alesage if still around): I have a problem selecting a subset of the tests. If we want to return an error when the test doesn't exist, then the host needs to have all the test packages installed too.
[02:24] <elopio> so far, only the phone needed all the test packages.
[02:24] <elopio> do you see that as an issue?
[02:25] <veebers> elopio: hmm, that's a good point (I've come across something similar just recently where there was code in webbrowser that isn't on utopic (but is on vivid)
[02:26] <veebers> elopio: so if we want the test on the host machine too we'll have to expect that the user is running vivid.
[02:26] <elopio> oh, right, that's an additional problem. If the host is in a different distro, the check is worthless.
[02:37] <elopio> veebers: alesage: I'm now inclined to let adt-run fail when we specify non-existing tests, instead of catching the error earlier.
[02:37] <veebers> elopio: yeah, that sounds good to me. It's a good start at least. If we get user feed back we can go from there
[02:38] <veebers> (Do the min. to get a card done and iterate with the users for further enhancements)
[02:39] <elopio> veebers: do you see any problem if we put the testsuite_list in the ubuntu_sanity_tests folder?
[02:39] <veebers> elopio: where is it at the moment?
[02:40]  * veebers looks
[02:42] <veebers> elopio: I can't think of a better place off the top of my head
[02:43] <elopio> veebers: do you mean, you can't think of a better place than debian/test/ ?
[02:44] <veebers> elopio: sorry, I can't think of a better place than what you've suggested
[02:44] <elopio> ack.
[02:44] <veebers> this is for the work of separating out the code from d/t/ right? So it'll need to be in a discoverable place
[02:45] <elopio> veebers: yeah, I want to put it under test to then be able to test the subset story.
[02:45] <veebers> ack
[02:45] <veebers> +1
[02:45] <elopio> veebers: I'm thinking ubuntu_sanity_tests/external_tests/testsuite_list
[02:45] <elopio> with updates in the README, of course.
[03:03] <alesage> elopio, something funky with my phablet-network on the serial branch: http://pastebin.ubuntu.com/9947891/
[03:04] <veebers> alesage: doc looks good, have left notes.
[03:04] <alesage> weird actually I'm getting that same return for the success case above :/
[03:04] <alesage> veebers, thx
[03:05] <veebers> alesage: hey, that looks like the error that I've had in the past (as per my comments re: flashing and starting tests)
[03:05] <elopio> alesage: I have no idea what that error code means.
[03:05] <alesage> elopio, please tell me all the answers
[03:05] <elopio> alesage: do you have the serial on the config, or not?
[03:06] <alesage> elopio I started fresh and no I didn't give the serial
[03:06] <alesage> elopio, but I think I just demonstrated that phablet-network itself does give that code for me raw
[03:07] <veebers> alesage: when you say fresh, did you delete your config file?
[03:14] <elopio> alesage: yeah, no errors here.
[03:14] <elopio> alesage: you might want to try jibel's alternative with nmcli: https://bugs.launchpad.net/ubuntu-sanity-tests/+bug/1408720/comments/2
[03:14] <elopio> that's something we need to do anyway, I think.
[03:23] <alesage> elopio I'm being selfish with reviews ATM :( , but also need to eat, will get a couple in
[03:24] <elopio> alesage: you should also rest. I'm here only because I slept all evening :D
[03:25] <alesage> elopio, maybe I can *reserve* either the reviews or the "subset of tests" for tomw, subset would enable some pairing
[03:26] <alesage> elopio, or you're already knee-deep on that one, eh?
[03:26] <elopio> alesage: I've splitted it in two, and took the smaller task first.
[03:26] <elopio> getting the existing code into test.
[03:26] <elopio> alesage: main thing are reviews. Then, whatever is on top.
[03:27] <alesage> elopio, I'll focus on reviews and getting everything running AM
[03:28] <elopio> ok.
[03:29] <veebers> note, I added a new card in the review column re: timeout
[03:29] <alesage> maybe we can leave those in the lane, e.g. if brendand also reviews
[03:30] <veebers> well, they do need to acks to merge :-)
[03:47] <elopio> veebers: brought back your timeouts branch. It is one line, but I still think it should be tested, and we now have the helpers to make it quickly.
[03:47] <veebers> elopio: ah good point. I'll look into that shortly
[03:49] <veebers> elopio: I see that you voted for plivo, what's the main reason for that? (e.g. I see that the python lib is not python3
[03:49] <veebers> )
[03:50] <elopio> veebers: main reason, it's free.
[03:50] <elopio> the lib is small, so quickly we can make it py3. At a first glance, I didn't see any big changes required for that.
[03:50] <veebers> elopio: no it's not, the first line says it'll cost money
[03:51] <veebers> hmm, ok fair enough as long as they take that contribution back, It would suck to have to distro patch that just for our own use
[03:51] <elopio> veebers: free as in freedom. We can install our own plivo server, and it won't cost money. Well, only the cost of the call.
[03:52] <elopio> veebers: I doubt they won't accept our contribution. Since I signed in, they send me constant emails, it seems it's a company that's alive.
[03:52] <veebers> elopio: I may have missed something, why would we install our own server? We only need a webservice (for either provider) right? They have a REST api that we hit
[03:52] <elopio> but, we have to check, you are right.
[03:53] <veebers> elopio: I'm not disagreeing with you, just wanting to know the reasons and talk through them
[03:53] <elopio> veebers: I'm not saying that we need our own server. I'm saying that we can have it.
[03:53] <veebers> ack
[03:53] <elopio> for security reasons, cost reasons, or anything. But for me, just the open source code makes me feel better.
[14:58] <brendand> elopio, hey
[14:58] <elopio> brendand: hello!
[14:59] <brendand> elopio, let's try to land as much as possible today!
[14:59] <elopio> brendand: yes indeed. Are you in need or a review?
[14:59] <brendand> elopio, top approve: https://code.launchpad.net/~brendan-donegan/ubuntu-sanity-tests/fix_wizard_test/+merge/247995
[15:00] <elopio> brendand: top approved.
[15:00] <brendand> elopio, review: https://code.launchpad.net/~canonical-platform-qa/ubuntu-sanity-tests/specific_config/+merge/247841
[15:01] <elopio> brendand: yes, the same test as autopilot, I like it. Thanks.
[15:01] <brendand> elopio, oh really, what a coincidence ;)
[15:02] <elopio> brendand: approving. alesage: can you please give the second review to the specific config branch? ^
[15:04] <elopio> brendand: and one thing for discussion. I prefer to keep the imports at the module level, not the object level.
[15:04] <elopio> like import argparse, and then use it like argparse.ArgumentParser(...)
[15:04] <elopio> because when you read the code, it's easier to tell which module is it that you are calling. In this example, it's obvious that ArgumentParser comes from argparse, but there are other symbols harder to link to a module.
[15:04] <elopio> brendand: do you have any preference there?
[15:08] <brendand> elopio, i think if the only symbols you're using are obvious then it's worth importing that way since it makes the code look cleaner
[15:09] <brendand> elopio, we couldn't use the other symbols if we don't import them anyway
[15:09] <elopio> brendand: I find it cleaner if it is consistent. But that's a fair point.
[15:10] <brendand> elopio, why use 'from' at all then?
[15:10] <elopio> balloons: to only use one level of modules.
[15:11] <elopio> from ubuntu_sanity_tests import tests, instead of import ubuntu_sanity_tests.tests.
[15:11] <elopio> s/balloons/brendand
[15:11] <brendand> true
[15:11] <elopio> alesage: you left a needs fixing here: https://code.launchpad.net/~canonical-platform-qa/ubuntu-sanity-tests/optional_options/+merge/247881
[15:12] <elopio> can you please check if you are happy with it now?
[15:13] <elopio> brendand: now lets talk about the coverage in https://code.launchpad.net/~canonical-platform-qa/ubuntu-sanity-tests/no_serial/+merge/247940
[15:13] <elopio> we are testing the same thing as before, the difference is that now we are not putting mocks everywhere.
[15:13] <elopio> so, I wouldn't call it a coverage drop. I would call it an increase in accuracy :)
[15:14] <elopio> to get everything under test in this module, we have the big problem that it needs subprocess execution. So we need to figure out how to do it properly.
[15:14] <brendand> elopio, run_sanity_tests is not covered at all now
[15:15] <elopio> brendand: before, it was run, but all the things that were hard were patched.
[15:15] <elopio> so it was the same as not running it.
[15:15] <elopio> this branch is about serial, so the tests only check that the serial was passed or not.
[15:16] <elopio> we need to put the other things into a test, but that's a different card. A harder one.
[15:16] <brendand> elopio, sounds like you're saying code that is trivial is not worth testing?
[15:17] <elopio> brendand: not at all. This run_sanity_tests method is not trivial at all.
[15:17] <elopio> and it needs to be tested.
[15:17] <elopio> what I'm saying is: it was untested before, this serial card was not about putting it under test.
[15:18] <brendand> elopio, it was tested before. maybe not thoroughly, but it was
[15:18] <elopio> we need a card to increase the coverage of command_line execution, and I have no idea how to do it properly. Needs discussion.
[15:18] <brendand> elopio, see: http://people.canonical.com/~brendan-donegan/ubuntu-sanity-tests/trunk/htmlcov/ubuntu_sanity_tests_command_line.html
[15:20] <elopio> brendand: no, it was run, but not tested. You reviewed the tests in the original serial branch.
[15:21] <elopio> what I did there was to call run_sanity_tests, but patch the IO, patch the report generation, patch popen, and only assert that -s was passed.
[15:21] <elopio> if you look at the new tests, we are testing the same. And now it's clear that run_sanity_tests needs tests.
[15:26] <brendand> elopio, did you remove test_main_must_setup_and_run_with_serial because it would fail with the new code?
[15:27] <elopio> brendand: no. Look at rev 59: https://bazaar.launchpad.net/~canonical-platform-qa/ubuntu-sanity-tests/no_serial/revision/59
[15:28] <elopio> I first made the new code pass with the old style of tests.
[15:28] <elopio> then I followed vila's suggestion to split the commands into build and run, and test only the build, which removes the need of mocks leaving us with the same tests.
[15:29] <elopio> brendand: I can revert to rev 59, which will give us a high but deceiving coverage number, and ugly tests.
[15:30] <brendand> elopio, what i'm asking is does anything stop you from reinstating test_main_must_setup_and_run_with_serial
[15:31] <elopio> brendand: no, I can revert to rev 59.
[15:32] <brendand> elopio, but if you revert won't you lose other tests you added/changed?
[15:32] <saqman2060> I was testing the autoresize feature and was unable to continue the install. The "install" button was grayed out. I was able to resize the partition but not finish the install. I am testing daily version " 20150129" using virtualbox 4.3.20.
[15:32] <brendand> elopio, i think all the new tests you added are good and valuable
[15:33] <elopio> brendand: I would lose the cleanups I did on the tests. I didn't added new tests. I split them and removed the mocks, except the IO ooooooooone.
[15:33] <elopio> one
[15:34] <brendand> elopio, are you looking at this diff: https://code.launchpad.net/~canonical-platform-qa/ubuntu-sanity-tests/no_serial/+merge/247940
[15:34] <brendand> ?
[15:34] <alesage> elopio I'll get on those reviews
[15:35] <brendand> elopio, the diff on test_command_line shows test_main_.. being removed and six new tests added
[15:35] <brendand> elopio, ah you split them
[15:35] <brendand> ok
[15:35] <elopio> brendand: I am. Compare the tests in rev 59 with the tests in rev 65.
[15:36] <elopio> alesage: thanks.
[15:38] <brendand> elopio, anyway next move is yours, reply on the MP
[15:40] <elopio> brendand: I'd say, next move: add a card to put run_sanity_tests under test. But the only thing that comes to mind is to patch Popen and check the order of popen calls.
[15:40] <elopio> which is a little better than what we had before, but not good enough.
[15:41] <elopio> brendand: do you want me to do it in order to get this branch landed? Or we put it in the backlog and decide later when to do it?
[15:42] <brendand> elopio, if you could reinstate the test (in addition to the ones you added), then put a card or a bug to do the tests 'right', if that will require a significant amount of time
[15:45] <elopio> IMO, that makes no sense. Between 59 and 66 I added no tests, so that would be testing the same thing twice, once ugly and once nice. I will just make a new branch to raise the coverage.
[15:47] <elopio> brendand: btw, I think you moved the wrong card back to doing.
[15:47] <elopio> unless I'm missing something. The one you moved has your +1.
[15:54] <brendand> elopio, ok reply in the comment what you think to do next
[15:54] <brendand> elopio, fixed the board.thanks
[15:59] <brendand> elopio, and get some feedback from alesage
[16:06] <elopio> brendand: alesage: https://code.launchpad.net/~canonical-platform-qa/ubuntu-sanity-tests/run_main_tests_tests/+merge/248135
[16:07] <elopio> that excercises run_main_tests just as how it did the serial branch, but has a check that makes a little sense.
[16:26] <brendand> elopio, we don't have sudo inside the tests themselves?
[16:29] <alesage> elopio concerning this last MP, and I was studying this a bit yesterday, this feels a bit tortured to me, why don't we just fake those calls in run_sanity_tests and then test those functions separately?
[16:29] <elopio> brendand: we can, but it makes some things harder.
[16:29] <elopio> we can tell in debian/tests that we require root access.
[16:29] <brendand> elopio, not having it also makes some things harder :)
[16:29] <alesage> the patented "fails only in one place" method as Mr. Richards is always saying
[16:30] <elopio> then we will be running with the root user, and have to switch to phablet at some point.
[16:30] <alesage> also I'm not sure I understand why __enter__ is executed here instead of __init__
[16:30] <elopio> alesage: Popen is called from with, thus we need to patch enter.
[16:31] <elopio> I was trying to split things and test them separately, but brendand requested to bring back the run_tests test
[16:31] <alesage> ok it's brendand's fault
[16:32] <elopio> no, it's mine for making the ugly test to begin with.
[16:32] <knome> it has to be balloons' fault
[16:32]  * knome runs
[16:33]  * balloons desperately tries to catch a fleeing knome, but he's gone
[16:35] <alesage> elopio, I see that it works but I want to refactor it :) , can I approve and then do so in a separate MP?
[16:36] <elopio> alesage: the branch is shared. You can just make your changes and push to it.
[16:37] <elopio> just bring the card back to doing, and assign it to yourself.
[16:37]  * alesage grabs a bunch of strings from balloons floating away
[16:37] <elopio> alesage: but, please do the missing reviews first. We are only three today, so we need your reviews before brendan leaves.
[16:37] <alesage> elopio, ok thanks
[16:37] <alesage> elopio, ok shall do
[16:38]  * elopio looks at the browser branches.
[16:40] <brendand> alesage, a top approve for https://code.launchpad.net/~canonical-platform-qa/ubuntu-sanity-tests/specific_config/+merge/247841 pretty please
[16:42] <alesage> I like that everyone needs my approval
[16:51] <alesage> brendand, elopio I have a lunch invite at our standup time, maybe we could meet quickly earlier to let brendand go earlier?
[16:51] <brendand> elopio, i could write a helper which switches to root and another which switches back to phablet
[16:51] <brendand> alesage, wouldn't mind meeting something in the next 30 minutes
[16:52] <brendand> alesage, so i can EOD :)
[16:52] <elopio> alesage: good for me.
[16:52] <brendand> elopio, top of the hour?
[16:52] <elopio> brendand: sounds ok to me. We tried it some time ago, and it was easier to put the root commands in the setup. But if you make it work, seems the same to me.
[16:53] <alesage> brendand, top o' the hour to you :)
[16:53] <elopio> brendand: alesage: in 7 minutes. I'll prepare the document.
[16:54] <brendand> alesage, i had literally no idea you'd say that...
[16:54] <alesage> brendand, I'm so unpredictable!
[16:54] <alesage> also it's Friday
[17:00] <elopio> brendand: meeting time.
[17:19] <brendand> alesage, i'm not leaving until that mp is approved :)
[17:19] <alesage> going to be a loooong night
[17:19] <elopio> alesage: please top-approve anything that you see as ready, and move the cards. I'm going to take a little break.
[17:20] <alesage> elopio, ok
[17:20] <alesage> brendand, need a push there
[17:24] <alesage> brendand, poke
[17:25] <brendand> alesage, oh might have got stuck, been having problems with that today
[17:25] <brendand> alesage, repoke
[17:25] <alesage> brendand, k
[17:25] <brendand> indeed, bzr push was hanging
[17:25] <brendand> grrr
[17:26] <alesage> brendand, took the liberty of moving that card thx
[17:30] <brendand> alesage, elopio - thanks and good night!
[17:30] <brendand> email me if anything urgent
[17:31] <elopio> enjoy the weekend brendand.
[17:39] <cgoldberg> hola 0/
[17:40] <balloons> cgoldberg, hola :-)
[17:40] <elopio> cgoldberg: o/
[17:42] <cgoldberg> i'm itching for an afternoon self-project.  I might pave my desktop and start running Vivid
[17:42] <cgoldberg> im still on Trusty
[17:44] <balloons> cgoldberg, oi, that's a longer term decision, but running -devel is fun
[18:02] <alesage> cgoldberg, big snows over there?
[18:03] <cgoldberg> alesage, yea.. like 2+ feet the other night... but Boston cleared it out pretty quick.. supposed to get more soon too
[19:09] <elopio> thanks for the reviews alesage. Now we are only two, so we can't land anything else. But the queues are actually pretty decent.
[19:10] <alesage> elopio, manually testing this no_serial one and then want to pick over the main testing one a bit
[19:11] <elopio> alesage: ok. I already top approved that one as it had +2. But it's always nice to have more reviews.
[19:11] <elopio> if you find something, we'll do it in a new branch.
[19:12] <alesage> elopio, ok, sure it's fine, although this quickie needs to get in on your serial branch fwiw http://paste.ubuntu.com/9961484/
[19:13] <elopio> alesage: oh, good catch. Let me see if I can stop jenkins.
[19:14] <elopio> just in time.
[19:14] <alesage> elopio, I have to lunch, will do the rest upon return
[19:15] <elopio> now, how did it got in there? I suppose I borked one of the merges.
[19:15] <alesage> elopio, no brendand's branch introduced it
[19:15] <alesage> don't know what else it affects
[19:15] <alesage> (i.e. into what else it's merged)
[19:16] <elopio> alesage: ah, I see. I didn't run that one.
[19:16] <elopio> ok, so trunk is broken. I'll make a new branch.
[19:16] <alesage> elopio, have to assume Brendan didn't either :)
[19:42] <Letozaf_> balloons, hi
[19:44] <balloons> Letozaf_, heelo
[19:45] <Letozaf_> balloons, I fixed pyflakes and pep8 on yesterdays mp
[19:45] <Letozaf_> balloons, by the way how's your wrist ?
[19:48] <elopio> we broke trunk on friday :D
[19:48] <elopio> there's a lesson there, somewhere.
[19:48] <knome> wrist? what have you done, balloons...
[19:49] <balloons> knome, I was in a soft cast for my wrist for a couple weeks at the beginning of the month
[19:49] <balloons> doing great now Letozaf_ thanks for asking
[19:49] <Letozaf_> balloons, great :)
[19:49] <davmor2> elopio: is it don't release on FRIDAYS EVA!!!!!
[19:49] <knome> aha... because? :)
[19:49] <Letozaf_> hello knome  :)
[19:49] <elopio> davmor2: we release on thursdays, every two weeks. So the problem has not been released.
[19:50] <knome> hullo Letozaf_
[19:50] <Letozaf_> :)
[19:50] <balloons> Letozaf_, approved
[19:51] <knome> did you know "hullo" was the word stephen fry and hugh laurie used when they met each other the first time?
[19:51] <Letozaf_> balloons, thanks
[20:12] <Letozaf_> knome, hullo sounds strange to me, I prefer hello :P
[20:13] <knome> heh
[20:13] <knome> Letozaf_, how does "hyvää päivää" sound to you then? ;)
[20:14] <elfy> rude ...
[20:14] <knome> elfy, hah :)
[20:15] <elfy> is what I'd say :p
[20:15] <elfy> if asked
[20:15] <Letozaf_> knome, ah man don't even know how to pronounce it
[20:15] <knome> one of the few non-rude things you can say in finnish
[20:15] <knome> :P
[20:15] <Letozaf_> knome, elfy what does it mean?
[20:15] <elfy> Letozaf_: I think that the h,y,v,p's and a's are all silent :)
[20:15] <knome> Letozaf_, http://www.forvo.com/word/hyv%C3%A4%C3%A4_p%C3%A4iv%C3%A4%C3%A4!/
[20:16] <elfy> Letozaf_: absolutely no idea - all dutch to me :)
[20:16] <knome> dutch.. ugh :D
[20:16] <Letozaf_> knome, OMG weired :P
[20:16] <knome> dutch is a weird language
[20:16] <elfy> http://en.wikipedia.org/wiki/Greek_to_me
[20:17] <Letozaf_> elfy, :) same for me
[20:17] <elfy> :)
[20:18] <knome> Letozaf_, there you go: http://www.forvo.com/word/laadunvarmistus/#fi
[20:18] <Letozaf_> knome, :S
[20:25] <knome> what :P
[20:27] <Letozaf_> knome, means "confused" :P
[20:28] <Letozaf_> knome, as elfy said sound greek to me
[20:28] <knome> do you mean hämmentynyt?
[20:28] <Letozaf_> sounds
[20:29] <Letozaf_> knome, if only I remembered Afrikaans well I could have answered you in Afrikaans, then :P
[20:29] <Letozaf_> knome, but I remember only a few words
[20:30] <knome> :)
[20:35] <knome> but afrikaans is relatively understandable
[20:35] <Letozaf_> knome, yeah compared to finnish yes :)
[20:36] <knome> ;)
[20:36] <knome> they say finnish is one of the hardest languages in the world to learn...
[20:37] <elfy> Martian would probably be easier
[20:37] <Letozaf_> knome, lekker, biltong, Droëwors
[20:37] <Letozaf_> elfy, ha ha :)
[20:38] <elfy> http://www.effectivelanguagelearning.com/language-guide/language-difficulty
[20:38] <Letozaf_> knome, dronkie, krimpie. toppie
[20:38] <elfy> as related to English that is
[20:39] <knome> elfy, yep..
[20:39] <Letozaf_> :D
[23:21] <alesage> elopio, I'm realizing that if two are pairing then the other two will be responsible for the reviews
[23:42] <ubuntu-plain> short feedback: when upgrading from 12.04 to 14.04 with german language settings, ubuntu switched to firefox in english. firefox-locale-de was missing. ps: please make a simple feedback form, there are so many places to report or file bugs on that launchpad thingy, i dont know where to turn to
[23:45] <knome> ubuntu-plain, what would be a simple feedback form?
[23:45] <knome> ubuntu-plain, and how would the people who read it figure out what the feedback is about, if no categorization was made?
[23:53] <ubuntu-plain> one webpage with forms or a package selector. or a working ubuntu-bug without 7 windows and redirect to some webpage to register an account
[23:54] <knome> i don't understand how those forms or the package selector could be any easier, or less complex
[23:54] <knome> do you realize how many packages there are in ubuntu?
[23:54] <knome> anyway, for the registration part... without that, launchpad would be full of spam