[08:53] <dandrader> kgunn, shellRotation branch should merge fine now
[10:09] <tsdgeos> Mirv: can you land https://bugs.launchpad.net/ubuntu/+source/qtdeclarative-opensource-src/+bug/1418370 ? It fixes the orientation issue with qt 5.4
[10:12] <Saviq> tsdgeos, any word on refreshing the certificate for qt-project? ;)
[10:12] <Mirv> tsdgeos: ok, uploading!
[10:13] <Mirv> as well as the oxide
[10:13] <tsdgeos> Saviq: two days ago it was supposed to be fixed ...
[10:13] <Saviq> right
[10:14] <tsdgeos> Mirv: cool
[12:56] <Saviq> Cimi, relatively pressing review needed: https://code.launchpad.net/~unity-team/unity8/wizard-auto-shutdown/+merge/248902
[12:56] <Cimi> Saviq, ok
[12:57] <Saviq> Cimi, oups, wrong version, fixing
[12:59] <Saviq> Cimi, actually, need to fix a test, too :/
[13:01] <Cimi> Saviq, do we really want to shut down the phone if inactive?
[13:01] <Saviq> Cimi, in wizard only, and only if you never interacted with it
[13:01] <Saviq> Cimi, i.e. in the factory
[13:01] <Cimi> why?
[13:02] <Cimi> what does design say?
[13:02] <Saviq> Cimi, it's not about design, it's about the factory process
[13:02] <Cimi> I never seen a phone/device shutting down
[13:02] <Saviq> Cimi, you never left an android phone on the wizard for 2 minutes ;)
[13:02] <Cimi> I might switch on the phone for the first time, go and make a coffee, come back and is switched off wtf
[13:03] <Cimi> Saviq, I understand your reasons, but I think we need someone to approve this change
[13:04] <Cimi> Saviq, and in any case, we need some sort of UI feedback (i'm shutting down because of inactivity-like notification)
[13:04] <Saviq> Cimi, yeah, except you dont'
[13:04] <Saviq> Cimi, request for this change comes directly from the product team
[13:05] <Saviq> I didn't just imagine that
[13:05] <Cimi> Saviq, let me test with android, see if it switches off
[13:06] <Saviq> Cimi, http://pad.lv/1418815 for reference
[13:06] <Cimi> Saviq, ok I understand, will review code...
[13:13] <Saviq> mterry, could use your eyes on https://code.launchpad.net/~unity-team/unity8/wizard-auto-shutdown/+merge/248902 too
[13:13] <Saviq> mterry, hi btw! http://pad.lv/1418815 for reference
[13:13] <mterry>  Saviq hello!  :)
[13:14] <Saviq> mterry, I'm not totally happy about the "pageLoaded" signal, maybe you can come up with a better thing, I'm not really sane today after the sprint
[13:15] <mterry> Saviq, :)  let me see
[13:18] <mterry> Saviq, a forced wait() in one of the tests?  grumble grumble
[13:18] <Saviq> mterry, read again ;)
[13:18] <Saviq> mterry, it's a wait on the signal spy
[13:18] <mterry> Saviq, right.  But you are expecting it to timeout
[13:18] <Saviq> mterry, well, what else?
[13:19] <Saviq> mterry, I could just verify() and go with that, the expectFail just adds one more
[13:19] <mterry> Saviq, I don't like delays in the tests, they are long enough to run already.  But I understand what you're doing here
[13:19] <mterry> Saviq, I might have been satisfied with just the verify() but I can't complain about more tests I guess
[13:19] <Saviq> mterry, yeah you know... how do you verify that something doesn't happen? :)
[13:20] <mterry> Saviq, well it's quite unlikely to happen if the timer isn't running  :)
[13:20] <Saviq> mterry, is true
[13:21] <mterry> Saviq, I'm surprised we didn't already have a Session mock
[13:21] <Saviq> mterry, yeah, was surprised, too
[13:23] <mterry> Saviq, so this is for unity8... but I assume the bug really cares about rtm?   which would be system-settings?
[13:23] <Saviq> mterry, yeah, I'll backport it to system-settings
[13:23]  * Saviq fixes bug tasks
[13:24] <mterry> Saviq, well I love it, pageLoaded is fine too.  Let me just test on my device and then approve
[13:25] <Saviq> kk
[13:28] <Saviq> mterry, later we might make it more robust (i.e. Keys.onPressed; mouse and touch events, + a dialog before it goes to sleep)
[13:28] <mterry> Saviq, yeah I did wonder.  Like, what if someone is just fooling around with language list
[13:28] <mterry> Saviq, or puts phone down to read manual
[13:29] <Saviq> mterry, I really think that's edge cases, but yeah, let's cater for those at some point, I think this is good for now
[13:30] <mterry> Saviq, I think ideal would be to throw up a dialog that also times out, but warns user about impending shutdown
[13:31] <Saviq> mterry, yup, that's the plan
[13:31] <Saviq> mterry, edge case, though
[13:31] <mterry> Saviq, yes, ideally new users are so excited they race through the wizard
[13:32] <mterry> :)
[13:36] <mterry> Saviq, for that wait to really be effective, wouldn't you want to specify the delay time yourself?  To be over two minutes?  I think the default is 30s
[13:37] <Saviq> mterry, right, or change the interval
[13:37] <Saviq> mterry, don't really wanna add 2mins wait time to our test suite
[13:38] <mterry> Saviq, ah sure.  But again, if we don't trust the !running check, why do we trust changing interval and running?  :)
[13:38] <Saviq> mterry, indeed
[13:38] <Saviq> mterry, I'll just check that it's not running and that the signal didn't fire before then
[13:38] <Saviq> mterry, which is kinda what the wait() was doing anyway
[13:41] <Saviq> mterry, done
[13:42] <mterry> Saviq, hrm.
[13:42] <mterry> Saviq, you might want to move the pageLoaded signal before the checkSkip line too
[13:42] <mterry> Saviq, otherwise you could end up emitting pageLoaded(2) then pageLoaded(1) if you skip 1
[13:48] <Saviq> mterry, done
[13:49] <mterry> Saviq, it's a little odd that we emit pageList.index rather than pageStack.depth, but either situation is deceptive (in the case of a page having follow-on pages).  And especially since we don't care about it being accurate here, no biggie
[13:49] <mterry> Saviq, I'll approve, worked fine in testing too
[13:50] <Saviq> mterry, tx
[14:20] <tsdgeos> mzanetti: ohmy, you got an all green MR
[14:20] <tsdgeos> we hadn't had that in ages :D
[14:20] <mzanetti> *\o/*
[14:27] <tedg> tsdgeos, Are you going to flash phones at MWC this year? ;-)
[14:28] <tsdgeos> tedg: don't know, wasn't year last year, and people that were there said the numbers of flashings where down compared to 2 years ago since flashing is so well documented nowadays
[14:28] <tedg> tsdgeos, Ah, okay. Probably they'll want to sell phones more than flash other ones this year.
[14:29] <tedg> It is kinda a funny part of Ubuntu Phone history :-)
[14:32] <tsdgeos> yep, one of the first phones we flashed was from the firefox phone people D:
[14:33] <mzanetti> :)
[14:40] <Saviq> tedg, the volume notifications are quite intrusive recently... they show up on boot, on DTMF tones in the dialer... on music...
[14:40] <Saviq> bug #1418089
[14:40] <Saviq> that known?
[14:40] <tedg> Saviq, Do you have the i-sound that landed last night?
[14:40] <Saviq> tedg, might not
[14:42] <tedg> Saviq, bug 1416233
[14:42] <Saviq> tedg, ok, that then might be fixed
[14:42] <Saviq> tedg, right, feel free to dupe my bug
[14:44] <dandrader> mzanetti, https://code.launchpad.net/~dandrader/unity8/improveLauncherTests/+merge/248919
[14:56] <Cimi> tsdgeos, hey, is this ok for closing scopes? http://paste.ubuntu.com/10092894/
[14:57] <tsdgeos> Cimi: don't remove it from all scopes, otherwise you're going to lose the scope in the mock
[14:57] <tsdgeos> Cimi: when activating it add it to a list
[14:57] <tsdgeos> when closing it check it's on the list
[14:57] <tsdgeos> that's all
[14:57] <tsdgeos> same the m_openedScope did
[14:57] <tsdgeos> but with alist
[14:58] <Cimi> tsdgeos, openedscope?
[14:58] <Cimi> tsdgeos, but that was never changed
[14:59] <Cimi> tsdgeos, we don't call activate
[14:59] <tsdgeos> we do
[14:59] <tsdgeos> we already discussed over this
[14:59] <tsdgeos> there's a test that proves we do
[14:59] <tsdgeos> and i pasted you the code that calls activate
[15:00] <Cimi> tsdgeos, only when we click an item
[15:00] <tsdgeos> yes
[15:00] <tsdgeos> which is the only way to open a scope
[15:00] <tsdgeos> isn't it?
[15:00] <Cimi> mmm
[15:00] <tsdgeos> or maybe not
[15:01] <tsdgeos> maybe you can also though a Preview Action
[15:01] <Cimi> tsdgeos, when we move between favorite scopes?
[15:01] <Cimi> tsdgeos, yes, correct
[15:01] <Cimi> tsdgeos, like in my bug
[15:02] <tsdgeos> well that goes through previewmodel triggered then
[15:02] <Cimi> tsdgeos, I can add activate in openScope
[15:02] <tsdgeos> no
[15:02] <Cimi> inside the tempscope
[15:02] <Cimi> mmm ok
[15:02] <tsdgeos> activate calls openscope
[15:02] <tsdgeos> not the other way around
[15:02] <tsdgeos> what you can't do in your test is call openScope
[15:02] <tsdgeos> openScope is not something we call
[15:02] <tsdgeos> is something the backend calls
[15:03] <Cimi> ok
[15:03] <tsdgeos> on actions from the user
[15:03] <tsdgeos> be it acivate()
[15:03] <tsdgeos> or                         previewModel.triggered(widgetId, actionId, data);
[15:03] <tsdgeos> in qml/Dash/Previews/Preview.qml
[15:15] <Cimi> tsdgeos, in the end what  we are doing in scopes plugin https://code.launchpad.net/~stolowski/unity-scopes-shell/fix-temp-scopes/+merge/248235
[15:15] <Cimi> tsdgeos, I need the same code...
[15:16] <tsdgeos> you need something similar
[15:16] <tsdgeos> you don't need to delete the scopes
[15:16] <tsdgeos> because the mock plugin creates them all the startup
[15:16] <tsdgeos> and stopres them in allscopes
[15:16] <tsdgeos> and serves them from there
[15:16] <tsdgeos> but yes, you need something similar
[15:22] <mzanetti> Saviq: http://notyetthere.org/data/com.ubuntu.terminal_0.7.latest_amd64_rev015.click
[15:58] <MacSlow> Saviq, I've pushed a fix for the property-count failure on Jenkins, but can't trigger a rebuild on jenkins as the site is dead from my end
[15:59] <MacSlow> Saviq, ... ^ regarding the swipe-to-dismiss branch
[15:59] <Saviq> MacSlow, if you pushed a change it will notice and rebuild
[16:00] <MacSlow> Saviq, sure... local test (on my slow machine no longer failed) 50 of 50 test-runs passed... that was good enough for me to push :)
[16:00] <Saviq> MacSlow, yup, sounds sane, kicked a jenkins rebuild anyway
[16:01] <MacSlow> Saviq, thanks
[16:36] <dandrader> greyback__, does it make sense to you? mapToItem(null, Qt.point(mouse.x, mouse.y)).x;
[16:37] <dandrader> point = mapToItem(null, Qt.point(mouse.x, mouse.y)).x;
[16:38] <dandrader> point = mapToItem(null, mouse.x, mouse.y)