/srv/irclogs.ubuntu.com/2015/02/09/#ubuntu-unity.txt

seb128Saviq, hey, do you know what's the status of https://bugs.launchpad.net/canonical-devices-system-image/+bug/1393438? is the fix on that bug supposed to address the issue? where is the translatable string in that case?08:35
ubot5Launchpad bug 1393438 in unity8 (Ubuntu) ""Enable location data" string displays untranslated" [Undecided,Confirmed]08:35
Saviqseb128, digging...08:36
Saviqseb128, right, so it's missing some work on our (unity8) side08:37
seb128Saviq, k, that explains, thanks08:37
seb128Saviq, any chance that get assigned to somebody? the string is quite visible in the ui08:38
Saviqseb128, just did08:38
seb128thanks08:38
seb128Saviq, sorry to have reported that dialer bug against unity8, I was unsure what component to pick, it's a bit of an app management issue ... could be the job from whoever started it to close it, or could be up to the dialer to exit after call09:21
Saviqseb128, no worries, I left a unity8 task just in case09:21
Saviqas it's indeed not clear dialer can do all it needs to do09:22
Cimitsdgeos, testing the temp scope to temp scope is a bit tricky: the only scope calling activate is the click scope, but the click scope cant be made unfavourite11:04
tsdgeosCimi: so what's the real world scenario we are fixing?11:06
tsdgeosit's store as temp, and then a preview in store calling another temp, no?11:07
SaviqCimi, the store scope calls activate too11:10
tsdgeosif that's what we're having11:10
SaviqCimi, you go to store, install a scope, press Search11:10
tsdgeoswe should try to replicate something similar11:10
tsdgeosit doesn't need to be "the store" in our mocks11:11
tsdgeosbut something similar to what we're fixing11:11
tsdgeosso the test is at least the real world case11:11
Cimiwe're fixing temp scope from tempo scope11:11
tsdgeosCimi: via what? preview or just activation of a result?11:12
Cimitsdgeos, for now preview, but I guess we need to see other possible scenarios11:13
tsdgeossure11:13
Cimiin the test I am manually calling activate11:13
tsdgeosyeah11:13
Cimifrom a temp scope11:13
tsdgeosdon't do that11:13
tsdgeoslet's please make a test that does the same the user does11:13
Cimibut how do I create a ubuntu store scope with previews?11:14
tsdgeosit doesn't need to be a ubuntu scope11:14
tsdgeosit can be any of the mock scopes11:14
tsdgeosand they have previews already11:14
tsdgeosyou just need to make one of those previews be special and do the same the store scope does to us when pressed11:15
Cimiyeah, don't know what it does11:15
Cimihave to dig11:16
Cimiwhere is the code of the store?11:19
tsdgeosyou don't need the code for the store11:19
tsdgeosjust add some console.log in the preview code11:20
tsdgeosand see how what it does11:20
tsdgeostriggeredAction looks like a good place to add a console log11:21
CimiOK11:21
Saviq/food11:22
Cimitsdgeos, it might be that is the preview model launching actions?11:45
CimiI see in Preview.qml that the buttons call previewModel.triggered()11:47
Cimi(with action  open_click [object Object] with the latter probably a scope)11:47
tsdgeosCimi: and how does that come back to us? in gotoScope/openScope of Dash.qml/DashContent.qml ?11:50
Cimitsdgeos, don't know11:52
tsdgeosCimi: console.log!11:54
=== MacSlow is now known as MacSlow|lunch
Cimitsdgeos, the action is called by the backend12:00
tsdgeosof course12:01
tsdgeosi'm just trying for you to understand the call path12:01
tsdgeosso you can make our mock do something similar12:01
=== alan_g is now known as alan_g|lunch
=== MacSlow|lunch is now known as MacSlow
=== alan_g|lunch is now known as alan_g
mzanettimterry: hey14:20
mterrymzanetti, hello!14:20
mzanettimterry: I'm trying to fix the as launcher model14:20
mzanettimterry: can I know if the session is running?14:20
mzanettiin order to ignore the non pinned ones14:20
mterrymzanetti, umm..  I just checked and I actually can't see that in the greeter API that LightDM exposes...14:23
mterrymzanetti, LightDM surely knows14:23
mterrymzanetti, but...  oh wait.14:23
mterrymzanetti, no the greeter does know14:23
mterrymzanetti, so the greeter can know via liblightdm14:24
mterrymzanetti, but your branch doesn't care about that side of things, right?14:24
mterrymzanetti, your branch doesn't actually *use* the AS launcher model?14:24
mzanettimterry: not really14:24
mzanettimterry: it's just preparing it for you, so you can take it into use without having to mess with the launcher too much14:25
mzanettimterry: I've added the pinned information to the sync process now14:25
mzanettimterry: so what do you propose?14:27
mterrymzanetti, let me see if you can do anything with that information, given the current state of the LightDM plugin... hold on14:28
mzanettiI could add a "hideUnpinned" property to the launcher api. then when you use that in the split greeter, set that to true somehow when the session is not running14:29
mterrymzanetti, so it is exported via the "loggedIn" data property on the LightDM.UsersModel object14:29
mterrymzanetti, so that should be simple to hook up to your hideUnpinned property, yeah14:30
mzanettiack14:30
=== marcusto_ is now known as marcustomlinson
greybackAnyone have an opinion on QQmlListProperty versus QAbstractListModel? I preferred QQmlListProperty for simple lists of objects, but now I think about it, it just has a "list changed" signal - it doesn't inform the view more detail about what changed like QAbstractItemList does (dataChanged, itemAdded/Removed)14:51
mzanettigreyback: yeah... QQmlListItem is pretty useless unless you want to create/change the list from qml14:52
mzanettierr. QQmlListProperty14:53
greybackmzanetti: so I'm seeing. But I never really liked creating a QAbstractListModel with a single roleName either, since the  role is kinda pointless14:54
mzanettiyeah...14:54
mzanettiI for one so far always ended up converting my QQmlListProperties into real models at some point14:54
* greyback takes note14:56
tsdgeosSaviq: Cimi: how do you guys see https://code.launchpad.net/~aacid/unity8/properVRangesCurrentScope/+merge/246465 ?15:15
Saviqtsdgeos, "see" in what way? it's a Needs-review MP?15:16
tsdgeosSaviq: yeah15:16
tsdgeosand i need someone not me15:16
tsdgeosto check if we actually want that :D15:16
tsdgeosor not15:16
Saviqok, I'll check it out15:16
CimiSaviq, thx15:17
pstolowskiCimi, hey! can we land https://code.launchpad.net/~stolowski/unity-scopes-shell/fix-temp-scopes/+merge/248235 ? did you have a chance to test it with your fix?15:18
Cimitsdgeos, today I noticed that when we open or switch to a scope, we load all results then we do collapse15:19
Cimipstolowski, seems to work, I am working on unity side15:20
tsdgeosCimi: what you mean load all results and then collapse?15:20
Cimitsdgeos, try with the kickstarter scope from the store15:21
pstolowskiCimi, ok, cool15:21
Cimitsdgeos, you see the categories start populating, then it collapses15:21
Cimiit starts expanded then collapse15:21
Cimimaybe when we load scopes we should load just collapsed results at first, then load the rest later?15:22
paulliuSeems mumble dies again?15:23
tsdgeosCimi: hmmm we load everything collapsed15:24
tsdgeosor we should15:24
tsdgeosCimi: can you record a video?15:24
Saviqpaulliu, yeah, it looks like15:25
Cimitsdgeos, ok15:26
Cimitsdgeos, https://www.youtube.com/watch?v=RTG6xPYmR4815:46
Cimialso, this "hide manage dash and scroll right to the scope" isn't the best, but it is more a design thing15:48
SaviqCimi, I assigned you to the bug today, the one about "Enable location" being untranslated in our UI, we need to add a special setting type that will have the strings to translate hardcoded15:49
CimiSaviq, saw it15:51
CimiSaviq, I am still trying to do this test for the temp scope fix15:51
SaviqCimi, yeah sure, just wanted to let you know the desired approach15:51
SaviqCimi, this looks like we're leaving the first category expanded until there's more categories, which is per design, but I agree the visual glitches are not nice15:51
tsdgeosCimi: hmmm, that's weird, we default to non expanded for all categories, does this only happen on that scope or all?15:51
Saviqtsdgeos, don't we have code that expands if there's only one category?15:52
Cimitsdgeos,  noticed only on that scope15:52
Saviqtsdgeos, Cimi, it might be that the scope registers the categories as they come in15:52
Cimiit's tedg fault :P15:53
Saviqinstead of early in the reply15:53
tsdgeosSaviq: hmmmm, can't find anything like that in the code tbh15:53
tedgCimi, Me? Temperature? It's nice here, not cloudy London.15:54
Saviqtsdgeos, GSV.qml:23615:54
tedgCimi, Do you even remember what the sun is like anymore? ;-)15:54
Saviqtsdgeos, and then GSV.qml:307-30815:55
Saviqtsdgeos, one category == not expandable; == expanded15:55
tsdgeosSaviq: but it has to match expandedCategoryId15:55
tsdgeosexpandedCategoryId is only set when clicking on see all15:56
Cimitedg, morning.15:56
Saviqtsdgeos, not really, height is selected based on bool expanded, which is always true if bool expandable is false15:57
Cimitedg, I forgot :(15:57
tedgCimi, You need to come visit!15:57
tsdgeosah right right15:57
tsdgeosSaviq: not expandable means not collapsable either15:58
Saviqtsdgeos, yup, it's just full-height always15:58
Saviqtsdgeos, which means that if we're just getting one category, all results, then another category15:58
tsdgeosyeah i think the code expects the categories not to change on runtime15:58
Saviqtsdgeos, we load them all just to collapse them again15:58
tsdgeosyeah15:58
Saviqyeah, the scope API I'm afraid allows that, if not encourages15:59
Cimitedg, will come to see you and evan...16:01
tsdgeostedg: Saviq: so on https://code.launchpad.net/~ted/unity8/delay-indicator-start/+merge/241124 ? discard?16:04
tedgI'm still +1 on it. I think it makes more sense. Doesn't fix that bug, but it should help.16:05
tedgNo reason to make Unity compete for resources.16:06
tsdgeosmzanetti: any idea why daniel didn't top approve https://code.launchpad.net/~mzanetti/unity8/launcher-fixes/+merge/248761 ?16:06
mzanettitsdgeos: he probably just forgot... was sitting next to him when he told me he's ok with it16:07
tsdgeosis he on holidays this week?16:07
mzanettidon't think so... I guess having a swap day for travelling across the sea16:08
tsdgeosok, let's wait for him tomorrow then16:08
tsdgeosmzanetti: can you do https://code.launchpad.net/~dandrader/unity8/improveLauncherTests/+merge/248919 alternatively?16:10
mzanettitsdgeos: yep, on my list16:10
mzanettilemme claim it16:10
tsdgeoscool16:10
tsdgeosMacSlow: so where are we on https://code.launchpad.net/~macslow/unity8/swipe-dismiss-snap-decisions/+merge/233347 can you reproduce the errors Saviq mentions?16:16
Saviqtsdgeos, that seems fixed already, but he's got some other failures16:16
tsdgeosi see16:16
Saviqactually a hash sum mismatch for qmluitests, /me rebuilds16:16
SaviqMacSlow, the ap test for lifecycle is sometimes flaky, don't worry about that16:17
MacSlowSaviq, I assumed that after a few tries on my machines here16:17
SaviqMacSlow, just start with kicking a jenkins rebuild next time16:18
mzanettimterry: ok. pushed the branch17:25
mzanettimterry: didn't change the appid/url thing for the reason of consistency. We use appId all over to identify items... not sure I want to do something else here17:26
mterrymzanetti, OK makes sense.  Like I said, I was just half-remembering a conversation about that17:27
mterrymzanetti, will review again, thanks!17:27
mzanettimterry: ah, I agree that we should collect split greeter based plugins in the Greeter dir. also that it should be another MP :D17:37
mterrymzanetti, yeah it's grown beyond a thin layer on top of lightdm17:38
mzanettiindeed17:39
=== alan_g is now known as alan_g|EOD

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!