| elopio | alesage: veebers: https://code.launchpad.net/~canonical-platform-qa/ubuntu-sanity-tests/apt_update/+merge/249430 | 00:01 |
|---|---|---|
| elopio | I'm going to the gym. bbl. | 00:02 |
| elopio | veebers: I made comments on the branches. | 03:38 |
| elopio | as before, maybe you can reply before leaving today so we can take over if needed, but following your preference. | 03:39 |
| veebers | elopio: ack, just finishing off a review now then will review your comments | 03:40 |
| veebers | elopio: and by branches you mean my one? Or are there others that you would like me to review too? | 03:40 |
| elopio | oh, right, one is actually mine :) | 03:40 |
| elopio | https://code.launchpad.net/~canonical-platform-qa/ubuntu-sanity-tests/apt_update/+merge/249430 | 03:40 |
| elopio | https://code.launchpad.net/~canonical-platform-qa/ubuntu-sanity-tests/selenium-ppa/+merge/249416 | 03:41 |
| veebers | elopio: awesome cheers, stacked and ready | 03:41 |
| veebers | elopio: you still around? | 03:54 |
| elopio | veebers: yes. | 03:54 |
| veebers | elopio: sweet, just quickly with no lag, is there a reason why we can make the update_apt arg to run_sanity_tests the last arg and give it a default False value? | 03:55 |
| veebers | i.e. run_sanity_tests(conf_name, tests_to_run, update_apt=False) | 03:56 |
| elopio | veebers: I made it the argument of the center because I think one would usually call ubuntu-sanity-tests -c test.conf -u test_suite.test_module.test1 | 03:57 |
| elopio | and I didn't add a default value for it because Argparse takes care of that. | 03:57 |
| elopio | veebers: but if you prefer to change the order and put a default value, I'll do it. No harm in that. | 03:57 |
| veebers | elopio: hmm, right but you've had to update all the tests to consider the new argument | 03:58 |
| veebers | (which is why I initially ask) | 03:58 |
| elopio | veebers: right. I could remove that part of the diff if it had a default value. | 03:58 |
| elopio | I'll do it. | 03:58 |
| veebers | elopio: right, to me it's an indication to me that it's changed something outside of it's own influence | 03:59 |
| veebers | elopio: regarding whoudl we even do this change, yeah I see the reason (something outside our influence caused it and it's not done under cover, the tester has to specificy it as a workaround) | 04:00 |
| veebers | elopio: re: the ppa branch, I'm not sure I follow with moving it to a file? | 04:01 |
| elopio | veebers: ok, going back a little, changing the order and using a default argument I removed one of the test changes. | 04:03 |
| veebers | coolio, yeah sorry to jump around on you while you're changing things :_) | 04:03 |
| elopio | the other are still needed, because we are testing the list of arguments received from the command line. And False will be there even if we don't pass -i | 04:03 |
| elopio | sorry, -u | 04:03 |
| elopio | I pushed it. | 04:04 |
| veebers | sweet | 04:09 |
| veebers | elopio: rats, i was really close to suggesting a sweet cleaner way of mocking Popen, but came across this bug :-\ https://bugs.launchpad.net/python-fixtures/+bug/1358085 | 04:48 |
| ubot5 | Launchpad bug 1358085 in Python Fixtures "FakePopen does not work in Python 3.3+" [High,Fix released] | 04:48 |
| veebers | This would have used fixtures.FakePopen instead of a mocked solution | 04:48 |
| === chihchun_afk is now known as chihchun | ||
| elopio | veebers: sorry, there was a black out. | 05:40 |
| veebers | elopio: 0_0 no worries, hope all is well (I'm not actually around any more) | 05:47 |
| elopio | veebers: yes, no worries. Some quiet time without electricity is always nice. Enjoy your long weekend. | 05:48 |
| veebers | heh ^_^. will do, thanks | 05:49 |
| === spineau is now known as spineau_afk | ||
| tzn | Hi guys | 08:50 |
| tzn | I’m looking for a way to calculate some stats | 08:51 |
| tzn | I need to research how often packages are updates for LTS | 08:51 |
| tzn | Ideally with distribution by day | 08:51 |
| tzn | Just wondering if ther eis a way to get such data somwhere | 08:51 |
| === spineau_afk is now known as spineau | ||
| === spineau is now known as spineau_afk | ||
| === vrruiz_ is now known as rvr | ||
| === spineau_afk is now known as spineau | ||
| === chihchun is now known as chihchun_afk | ||
| === elfy is now known as hobgoblin | ||
| === [BNC]elfy is now known as hobgoblin | ||
| elfy | and here too gbb :D | 13:22 |
| gbb | 8(): | 13:23 |
| elfy | balloons: gbb is a new tester, has been doing some for us, and it was her who discovered that testcase tracker bug last night | 13:26 |
| gbb | elfy: About test cases: I'm wasn't clear what the difference between 'entire disk' and 'autosize' is. (I'm guessing autosize expects to co-exist with another OS?) Could there be a little extra blurb on top of the test case to explain this? I think perhaps my test case bug about autosize may have been wrong, since I think I did an entire disk test there if I understand this correctly. | 13:34 |
| elfy | thanks - this is for more general holistic QA stuff :) | 13:35 |
| gbb | ok, bear with me, this is all new and thus confusing %-) | 13:35 |
| elfy | you do guess right | 13:35 |
| elfy | yea :) | 13:35 |
| elfy | xubuntu-devel is xubuntu only :) | 13:35 |
| elfy | and it's actually only been in the last couple of years that testing seems to have had much talk in there | 13:36 |
| * gbb admits she isn't quite sure of the difference. Other than that that xubuntu is of course superior ;-P | 13:36 | |
| elfy | I'm not sure that there is any info anywhere specifically about the different types of install - that's more a general how to install type thing | 13:37 |
| elfy | gbb: of course ;) | 13:37 |
| elfy | https://help.ubuntu.com/community/GraphicalInstall | 13:37 |
| elfy | for example | 13:37 |
| elfy | I suppose that a line could be added to image testcases making it more obvious | 13:39 |
| elfy | gbb: balloons is the Canoncial Community Manager who deals with us QA types - he's really quite friendly, make the case for this to him :) | 13:40 |
| elfy | he's in Pacific time - will be about a bit later on | 13:40 |
| elopio | hello. | 13:40 |
| elfy | hi elopio | 13:40 |
| gbb | A little precis (one line) on top of the test cases that explains what we're trying to do would be useful in general tho. Just to set the scene. | 13:41 |
| elopio | hi elfy. | 13:41 |
| elfy | gbb: yea I understand what you're saying - balloons is the one to make the case too really, I'd likely be the one who did the donkey work on it :) | 13:42 |
| elfy | gbb: looking at them, the resize test does mention that you'll need another installed system and sufficient disk space for 2 systems | 13:45 |
| elfy | back in a bit | 13:46 |
| dobey | elopio: so you are unable to click on 'buy now' while running locally? | 14:11 |
| elopio | dobey: yes. | 14:18 |
| elopio | when you remove the skips and make autopilot, do you get all tests passing? | 14:19 |
| dobey | elopio: i don't have a utopic vm set up to do that in. so i've not been able to run the tests locally | 14:19 |
| dobey | elopio: afaik though, alecu ran them and they passed for him, as he wrote those tests | 14:20 |
| elopio | dobey: why utopic? I ran on vivid, is that ok? | 14:20 |
| dobey | elopio: well i don't have a vivid vm either | 14:20 |
| elopio | you are living in the past :) | 14:21 |
| dobey | elopio: i'm running lts as my host. | 14:21 |
| elopio | dobey: if I understand correctly, after clicking buy the window should be closed. | 14:21 |
| dobey | elopio: even if i were running vivid as my host, i'd still need a vm. i don't want tests fiddling with my actual home director/dbus/etc | 14:21 |
| elopio | that's not happening. But the button is gettting clicked. | 14:22 |
| dobey | elopio: yes, it should "buy" the thing | 14:22 |
| dobey | well the button isn't receiving the click event | 14:22 |
| dobey | otherwise the logs would show more info | 14:22 |
| dobey | ie, it would have a debug message of something like "Purchase requested: blah blah" | 14:23 |
| elopio | dobey: where are the logs stored when I make autopilot? | 14:25 |
| dobey | elopio: do they not go to stdout/stderr? | 14:25 |
| elopio | only autopilot's log. | 14:27 |
| elopio | ah, wait, I think you are right. | 14:27 |
| elopio | 2015-02-12 08:24:46,468 - DEBUG - Emit signal certificateFound | 14:28 |
| elopio | that seems to come from the app. | 14:28 |
| dobey | yeah | 14:28 |
| elopio | and yes, no events logged after the click. | 14:28 |
| dobey | and then nothing after that | 14:28 |
| dobey | which means something is probably stealing the click and it's not getting through to the app | 14:29 |
| === josepht_ is now known as josepht | ||
| === pgraner-afk is now known as pgraner | ||
| elopio | dobey: putting some more logging here. The one that doesn't get executed is the onBuy in payui.qml. launcPurchase in CheckoutPage.qml is executed. | 15:00 |
| dobey | hmm | 15:05 |
| elopio | dobey: If I'm getting it right, accountView.currentItem is null | 15:08 |
| paulliu | elopio: about https://code.launchpad.net/~paulliu/unity8/notification_helper/+merge/249211 | 15:08 |
| paulliu | elopio: I wondering why we need a get_data() function. | 15:08 |
| elopio | so accountView.currentItem.email fails and the pageCheckout.buy is not executed. | 15:08 |
| paulliu | elopio: The Notification will disappear and the data might get cleared. | 15:08 |
| paulliu | elopio: Shound't we backup those data? | 15:09 |
| elopio | funny silent error, I dont' like you javascript. | 15:09 |
| elopio | paulliu: hi. | 15:09 |
| elopio | paulliu: I see. | 15:09 |
| elopio | paulliu: so, I think that in that case, it would be better to make wait_for_notification | 15:10 |
| elopio | return the data. not the object. | 15:10 |
| paulliu | elopio: ok. got it. | 15:10 |
| elopio | def wait_for_notification(self, timeout): | 15:12 |
| elopio | notify_list = self.main_window.select_single('Notifications', objectName='notificationList'); dialot = notify_list.wait_select_single('Notification', visible=True); return{ 'summary': dialog.summary,'body': dialog.body, | 15:12 |
| elopio | 'iconSource': dialog.iconSource } | 15:12 |
| elopio | paulliu: makes sense? | 15:12 |
| elopio | oh, I missed your previous ping. okay then :) | 15:12 |
| paulliu | elopio: yeah. But I'll change it with a timeout? not using wait_select_single. | 15:13 |
| paulliu | elopio: or we don't need a timeout. | 15:14 |
| elopio | paulliu: ah, right, with wait_select_single the timeout is not needed. Well, there's one but the default is alright. | 15:14 |
| elopio | I prefer wait_select_single. | 15:14 |
| balloons | gbb, elfy hello :-) | 15:31 |
| elfy | hi balloons | 15:37 |
| dobey | elopio: oh right, ok, that makes sense. hrmm | 15:44 |
| dobey | elopio: ok, well i think i have an idea how to fix that, but i think it would best be done in another branch, so i think we should leave those skipped for now and i'll file a bug about that | 15:50 |
| dobey | i wonder why qml isn't spitting an error to the console for that though | 15:54 |
| dobey | thanks for finding that elopio | 15:54 |
| dobey | elopio: i filed a bug for that: https://bugs.launchpad.net/pay-ui/+bug/1421277 | 15:54 |
| ubot5 | Launchpad bug 1421277 in pay-ui "Autopilot tests fail due to missing account model" [High,Triaged] | 15:54 |
| elfy | balloons: do we need both of these pages? or would you be happy to see an amalgamation of them -https://wiki.ubuntu.com/Testing/TestCaseFormat and https://wiki.ubuntu.com/QATeam/ContributingTestcases/ManualStyleGuide | 16:07 |
| balloons | elfy, it's a little confusing, but we do dual purpose on the https://wiki.ubuntu.com/Testing/TestCaseFormat page | 16:08 |
| elfy | yes I know - but does that matter? | 16:09 |
| balloons | we talk about what testcases look like, but also mention what they look like for contributing | 16:09 |
| balloons | the manual style guide as it where, is an attempt to get folks to get the naming, wording and format correct | 16:09 |
| elopio | dobey: ok to me. | 16:09 |
| balloons | I would say you could change that page a bit easier than the other | 16:09 |
| elopio | dobey: my only question remaining for your branch is the return '' | 16:10 |
| elfy | effectively that one is just a rehash of info from the testcaseformat page | 16:10 |
| elfy | I can't see a logical reason not to add the 'extra' from manualstyleguide to the other one | 16:10 |
| elfy | but - whatever, just wanted to ask the question before doing anything :) | 16:11 |
| dobey | elopio: i'lll have to look at that one again. i really need to get lunch though. so will respond to that after | 16:15 |
| dobey | and i have been getting pinged like crazy this morning, so didn't get to concentrate on that | 16:16 |
| elopio | dobey: that's alright. You have already done all the parts I was worried about :) Thanks a lot for that. | 16:25 |
| elopio | I'll copy some of your stuff to the webapps. | 16:25 |
| elopio | fgimenez: like | 16:33 |
| elopio | + from ubuntuuitoolkit import fixture_setup | 16:34 |
| elopio | + self.useFixture(fixture_setup.InitctlEnvironmentVariable( | 16:34 |
| elopio | + global_=True, | 16:34 |
| elopio | + UBUNTU_WEBVIEW_DEVTOOLS_HOST=ip, | 16:34 |
| elopio | + UBUNTU_WEBVIEW_DEVTOOLS_PORT=str(port))) | 16:34 |
| elopio | the global might not be needed. | 16:34 |
| fgimenez | elopio: ok, instead of calling initctl with subprocess, right? | 16:38 |
| fgimenez | elopio: initctl set-env | 16:38 |
| elopio | fgimenez: it will do the same, but takes care of the cleanup. | 16:38 |
| fgimenez | elopio: ok thanks! | 16:38 |
| === roadmr is now known as roadmr_afk | ||
| === roadmr_afk is now known as roadmr | ||
| dobey | elopio: ok, just replied to your comments on the MP. finally. got pinged a bit upon return from lunch, too | 18:28 |
| elopio | dobey: +1 | 18:34 |
| === roadmr is now known as roadmr_afk | ||
| Letozaf_ | balloons, hello | 20:05 |
| balloons | Letozaf_, hello | 20:05 |
| Letozaf_ | balloons, I found the solution to solve this mp's problem: https://code.launchpad.net/~nikwen/ubuntu-filemanager-app/compressed-tars/+merge/249250 | 20:06 |
| Letozaf_ | balloons, but I do not have permission to push the changes | 20:06 |
| balloons | Letozaf_, awesome. You can ask him to merge your changes into his branch | 20:07 |
| balloons | you can even create an mp for it, just change the target from trunk to his branch | 20:07 |
| Letozaf_ | balloons, ok fine I will do that thanks | 20:08 |
| balloons | yw, thanks for finding the issue :-) | 20:08 |
| Letozaf_ | balloons, my pleasure :) | 20:09 |
| elopio | dobey: do you know what we would have to access the internet fromt the qemu test bed? | 20:19 |
| elopio | is there an easy command to share the host network? | 20:19 |
| dobey | elopio: i'm pretty sure it works already, given that adt-run installs stuff with apt | 20:21 |
| elopio | ok, let me give it another try. I might be doing something else wrong here. | 20:23 |
| === roadmr_afk is now known as roadmr | ||
| Letozaf_ | balloons, this is weired, I wanted to install ubuntu-filemanager-app on my desktop, but even if I got core apps PPA cannot find it to install | 21:33 |
| Letozaf_ | balloons, I've searched ubuntu-filemanager-app filemanager-app but nothing | 21:34 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!