=== duflu_ is now known as duflu [09:26] tsdgeos, morning [09:37] Cimi: hey [09:37] Saviq: i installed the bbc scope on the N4 but still not showing in the scope list after a reboot, any clue why? [09:38] tsdgeos, huuh, no [09:38] pstolowski, any idea ↑? [09:40] oh [09:40] so i have to pkcon *not* as sudo [09:40] Saviq: pstolowski: ↑ [09:40] tsdgeos, oh, so you've installed it manually? [09:40] tsdgeos, ah yeah, pkcon install-local, otherwise you installed for root [09:41] greyback_, there's a needs fixin' from you on https://code.launchpad.net/~mzanetti/unity8/saveRestoreWindowSizePosition/+merge/247840, that still correct? [09:41] Saviq: not any more [09:42] t [09:42] x [09:42] tsdgeos, now my doubt is... what will be in charge of adding temp scopes to the temp scopes list? [09:42] we'll have an (almost, but that expected) all green landing for the first time in a long time ;P [09:42] *drumroll* [09:42] tsdgeos, and also when to call activate [09:42] Cimi: "what is the temp scopes list" for you? [09:43] Cimi: you never call activate, you just click the button on the preview [09:46] tsdgeos, I mean on the mock and in dash.qml [09:46] tsdgeos, what is activate supposed to do? [09:47] it already does it, no? call triggered [09:47] i don't see what you want to change there [09:47] tsdgeos, in itemClicked inside GSV, we call activate [09:47] not triggered or sth [09:47] or open scope [09:48] but that's not the preview, weren't we doing the preview case? [09:48] activate is just fine, there's a test for it that already works [09:48] tsdgeos, yes, so I was wondering if on this openScope I have to also call activate or just closing the previous scope [09:48] tsdgeos, what is activate compared to open? [09:49] Cimi: activate is something we call on the scope because the user did something [09:49] Cimi: open is something the scope tells us because the user did something [09:49] acivate is a slot, open is a signal [09:50] ok [09:55] tsdgeos, in the scopes mock, do we want to do sth on closeScope? [09:55] Cimi: yes, we want to make sure it is one of the scopes we told the ui to open [09:55] like we're doing now [09:56] tsdgeos, on close [09:57] yes? [09:57] tsdgeos, I can try calling delete or removing the scope from the temp scopes list, or allScope too [09:57] don't delete [09:57] don't remove it from allScope [09:57] ok [09:57] what is the temp scopes list? [09:57] tsdgeos, I think a list of opened temp scopes [09:58] what you mean you think? isn't that a variable you created? [09:58] but yes, if you have a list of all opened temp scopes, check the scope is there, assert if not and remove it from the list [09:58] sounds like a good plan [09:59] tsdgeos, pawel did :) [09:59] not me [09:59] anyway let me see then what he does [10:00] pawel added code to our mock? [10:21] Saviq: so the borked aspect ratio is SDK's fault [10:21] digging a bit more [10:21] * Saviq waves fist! [10:21] breaks when setting the color: attribute [10:21] oh [10:21] so the colorize shader is goof [10:21] i guess some gl magic happens somehwere that doesn't work much [10:21] or something [10:26] what, QtLocation has an Icon QML Type [10:26] what can go wrong with that name ... D: [10:28] :) [10:28] biab, testing desktop and food [10:32] Saviq: what's the eta on silo 4? looking good already or not tested yet? === vrruiz_ is now known as rvr [10:40] mzanetti, just the testplan remaining [10:41] cool. then I won't rebase stuff for silo 0 now [10:46] I have tags, please check in your branches too [10:47] Cimi: run fast! [10:47] :D [10:47] yeah [10:47] Tagminator will come for me [10:47] i cleaned mine yesterday [10:47] so did mterry [10:47] i think paul still has one that needs cleaning [10:49] ok I cleaned [10:49] mzanetti, http://pastebin.ubuntu.com/10186287/ :/ [10:50] hmm [10:50] fixing [10:50] tsdgeos, ok I got your branch approved, now is your turn to needfix mine :P [10:51] Cimi: saw it, give me a sec :) [10:51] mzanetti, it's just a warning, I'm not gonna block the silo on this, but please clean it up [10:51] ack [10:53] is there a way to change the grid units from qml' [10:53] ? [10:54] probably not [10:55] or there is [10:55] tsdgeos, mmm maybe if you override sdk definition [10:57] tsdgeos, like importing something that overrides units.gu [10:57] units.gridUnit = 30; just works :D [10:59] yeah [10:59] bravo [11:13] guys, ideas for testing https://code.launchpad.net/~aacid/unity8/attributeAspectRatio/+merge/249472 that doesn't actually involve checking the division is right? [11:16] tsdgeos, you check the aspect ratio? [11:17] instead of checking the actual division, you check the result [11:17] you mean diving width/height? but that's just checking math works, no? [11:17] not sure it makes sense, I need contextr [11:17] it'd be like checking height is units.gu(2) [11:18] Cimi: context is https://launchpadlibrarian.net/197105998/out.png, see the bbc logo [11:19] tsdgeos, you could check that the locale is not polish :D [11:21] i'm thinking btw [11:23] mzanetti, will reminders ask me for an account on every start? ;) [11:24] Saviq: since you seem to have the 3 devices, can you review https://code.launchpad.net/~aacid/unity8/attributeAspectRatio/+merge/249472 ? [11:25] tsdgeos, will do [11:25] tsdgeos, will you file a bug with the SDK then? [11:25] Saviq: undecided [11:25] Saviq: tbh we're setting the height, and i am not sure there's any guarantee that the width will be accordingly changed [11:26] tsdgeos, is there not? [11:26] tsdgeos, FWIW, as you said it worked fine without color... [11:26] Saviq: well it doesn't "work fine" [11:26] it just behaves different [11:26] i.e. you end up with lots of empty space [11:27] in the top/bottom (i.e. the image doesn't grow) [11:27] so there's defenitely a bug [11:27] i'm just not sure what the bug really is :D [11:27] tsdgeos, "Icon does not preserve aspect ratio" ;) [11:27] or "does not behave like Image" :P [11:28] Saviq: right, but that can perfectly be by design [11:28] the only bug i can see is [11:28] adding color: changes the behaviour [11:28] i can file two and see if it ever gets any traction :D [11:29] tsdgeos, yeah, I'd say it should behave intuitively, which is to preserve AR unless you tell it not to :) [11:29] tsdgeos, same as Image [11:30] tsdgeos, what you could do (fasten seatbelts) is to create a QML image in your test, reusing the Icon's url, and check if your icon matches the aspect ratio of the Image [11:30] Saviq: it's just that image doesn't preserve the AR :D [11:30] tsdgeos, sure it does if you only give it one dimension [11:30] Saviq: nope [11:30] hmm? [11:30] tsdgeos, Saviq might be an sdk bug [11:30] if it doesn't preserve [11:31] Saviq: http://paste.ubuntu.com/10186800/ [11:32] gives you http://i.imgur.com/9KtUmLq.png [11:32] tsdgeos, maybe is the fillMode [11:32] i know it's the fillMode [11:32] try with PreserveAspectFit [11:32] i'm just saying that you can't say Icon should preserve aspect ratio like Image does by default [11:32] since Image doesn't [11:33] Cimi: there's no fillMode in Icon {} [11:33] tsdgeos, did you try the same code adding fillMode: Image.PreserveAspectFit [11:33] tsdgeos, right, my bad [11:33] tsdgeos, but for Image [11:33] Cimi, we're good here, thanks ;) [11:33] Saviq: does it? [11:33] it shouldn't [11:34] yeah, it just keeps implicitFoo [11:34] Saviq, why it shouldn't adding that fillMode? [11:34] Cimi, because we're talking about the default behaviour [11:37] Cimi: please drop the scopeThatOpenedScope variable [11:38] anyone else got "fat thursday" today? ;) [11:38] tsdgeos, Saviq fillMode: Image.PreserveAspectFit preserves the aspect ratio [11:38] I just tested [11:38] Cimi: we know [11:38] Cimi, yes, thanks for helping [11:38] Cimi: it is not what we were discussing though [11:38] Saviq: if by fat thursday you mean "omelette day", yeah [11:39] tsdgeos, it's actually a PL tradition, somewhere during the carnival period there's a Thursday during which people eat all kinds of unhealthy pastries :P [11:39] yeah it'd be the same [11:40] we just eat omelette :D [11:40] oh ok [11:40] Saviq, we have all those fat days in italy [11:40] ah yeah, we do have that, but its more the "insane thusday" here [11:40] Saviq, we have those sweets http://www.enricarocca.com/files/foto_4.jpg [11:40] tsdgeos, grep for Icon please and do this in other places (like in emblem we need it for sure) [11:40] well, I don't have them here :'( [11:41] though actually it seems we should be eating omelette of sausages http://ca.wikipedia.org/wiki/Dijous_gras [11:41] can't compute [11:41] Cimi, looks similar http://www.interwellness.pl/wp-content/uploads/2012/02/T%C5%82usty_Czwartek.jpg [11:41] Saviq: ok, let me check [11:42] Cimi, and http://agatagotuje.pl/wp-content/uploads/2014/01/DSC_0073-1024.jpg [11:42] Saviq, filled with cream? looks delish [11:42] yeah they are the same!!! [11:42] Cimi, traditionally filled with rose fruit jam [11:42] well, actually depends on the region [11:42] but those are the best ;P [11:43] Ich bin ein Berliner! [11:43] :D [11:43] tsdgeos, for your test, if you really want one I'd do as I said [11:44] tsdgeos, have an Image in the test with PreserveAspectFit and compare its width with your icon width [11:44] Cimi: yeah, i thought about that but i'm not sure i'm testing anything else other than the division works [11:45] tsdgeos, well you don't check the division, you check the result [11:45] inside Icon you could replace the division with something else, but if it works the test will not fail [11:46] I'd personally try that [11:46] Saviq: so for those other Icon { } we have around, if they specify height and width we're fine, even if they are not "respecting" the aspect ratio of the image, we assume that whoever provides the image will abide to the AR defined in the code, right? [11:46] tsdgeos, yes, where we had both, we're forcing square usually [11:47] tsdgeos, but there's a bunch where we want to keep AR (indicator panel, emblem, attributes come to mind) [11:48] yeah, checking [11:49] Cimi: ok, i'll see if i can get something that makes sense [11:52] Saviq, how is fat thursday in pl? I'm gonna text Ola hoping she'll bring something home tonight :) [11:52] Cimi, "tłusty czwartek" [11:53] Saviq, dziekuje bardzo [12:12] Saviq: https://code.launchpad.net/~mzanetti/unity8/fix-cmake-sql-warnings/+merge/249478 [12:13] mzanetti, tx [12:26] tsdgeos, fixed [12:27] yep, asw === MacSlow is now known as MacSlow|lunch === dandrader_ is now known as dandrader === alan_g is now known as alan_g|lunch [13:11] flashed my phone, then build unity8 trunk + some branch and installed it there [13:11] tsdgeos , now unity8-dash is stuck in the splash screen. other apps launch normally [13:11] tsdgeos any ideas? [13:17] dandrader, that persistent? if you go restart unity8-dash? [13:17] dandrader, we've seen quite a bunch of dbus-related lockups recently :/ [13:18] paulliu, that failure is very much related unity8.shell.tests.test_screenshots.ScreenShotTestCase.test_take_screenshot [13:19] Saviq, right, restarting unity8-dash solves it [13:20] Saviq, but if you restart everyone (sudo restart lightdm) it does not [13:20] dandrader, yay for races [13:20] Saviq, some race condition of sorts [13:20] yeah [13:20] Saviq: yeah.. I just correct it. Sorry. [13:21] Saviq: I loaded another branch's build results.. [13:21] Too many tabs.. [13:23] kk [13:26] Saviq: Hey, who should I poke to get some reviews of MP's I have for Unity 8? [13:27] ChrisTownsend, ideally, no one, but I can ping some for you: tsdgeos, Cimi, dandrader, greyback_, mterry, mzanetti, MacSlow|lunch, dednick, paulliu ;) [13:28] ↑↑↑ [13:28] ChrisTownsend: I'll do. [13:28] Because I'm not very busy. [13:28] ChrisTownsend, just a request: please name the branches after the things they fix, not just the bug# [13:29] Saviq: Ok, sure, I will do that. Do you want those branches renamed now or just for future branches? [13:29] paulliu: Ok, thanks! [13:29] ChrisTownsend, just for future ref :) [13:29] Saviq: Gotcha [13:46] Cimi: you need a commit message https://code.launchpad.net/~cimi/unity8/fix-open-new-scope-from-tmp/+merge/249471 [13:54] tsdgeos, done [13:56] Cimi: dashTempScopeItem.backClicked(); is cheating [13:56] Cimi: http://paste.ubuntu.com/10188539/ [13:57] tsdgeos, https://code.launchpad.net/~aacid/unity8/attributeAspectRatio/+merge/249472/comments/618063 === alan_g|lunch is now known as alan_g [13:59] Saviq: the title you mean the "BBC" ? [13:59] tsdgeos, no, there's no title even [13:59] tsdgeos, krillin is leftmost, compare with the other two [13:59] tsdgeos, there's no title label [14:00] brb, lost adb, gotta reboot [14:00] ah [14:00] that's very weird [14:01] tsdgeos, you want me to click on the button instead?> [14:01] ok [14:01] Cimi: of course [14:02] Cimi: see the paste [14:02] ok [14:03] tsdgeos, pushed [14:14] Saviq: the indicators are basically abusing the thing [14:14] it's a square icon [14:14] AFAICS [14:14] i mean battery [14:14] that or i can't find the icnon we're using [14:14] that may also be [14:14] tsdgeos, it's not square [14:15] Saviq: do you know the exact file we're using? [14:15] /usr/share/icons/suru/status/scalable/battery-060-charging.svg for example [14:15] because image://theme/battery-full-charged-symbolic,battery-full-charging-symbolic,gpm-battery-full,gpm-battery-100,battery-full-charged,battery-full-charging makes it a bit hard to find [14:15] tsdgeos, that would be /usr/share/icons/suru/status/scalable/battery-full-charged-symbolic.svg [14:16] which is a symlink to /usr/share/icons/suru/status/scalable/battery-charged.svg [14:16] ok, so i was seeing the wrong icon then [14:19] there's no implicitHeight for svg files [14:19] he he [14:21] d'oh [14:22] and why's that, pray tell? [14:24] because they have no size [14:24] it's scalable [14:24] so no size [14:25] it's a bit convoluted [14:29] Saviq: on krillin [14:29] how did you try the patch? [14:31] because on rtm the CardCreator patch doesn't apply directly [14:31] wonder if that's what made you lose stuff [14:31] or was it vivid on krillin? [14:31] tsdgeos, vivid [14:32] tsdgeos, I x-built a proper package [14:32] and tried on the three devices [14:32] ok [14:32] let me try krillin here then [14:43] pstolowski: wops :D https://code.launchpad.net/~stolowski/unity-api/scopes-close-scope/+merge/248725 doesn't build [14:45] tsdgeos, uhm, looking [14:51] tsdgeos, fixed [14:53] tx === MacSlow|lunch is now known as MacSlow [15:02] mzanetti: this is a hell of a conflcit :D https://code.launchpad.net/~mzanetti/unity8/inputinfo/+merge/248407/comments/618108 [15:07] tsdgeos: interesting... I don't even tough those files [15:07] weird [15:08] maybe it's a criss cross or soemthgin? [15:08] tsdgeos: ah... it's based on top of ShellRotation [15:08] ah [15:08] tsdgeos: forgot the prereq it seems. but this is not meant to go into trunk atm [15:09] "Author: handsome_feng<445865575@qq.com>" <- this guy need to configure his bzr environment, that can't be right :) [15:16] grrrrr unity8, sometime switching between vt and unity8 leads to a system where ctrl-alt-fn stops working [15:18] seb128, that's grrrrr mir, rather [15:19] and the reason why greyback_ has two laptops with him all the time ;P [15:19] Saviq, do you know if that's a known issue? [15:19] guess so [15:19] seb128, I kinda believe it's known I think [15:19] seb128, mostly because it's the display server on the current vt that needs to handle the ctrl+alt+fn switch, and when it stops is when you're screwed [15:20] you know, because display servers are always working so well, it's fine to rely on them to handle that shortcut === snadg3 is now known as snadge [15:20] X has nearly all the right magic to ensure VT switching just works. Mir not there yet [15:21] Saviq, while you are here, what's the best way to run a qt5 app from a vt and have it display under unity8? [15:21] seb128: only fix I know is to ssh in and run "startx" as root [15:21] seb128, just export MIR_SOCKET [15:21] QT_QPA_PLATFORM=ubuntumirclient .... --desktop...? [15:21] seb128, you'll need MIR_SOCKET as well [15:21] k [15:21] seb128, so what I'd do [15:21] seb128, is start terminal [15:21] seb128, to get all the env [15:21] seb128, and do from there [15:22] Saviq, what if I want to ssh? ;-) [15:22] can use byobu or screen or so [15:22] seb128, well in that case yeah, just inspect unity8 for a few vars and you'll be golden [15:22] MIR_SOCKET being the primary one [15:22] thanks [15:22] or well, it's always in /run/user/$UID/mir_socket [15:22] or so [15:23] fuck [15:23] why does running the app on a vt freezes the vt switch [15:24] k, need to ssh I guess [15:26] Saviq: can you try the new version of https://code.launchpad.net/~aacid/unity8/attributeAspectRatio/+merge/249472 ? I tried it on my krillin and it doesn't have the issues you had [15:30] tsdgeos, will do [15:30] tsdgeos, well, that's the version I tried [15:31] tsdgeos, ah no [15:31] will do in a sec [15:31] but that looks dumb to have to do :/ [15:32] agreed :/ [15:32] but it's the only way i can think of knowing if the image actually has a size or not [15:32] pstolowski: https://code.launchpad.net/~stolowski/unity-scopes-shell/fix-temp-scopes/+merge/248235/comments/618133 [15:32] Cimi: https://code.launchpad.net/~cimi/unity8/fix-open-new-scope-from-tmp/+merge/249471/comments/618134 [15:33] tsdgeos, ok, sure [15:33] tsdgeos, ok [15:35] tsdgeos, pushed [15:37] Cimi, tsdgeos btw, I think you mentioned this to me but just double checking.. you do explicitly close all the temp scopes when user taps BFB, screen is locked, user navigates somewhere else etc.? no potential for leaking there? [15:39] pstolowski: the code path is the same wether you click back or push the bfb, so we shouldn't be leaking there no [15:39] cool [15:46] Saviq, can I test this? https://code.launchpad.net/~aacid/unity8/hack_location_data_i18n/+merge/249174 [15:46] Saviq, or you wanted to do, since you asked us to fix... [15:46] Cimi, go for it [15:53] tsdgeos, yeah, looking better, but at the solution :/ [15:53] Saviq: my understanding is that Image is a bit of a mixup itself [15:53] this is the best i could come up [15:53] i'll accept suggestions :/ [15:54] Saviq: also at some point we should create our own Icon class or something, when grepping like 90% of them have the same units.gu(2) in width and hegiht [15:54] that would probably make sense to be together [15:54] in one place [15:54] just one day someone thinks 3 gu is better [15:54] or something :D === dandrader is now known as dandrader|lunch [15:54] ;) [15:55] tsdgeos, on that note, any idea why emblem and attributes are different height? [15:55] is that hardcoded at different values? [15:55] let me se [15:55] +e [15:56] yeah [15:56] attribute is height: units.gu(2) [15:56] embñem is [15:56] height: titleLabel.font.pixelSize [15:56] so the emblem matches the height of the title [16:04] Cimi: if you push the quick change to https://code.launchpad.net/~cimi/unity8/fix-open-new-scope-from-tmp/+merge/249471 i'll top approve [16:05] tsdgeos, doing now [16:08] tsdgeos, done [16:13] Saviq: yeah the more i look it, something looks fishy in Icon [16:13] Saviq: see http://i.imgur.com/4AnJKbA.png [16:13] its with px 25 and px 50 [16:14] battery icon grows [16:14] but BBC needs to be told to grow [16:14] tsdgeos, yup [16:14] so either BBC should also grow or battery should not [16:16] Saviq: Cimi: pstolowski: so https://code.launchpad.net/~cimi/unity8/fix-open-new-scope-from-tmp/+merge/249471 is now approved, who is landing it and the deps? [16:17] tsdgeos, next unity8 landing, I believe, so me/mzanetti [16:17] okidoki [16:20] great, thanks [16:23] Saviq: https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1421293 ? [16:23] Launchpad bug 1421293 in ubuntu-ui-toolkit (Ubuntu) "Icon width is inconsistent when height is specified" [Undecided,New] [16:23] i'll refer to taht bug in the code [16:24] tx [16:29] pushed === dandrader|lunch is now known as dandrader [17:13] pstolowski, ah, your branch for unity-api will need a merge and another changelog bump [17:15] Saviq, looking [17:19] Saviq, updated, both unity-api and shell plugin [18:20] help [18:20] with is that not working [18:20] IR_SOCKET=/run/user/1000/mir_socket QT_QPA_PLATFORM=ubuntumirclient system-settings --desktop_file_hint=/usr/share/applications/ubuntu-system-settings.desktop [18:20] translate messages fr_FR.UTF-8 [18:20] that line starts with a M === alan_g is now known as alan_g|EOD [18:21] running in a ssh from an user who has an active unity8 session on the same machine [18:21] Saviq, greyback_ ^ do you have any idea? [18:22] seb128: are you getting any error messages? [18:23] did you check the mir socket is actually there [18:23] (system-settings:8918): Gtk-WARNING **: cannot open display: [18:23] check output of unity8.log too, in case it decided to reject the connection for some reason [18:23] I get [18:23] why gtk? it's not even a gtk codebase [18:23] the socket is there [18:23] that gtk warning shouldn't be happening [18:24] why the heck is it [18:24] indeed [18:25] ok, got it [18:25] QT_QPA_PLATFORMTHEME=appmenu-qt5 [18:25] aha [18:25] Mirv, sil2100, ^ appmenu not being nice! [18:25] good catch [18:25] thanks ;-) [18:26] What what? [18:26] sil2100, trying to run a qt5 app from ssh to a desktop running unity8 [18:26] greyback_, next fun is [18:26] what(): org.freedesktop.DBus.Error.NotSupported: Unable to autolaunch a dbus-daemon without a $DISPLAY for X11 [18:26] aii [18:26] Sorry, I didn't test this usecase ;) [18:28] greyback_, works after setting DBUS_SESSION_BUS_ADDRESS [18:28]