[02:29] <axw> wallyworld_: reviewed, let me know what you think
[02:29] <wallyworld_> sure ty
[02:36] <wallyworld_> axw: i had to move providerregistry to avoid circular imports, from memory with LoopProviderType. i think adding a registry package is a good idea
[03:47] <anastasiamac_> wallyworld_: thnx for env destroy and suggestions :D
[03:47] <anastasiamac_> waigani: ^^ not wallyworld_
[03:47] <waigani> anastasiamac_: welcome :)
[03:47] <anastasiamac_> waigani: i'll put on my todo list
[03:48] <anastasiamac_> waigani: but while tests pass with calling RemoveEnvironment
[03:48] <anastasiamac_> waigani: probably not so high a priority to change :D
[03:48] <waigani> anastasiamac_: absolutely. Nothing urgent. I just wanted to follow up from last week.
[03:49] <anastasiamac_> waigani: it's awesome! thank u :D
[03:49] <anastasiamac_> waigani: ur thoughtfulness is highly appreciated!
[03:50] <waigani> :)
[06:54] <wallyworld_> jam: hey, did you discuss with mark the storage CLI?
[06:55] <wallyworld_> axw: ty for review, that branch now merged
[06:55] <axw> wallyworld_: cool :)
[06:58] <wallyworld_> axw: i'll now convert Pool to storage.Config etc
[08:17] <jam> dimitern: poke?
[08:18] <dimitern> jam, I've got kicked out
[08:18] <dimitern> jam, and now I'm the only one in the hangout
[08:25] <TheMue> morning
[08:28] <dimitern> TheMue, o/
[08:28] <TheMue> dimitern: o/
[10:00] <dooferlad> dimitern, TheMue, voidspace: standup?
[10:00] <TheMue> dooferlad: sure ;)
[10:01] <dimitern> omw
[11:21] <TheMue> phew, all those nested references to network parameters :/
[11:40] <wallyworld> jam: hey there
[11:43] <jam> wallyworld: hey
[11:44] <wallyworld> jam: have you had a chance to talk to mark about the storage CLI changes we are proposing?
[11:44] <jam> I have not, though I'd still advise you to make progress and I'll chat with him about it.
[11:45] <wallyworld> ok, will do, thanks
[11:50] <axw> wallyworld: which changes are those?
[11:50] <wallyworld> axw: the ones where we use 3 levels
[11:50] <wallyworld> juju storage pool create
[11:50] <wallyworld> as oposed to
[11:50] <wallyworld> juju storage create-pool
[11:51] <axw> wallyworld: I thought nobody liked it?
[11:51] <wallyworld> the spec says create-pool
[11:51] <wallyworld> axw: i sent an email saying we were revisiting it (or at least i thought i did)
[11:51] <axw> ok, I probably just forgot
[11:52] <wallyworld> np, i thin storage pool create etc is better
[11:52] <wallyworld> so want to try and get that approved
[11:53] <wallyworld> axw: https://docs.google.com/a/canonical.com/document/d/1JMDDOPXHV6SPrTSA3SRb_qyyRUYcz7huo_tTIjD8UOc
[11:53] <axw> wallyworld: ta
[11:56] <axw> wallyworld: I think we'd still have "juju storage add", at the top level, allowing you to add storage instances to a unit or service
[11:57] <axw> wallyworld: just saying since it's missing from the first "--help" output example .. not sure if that's meant to be complete
[11:57] <anastasiamac_> wallyworld: axw: jam: thnx :D
[11:57] <wallyworld> axw: yes, true. i was mainly focusing on what we had implemented so far
[11:57] <wallyworld> axw: feel free to add to doc to make it more completed
[11:58] <wallyworld> i just update dsharing
[12:53] <wwitzel3> wallyworld: thanks for the review
[12:53] <wallyworld> sure, np
[12:53] <wallyworld> thanks for fix, will be good to get 1.21/1.22 out
[13:20] <wallyworld> axw: oarsome, thanks for review
[13:20] <axw> wallyworld: nps
[13:42] <rogpeppe> where can i go to to find out whether juju-core updates are currently blocked?
[13:42] <jw4> rogpeppe: http://goo.gl/4zd1e9
[13:43] <rogpeppe> jw4: so, any critical bugs == blocked ?
[13:43] <jw4> rogpeppe: yeah, that's basically the same query CI uses
[13:43] <rogpeppe> jw4: ta
[13:43] <jw4> rogpeppe: if you prefer json: https://api.launchpad.net/devel/juju-core?ws.op=searchTasks&status%3Alist=Triaged&status%3Alist=In+Progress&status%3Alist=Fix+Committed&importance%3Alist=Critical&tags%3Alist=regression&tags%3Alist=ci&tags_combinator=All
[13:43]  * rogpeppe puts the PR on hold for a bit more
[13:44] <rogpeppe> jw4: that json query doesn't give me any results
[13:44] <jw4> rogpeppe: hmm; my JSON query shows zero though... yeag
[13:44] <jw4> yeah
[13:45] <rogpeppe> jw4: (JSON is indeed preferable for me in this case)
[13:45] <jw4> rogpeppe: I personally use the JSON one :)
[13:46] <rogpeppe> jw4: except it doesn't work :)
[13:46] <jw4> rogpeppe: I wonder if the 'Incomplete' status is why it's not showing
[13:48] <rogpeppe> jw4: this one also return empty: http 'https://api.launchpad.net/devel/juju-core?ws.op=searchTasks&status%3Alist=Fix+Committed&importance%3Alist=Critical&tags%3Alist=regression&tags%3Alist=ci&tags_combinator=All'
[13:48] <anastasiamac_> jw4: this query is helpful in most cases... however, in this particular case, it's not right
[13:48] <anastasiamac_> jw4: TRUNK IS NOT BLOCKED
[13:48] <anastasiamac_> jw4: sorry for caps...
[13:48] <rogpeppe> jw4: but removing the Fix+Committed qualification makes it work
[13:48] <rogpeppe> anastasiamac_: that's useful to know!
[13:48] <rogpeppe> anastasiamac_: thanks
[13:48] <jw4> anastasiamac_, rogpeppe yeah - thanks!
[13:49] <anastasiamac_> jw4: did not mean to cap :D
[13:49] <jw4> anastasiamac_: lol
[13:49] <rogpeppe> so it seems that it might be nice to have an indepdendent source of truth maintained so that we can actually see whether it's blocked or not
[13:49] <anastasiamac_> jw4: but landing has been happening today :D
[13:49] <anastasiamac_> rogpeppe: +1 this would be gr* and was the intention of jw4's query...
[13:49] <rogpeppe> and so that the criteria can be changed without everyone needing to update their search query
[13:50] <rogpeppe> perhaps someone can grab are-juju-core-commits-blocked.com :)
[13:51] <anastasiamac_> rogpeppe: and make it branch specific too, so if u were curious about 1.21, u'd b able to "know" at a glance..
[13:51] <rogpeppe> it would be even better if the 'bot automatically retried previously blocked commits after blocking is removed
[13:51] <rogpeppe> anastasiamac_: yeah
[13:52] <anastasiamac_> rogpeppe: not sure about automatically re-try but at least notifying the person that tried to merge :D
[13:53] <anastasiamac_> rogpeppe: it's nice to dream... especially since it's midnight here :D m eod-ing
[13:53] <rogpeppe> anastasiamac_: i think an automatic retry would be best, particularly if no further commits have been pushed or comments made since the block message
[13:53] <rogpeppe> anastasiamac_: good night
[13:53] <anastasiamac_> rogpeppe: nite
[13:53] <rogpeppe> anastasiamac_: i had no idea you were that far east!
[13:56] <anastasiamac_> rogpeppe: Surprise :D
[13:58] <rogpeppe> anastasiamac_: eastern australia?
[14:01] <TheMue> yummy, api/apiserver tests are passing again
[14:12] <TheMue> dimitern: I'll keep the NetworkInfo. we've several other types and fields named based on it. so we (a) would get inconsistent or (b) change the wire protocol
[14:15] <dimitern> TheMue, what are these cases?
[14:16] <TheMue> dimitern: e.g. MachineNetworkInfoResult with the Info field and MachineNetworkInfoResults containing the former
[14:18] <dimitern> TheMue, that's fine - the field can be called Info, but the internal type should be params.NetworkConfig
[14:19] <TheMue> dimitern: and so don't change the name of the types too?
[14:19] <dimitern> TheMue, I'd add a TODO comment there to change the field from Info to Config
[14:19] <dimitern> TheMue, or even name the field Config but leave the json:"Info" tag on it
[14:20] <dimitern> TheMue, which types?
[14:20] <TheMue> dimitern: MachineNetworkInfoResult in MachineNetworkConfigResult, and ...Results too
[14:21] <dimitern> TheMue, ah, ok - let's call them MachineNetworkConfigResult etc. as the type names don't matter
[14:21] <TheMue> dimitern: also in the code we reference it as info :D
[14:21] <TheMue> dimitern: but that's easy to change
[14:21] <dimitern> TheMue, cheers :)
[14:24] <rogpeppe> so can someone tell me a definitive query that lets me know whether juju-core commits are blocked, please?
[14:24] <TheMue> dimitern: networks counterpart in one place is InterfaceInfo *lol* the trail of the info
[14:29] <dimitern> TheMue, indeed, we'll likely change that at some point as well
[14:29] <mgz> rogpeppe: `bzr branch lp:juju-ci-tools; cd juju-ci-tools; ./check-blockers.py master ${YOUR_PR}`
[14:29] <dimitern> TheMue, but the params.NetworkConfig should correspond to network.InterfaceInfo for now
[14:29] <rogpeppe> mgz: thank you
[14:29] <TheMue> dimitern: I'll add TODOs
[14:30] <dimitern> TheMue, +1
[14:32] <rogpeppe> mgz: one tiny change - the "-" should actually be "_" there
[14:32] <jw4> mgz: thanks, i've been looking this morning for that repo again, but I couldn't remember where it was
[14:32] <mgz> ups yeah, underscores
[14:34] <rogpeppe> mgz: it would probably be better overall if it was an online status, because if someone changes the criteria, i'll have to re-pull that repo
[14:39] <mgz> we've talked about putting it on reports
[14:41] <mgz> you could still have an out of date page, running the script is just what the lander does in practice
[14:41] <mgz> I struggle to believe pull/run script is that complex for a bunch of elite programmers
[14:42] <jw4> mgz: tsk tsk.. .snarkiness ill becomes you ;)
[14:43] <mgz> hey, I struggle to get underscores vs hyphens right :)
[14:43] <jw4> haha
[16:41]  * dimitern eod-s
[17:41] <rogpeppe> anyone know how to enable feature flags?
[17:49] <jw4> rogpeppe: export JUJU_DEV_FEATURE_FLAGS="<flag name>"
[17:50] <rogpeppe> jw4: i just managed to work that out...
[17:50] <jw4> heh
[17:50] <jw4> :)
[17:50] <rogpeppe> jw4: if i set it when bootstrapping an environment, it'll be inherited by all that environment's instances, right?
[17:50] <rogpeppe> jw4: (i *think* i saw that in the code, but just making sure)
[17:50] <jw4> rogpeppe: that is beyond my ken
[17:50] <jw4> rogpeppe: but that sounds plausible :)
[17:51] <rogpeppe> jw4: well... we'll see what happens if/when this bootstrap works
[17:56] <rogpeppe> jw4: it worked!
[17:56] <jw4> rogpeppe: suhweet
[18:43] <voidspace> ok, EOD
[18:43] <voidspace> g'night
[20:31] <waigani> wallyworld: thanks for the review
[22:29] <waigani> wallyworld_: I've addressed your review, thanks: http://reviews.vapour.ws/r/928/
[22:30] <wallyworld_> ok
[22:40] <wallyworld_> waigani: reviewed, have to head to dentist in about 20 mins, will check as soon as i'm back if not before I go
[23:02] <waigani> wallyworld_: thanks