[09:12] tsdgeos, could you run the test plans for vivid silo 18 http://people.canonical.com/~platform/citrain_dashboard/#?distro=ubuntu&q=landing-018 ? [09:12] https://wiki.ubuntu.com/Process/Merges/TestPlans/Unity8 [09:12] https://wiki.ubuntu.com/Process/Merges/TestPlan/scopes [09:13] sure [09:14] let me just the fix for the dash hint thing and i'll do this one [09:27] Saviq: will you do the rest of review of https://code.launchpad.net/~aacid/unity8/attributeAspectRatio/+merge/249472 or want me to find someone else? [09:27] also, can someone do https://code.launchpad.net/~aacid/unity8/update_qmltypes/+merge/249612 ? it's just running an automated tool :D [09:28] Cimi: can you do https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1422260 ? [09:28] er [09:28] Launchpad bug 1422260 in unity8 (Ubuntu) "bottom edge hint inactive in application details screen" [High,In progress] [09:28] Cimi: https://code.launchpad.net/~aacid/unity8/noManageDashHintPreview [09:29] tsdgeos, unlikely this week [09:29] ok [09:30] Cimi: maybe you can do https://code.launchpad.net/~aacid/unity8/attributeAspectRatio/+merge/249472 too? [09:46] tsdgeos, when testing the screenshot feature, please not how does long-vol-press behave [09:51] ok [09:51] Saviq: what was/might be the problem? [09:52] tsdgeos, we've switched from onPressed to onRelease for incremental changes [09:53] tsdgeos, so if we didn't take care, we might have broken long press to change quickly [09:53] * Saviq actually flashes the silo to check [10:02] Saviq: yeah broken [10:03] tsdgeos, that's what I was afraid [10:03] ok /me replies to his own email [10:05] Saviq: but that was 18 vs 20 or is it vivid vs rtm? [10:07] tsdgeos, it's in vivid 18, to be ported to rtm 20 [10:07] oki [10:24] Saviq: https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1422309 this is not us, but who to assign to? [10:24] Launchpad bug 1422309 in unity8 (Ubuntu) "Today's scope doesn't refresh automatically and indicates wrong day" [Undecided,New] === vrruiz_ is now known as rvr [10:59] tsdgeos, just asked cwayne to reassign as appropriate [11:00] tx [11:38] Cimi: Saviq: needs fixing test wise [11:38] https://code.launchpad.net/~cimi/unity8/fix-open-new-scope-from-tmp/+merge/249471 [11:39] tsdgeos, it segfaults for you? [11:39] on your machine? [11:39] yes [11:39] Cimi: doesn't it for you? [11:39] mmm nope [11:39] let me try again [11:41] Cimi: testPreview, not the new test you added [11:41] tsdgeos, oh yeah... [11:41] tsdgeos, here too [11:41] thanks [11:42] tsdgeos, how do you run a test with gdb? [11:43] there's two ways [11:43] the lazy and the non lazy one [11:43] non lazy one [11:43] make testPreview VERBOSE=moo [11:43] and then get the command line and inject gdb [11:43] the lazy one [11:43] make gdbtestPreview [11:44] tsdgeos, you did you bother telling me the non lazy one? :D [11:44] in case one day you need to run valgrind [11:44] or some other tool [11:44] ahah ok [11:45] segfaults as soon as start loading with the lazy method [11:47] ? [11:48] tsdgeos, tx [11:48] Cimi: http://paste.ubuntu.com/10254655/ [11:48] Cimi: basically there's no scopes in that test [11:53] tsdgeos, can I instantiate scopes for the test? [11:54] tsdgeos, or patch the mocks to close gracefully when scopes is null? [11:54] close gracefully? [11:55] tsdgeos, if segfaults because scopes is null, maybe we can skip the code that segfaults if scopes is null [11:55] tsdgeos, or initialize scopes for the test [11:56] what does that have to do with closing? [11:58] tsdgeos, I saw a deletepointer, nevermind, it's the triggered signal [11:58] yes it is === MacSlow is now known as MacSlow|lunch [12:10] tsdgeos, fixed [12:14] Cimi: cool, can you review my small reviews i have waiting for manpower? [12:14] tsdgeos, I did review the one for the manage dash [12:14] ah cool [12:14] tsdgeos, just have to comment on the launchpad page :D [12:15] tsdgeos, there is just one empty line to remove at end of tst_Dash [12:16] I tested and I don't see regressions [12:16] Cimi: line's gone [12:18] tsdgeos, I also tested that your test failed before [12:18] so yeah, approving [12:18] Cimi: do you think you could do https://code.launchpad.net/~aacid/unity8/update_qmltypes/+merge/249612 and https://code.launchpad.net/~aacid/unity8/attributeAspectRatio/+merge/249472 ? [12:18] first one is just running the make target [12:18] second one is a bit trickier [12:18] tsdgeos, yes I can [12:18] Cimi: cool [12:24] Saviq: can you trigger a rebuild of the silo? or we wait for josh's fix? [12:55] tsdgeos, I'll rebuild the silo without Josh's items === alan_g is now known as alan_g|lunch [13:39] Saviq, hey, so re: that today scope bug, it kind of seems like a unity8 thing to me, shouldn't scopes be auto-refreshed every once in a while? [13:39] cwayne_, no [13:39] cwayne, at least we don't have the facilities to do that right now [13:41] cwayne_, if we went that way, all scopes would declare to refresh every 5 mins, meh [13:46] Saviq, hm, so how else could we do it then? [13:48] cwayne, ideally all the scopes that are aggregated there are informed when there's new content there, either via push notifications or helpers on the device (say mediascanner, telephony etc.) [13:49] cwayne, then the dash refreshes the content when it makes sense, not at arbitrary points in time [13:49] cwayne, i.e. push vs. pull [13:51] Cimi: answered your comment on https://code.launchpad.net/~aacid/unity8/attributeAspectRatio/+merge/249472 [13:54] tsdgeos, silo is built [13:54] Saviq, what about auto-refreshing only favorited scopes, with a frequency based on their sorting in the dash? More accessed scopes would be refreshed more often. [13:54] Saviq: oki [13:55] davidcalle, I'd say not until we get diffs instead of full refreshes [13:55] davidcalle, full refresh is just too disruptive UI-wise [13:56] Saviq, you mean that we are actually going to have Dash diffs? [13:58] :P [13:58] Saviq, so how do you signal a refresh? that dbus api? [13:59] cwayne_: yup [14:03] davidcalle, if you bug pete-woods1 enough about it (and pstolowski when he's back from holidays :P) [14:04] or well, you don't even need to wait ;P [14:07] Saviq, I'll be a great tester for that silo ;) === MacSlow|lunch is now known as MacSlow [14:15] Saviq: can I push manually to trunk instead of the MP? I've all packages ready to push now the changelog entry. [14:15] or well, I can actually mark that as merged [14:16] so both win! [14:17] Saviq: what's the logic btw that I've checked out clean lp:unity8 today, I updated the changelog entry (+ merged your branch) and tagged the release, and pushing it once again says "11 tags updated"? [14:18] where do all the tags still come from :) [14:33] Saviq: i've tested that silo and it looks good to me [14:33] Saviq: do i have to write that somewhere? [14:34] Cimi: did you figure out what was the scope/problem you told me on friday? [14:45] tsdgeos: if happy with silo, you go to the spreadsheet, find the row for the silo, there's a column "Testing pass" which you can fill in [14:45] greyback_: "the spreadsheet" is an alien concept to me === alan_g|lunch is now known as alan_g [15:16] Cimi: do you still need help with https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1414870 ? [15:16] Launchpad bug 1414870 in unity8 (Ubuntu) "Result subtitles are cut off" [High,In progress] [15:27] tsdgeos, you can try if you can reproduce, I will fix it [15:29] Cimi: so you can't repro? [15:29] oki [15:38] tsdgeos, so the better would be trying to reproduce with tryCard [15:39] tsdgeos, I think that from the meetup scopes, I see a similar or different bug [16:03] cwayne_: which scope is this? https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1414870 [16:03] Launchpad bug 1414870 in unity8 (Ubuntu) "Result subtitles are cut off" [High,In progress] [16:04] tsdgeos, eventbrite, want me to send over a click [16:06] cwayne_: go home your drunk, that or not drunk enough, you're meant to be on holiday :P [16:16] Mirv, looks like your branch was contaminated with bad tags [16:21] davmor2, lol [16:25] Can anybody help to confirm a bug reported by me? I just want to know if I am really the only one. [16:25] https://bugs.launchpad.net/ubuntu/+source/unity/+bug/1393024 [16:25] Launchpad bug 1393024 in unity (Ubuntu) "Graphical corruption with hidpi scaling " [Undecided,Incomplete] [16:29] Saviq: but how, if it was fresh checkout, copying changelog and no-op merge of your branch? I'd guess your branch was clean checkout too. just interesting. [16:44] Mirv, might not have been actually [16:44] Mirv, yeah, my branch was infected, too [16:45] josharenson, hey, did you see email? [16:46] Saviq: rumour is that USA is on holiday today [16:46] oh [16:46] right [16:46] ok, /me will get at work later tonight then [16:47] Saviq: if you have a sec, i'd want your opinion over https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1414870 [16:47] Launchpad bug 1414870 in unity8 (Ubuntu) "Result subtitles are cut off" [High,In progress] [16:47] Saviq: basically subtitles with \n are cut [16:47] it's something we want to support? [16:48] tsdgeos, no [16:49] tsdgeos, so we should sanitize on input? [16:49] and s/\n// [16:49] Saviq: but then it'll look crap (i.e. not as they want) [16:49] tsdgeos, we don't support multi-line subtitles, per design [16:50] tsdgeos, do we not have a maximumLineCount: 1 there? we should [16:51] Saviq: we don't [16:52] Saviq: adding it "fixes" it [16:52] not sure cwayne_ et al will be happy with the fix :D [16:52] well, that's the design [16:52] sorries [16:52] gtg o/ [16:53] darn those infectious bazaar branches! [16:53] indeed [16:56] whats up? [16:58] cwayne_: using \n in subtitle is not "according to design" to what subtitle is supposed to do, that's why it breaks [17:02] tsdgeos, hrm okay, so if i take out the \n, will it wrap? [17:03] cwayne_: subtitle's are supposed to be 1 line, so no it won't wrap [17:03] that's what design for subtitles is [17:04] so what if it's too long? is it just cut off with ... [17:04] yes [17:09] that's better than just cut off i suppose [17:24] Can anybody help to confirm a bug reported by me? The bug was set incomplete and I don't know why. https://bugs.launchpad.net/ubuntu/+source/unity/+bug/1393024 [17:24] Launchpad bug 1393024 in unity (Ubuntu) "Graphical corruption with hidpi scaling " [Undecided,Incomplete] === alan_g is now known as alan_g|EOD [18:11] Can anybody help to confirm a bug reported by me? The bug was set incomplete and I don't know why. https://bugs.launchpad.net/ubuntu/+source/unity/+bug/1393024 [18:11] Launchpad bug 1393024 in unity (Ubuntu) "Graphical corruption with hidpi scaling " [Undecided,Incomplete] === sil2100_ is now known as sil2100 [23:39] Can anybody help to confirm a bug reported by me? The bug was set incomplete and I don't know why. https://bugs.launchpad.net/ubuntu/+source/unity/+bug/1393024 [23:39] Launchpad bug 1393024 in unity (Ubuntu) "Graphical corruption with hidpi scaling " [Undecided,Incomplete]