[09:12] <Saviq> tsdgeos, could you run the test plans for vivid silo 18 http://people.canonical.com/~platform/citrain_dashboard/#?distro=ubuntu&q=landing-018 ?
[09:12] <Saviq> https://wiki.ubuntu.com/Process/Merges/TestPlans/Unity8
[09:12] <Saviq> https://wiki.ubuntu.com/Process/Merges/TestPlan/scopes
[09:13] <tsdgeos> sure
[09:14] <tsdgeos> let me just the fix for the dash hint thing and i'll do this one
[09:27] <tsdgeos> Saviq: will you do the rest of review of https://code.launchpad.net/~aacid/unity8/attributeAspectRatio/+merge/249472 or want me to find someone else?
[09:27] <tsdgeos> also, can someone do https://code.launchpad.net/~aacid/unity8/update_qmltypes/+merge/249612 ? it's just running an automated tool :D
[09:28] <tsdgeos> Cimi: can you do https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1422260 ?
[09:28] <tsdgeos> er
[09:28] <tsdgeos> Cimi: https://code.launchpad.net/~aacid/unity8/noManageDashHintPreview
[09:29] <Saviq> tsdgeos, unlikely this week
[09:29] <tsdgeos> ok
[09:30] <tsdgeos> Cimi: maybe you can do https://code.launchpad.net/~aacid/unity8/attributeAspectRatio/+merge/249472  too?
[09:46] <Saviq> tsdgeos, when testing the screenshot feature, please not how does long-vol-press behave
[09:51] <tsdgeos> ok
[09:51] <tsdgeos> Saviq: what was/might be the problem?
[09:52] <Saviq> tsdgeos, we've switched from onPressed to onRelease for incremental changes
[09:53] <Saviq> tsdgeos, so if we didn't take care, we might have broken long press to change quickly
[09:53]  * Saviq actually flashes the silo to check
[10:02] <tsdgeos> Saviq: yeah broken
[10:03] <Saviq> tsdgeos, that's what I was afraid
[10:03] <Saviq> ok /me replies to his own email
[10:05] <tsdgeos> Saviq: but that was 18 vs 20 or is it vivid vs rtm?
[10:07] <Saviq> tsdgeos, it's in vivid 18, to be ported to rtm 20
[10:07] <tsdgeos> oki
[10:24] <tsdgeos> Saviq: https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1422309 this is not us, but who to assign to?
[10:59] <Saviq> tsdgeos, just asked cwayne to reassign as appropriate
[11:00] <tsdgeos> tx
[11:38] <tsdgeos> Cimi: Saviq: needs fixing test wise
[11:38] <tsdgeos> https://code.launchpad.net/~cimi/unity8/fix-open-new-scope-from-tmp/+merge/249471
[11:39] <Cimi> tsdgeos, it segfaults for you?
[11:39] <Cimi> on your machine?
[11:39] <tsdgeos> yes
[11:39] <tsdgeos> Cimi: doesn't it for you?
[11:39] <Cimi> mmm nope
[11:39] <Cimi> let me try again
[11:41] <tsdgeos> Cimi: testPreview, not the new test you added
[11:41] <Cimi> tsdgeos, oh yeah...
[11:41] <Cimi> tsdgeos, here too
[11:41] <Cimi> thanks
[11:42] <Cimi> tsdgeos, how do you run a test with gdb?
[11:43] <tsdgeos> there's two ways
[11:43] <tsdgeos> the lazy and the non lazy one
[11:43] <tsdgeos> non lazy one
[11:43] <tsdgeos> make testPreview VERBOSE=moo
[11:43] <tsdgeos> and then get the command line and inject gdb
[11:43] <tsdgeos> the lazy one
[11:43] <tsdgeos> make gdbtestPreview
[11:44] <Cimi> tsdgeos, you did you bother telling me the non lazy one? :D
[11:44] <tsdgeos> in case one day you need to run valgrind
[11:44] <tsdgeos> or some other tool
[11:44] <Cimi> ahah ok
[11:45] <Cimi> segfaults as soon as start loading with the lazy method
[11:47] <tsdgeos> ?
[11:48] <Saviq> tsdgeos, tx
[11:48] <tsdgeos> Cimi: http://paste.ubuntu.com/10254655/
[11:48] <tsdgeos> Cimi: basically there's no scopes in that test
[11:53] <Cimi> tsdgeos, can I instantiate scopes for the test?
[11:54] <Cimi> tsdgeos, or patch the mocks to close gracefully when scopes is null?
[11:54] <tsdgeos> close gracefully?
[11:55] <Cimi> tsdgeos, if segfaults because scopes is null, maybe we can skip the code that segfaults if scopes is null
[11:55] <Cimi> tsdgeos, or initialize scopes for the test
[11:56] <tsdgeos> what does that have to do with closing?
[11:58] <Cimi> tsdgeos, I saw a deletepointer, nevermind, it's the triggered signal
[11:58] <tsdgeos> yes it is
[12:10] <Cimi> tsdgeos, fixed
[12:14] <tsdgeos> Cimi: cool, can you review my small reviews i have waiting for manpower?
[12:14] <Cimi> tsdgeos, I did review the one for the manage dash
[12:14] <tsdgeos> ah cool
[12:14] <Cimi> tsdgeos, just have to comment on the launchpad page :D
[12:15] <Cimi> tsdgeos, there is just one empty line to remove at end of tst_Dash
[12:16] <Cimi> I tested and I don't see regressions
[12:16] <tsdgeos> Cimi: line's gone
[12:18] <Cimi> tsdgeos, I also tested that your test failed before
[12:18] <Cimi> so yeah, approving
[12:18] <tsdgeos> Cimi: do you think you could do https://code.launchpad.net/~aacid/unity8/update_qmltypes/+merge/249612 and https://code.launchpad.net/~aacid/unity8/attributeAspectRatio/+merge/249472 ?
[12:18] <tsdgeos> first one is just running the make target
[12:18] <tsdgeos> second one is a bit trickier
[12:18] <Cimi> tsdgeos, yes I can
[12:18] <tsdgeos> Cimi: cool
[12:24] <tsdgeos> Saviq: can you trigger a rebuild of the silo? or we wait for josh's fix?
[12:55] <Saviq> tsdgeos, I'll rebuild the silo without Josh's items
[13:39] <cwayne_> Saviq, hey, so re: that today scope bug, it kind of seems like a unity8 thing to me, shouldn't scopes be auto-refreshed every once in a while?
[13:39] <Saviq> cwayne_, no
[13:39] <Saviq> cwayne, at least we don't have the facilities to do that right now
[13:41] <Saviq> cwayne_, if we went that way, all scopes would declare to refresh every 5 mins, meh
[13:46] <cwayne_> Saviq, hm, so how else could we do it then?
[13:48] <Saviq> cwayne, ideally all the scopes that are aggregated there are informed when there's new content there, either via push notifications or helpers on the device (say mediascanner, telephony etc.)
[13:49] <Saviq> cwayne, then the dash refreshes the content when it makes sense, not at arbitrary points in time
[13:49] <Saviq> cwayne, i.e. push vs. pull
[13:51] <tsdgeos> Cimi: answered your comment on https://code.launchpad.net/~aacid/unity8/attributeAspectRatio/+merge/249472
[13:54] <Saviq> tsdgeos, silo is built
[13:54] <davidcalle> Saviq, what about auto-refreshing only favorited scopes, with a frequency based on their sorting in the dash? More accessed scopes would be refreshed more often.
[13:54] <tsdgeos> Saviq: oki
[13:55] <Saviq> davidcalle, I'd say not until we get diffs instead of full refreshes
[13:55] <Saviq> davidcalle, full refresh is just too disruptive UI-wise
[13:56] <davidcalle> Saviq, you mean that we are actually going to have Dash diffs?
[13:58] <davidcalle> :P
[13:58] <cwayne_> Saviq, so how do you signal a refresh? that dbus api?
[13:59] <Saviq> cwayne_: yup
[14:03] <Saviq> davidcalle, if you bug pete-woods1 enough about it (and pstolowski when he's back from holidays :P)
[14:04] <Saviq> or well, you don't even need to wait ;P
[14:07] <davidcalle> Saviq, I'll be a great tester for that silo ;)
[14:15] <Mirv> Saviq: can I push manually to trunk instead of the MP? I've all packages ready to push now the changelog entry.
[14:15] <Mirv> or well, I can actually mark that as merged
[14:16] <Mirv> so both win!
[14:17] <Mirv> Saviq: what's the logic btw that I've checked out clean lp:unity8 today, I updated the changelog entry (+ merged your branch) and tagged the release, and pushing it once again says "11 tags updated"?
[14:18] <Mirv> where do all the tags still come from :)
[14:33] <tsdgeos> Saviq: i've tested that silo and it looks good to me
[14:33] <tsdgeos> Saviq: do i have to write that somewhere?
[14:34] <tsdgeos> Cimi: did you figure out what was the scope/problem you told me on friday?
[14:45] <greyback_> tsdgeos: if happy with silo, you go to the spreadsheet, find the row for the silo, there's a column "Testing pass" which you can fill in
[14:45] <tsdgeos> greyback_: "the spreadsheet" is an alien concept to me
[15:16] <tsdgeos> Cimi: do you still need help with https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1414870 ?
[15:27] <Cimi> tsdgeos, you can try if you can reproduce, I will fix it
[15:29] <tsdgeos> Cimi: so you can't repro?
[15:29] <tsdgeos> oki
[15:38] <Cimi> tsdgeos, so the better would be trying to reproduce with tryCard
[15:39] <Cimi> tsdgeos, I think that from the meetup scopes, I see a similar or different bug
[16:03] <tsdgeos> cwayne_: which scope is this? https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1414870
[16:04] <cwayne_> tsdgeos, eventbrite, want me to send over a click
[16:06] <davmor2> cwayne_: go home your drunk, that or not drunk enough,  you're meant to be on holiday :P
[16:16] <Saviq> Mirv, looks like your branch was contaminated with bad tags
[16:21] <cwayne_> davmor2, lol
[16:25] <taringen> Can anybody help to confirm a bug reported by me? I just want to know if I am really the only one.
[16:25] <taringen> https://bugs.launchpad.net/ubuntu/+source/unity/+bug/1393024
[16:29] <Mirv> Saviq: but how, if it was fresh checkout, copying changelog and no-op merge of your branch? I'd guess your branch was clean checkout too. just interesting.
[16:44] <Saviq> Mirv, might not have been actually
[16:44] <Saviq> Mirv, yeah, my branch was infected, too
[16:45] <Saviq> josharenson, hey, did you see email?
[16:46] <tsdgeos> Saviq: rumour is that USA is on holiday today
[16:46] <Saviq> oh
[16:46] <Saviq> right
[16:46] <Saviq> ok, /me will get at work later tonight then
[16:47] <tsdgeos> Saviq: if you have a sec, i'd want your opinion over https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1414870
[16:47] <tsdgeos> Saviq: basically subtitles with \n are cut
[16:47] <tsdgeos> it's something we want to support?
[16:48] <Saviq> tsdgeos, no
[16:49] <Saviq> tsdgeos, so we should sanitize on input?
[16:49] <Saviq> and s/\n//
[16:49] <tsdgeos> Saviq: but then it'll look crap (i.e. not as they want)
[16:49] <Saviq> tsdgeos, we don't support multi-line subtitles, per design
[16:50] <Saviq> tsdgeos, do we not have a maximumLineCount: 1 there? we should
[16:51] <tsdgeos> Saviq: we don't
[16:52] <tsdgeos> Saviq: adding it "fixes" it
[16:52] <tsdgeos> not sure cwayne_ et al will be happy with the fix :D
[16:52] <Saviq> well, that's the design
[16:52] <Saviq> sorries
[16:52] <Saviq> gtg o/
[16:53] <Mirv> darn those infectious bazaar branches!
[16:53] <Saviq> indeed
[16:56] <cwayne_> whats up?
[16:58] <tsdgeos> cwayne_: using \n in subtitle is not "according to design" to what subtitle is supposed to do, that's why it breaks
[17:02] <cwayne_> tsdgeos, hrm okay, so if i take out the \n, will it wrap?
[17:03] <tsdgeos> cwayne_: subtitle's are supposed to be 1 line, so no it won't wrap
[17:03] <tsdgeos> that's what design for subtitles is
[17:04] <cwayne_> so what if it's too long? is it just cut off with ...
[17:04] <tsdgeos> yes
[17:09] <cwayne_> that's better than just cut off i suppose
[17:24] <taringen> Can anybody help to confirm a bug reported by me? The bug was set incomplete and I don't know why. https://bugs.launchpad.net/ubuntu/+source/unity/+bug/1393024
[18:11] <taringen> Can anybody help to confirm a bug reported by me? The bug was set incomplete and I don't know why. https://bugs.launchpad.net/ubuntu/+source/unity/+bug/1393024
[23:39] <taringen> Can anybody help to confirm a bug reported by me? The bug was set incomplete and I don't know why. https://bugs.launchpad.net/ubuntu/+source/unity/+bug/1393024