/srv/irclogs.ubuntu.com/2015/02/17/#juju-dev.txt

anastasiamac_axw: wallyworld_: plz don't review yet :D m resolving merge conflicts01:45
axwok01:45
wallyworld_k01:45
anastasiamac_wallyworld_: someone has been very busy in the area01:45
* anastasiamac_ rolls eyes :D01:45
anastasiamac_axw: wallyworld_: and resolved... PTAL http://reviews.vapour.ws/r/941/02:08
axwlooking02:08
anastasiamac_axw: tyvm :D02:09
thumperphew04:45
thumperdoc finished (for now)04:45
thumperemail sent04:45
thumperI'm done04:45
* thumper looks for the wine04:45
TheMuemorning08:49
anastasiamac_TheMue: morning08:52
TheMueanastasiamac_: heya o/08:52
TheMueanastasiamac_: still awake?08:52
* TheMue has to look at the time zones08:53
anastasiamac_TheMue: it's 7pm, m about to take my son to soccer08:53
anastasiamac_TheMue: but will be back again soon :D08:53
TheMueanastasiamac_: ah, ok, not so late, but a good time to care for the son08:53
anastasiamac_TheMue: u r not travelling very far in April ;(08:53
TheMueanastasiamac_: absolutily not, and the city is IMHO quite boring (have been there twice)08:54
anastasiamac_TheMue: yes, it's good time to care for one... unfortunately, i have 3 :(08:54
TheMueanastasiamac_: there are others more interesting, like Hamburg or Berlin08:54
anastasiamac_TheMue: but with us, it will feel like new :D08:54
TheMueanastasiamac_: hehe, I've got 2, but the are now almost 19 and 21.08:54
anastasiamac_TheMue: oh - so u know my dilemma08:55
TheMueanastasiamac_: yep *lol*08:55
anastasiamac_TheMue: ttyl08:55
TheMueanastasiamac_: cu08:55
jamfwereade: how's it going?09:02
fwereadejam, heyhey09:23
fwereadejam, actually decent again, how about you?09:23
fwereadeaxw, thanks for moving those relation.Hook* things09:25
fwereadeaxw, I was worried there'd be import hassle09:25
axwfwereade: nps, I hope it looks okay?09:25
fwereadeaxw, I haven't looked at the change, just the log,but it sounds absolutely sane09:26
axwok :)09:26
axwfwereade: I'll have some more changes soon, but that'll all be about storage. probably will have to pick your brain again soon09:26
jamfwereade: did you have a good weekend? Things are going ok here, though we should get back on Leader Election stuff09:27
jamI did manage to land a couple patches there09:27
fwereadejam, yeah, I saw, and I have one here with just a few review fixes to apply I think09:27
fwereadejam, so we're getting perilously close to the actually-call-the-apis point09:28
jamfwereade: I was thinking to go make some coffee and then jump on a hangout, does that sound decent to you?09:28
fwereadejam, perfect, will do likewise09:28
voidspacedooferlad: dimitern: TheMue: got kicked out! Need to reauthenticate, sorry10:04
dooferladdimitern, TheMue, voidspace: https://github.com/dooferlad/next_up11:17
TheMue*click*11:18
dooferladTheMue: Would happily move the remaining Python stuff into Go, but can't justify the time spent at the moment. Suggestions welcome :-)11:19
dimiterndooferlad, nice! :)11:19
voidspacedooferlad: cool11:19
TheMuedooferlad: will come automatically over the time11:19
TheMuedooferlad: together with more commenting *scnr*11:21
dooferladTheMue: It has... evolved quickly.11:21
* fwereade lunch11:21
dooferladTheMue: I would classify it as "I don't like it, but it works"11:22
voidspacedooferlad: for the JSON documents in Go you could use a generic (bad choice of word) JSONObject11:23
voidspacedooferlad: with methods to fetch a map, an array or a string11:23
voidspacedooferlad: and then just traverse the known structure11:23
voidspacedooferlad: this is what we do for MaaS - you could nick the code from that11:23
voidspaceit's still a bit more tedious than Python, but you don't have to define a type for each document11:24
dooferladvoidspace: cool!11:25
voidspaceso GetArray returns a JSONObject representing the array, or an error if the underlying JSON you've asked for isn't an array11:25
voidspaceso more than half your code is still error handling :-)11:25
voidspaceprovider/maas/environ.go is a good place to look for examples11:26
voidspaceand by coincidence the place you'll need to be looking for the networking stuff11:26
voidspacedooferlad: did you say you had a pact referral code?11:27
voidspacedooferlad: I'm thinking of giving them a try11:28
voidspacedooferlad: gomaasapi.JSONObject11:28
voidspacewhich should probably be broken out into it's own little library11:29
dooferladvoidspace: https://www.pactcoffee.com/spread/james-cmocka11:36
voidspacedooferlad: thanks11:36
dooferladvoidspace: that gomaasapi.JSONObject looks spot on!11:37
voidspacedooferlad: coffee ordered :-)11:51
dooferladvoidspace: hope you enjoy it :-)11:51
TheMueaaaah, found it, go test dislikes the combination of -check.v or -gocheck.v with ./...11:59
dimiternTheMue, yeah, it's either go test -v ./... or go test -check.v (in current dir)12:19
voidspacedimitern: dooferlad: https://www.dropbox.com/s/ovdml6fs4u3n1wv/maas.txt?dl=012:30
voidspacedimitern: dooferlad: that's the document on the container addressability information for MaaS12:31
dimiternvoidspace, thanks, looking12:31
voidspaceit's just an overview, but hopefully detailed enough to be useful12:31
voidspacefeel free to point out errors, missing information or suggest clarification12:32
voidspaceit doesn't detail all the specific API calls as they should be clear from the code12:32
voidspaceit's meant as a guide to the code12:32
jamfwereade: are you around to chat a bit about the Dying() stuff?13:04
* jam goes to walk the dog13:09
=== kadams54 is now known as kadams54-away
=== kadams54-away is now known as kadams54
dimiternhey guys, fwereade just texted me he's having issues with the internet connection13:41
dimiterntasdomas, ^^13:41
jw4plantuml state diagram of uniter modes : http://reviews.vapour.ws/r/944/13:54
jw4still really basic; lots of room for improvement13:54
jw4katco: fyi, you were interested in this ^^13:55
=== kadams54 is now known as kadams54-away
=== kadams54-away is now known as kadams54
=== ChanServ changed the topic of #juju-dev to: https://juju.ubuntu.com | On-call reviewer: see calendar | Open critical bugs: 1416928
marcoceppigsamfira aznashwan o/14:51
gsamfiramarcoceppi hey there :D14:53
katcojw4: thanks, i'll have a look :)14:57
* katco is OCR today; covering for perrito666 who is on holiday today. Please send review requests my way!14:58
TheMuekatco: don't cry so loud, I'm currently finishing a larger one15:01
TheMuekatco: :D15:01
katcoTheMue: haha15:02
=== kadams54 is now known as kadams54-away
sinzuiwwitzel3, You can merge your fix for bug 1417875 and since your work is required for 1.21 and 1.22, you were permitted to to use the __JFDI__ to make it merge15:14
mupBug #1417875: ERROR juju.worker runner.go:219 exited "rsyslog": x509: certificate signed by unknown authority <canonical-bootstack> <logging> <regression> <juju-core:In15:14
mupProgress by wwitzel3> <juju-core 1.21:In Progress by wwitzel3> <juju-core 1.22:In Progress by wwitzel3> <https://launchpad.net/bugs/1417875>15:14
wwitzel3sinzui: thank you15:16
sinzuidimitern, how goes your fix for bug 141692815:17
mupBug #1416928: juju agent using lxcbr0 address as apiaddress instead of juju-br0 breaks agents <api> <lxc> <network> <juju-core:In Progress by dimitern> <juju-core 1.21:In Progress by dimitern> <juju-core 1.22:In Progress by dimitern> <https://launchpad.net/bugs/1416928>15:17
dimiternsinzui, mostly done, testing various scenarios live now15:17
sinzuirock, thank you dimitern  and wwitzel315:18
bodie_where can I find a picture of what's going on with Windows support?  We're looking to add an "action kill" worker behavior which we were planning to implement using syscall; do we need to implement windows support as well (I know we offer a few Windows charms?)15:23
bodie_(the current plan is to implement it in a system agnostic way and add OS specific support, fwiw.)15:31
jw4katco: tx15:36
katcojw4: ty :)15:36
=== kadams54-away is now known as kadams54
dimiternmgz, ping15:38
mgzdimitern: hey15:38
dimiternmgz, hey, any update on goose? :)15:38
mgzI have script for managing the pull/test, plan today is fork the existing gating job and add as experimental without the github actual landing part15:39
dimiternmgz, sweet! please keep me updated15:40
katcodimitern: would goose need a new branch for adding cinder support? technically it's not a breaking change15:50
dimiternkatco, it depends on the PR I guess15:51
katcodimitern: picture a new package15:51
dimiternkatco, if you're only adding things, cindertest double subpackage included, then I guess it's backwards compatible15:52
mgzkatco: it shouldn't, but I think we never did the "cloud doesn't support this extention/module" code, so you may have compat issues15:52
katcomgz: you mean instances of openstack that don't support cinder?15:53
mgzor only expose it via the nova interfacs15:54
katcomgz: i'm not touching the nova package, i think it's expected that users utilize the cinder API15:56
katcomgz: but i might be missing the just of what you're saying15:56
mgzright, which may not work on any given cloud15:56
mgzbecause the older api was through nova15:56
katcomgz: so wouldn't they then be able to fall back to the nova implementation? or is that not in goose?15:57
dimiternkatco, not the storage apis of nova15:57
katcodimitern: mgz: ah i see15:58
dimiternkatco, but I'd vote to deal with this if we need to15:58
dimiterncinder api is the way forward, if we need to also support nova legacy storage apis, we'll do it15:59
mgzbasically, I think we just want to make sure the code does something sensible if keystone doesn't give you a cinder endpoint15:59
mgzbecause that's what would break existing uses16:00
katcomgz: good point. i think that's more on the juju side though16:00
katcodimitern: agreed. now that i can auto-generate api client's it can be trivial16:00
mgzwe only look at endpoints if you import and try to construct a cinder object?16:00
katcomgz: it would fail upon making a cinder call most likely16:01
mgzokay, that's late enough I guess16:01
katcomgz: i haven't actually wrapped goose around the auto-generated client yet16:01
dimiternkatco, i'd like to have a look at your proposal when you're ready btw16:02
katcodimitern: sure thing. that's what i'm working on today16:02
katcodimitern: (i'll be getting back to amz after this, but i want to unblock my team)16:03
dimiternkatco, sgtm16:03
katcodimitern: here's the autogenerated code: http://paste.ubuntu.com/10212665/16:03
dimiternkatco, cool, can I suggest to tweak the generation to follow Go style guide? e.g. no "_" in field names mostly and stripping <tags> from doc comments will be nicer16:05
katcodimitern: yeah it needs a bit more cleanup. i'm not sure i'll be able to easily get rid of the "_", but will endeavor to16:06
katcodimitern: within a reasonable amount of time16:06
dimiternkatco, cheers16:06
dimiternkatco, also, are these client-facing exports?16:07
katcodimitern: the idea is that goose wraps this16:07
dimiternkatco, i.e. do I have to call DeleteSnapshot(request MakeRequestFn, args DeleteSnapshotParams) directly?16:07
dimiternkatco, ah, that's better16:07
katcodimitern: so probably not; we'll see how the api evolves16:07
katcodimitern: mostly i just didn't want to sit there and write a billion http requests :)16:08
dimiternkatco, do you even need them all?16:08
katcodimitern: what do you mean?16:09
dimiternkatco, remember that everything we use in juju needs a corresponding support in its corresponding test double (e.g. testservices/novatestservice)16:09
dimiternkatco, so that live tests can be written against these and run (quickly) against them the same way as they would against live OS servers16:10
katcodimitern: apologies; i'm not drawing the connection16:11
dimiternkatco, the test servers implement the same API as the real openstack servers (well, only a subset needed by juju)16:12
katcodimitern: do http requests somehow preclude us from testing that manner?16:13
dimiternkatco, so that you can then write "local live" tests running against the test doubles or real openstack servers16:13
dimiternkatco, no, but if you implement the full cinder api just to save time writing each method individually, this won't help with the implementation of the test double16:14
katcodimitern: i.e. the tests should be able to use this code to hit the test double16:15
voidspacedimitern: ping16:15
dimiternkatco, juju (and its live tests) will use the generated code to talk to real OS API or the test double16:16
katcodimitern: i might be missing something, but i still don't see an issue16:16
katcodimitern: just pass in a MakeRequestFn that does what you want with the *http.Request16:17
dimiternkatco, it's not just about tweaking a request or response, it's about faking a sequence of calls, e.g. start a node, allocate an ip to it, list node's ips, set node state, etc.16:19
katcodimitern: i'll have a look at nova and see if i can understand better what you're describing16:21
dimiternkatco, yeah, have a look at juju livetests as well and you the open stack test services are used in goose and in juju16:22
katcodimitern: ok will do. thanks!16:23
dimiternkatco, np! after going through the code you'll probably understand better what I'm trying (and obviously failing :)) to explain16:25
katcodimitern: no worries; i'm sure you're right :)16:25
aznashwanhey, just another quick centos-userdata question for you guys: considering that cloudinit only has very marginal support for [serious] yum-related work, would anyone consider it bad to run all other the packaging-related operations as {boot,run}cmds?16:43
dimiternI'd appreciate a review on http://reviews.vapour.ws/r/946/ which fixes the critical 1.21 release blocker bug 141692817:16
mupBug #1416928: juju agent using lxcbr0 address as apiaddress instead of juju-br0 breaks agents <api> <lxc> <network> <juju-core:In Progress by dimitern> <juju-core 1.21:In Progress by dimitern> <juju-core 1.22:In Progress by dimitern> <https://launchpad.net/bugs/1416928>17:16
TheMuegnah, my local git repo dislikes me. thankfully e'thing is pushed17:16
TheMuedimitern: *click*17:16
dimiternTheMue, ta!17:17
stokachuif proxies are defined within juju are they exported to the charm's environment as well?17:30
stokachufor things like wget to utilize17:30
TheMuedimitern: you've got a review17:37
dimiternTheMue, thanks!17:41
dimiternstokachu, yes they are17:41
TheMuedimitern: yw17:41
TheMuedimitern: I'll push mine when I fixed my git troubles :D17:42
dimiternTheMue, ok17:43
natefinchsinzui: what's the bug situation?  Anything blocking us that I should be looking into?18:05
sinzuinatefinch, I think dimitern and wwitzel3 are finishing up.18:06
sinzuinatefinch, there is this issue been in 1.22 that needs someone to investigate and maybe fix bug 142004918:06
mupBug #1420049: ppc64el - jujud: Syntax error: word unexpected (expecting ")") <deploy> <openstack> <regression> <uosci> <juju-core:Triaged> <juju-core 1.22:Triaged> <https://launchpad.net/bugs/1420049>18:06
dimiternnatefinch, my fix has a review and I'll be setting it to land before I go today18:07
natefinchdimitern: cool18:08
=== tvansteenburgh is now known as tvan-lunch
=== kadams54 is now known as kadams54-away
katcodimitern: i think i see what you're saying? auto-generating the client doesn't save any time because i have to write all the mock endpoints anyway?18:49
voidspaceright EOD18:49
katcotc voidspace18:49
voidspacedimitern: I'll post my self  evaluation later (nearly done) - and email you about my branch18:50
voidspacedimitern: what's still to be done (not much - just one bit of code to be moved and maybe another test I think)18:50
voidspacebut later18:50
voidspacegotta go now18:50
voidspacekatco: bye o/18:50
katcovoidspace: ciao18:50
dimiternkatco, yep18:51
dimitern:)18:51
katcodimitern: i might have to auto-generate those too :)18:53
dimiternkatco, now that will be awesome! :)18:56
=== kadams54-away is now known as kadams54
=== kadams54 is now known as kadams54-away
=== kadams54-away is now known as kadams54
=== kadams54 is now known as kadams54-away
=== kadams54-away is now known as kadams54
=== _thumper_ is now known as thumper
=== kadams54 is now known as kadams54-away
=== kadams54-away is now known as kadams54
=== menn0_ is now known as menn0
wwitzel3thumper: ping21:52
thumperpong21:53
wwitzel3thumper: quick hangout21:53
thumpersure21:53
wwitzel3thumper: https://plus.google.com/hangouts/_/canonical.com/moonstone?v=1423613698&clid=BF4AF0604617145E&authuser=021:54
=== kadams54 is now known as kadams54-away
=== thumper is now known as thumper-dogwalk
sinzuiwallyworld, xwwt good news of sorts. the job failed without lxc. Looks like an apt issue22:47
wallyworldoh, interesting22:48
xwwtsinzui, so this might not be the br0 error?22:48
sinzuixwwt, yep22:48
sinzuiwallyworld, What is this22:48
sinzui2015-02-17 22:45:18 ERROR juju.cmd supercommand.go:323 failed to stop mongo: exec ["stop" "--system" "juju-db"]: exit status 1 (stop: Method "Get" with signature "ss" on interface "org.freedesktop.DBus.Properties" doesn't exist)22:48
sinzuiI think the dbus package got removed when I removed the lxc?22:49
sinzuiyep it was missing22:49
sinzuiretesting now22:49
wallyworldfingers crossed22:49
sinzuiwallyworld, xwwt   The bug is fixed, we are unblocked. The false failure was cause by a mongod being left behind by the broken juju. I had to clean the machine to let the test run cleanly.23:11
wallyworldsinzui: awesome23:11
sinzuiwallyworld, we have two passes in a row, so I an sure working juju cleans up23:11
sinzuiwallyworld, CI has blessed the 1.21 rev. I will send packages of to the builds now23:21
wallyworldwhiihii23:21
wallyworldwhoohoo23:21
sinzuiwallyworld, do you have a moment to review this formality http://reviews.vapour.ws/r/948/23:40
wallyworldsure23:40
wallyworldsinzui: i love your optimism :-)23:41
=== thumper-dogwalk is now known as thumper
=== kadams54-away is now known as kadams54

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!