| === mhilton is now known as mhilton-lunch | ||
| === kadams54 is now known as kadams54-away | ||
| === kadams54-away is now known as kadams54 | ||
| === kadams54 is now known as kadams54-away | ||
| === kadams54-away is now known as kadams54 | ||
| === mhilton-lunch is now known as mhilton | ||
| === kadams54 is now known as kadams54-away | ||
| === kadams54-away is now known as kadams54 | ||
| hatch | uiteam lf reviews for https://github.com/juju/juju-gui/pull/695 | 17:51 |
|---|---|---|
| Makyo | On it | 18:07 |
| hatch | thanks | 18:08 |
| hatch | man this test suite.... | 18:16 |
| === tvansteenburgh is now known as tvan-lunch | ||
| === kadams54 is now known as kadams54-away | ||
| === kadams54-away is now known as kadams54 | ||
| hatch | uiteam I need one more review https://github.com/juju/juju-gui/pull/695 | 19:00 |
| jcsackett | hatch: i can look at it in a few. | 19:02 |
| hatch | thanks | 19:03 |
| jcsackett | hatch: remind me in js what .bind is doing. | 19:14 |
| jcsackett | it's been too long, and the weird ways of the gui code no longer make sense to me. :p | 19:14 |
| Makyo | jcsackett, setting the context of 'this' within the function being bound. | 19:14 |
| jcsackett | so fn.bind(fn_args, context) is the usual signature? | 19:15 |
| hatch | jcsackett: yep | 19:15 |
| hatch | so bind actually returns a new function which is run in the context | 19:15 |
| Makyo | fn.bind(context, args...) | 19:15 |
| hatch | jcsackett: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/bind | 19:16 |
| Makyo | So fn.bind(this, args) ensure that fn has access to all that's in `this` context | 19:16 |
| hatch | thatses in thises | 19:16 |
| hatch | :) | 19:16 |
| Makyo | It's all very generic | 19:18 |
| hatch | and yet....surprisingly specific | 19:18 |
| * jcsackett laughs | 19:18 | |
| jcsackett | hatch: comments on your PR. very possibly just me misreading things, so feel free to straighten me out if that's the case. | 19:18 |
| hatch | will do! | 19:19 |
| hatch | thanks! | 19:19 |
| hatch | jcsackett: good comments - it's all js funkyness I'll explain in the questions | 19:19 |
| jcsackett | hatch: thanks. | 19:23 |
| hatch | jcsackett: replied | 19:24 |
| hatch | hope that my responses make sense | 19:24 |
| hatch | going to grab some lunch | 19:27 |
| === kadams54 is now known as kadams54-away | ||
| === kadams54-away is now known as kadams54 | ||
| === kadams54 is now known as kadams54-away | ||
| === kadams54-away is now known as kadams54 | ||
| hatch | jcsackett: my comments make sense? | 20:08 |
| jcsackett | hatch: yup, just now was able to reply. | 20:18 |
| === kadams54 is now known as kadams54-away | ||
| === kadams54-away is now known as kadams54 | ||
| huwshimi | Morning | 22:00 |
| === kadams54 is now known as kadams54-away | ||
| === kadams54-away is now known as kadams54 | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!