=== mhilton is now known as mhilton-lunch === kadams54 is now known as kadams54-away === kadams54-away is now known as kadams54 === kadams54 is now known as kadams54-away === kadams54-away is now known as kadams54 === mhilton-lunch is now known as mhilton === kadams54 is now known as kadams54-away === kadams54-away is now known as kadams54 [17:51] uiteam lf reviews for https://github.com/juju/juju-gui/pull/695 [18:07] On it [18:08] thanks [18:16] man this test suite.... === tvansteenburgh is now known as tvan-lunch === kadams54 is now known as kadams54-away === kadams54-away is now known as kadams54 [19:00] uiteam I need one more review https://github.com/juju/juju-gui/pull/695 [19:02] hatch: i can look at it in a few. [19:03] thanks [19:14] hatch: remind me in js what .bind is doing. [19:14] it's been too long, and the weird ways of the gui code no longer make sense to me. :p [19:14] jcsackett, setting the context of 'this' within the function being bound. [19:15] so fn.bind(fn_args, context) is the usual signature? [19:15] jcsackett: yep [19:15] so bind actually returns a new function which is run in the context [19:15] fn.bind(context, args...) [19:16] jcsackett: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/bind [19:16] So fn.bind(this, args) ensure that fn has access to all that's in `this` context [19:16] thatses in thises [19:16] :) [19:18] It's all very generic [19:18] and yet....surprisingly specific [19:18] * jcsackett laughs [19:18] hatch: comments on your PR. very possibly just me misreading things, so feel free to straighten me out if that's the case. [19:19] will do! [19:19] thanks! [19:19] jcsackett: good comments - it's all js funkyness I'll explain in the questions [19:23] hatch: thanks. [19:24] jcsackett: replied [19:24] hope that my responses make sense [19:27] going to grab some lunch === kadams54 is now known as kadams54-away === kadams54-away is now known as kadams54 === kadams54 is now known as kadams54-away === kadams54-away is now known as kadams54 [20:08] jcsackett: my comments make sense? [20:18] hatch: yup, just now was able to reply. === kadams54 is now known as kadams54-away === kadams54-away is now known as kadams54 [22:00] Morning === kadams54 is now known as kadams54-away === kadams54-away is now known as kadams54