/srv/irclogs.ubuntu.com/2015/03/06/#juju-dev.txt

wallyworld_thumper: ?00:34
thumperwallyworld_: sorry01:42
wallyworld_thumper: np, chat now?01:45
thumpersure01:45
axwanastasiamac: re http://aws.amazon.com/ec2/pricing/, I was looking at spot instances - I see it says unspecified in the on-demand section as you said01:45
axwweird01:45
anastasiamacaxw: yes, if you look at sao paolo region, it shriks the list of supported instances01:50
anastasiamacaxw: i deduced that frankfurt *could* have the types marked as **unspecified**01:50
anastasiamacaxw: but m happy to let it rest for now01:51
anastasiamacaxw: :D it's amazing what an effect a small change can have :))01:52
axw:)01:52
ericsnowcould someone spare me a review on http://reviews.vapour.ws/r/1094/01:56
ericsnowit un-reverts an earlier patch and adds logging01:56
ericsnowit will help me sort out the vivid issues01:56
anastasiamacericsnow: *un-reverts*? u must b having soo much fun :D01:59
ericsnowanastasiamac: imagine bamboo and fingernails02:00
axwkatco: are you still around? did you have anything more to say on the remaining open points on http://reviews.vapour.ws/r/1071/ ?02:05
wallyworld_axw: free whenever you are02:19
axwwallyworld_: omw02:19
=== kadams54-away is now known as kadams54
=== kadams54 is now known as kadams54-away
=== kadams54 is now known as kadams54-away
mattywaxw, ping?08:21
axwmattyw: pong08:22
TheMuemorning o/09:04
menn0dimitern: ping09:09
dimiternmenn0, pong09:12
menn0dimitern: did you see that email about issues with using MongoDB unique indexes with mgo/txn?09:13
dimiternmenn0, probably, but can you remind me the gist?09:14
menn0dimitern: basically you can't really use mgo/txn with a unique index09:14
menn0dimitern: if there's a unique index collision, the txn will appear to have worked (no error returned)09:15
dimiternmenn0, because it returns nil on violation?09:15
menn0dimitern: but the insert into the collection with index fails, and any other ops succeed09:15
menn0dimitern: so you end up with partial application09:15
dimiternmenn0, yeah, nasty09:16
menn0dimitern: I mention it to you because there's a bunch of networking related collections in Juju with unique indexes09:16
menn0dimitern: there's 2 ways around it09:16
menn0dimitern: 1. check for the failed insert afterwards and clean up any docs in other collections that shouldn't have been inserted09:17
dimiternmenn0, have you looked at the code that handles the nil result?09:17
menn0dimitern: 2. introduce another collection which has docs which have the index key as the _id and Assert on that as part of the txn (instead of using a unique index)09:18
menn0dimitern: the code where?09:18
dimiternmenn0, ok, these pointers are good to know, thank you09:18
menn0dimitern: there's a simple example linked to from the email (see the quoted bit at the bottom of Gustavo's reply)09:19
dimiternmenn0, but so far I think the only place we're using unique indexes are for networks09:19
dimiternmenn0, and they are handled correctly - check AddNetwork and AddNetworkInterface09:21
menn0dimitern: I hadn't checked the networking code. I just saw the indexes there and figured that this situation might not have been handled.09:21
menn0dimitern: looks like you guys already knew about this.09:22
menn0dimitern: we're probably going to go with option 2 for the case where Jesse ran into this today (not allowing multiple envs with the same name for a single owner)09:22
menn0dimitern: (a separate collection which tracks the uniqueness constraint)09:23
dimiternmenn0, what I wasn't quite aware of is that just the insert fails, and to watch out for partially succeeded ops in other collections09:23
menn0dimitern: yeah, it's pretty subtle09:24
menn0dimitern: i've looked at the mgo/txn code in question and see why this happens.09:24
menn0dimitern: mongodb doesn't return specific enough error codes for it to be able to handle this any better09:24
dimiternmenn0, even more recent versions of mongo?09:25
menn0dimitern: yeah. i don't think this has been fixed. basically "document already exists" and "index unique violation" are returned as the same error (and they kind of are if you think about it). but mgo/txn needs to know the difference.09:26
menn0brb09:26
dimiternI see :/09:28
menn0dimitern: so anyway, now you know :)09:32
menn0dimitern: AddNetworkInterface is fine because although it involves several collections, it only inserts into one09:32
menn0dimitern: AddNetowork is fine too because it only involves one collection.09:33
dimiternmenn0, ok, thanks for checking, and I'll keep that in mind for other of our cases - should we need unique indexes09:34
menn0dimitern: kk09:34
=== ChanServ changed the topic of #juju-dev to: https://juju.ubuntu.com | On-call reviewer: see calendar | Open critical bugs: none
TheMuedimitern: dooferlad: thx, test works now10:23
dimiternTheMue, o/o10:24
dimiternTheMue, \o/ even :)10:24
TheMuedimitern: *lol*10:25
mattywdavecheney, ping?10:28
dimiternmattyw, hey there - have you seen my review of 994?10:33
mattywdimitern, I have - thank you very much, I'm mid changes at the moment, will be pinging when I'm done10:34
dimiternmattyw, cheers10:34
mattywdimitern, thanks for taking a look - and thanks for the comments, all good stuff10:36
dimiternmattyw, no worries - I'm happy to see the proposal improved considerably10:36
mattywdimitern, +1k10:37
dimiterndooferlad, here's my branch - https://github.com/dimitern/juju/tree/container-addressability-fixes I've just confirmed with those changes and lxc-clone: false I successfully deployed 2 nodes with 2 containers each, and was able to do juju ssh x/lxc/y where x and y are [0,1] on EC210:55
* dimitern steps out for ~1h11:10
* TheMue -> lunch11:57
dimiterndooferlad, ping13:30
dooferladdimitern: hi13:31
dimiterndooferlad, I've discovered a disturbing issue13:31
dooferladdimitern: ?13:31
dimiterndooferlad, both with lxc-clone: true and false and the changes in my branch I sent you earlier, I successfully live tested a scenario on EC213:32
dooferladand that is bad?13:32
dimiterndooferlad, and was able to do juju ssh 0/lxc/0 (or any other container for that matter)13:32
perrito666morning13:32
dimiterndooferlad, the bad part is, I left the lxc-clone: true env sitting around while I was out and now trying juju ssh 0/lxc/0 fails13:33
dooferladdimitern: so it did work, you left it alone, it didn't13:33
dimiterndooferlad, so something happened in the mean time - juju status shows all units are running, no issues13:34
dooferladdimitern: so it did work, you left it alone, now it doesn't?13:34
dimiterndooferlad, yes13:34
dimiterndooferlad, I'm investigating13:34
=== jorge_ is now known as jcastro
dimiterndooferlad, I think the issue comes from dnsmasq configured by lxc to issue dhcp addresses for containers and renew them hourly14:23
dimiternin the 10.0.3.0/24 range14:25
perrito666natefinch: ?14:33
ericsnowcould someone spare me a review on http://reviews.vapour.ws/r/1094/14:43
ericsnowericsnow: it's pretty basic14:44
jw4talking to yourself again ericsnow ?14:44
ericsnowjw4: hey, you're not part of this conversation <wink>14:44
jw4hqhq14:44
jw4haha even14:45
* ericsnow goes back to using his quiet voice14:45
natefinchperrito666: sorry, gotta fix a dumb bug I introduced14:50
perrito666np14:50
jw4ericsnow, presumably that PR has been reviewed a few times? Are you just looking for a graduated approver to say shipit?14:51
ericsnowjw4: noone has looked at it :(14:51
jw4ericsnow, it *is* a little daunting14:51
ericsnowjw4: regardless, I'll need some authority to get it landed :)14:51
ericsnowjw4: the un-revert part was already reviewed and merged last week14:52
jw4bamboo? fingernails?14:52
ericsnowericsnow: I suppose it would be simpler if I split the patch in two14:52
* ericsnow mumbles to self14:53
ericsnowjw4: ^^^14:53
jw4hehehe14:53
ericsnowjw4: the torture reference was about getting the vivid stuff sorted out14:53
jw4oh, I thought it was related to un-reverting and assumed it was the same one14:54
ericsnowjw4: it's been a real pain because I don't have a local vivd host with which to test14:54
jw4Yeah, I got a utopic vm, but no vivid yet14:54
ericsnowjw4: oh, just a VM isn't sufficient :(14:55
ericsnowjw4: vivid and containers still have issues when the host isn't vivid14:55
jw4ericsnow, really?  That's interesting14:55
ericsnowjw4: that's one word for it :P14:56
* jw4 whispers - I do all my development in a hyper-v instance 14:56
ericsnowjw4: you have all the answers, don't you? <wink>14:57
jw4hehe14:57
ericsnowjw4: is the performance of hyper-v good?14:58
ericsnowjw4: LXC is pretty fast and light14:58
jw4It seems pretty fast to me14:58
ericsnowjw4: cool14:59
ericsnowjw4: I'll have to look into that14:59
jw4it's hard to compare across hardware, but it handily outperforms native ubuntu on my early 2011 macbook pro with SSD and 16GB ram14:59
jw4the full test suite runs in about 15 minutes for me, and it's on a i7 dell optiplex from 2011 too15:01
wwitzel3ericsnow: ping15:06
ericsnowwwitzel3: coming15:06
mbruzekdavecheney: ping15:27
=== kadams54 is now known as kadams54-away
=== kadams54-away is now known as kadams54
=== kadams54 is now known as kadams54-away
TheMueAnybody interested in doing a review? http://reviews.vapour.ws/r/1096/15:36
dimiternTheMue, I'm on it, but keep getting distracted; should finish it soon though15:39
alexisbmbruzek, davecheney is probably sleeping15:39
TheMuedimitern: fine, thanks15:40
alexisbis there something someone else on the team can help with?15:40
TheMuedimitern: doesn't hurry, I'm on the next one. ;)15:40
dimiternalexisb, well, dooferlad is actually OCR today15:40
dimiterndooferlad, it wouldn't hurt to have a look as well15:40
dooferladdimitern: on it15:41
dimiterndooferlad, cheers!15:41
=== kadams54-away is now known as kadams54
dooferladTheMue: My non-expert opinion is that it looks fine!15:52
TheMuedooferlad: thanks, and don't hide your light under a bushel15:53
mbruzekalexisb: I need some go help was davecheney is the person to talk with about that.  I have an email out to natefinch and katco about my question.16:00
natefinchmbruzek: yeah, sorry, meant to respond to you last night16:01
alexisbmbruzek, dave is our resident gccgo expert16:01
alexisbmbruzek, you can send him mail if it is not urgent, but he will be out for his weekend atm16:01
mbruzekalexisb:  it is not urgent.   I am sure Nate or Katherine can help16:02
alexisbmbruzek, natefinch is currently on a critical task16:02
alexisbmbruzek, can you forward me th email so I can help facilitate16:03
mbruzekalexisb: OK stand down natefinch, I will email davecheney and you16:03
alexisbthanks mbruzek16:03
natefinchmbruzek: my off the cuff response is - don't install go, just deploy a binary, but I doubt you'll like that answer :)16:03
natefinch(but it's sort of the whole point of writing anything in Go in the first place)16:04
mbruzeknatefinch: It doesn't matter if I like it or not if that is your answer.  I don't know how that would survive bit rot, but yeah don't worry about it, do you critical task16:05
natefinchOh wow, this joyent test is totally fubared16:10
natefinch(sorry alexisb, this is also a critical fix)16:11
alexisbnatefinch, yep I see it16:11
natefinchwho sets environment variables in table driven tests and then doesn't clear them out before the next test in the table? :/16:22
natefinchEvidently wallyworld_ , that's who :)16:33
natefinchericsnow, perrito666, TheMue, wwitzel3:  can someone review this fix to a critical regression? http://reviews.vapour.ws/r/1098/diff/#16:35
ericsnownatefinch: ah, my old enemy, table-driven tests16:35
natefinchvery small fix16:35
natefinchericsnow: yeah.... I like them, but they're easy to abuse16:36
ericsnownatefinch: I just used them for systemd to great effect (because they were a good fit)16:36
TheMuenatefinch: done16:42
ericsnownatefinch: done16:42
TheMueericsnow: h516:42
ericsnowTheMue: :)16:46
dimiternTheMue, you have a review16:50
dooferladTheMue / dimitern: could you point me to where we construct the libvirt domain XML? We seem to have no network defined for kvm16:50
TheMuedimitern: thanks and good hint, I like it16:51
natefinchwhoever told me to write a test that fails before I write a bugfix was a genius.  I would have wasted so much time over my career if I didn't do that.16:51
ericsnownatefinch: :)16:52
dimiternTheMue, np :)16:53
natefinchthat's how I found that missing defer os.SetEnv(k, "").  I wrote a test that should have failed... and it didn't.16:53
dimiterndooferlad, we use uvt-kvm for that, which I believe creates the XML for us (or uses virsh underneath or something)16:53
TheMuenatefinch: hehe, currently doing the same with my actual fix. first a test to simulate the failure and then change to remove it again16:53
dooferladdimitern: just found that :-)16:53
dooferladdimitern: typical, spend 10 minutes looking, go for tea, come back, ask on IRC and it just pops up in front of me.16:54
dimitern:D16:54
perrito666meh non capturin groups are not something to be found in grep regexes?16:57
mgzyou can always use grep -P17:00
perrito666mgz: I am actually using supercat17:01
perrito666to color my tests output so I can make more sense of them17:01
perrito666but I try to use a non capturing group to make a match of json dicts17:02
perrito666and it tells me that its not a valid syntax17:02
mgzwell, generic answer then is yeah, not all regexp dialects support non-capturing groups17:02
* perrito666 cries17:02
natefinchperrito666: http://stackoverflow.com/questions/27242652/colorizing-golang-test-run-output17:05
natefinchperrito666: also: http://bit.ly/1A4eY7v17:06
perrito666natefinch: trust me youll like what I am doing17:09
perrito666:D, it mostly colorizes the output of the logs between test failures17:09
perrito666I donr really care for tsts when they pass17:09
natefinchperrito666: also: https://github.com/natefinch/nolog17:11
marcoceppixwwt__: abentley: why isn't this marked as a regression? https://bugs.launchpad.net/juju-core/+bug/142406917:13
mupBug #1424069: juju resolve doesn't recognize error state <resolved> <juju-core:Triaged> <https://launchpad.net/bugs/1424069>17:13
marcoceppialexisb: ^17:14
* marcoceppi is trying to figure out what constitutes a critcal bug vs a high bug17:14
perrito666natefinch: mgz this is the kind of output I am getting http://www.webdevout.net/test?01MH17:15
abentleymarcoceppi: I agree, it looks like a regression to me.  Curtis did the triage, but unfortunately, he's out today.17:15
marcoceppiabentley: cool, it's making our testing of actions in trunk a bit difficult17:17
xwwt__abentley: Looks like the inline comments issues are important, but were deprioritized to work on git.  Sounds like they will be added back to the list.17:18
abentleymarcoceppi: We don't have any functional tests of "resolve", but maybe we should.17:18
natefinchperrito666: you could modify the code in my nolog application to change the output to include color17:18
=== xwwt__ is now known as xwwt
marcoceppiabentley: O17:18
marcoceppiabentley: I'd argue there should be, but I'm biased ;)17:18
mgzmarcoceppi: the bug was just confused by the report/unreport/report cycle17:19
marcoceppiit's still an issue in trunk fwiw17:19
perrito666natefinch: you have a severe case of NIH17:19
perrito666natefinch: although I might17:19
=== kadams54 is now known as kadams54-away
natefinchperrito666: I have a severe case of wanting to use a real programming language to write applications17:20
abentleymarcoceppi: We (Juju QA) only functionally test a few commands: bootstrap, deploy, upgrade-juju, add-relation, backup, restore, ensure-ha.  The bulk of tests are juju-core's unit tests.17:20
marcoceppiabentley: makes sense17:20
marcoceppiabentley: is there liek a repo of the functional tests?17:21
abentleymarcoceppi: All our testing stuff is in lp:juju-ci-tools17:21
marcoceppiabentley: cool17:22
perrito666natefinch: I am pretty sure supercat is written in a real programming language, I just configured it17:22
perrito666natefinch: its in C, which beats go in what refers to "real programming language" ;)17:24
ericsnowcmars: thanks for your help18:09
cmarsericsnow, de nada18:20
jw4perrito666, the first few pages of google on 'supercat' don't seem relevant ...18:54
perrito666jw4: yes, anything with cat on the name sucks for googling18:57
perrito666jw4: man supercat18:57
perrito666no man spc18:57
jw4ah18:57
jw4apt search supercat wasn't helpful either - I should have thought of the actual command name in your snippet18:58
perrito666jw4: seems to be a rather old tool18:59
jw4hmm apt-get install supercat worked now cool19:00
perrito666well it seems supercat was too much for him :p19:01
natefinchcrap, how did I manage to disable my scroll wheel in my editor? :/19:57
perrito666you are a talented person19:59
* natefinch reboots... can't function w/o scroll wheel in editor.20:08
ericsnowcould I get a review on a tiny patch I have up: http://reviews.vapour.ws/r/1100/20:19
ericsnowand on an only slightly bigger one: http://reviews.vapour.ws/r/1099/20:20
natefinchgah, I hate it when err == nil means something is wrong... it just makes the code so hard to follow.20:25
natefinchdammit... that feeling when you realize you waited forever for amazon to bootstrap only to realize you forgot --upload-tools20:38
perrito666natefinch: lool20:39
perrito666natefinch: I upload my own stream20:39
perrito666and its all in the ctrl+r :p20:39
marcoceppiI'm getting a weird error trying to deploy behind a proxy20:47
marcoceppihttp://paste.ubuntu.com/10552644/20:48
natefinchmarcoceppi: I think that's the 409 error code "Conflict"  no idea why you'd be getting that20:50
natefinchhttp 409 error code that is20:51
marcoceppiright, not idea why I'm getting it or how to get more information20:51
natefinchtry with curl?  It sounds like there's a problem with the proxy20:52
marcoceppinatefinch: it works on teh local system using wget20:52
marcoceppihttp://paste.ubuntu.com/10552661/20:52
marcoceppiah, there we go20:53
marcoceppiapparently you have to put the /right/ proxy in the configuration20:53
marcoceppiwhen running wget from the bootstrap node, I got this "Proxy tunneling failed: ConflictUnable to establish SSL connection."20:54
marcoceppiwell, now it just hangs, which I guess is progress20:56
natefinchhaha20:57
marcoceppiblarg20:59
marcoceppiit's not respecting my proxy port20:59
marcoceppihttp://paste.ubuntu.com/10552707/21:00
marcoceppihow have we made it this far without hitting this in other canonical infrastructures21:00
marcoceppiany suggestions :/21:05
natefinchmarcoceppi: so your proxy is trying to redirect to a different port, too?21:11
marcoceppinatefinch: it looks like Juju is trying to use port 44321:11
marcoceppion the bootstrap node just doing a curl works21:11
natefinchmarcoceppi: it's using 443 because it's HTTPS21:11
marcoceppinatefinch: but the proxy isn't running on 443, just because 443 is a common convention does not mean it's the sole port that HTTPS traffic operates on21:12
marcoceppimy https_proxy line defines a port21:12
marcoceppinatefinch: looking at the unit tests, for config.go, it never tests aproxy address with a port21:16
* marcoceppi tries to patch21:16
marcoceppiactually Ihave no idea what I'm doing21:17
natefinchlol21:17
marcoceppiI didn't think grep "proxy" * would return so many hits21:18
natefinchI honestly don't know if we're supposed to support changing the port or not.... I mean, it sounds like we don't, obviously21:19
marcoceppiwell everything else does21:19
natefinchI understand that, and it does seem completely reasonable21:19
marcoceppiI mean, in canonical we use squid.internal:3128 for http and https, which is why I'm hitting this21:20
marcoceppibut I'm not sure if that's the acutal issue or if I'm just doing something wrong21:20
natefinchI don't see anything in the proxy code about ports, so it's likely they just weren't considered21:21
=== kadams54 is now known as kadams54-away
marcoceppiwell it's setting it properly on the host machine, just when consuming it, it seems to do something odd21:22
marcoceppiI'll report a bug for now21:23
marcoceppihum, actually21:23
marcoceppithat's my bad, the IP address is actually for store.juju.ubuntu.com and not the proxy address21:24
marcoceppiso something else seems broken21:24
marcoceppinvm, it works now21:25
* marcoceppi hangs head in shame21:25
marcoceppithis is probably a good time to just EOW21:25
natefinchhasha21:26
natefinchhaha21:26
natefinchhave a good weekend :)21:26
marcoceppithanks for entertaining my crazy natefinch o/21:28
ericsnownatefinch: the releases page updated with your joyent fix: http://reports.vapour.ws/releases/242021:28
ericsnownatefinch: it isn't "blessed" because of unstable joyent substrate21:28
ericsnownatefinch: coincidence?21:28
=== kadams54-away is now known as kadams54
natefinchericsnow: actually t he joyent tests are passing there, looks like21:29
ericsnownatefinch: ah, nevermind; looks like it just didn't identify the failing voting test at the top of the page21:32
=== kadams54 is now known as kadams54-away
=== kadams54-away is now known as kadams54
=== kadams54 is now known as kadams54-away

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!