[15:38] larsu, can you please take a look at https://code.launchpad.net/~l3on/ubuntu-themes/csd-fix-resize-and-shadow/+merge/252992 . [15:38] Thanks in advance! [17:10] l3on: we're unfortunately having troubles in supporting shadows in compiz side :( [17:11] Trevinho, that's a patch for the theme, nothing more. What about compiz? [17:12] l3on: I know, but the fact is when enabling shadows, gtk windows defines a gtk_frame_extent, that compiz should ignore... but doing that is currently breaking some other stuff [17:12] like resizing ? [18:35] l3on: ya, this depends on compiz, which is why we don't have this yet [18:35] l3on: I also don't like the padding (and it shouldn't be in the same commit) [18:39] l3on: btw, this branch contains some headerbar fixes if you're interested: lp:~larsu/ubuntu-themes/titlebars [18:39] it makes the decoration buttons look more like unity's [20:26] larsu, Trevinho ok I got it ... we need Compiz as "shadow maker". That's clear... Anyway, such kind of changes (the ones I proposed) could be a temporary workaround... no? [20:26] larsu, ah.. interesting branch, the icons are too big... aren't they ? [20:28] l3on: by one pixel... [20:30] larsu, I think that part of code should be in the same file of unity's one. I mean, instead of having a "apps/unity.css", it may have sense have a "windows.css" [20:32] larsu, about padding: I found nice the padding added to nautilus titlebar.. buttons are bigger, it's true.. and (from my point of view) they are so because of the importance ... if a button is in HeaderBar you may assume it has a "primary function" in the app... [20:32] that's way they are put in the HeaderBar. (imho) [20:32] l3on: I put it in unity.css because it already existed [20:33] unity uses little padding almost everywhere [20:33] I don't think adding a lot of padding to those buttons makes sense [20:39] In my opinion, this: http://i.imgur.com/0WYFu0H.png [20:39] is better than this: http://i.imgur.com/csPHkRG.png [20:41] (larsu unity.css is untouched, you used gtk-widgets.css.. that's why I said that) [20:41] oh, indeed [20:41] meh :) [20:42] I like the one with more padding as well, but I feel that it's not consistent with the rest of the theme [20:43] Not really .. padding comes from nautilus bar :) [20:44] larsu, see this http://i.imgur.com/uIoxm10.png [20:45] that's a toolbar, though [20:45] not sure - we can add it if people like it [20:45] ok... [20:45] but as I said, please don't put it in the same merge request so that we can have some discussion about it [20:46] * larsu has a feeling people will hate us if we widen their title bars [20:46] also, all of this is irelevant until compiz gets fixes [20:46] *fixed [20:46] sadly :( [20:46] so, with compiz "fixed" every windows will be decorated via compiz itself ? [20:47] that would be the fallback if implementing GTK_FRAME_EXTENTS fails [20:47] not sure what the status is on that [20:48] if we get frame extents, we can draw the shadows client side and resizing at the window border will still work [20:49] Just for the log: GTK_FRAME_EXTENTS has been dropped since GTK 3.13.1 [20:50] l3on: really? In favor of what? [20:52] gdk_x11_window_set_shadow_width() still sets it... [20:57] larsu, I think now GTK checks only for gdk_screen_is_composited and has alpha (rgba). In 3.12 the library was sending a Xatom named _GTK_FRAME_EXTENTS to check the support .. [20:58] larsu, now look at gtkwindow.c/gtk_window_supports_csd [20:59] so, in compiz you may not want to catch the GTK_FRAME_EXTENTS atom... [20:59] but how does it find out the actual extents of the window if we draw a shadow client side? [21:00] and like I said, it still sets the atom unconditionally on x11 [21:02] gdk_x11_window_set_shadow_width is used only in a deprecated (since 3.12) function ... so we can asssume it deprecated as well [21:04] l3on: no, it's the vfunc for gdk_window_set_shadow_width() [21:04] which is not deprecated [21:05] and the atom is still set on my machine [21:05] for windows with csd, of course [21:10] you're right. [21:11] the GTK says this: http://paste.ubuntu.com/10606460/ [21:11] I misunderstood it. [21:12] ah, makes sense [21:12] no worrie [21:17] larsu, ok, padding removed. I will prepare another merge request [21:19] gtg