thumper | fark | 00:00 |
---|---|---|
thumper | I thought this was a small branch | 00:00 |
thumper | $ git diff master | wc -l | 00:00 |
thumper | 973 | 00:00 |
thumper | 15 files changed, 467 insertions(+), 174 deletions(-) | 00:00 |
thumper | hmm... menno is reviewer | 00:00 |
thumper | no worries then | 00:00 |
* thumper goes to write more tests :) | 00:01 | |
=== kadams54 is now known as kadams54-away | ||
=== kadams54-away is now known as kadams54 | ||
=== kadams54 is now known as kadams54-away | ||
menn0 | thumper: screw you hippie :) | 00:39 |
* thumper bows | 00:40 | |
thumper | oh fuck | 00:41 |
thumper | hmm... | 00:41 |
* thumper found an interesting bug^Wfeature | 00:42 | |
thumper | FINE | 01:01 |
thumper | IF THAT IS THE WAY IT'S GOING TO BE... | 01:01 |
* thumper beats the code into submission | 01:01 | |
jw4 | fwereade: if you get a chance in the morning could you review http://reviews.vapour.ws/r/1181/ ? | 01:19 |
jw4 | fwereade: I've updated with good feedback from perrito666 and dimitern | 01:20 |
thumper | menn0: got a few minutes to discuss a testing approach? | 01:34 |
* thumper grumbles | 01:43 | |
thumper | davecheney: can I pass around an unbound method as a func to call on a target? | 01:44 |
* thumper recalls the following | 01:46 | |
thumper | type foo struct {} | 01:46 |
thumper | func (f *foo) method(param string) error {...} | 01:47 |
thumper | foo.method -> func (*foo, string) error | 01:47 |
thumper | ... | 01:47 |
thumper | that'll work | 01:47 |
menn0 | thumper: back now. standup hangout? | 01:48 |
thumper | yea | 01:48 |
mup | Bug #1433384 was opened: utopic unit-test failure: TrackerSuite.TestWaitMinionBecomeMinion <ci> <i386> <regression> <test-failure> <utopic> <juju-core:Triaged> <https://launchpad.net/bugs/1433384> | 01:54 |
mup | Bug #1433384 changed: utopic unit-test failure: TrackerSuite.TestWaitMinionBecomeMinion <ci> <i386> <regression> <test-failure> <utopic> <juju-core:Triaged> <https://launchpad.net/bugs/1433384> | 02:07 |
mup | Bug #1433384 was opened: utopic unit-test failure: TrackerSuite.TestWaitMinionBecomeMinion <ci> <i386> <regression> <test-failure> <utopic> <juju-core:Triaged> <https://launchpad.net/bugs/1433384> | 02:13 |
thumper | menn0: what do you think about having the function api.OpenWithLoginV1 exported publicly? | 02:17 |
thumper | menn0: that way we can call it from the apiserver package | 02:17 |
menn0 | thumper: it's a little ugly but it doesn't bug me that much | 02:19 |
* thumper nods | 02:19 | |
menn0 | thumper: perhaps it should be OpenWithVersion | 02:19 |
thumper | but that implies it takes an arg | 02:20 |
thumper | but it doesn't | 02:20 |
menn0 | thumper: would that make sense? then there'd be just one call to let people get at any version. | 02:20 |
thumper | hmm... | 02:21 |
thumper | perhaps | 02:21 |
menn0 | thumper: but could it take an arg | 02:21 |
menn0 | ? | 02:21 |
thumper | yes | 02:21 |
thumper | we could switch on the version | 02:21 |
thumper | and error on unknown | 02:21 |
menn0 | thumper: why do you really need to export it from apiserver? | 02:21 |
thumper | it is an api client function right now | 02:21 |
thumper | and I want to use it in the apiserver package | 02:22 |
* thumper hunts for some books of equal height | 02:22 | |
menn0 | thumper: right I see. | 02:22 |
* thumper is trying standing up | 02:22 | |
thumper | Beginning GIMP is the same thickness as Generative Programming | 02:23 |
* thumper is winning | 02:23 | |
menn0 | :) | 02:23 |
thumper | hmm... that's better | 02:23 |
thumper | keyboard was a little low before | 02:23 |
menn0 | thumper: just thought some more about it | 02:24 |
thumper | yus... | 02:24 |
menn0 | thumper: and it seems ok | 02:24 |
thumper | which bit? | 02:25 |
menn0 | thumper: esp if there's a docstring saying that it's mainly for testing | 02:25 |
thumper | exporting one that takes a version | 02:25 |
* thumper nods | 02:25 | |
thumper | will do | 02:25 |
menn0 | thumper: either is ok | 02:25 |
thumper | and I'll have it take a version number | 02:25 |
thumper | I think it is a little more flexible | 02:25 |
menn0 | thumper: but i prefer the version taking form | 02:25 |
thumper | ack | 02:25 |
* thumper takes a deep breath and ignores a little mess | 02:26 | |
* thumper makes a note to clean it up next | 02:26 | |
thumper | menn0: I'm not sure I'm going to get all this done before 6 today | 02:30 |
thumper | menn0: as I have a parent-teacher interview at 4 | 02:30 |
thumper | and a class at 5 | 02:30 |
thumper | but I'll finish it off tongiht | 02:30 |
thumper | menn0: I don't expect you to review it today (maybe tomorrow) :) | 02:31 |
menn0 | thumper: np | 02:32 |
axw | wallyworld: http://reviews.vapour.ws/r/1193/ | 03:48 |
wallyworld | ok | 03:48 |
menn0 | anyone able to review this? http://reviews.vapour.ws/r/1192/ | 03:49 |
menn0 | it's a fix for a problem I introduced that is preventing compilation on i386 | 03:50 |
wallyworld | axw: i've done the go-amz mods ti support volumes, writing tests. had to update v4-unstable branch with latest v3 changes, conflicts due to stupid paths in imports. that shits me no end with Go | 03:50 |
wallyworld | menn0: looking | 03:50 |
thumper | menn0: class is at 6 not 5 | 03:50 |
thumper | so I'm about to push this branch up | 03:50 |
menn0 | thumper: ok, bring it on | 03:50 |
thumper | 20 files changed, 588 insertions(+), 192 deletions(-) | 03:51 |
* menn0 warms up his review issue fingers | 03:51 | |
wallyworld | menn0: i just left a suggestion, not that important | 03:54 |
menn0 | wallyworld: good idea. i'll do that. | 03:54 |
thumper | hmm... | 03:57 |
thumper | why is reviewboard not picking that up | 03:57 |
thumper | menn0: https://github.com/juju/juju/pull/1868 | 03:57 |
menn0 | thumper: cool. i'll do that next. | 03:58 |
menn0 | looks like CI is blocked at the moment | 04:06 |
menn0 | bug 1433384 | 04:06 |
mup | Bug #1433384: utopic unit-test failure: TrackerSuite.TestWaitMinionBecomeMinion <ci> <i386> <regression> <test-failure> <utopic> <juju-core:Triaged> <https://launchpad.net/bugs/1433384> | 04:06 |
menn0 | thumper: your PR didn't make it to RB? | 04:07 |
* thumper shrugs | 04:08 | |
thumper | NFI | 04:08 |
menn0 | thumper: i'll review on GH | 04:10 |
thumper | this standing desk thing has my shoulders aching | 04:13 |
thumper | less hunching and more hanging I guess | 04:13 |
rick_h_ | thumper: time to go to walking desk :) | 04:19 |
ericsnow | thumper: FYI, that RB problem is a bug in my hook code where it cannot handle unicode properly (yay 7 year old Python version) | 04:20 |
ericsnow | thumper: from time to time Github sends unicode in the request (or we have some in our code somewhere) | 04:20 |
ericsnow | thumper: once the vivid stuff settles down I'm planning on fixing it | 04:21 |
wallyworld | axw: reviewed, sorry about delay, pool man was here | 04:29 |
axw | wallyworld: nps, thanks | 04:29 |
thumper | ericsnow: ah... I was wondering what it was | 04:34 |
ericsnow | thumper: yeah, it's the most common reason why the hook fails | 04:35 |
thumper | ok, handy to know | 04:35 |
thumper | I'm going to head off to my boxing class now | 04:35 |
thumper | time to hit things hard | 04:35 |
menn0 | thumper: review done | 04:35 |
ericsnow | thumper: the other is when a branch get's rebased against an incompatible base revision to the original | 04:35 |
thumper | menn0: awesome thanks | 04:35 |
thumper | menn0: I was wondering about the restricted root ordering | 04:35 |
thumper | it seemed weird to do work that you were going to throw away | 04:35 |
thumper | but I'll look for the method first | 04:36 |
thumper | for consistency | 04:36 |
thumper | with the other methods | 04:36 |
ericsnow | menn0: thanks for pointing out filepath.EvalSymlinks | 04:36 |
ericsnow | menn0: I've updated the patch | 04:36 |
menn0 | thumper: yeah it does looks weird but I did put some thought into it for upgradingRoot | 04:36 |
thumper | laters peeps | 04:36 |
thumper | menn0: ack, will address tomorrow | 04:36 |
menn0 | ericsnow: no problems | 04:36 |
ericsnow | thumper: o/ | 04:36 |
menn0 | ericsnow: i've got to finish up in a sec so i might not be able to get back to your PR until tomorrow | 04:37 |
ericsnow | menn0: no worries | 04:37 |
ericsnow | menn0: thanks for the reviews | 04:38 |
ericsnow | menn0: we kept you busy today | 04:38 |
ericsnow | menn0: I'll probably have someone else wrap up the review so I that we can maybe release 1.23b1 tomorrow | 04:39 |
jw4 | menn0: thanks for the review, and the kind words :) | 04:39 |
menn0 | ericsnow: np | 04:40 |
menn0 | jw4: np | 04:40 |
menn0 | ericsnow: i just managed to sneak another review in | 04:44 |
menn0 | ericsnow: one problem, but otherwise ship it | 04:44 |
ericsnow | \o/ | 04:44 |
ericsnow | menn0: a pity review :) | 04:44 |
wwitzel3 | ericsnow: what are you still doing here? | 04:58 |
ericsnow | wwitzel3: just checking on reviews before going to bed :) | 05:07 |
axw | wallyworld: I've proposed another couple of branches. I'll now look at the last bits required to populate filesystem info for filesystems-on-volumes | 06:14 |
axw | can't land anything atm, as trunk is blocked | 06:14 |
wallyworld | axw: ok, i'm still plowing through writing tests for the go-amz work, have to go to soccer soon, may look after i get back. i expect tmorrow we'll have EBS volume source working | 06:17 |
axw | wallyworld: awesome :) | 06:18 |
wallyworld | axw: oh, and that will include attach, detach | 06:18 |
axw | great | 06:18 |
axw | wallyworld: I haven't removed VolumeParams.Attachment yet, will defer that for now | 06:18 |
axw | but it's still necessary to have separate attach/detach anyway | 06:19 |
wallyworld | axw: sure, np, yep | 06:19 |
wallyworld | and it's not much extra work to do it up front | 06:19 |
dimitern | wallyworld, hey there, do you know if thumper's on leave? | 06:35 |
wallyworld | dimitern: he was here before, but it's past his EOD now | 06:48 |
dimitern | wallyworld, yeah, I was wondering about that i386 issue, but I've seen menn0 proposed a fix for it.. and now we have another blocker | 06:49 |
wallyworld | i saw the i386 fix (reviewed it) but hadn't seen the other blocker | 06:49 |
dimitern | #1433384 - some leadership fallout it seems | 06:51 |
mup | Bug #1433384: utopic unit-test failure: TrackerSuite.TestWaitMinionBecomeMinion <ci> <i386> <regression> <test-failure> <utopic> <juju-core:Triaged> <https://launchpad.net/bugs/1433384> | 06:51 |
=== urulama|afk is now known as urulama | ||
dimitern | fwereade, hey | 08:36 |
fwereade | dimitern, heyhey | 08:37 |
dimitern | fwereade, I wonder if you can clarify the logic around worker/leadership/tracker_test.go - the durations chosen | 08:37 |
dimitern | fwereade, seems like refreshes() picks a halfRefreshes in the order or a few nanoseconds, which leads to frequent failures in TestWaitMinionBecomeMinion | 08:38 |
dimitern | fwereade, that's related to the current blocker for 1.23 - bug 1433384 | 08:39 |
mup | Bug #1433384: utopic unit-test failure: TrackerSuite.TestWaitMinionBecomeMinion <ci> <i386> <regression> <test-failure> <utopic> <juju-core:Triaged> <https://launchpad.net/bugs/1433384> | 08:39 |
fwereade | dimitern, hmm, did I screw up the logic? it ought to always pick (2n+1)/2 * coretesting.ShortWait for integer N | 08:40 |
dimitern | fwereade, hmm so that looks like it needs to yield a duration around 1.5 - 2.5 x shortWait | 08:42 |
fwereade | dimitern, yeah, it shouldn't ever return anything less than half shortWait | 08:42 |
fwereade | dimitern, and looking at the code I can't immediately see how it's not doing that | 08:43 |
dimitern | fwereade, depending on N ofc; the trouble is if you run the worker/leadership tests a few times - that same test (and only it so far I can see) fails - it happens to me about 50% of the time | 08:43 |
dimitern | fwereade, hmm, actually it's a lot less than 50% | 08:45 |
dimitern | fwereade, can you try running this on 1.23 in worker/leadership?: time go test -c && for i in `seq 50`; do ./leadership.test & sleep 0.01; done | 08:45 |
fwereade | dimitern, yeah, it looks like I *can*induce failures, but I'm not seeing the one you mentioned above | 08:46 |
dimitern | fwereade, but is the ultimate failure the same - got unexpected readiness: true ? | 08:47 |
mattyw | morning all | 08:47 |
dimitern | mattyw, o/ | 08:47 |
fwereade | dimitern, afraid not -- I'm seeing occasional failures to unblock the release goroutine in TestFailGainLeadership | 08:47 |
fwereade | mattyw, o/ | 08:48 |
fwereade | dimitern, and they're not guaranteed to trigger, whether running with seq 50 or seq 500 | 08:49 |
dimitern | fwereade, :) ok, there goes my one clue of the cause of the failure | 08:50 |
dimitern | fwereade, I'll experiment on i386 to see if it makes a difference | 08:51 |
fwereade | dimitern, hmm, seq 5000 seems to be stressing it a bit more, I managed to get 21 failures -- but *all* of them are in unblockRelease :/ | 08:55 |
dimitern | fwereade, are you using go 1.2.1 from the archive? | 08:55 |
fwereade | dimitern, hmm, looks like I'm on 1.2 actually | 08:56 |
fwereade | dimitern, (I think the unblockRelease *is* an issue actually -- we ought to have a generous timeout there instead of the default: case) | 08:57 |
dimitern | fwereade, right, sounds fair | 08:57 |
fwereade | dimitern, yeah, with coretesting.LongWait in unblockRelease I can do seq 5000 without failures | 09:00 |
dimitern | fwereade, nice! well, if I have success with that other test on i386 I can propose a fix for both | 09:04 |
fwereade | dimitern, cool, thanks | 09:08 |
dimitern | fwereade, it gets weirder.. on a i386 machine even with seq 5000 I couldn't reproduce the TestWaitMinionBecomeMinion failure | 09:32 |
fwereade | dimitern, blargh | 09:33 |
dimitern | fwereade, I had ~25 failures and all of them related to unblockRelease | 09:33 |
* fwereade out, laura's school, bbs | 09:55 | |
dooferlad | dimitern, voidspace, TheMue: hangout? | 10:02 |
voidspace | dooferlad: yes | 10:02 |
dimitern | dooferlad, sorry, omw | 10:02 |
natefinch | I need to be able to alias juju destroy-enviroment to juju destroy-environment | 10:41 |
natefinch | ...or learn to type/spell | 10:41 |
mattyw | natefinch, juju burn-more-fossil-fuels? | 11:27 |
mattyw | natefinch, would you mind taking another look at http://reviews.vapour.ws/r/1005/? I'm going to fix the test up - but I'll do it in a follow up | 11:36 |
mup | Bug #1433566 was opened: Precise unit test failure discoverySuite.TestDiscoverInitSystemScript <ci> <precise> <regression> <test-failure> <juju-core:Triaged> <https://launchpad.net/bugs/1433566> | 12:29 |
voidspace | virt-manager changes the owner of iso images you use to create kvm images from! | 12:36 |
dimitern | voidspace, yeah, because they're in added to the libvirt storage pool | 12:37 |
voidspace | dimitern: the iso image? | 12:37 |
voidspace | that seems unfriendly | 12:37 |
dimitern | voidspace, indeed | 12:37 |
voidspace | dimitern: I can now create a storage pool - but can't read the iso image. Which is odd. I think it's because the iso image is behind a symlink | 12:38 |
voidspace | well, copying elsewhere worked - for whatever reason | 12:39 |
dimitern | voidspace, :) go figure | 12:39 |
voidspace | dimitern: I think the type of access it uses doesn't like symlinks | 12:41 |
voidspace | block level | 12:41 |
dimitern | voidspace, why are there symlinks in there? | 12:42 |
voidspace | dimitern: I moved the directory and left a symlink in the old location | 12:43 |
voidspace | dimitern: ~/Downloads | 12:43 |
voidspace | dimitern: it's where the iso image is | 12:43 |
voidspace | dimitern: for the storage volumes I used bind mount to move them | 12:44 |
voidspace | dimitern: which may or may not be necessary - but works | 12:44 |
voidspace | dimitern: I just needed to set the right owner/group on the files as well | 12:44 |
dimitern | voidspace, hmm bind mounts should work better than symlinks | 12:46 |
dimitern | voidspace, can't you specify default owner/perms at mount time of the bind? | 12:47 |
voidspace | dimitern: the bind mount is working fine | 12:49 |
voidspace | dimitern: the ~/Downloads symlink is also fine normally | 12:49 |
voidspace | dimitern: it's just that because it's a symlink virt-manager can't get block level access to iso images there | 12:50 |
voidspace | dimitern: I should have specified the full path instead of via the symlink - just habit | 12:50 |
dimitern | voidspace, ah, I got you | 12:50 |
dimitern | fwereade, are you around? | 12:50 |
mup | Bug #1433577 was opened: Vivid unit tests need to pass <ci> <test-failure> <vivid> <juju-core:Triaged> <https://launchpad.net/bugs/1433577> | 12:59 |
mup | Bug #1433577 changed: Vivid unit tests need to pass <ci> <test-failure> <vivid> <juju-core:Triaged> <https://launchpad.net/bugs/1433577> | 13:05 |
mup | Bug #1433577 was opened: Vivid unit tests need to pass <ci> <test-failure> <vivid> <juju-core:Triaged> <https://launchpad.net/bugs/1433577> | 13:11 |
natefinch | mattyw: that severity is different than the severity you were using before... is that right? | 13:35 |
mattyw | natefinch, it's changed a little bit, the logic had changed with it though yes | 13:53 |
mattyw | natefinch, I think this order makes more sense | 13:53 |
ericsnow | dimitern: FYI, bug 1433577 looks like the same issue as bug 1433384, but on vivid | 13:57 |
mup | Bug #1433577: Vivid unit tests need to pass <ci> <test-failure> <vivid> <juju-core:Triaged> <https://launchpad.net/bugs/1433577> | 13:57 |
mup | Bug #1433384: unit-test failure: TrackerSuite.TestWaitMinionBecomeMinion <ci> <i386> <regression> <test-failure> <utopic> <juju-core:In Progress by fwereade> <https://launchpad.net/bugs/1433384> | 13:57 |
dimitern | ericsnow, well part of it is | 13:58 |
ericsnow | dimitern: right | 13:58 |
dimitern | ericsnow, fwereade is already on #1433384 btw | 14:00 |
mup | Bug #1433384: unit-test failure: TrackerSuite.TestWaitMinionBecomeMinion <ci> <i386> <regression> <test-failure> <utopic> <juju-core:In Progress by fwereade> <https://launchpad.net/bugs/1433384> | 14:00 |
ericsnow | dimitern: ah, great | 14:00 |
dimitern | ericsnow, I wanted to check something with you re systemd support | 14:01 |
ericsnow | dimitern: sure | 14:02 |
dimitern | ericsnow, looking at https://github.com/juju/juju/blob/master/container/lxc/clonetemplate.go#L129-L172 | 14:02 |
ericsnow | dimitern: yep | 14:03 |
dimitern | ericsnow, and the corresponding test - https://github.com/juju/juju/blob/master/container/lxc/lxc_test.go#L811-L841 | 14:03 |
dimitern | ericsnow, do you think this will work for systemd? I mean for upstart it does (it's live tested), but I wasn't sure if you can have multiple commands in ExecStart (provided all of them have abs. paths) | 14:04 |
ericsnow | dimitern: systemd only allows a single command for ExecStart (or any Exec*) | 14:06 |
ericsnow | dimitern: however, the systemd code in juju turns a multi-line ExecStart into a separate shell script that ExecStart then calls | 14:06 |
dimitern | ericsnow, so it will work? | 14:08 |
ericsnow | dimitern: it should work fine; I'll look more closely at it in a minute | 14:09 |
perrito666 | ericsnow: wwitzel3 ? | 14:09 |
dimitern | ericsnow, thanks! | 14:09 |
mup | Bug #1433615 was opened: Manual provider fails to bootstrap: failed to check provisioned status ... /: Is a directory <bootstrap> <ci> <manual-provider> <regression> <juju-core:Triaged> <https://launchpad.net/bugs/1433615> | 14:29 |
alexisb | natefinch, ericsnow, fwereade, dimitern thank you all for tackling critical bugs for 1.23 quickly | 14:45 |
ericsnow | alexisb: blame my feeling of guilt :) | 14:46 |
alexisb | ericsnow, given the number of features we landed in 1.23 we will be seeing a fair amount of guild :) | 14:47 |
alexisb | we will just need to tackle the bugs quickly and get things hardened and stable, ready for the release | 14:48 |
dimitern | ericsnow, :) guilt usually works for me as well | 14:48 |
dimitern | alexisb, thanks! | 14:49 |
ericsnow | fwereade: you free to meet briefly? | 15:06 |
fwereade | ericsnow, oops, sorry, with you in 2 | 15:07 |
ericsnow | fwereade: no worries | 15:07 |
=== kadams54 is now known as kadams54-away | ||
=== kadams54-away is now known as kadams54 | ||
=== kadams54 is now known as kadams54-away | ||
fwereade | mgz, sinzui: FATAL: Unable to delete script file /tmp/hudson7105716500738528055.sh ? | 16:02 |
natefinch | gah, why the heck is machine 0 running without the environmanager job when it first boots up? :/ | 16:02 |
natefinch | oops, nevermind... figured out what I was doing wrong :) | 16:04 |
=== kadams54-away is now known as kadams54 | ||
natefinch | man I hate it when people type assert stuff and then if the type assert fails... don't tell me what type it actually was in the error - https://github.com/juju/juju/blob/master/apiserver/watcher.go#L90 | 16:41 |
jw4 | natefinch: at least log the type right? | 16:49 |
jw4 | natefinch: not sure if it's a potential security issue to reveal the type in the error? | 16:50 |
* jw4 out for a couple hours | 16:51 | |
fwereade | dimitern, can you clarify http://reviews.vapour.ws/r/1165/diff/3/?file=42926#file42926line396 ? | 17:22 |
fwereade | dimitern, that's a comment I added (in what I thought was the right place) to address my remembering someone had once asked why we did that, and that it wasn't immediately clear from context | 17:23 |
fwereade | dimitern, if I explained it nearer the top of the method it'd be further away from the code it's explaining and likely to rot even faster than most comments | 17:24 |
natefinch | fwereade: I hate that this code doesn't differentiate between "not found" and "wrong type" :/ https://github.com/juju/juju/blob/master/apiserver/watcher.go#L90 | 17:48 |
=== kadams54 is now known as kadams54-away | ||
=== kadams54-away is now known as kadams54 | ||
fwereade | natefinch, I think the error is reasonable for both cases, but yes, when debugging you'd probably want to know more | 18:00 |
fwereade | abentley, if you're around I appear to have broken the bot with http://juju-ci.vapour.ws:8080/job/github-merge-juju/2552/ | 18:01 |
abentley | fwereade: looking... | 18:09 |
abentley | fwereade: do you have an idea what the cause is here? I don't understand why it can't delete the script. I can (try to) delete the script, but I imagine the same thing will happen with the next run. | 18:14 |
fwereade | abentley, I have no idea, I'm afraid | 18:14 |
abentley | fwereade: AFAICT, the script is being deleted by jenkins, and it has 0644 with ownership jenkins:jenkins, and /tmp (the parent directory) is 0777 | 18:16 |
abentley | fwereade: I might as well try | 18:17 |
abentley | fwereade: I've deleted the script and triggered a rebuild. | 18:17 |
abentley | fwereade: It seems to be getting further: http://juju-ci.vapour.ws:8080/job/github-merge-juju/2553/console | 18:19 |
fwereade | abentley, cool, thanks | 18:19 |
voidspace | dimitern: ping | 18:29 |
voidspace | dimitern: you shouldn't be here even if you are :-) | 18:29 |
voidspace | dimitern: but just in case... | 18:29 |
voidspace | dimitern: running upgrade with loggging shows that the life field is correctly set to "dead" for a destroyed container IP address | 18:30 |
voidspace | dimitern: so I'm proposing the logging branch (just two logging lines) | 18:30 |
voidspace | dimitern: and moving onto the worker | 18:30 |
=== arosales_ is now known as arosales | ||
natefinch | you know it's bad when I can't even tell WTF is going on with a full traceback. | 19:11 |
natefinch | this watcher code is a twisted mess | 19:11 |
perrito666 | natefinch: there are worse, beware of what you wish | 19:21 |
perrito666 | I have been around watcher when changin state, need a hand? | 19:21 |
natefinch | perrito666: yeah... just trying to debug why this watcher is causing an error | 19:23 |
natefinch | perrito666: brb | 19:24 |
perrito666 | heh, seems my help causes people to flee :p | 19:24 |
natefinch | perrito666: back | 19:28 |
natefinch | perrito666: let's jump in moonstone | 19:28 |
=== kadams54 is now known as kadams54-away | ||
natefinch | wwitzel3: you around? | 19:38 |
=== kadams54 is now known as kadams54-away | ||
wwitzel3 | natefinch: yep | 20:04 |
natefinch | wwitzel3: was the watcher working for you? I keep getting a problem where the state server says it's trying to find a watcher with an empty id... but I can't figure out why, because the watcher code is all so twisty | 20:06 |
wwitzel3 | wwitzel3: nope. that is the same error I left it at last night, I'm working on that no, trying to get it fixed. | 20:07 |
wwitzel3 | natefinch: | 20:07 |
wwitzel3 | natefinch: the setup runs, the handle runs (which is our usual throw away the first run stuff), then I get that unknown watcher id | 20:08 |
natefinch | wwitzel3: ok, cool (sorta). I made a branch with more logging on my github called nate-ww3-ha-to | 20:09 |
natefinch | it also has some of the work to actually do stuff inside the watcher when it triggers... but yeah, I haven't been able to figure out the unknown watcher ID thing either | 20:10 |
perrito666 | juju local behaves much like the ring from lotr, when you most need it it leaves you stranded | 20:10 |
natefinch | wwitzel3: I know that it's because it's somehow getting an empty id in newNotifyWatcher, but can't figure out why | 20:10 |
wwitzel3 | natefinch: right, and the Next attempt throws the error | 20:10 |
niedbalski | abentley, ping | 20:11 |
niedbalski | abentley, are you able to target https://bugs.launchpad.net/juju-core/+bug/1423936 to 1.22 ? | 20:11 |
mup | Bug #1423936: Juju backup fails when journal files are present <backup-restore> <cts> <juju-core:Triaged by niedbalski> <https://launchpad.net/bugs/1423936> | 20:11 |
abentley | niedbalski: I can. | 20:15 |
alexisb | o perrito666 look a backup and restore bug, your favorite | 20:16 |
wwitzel3 | lol | 20:16 |
perrito666 | alexisb: it is my favorite | 20:16 |
perrito666 | because natefinch has a patch for it | 20:16 |
perrito666 | :p | 20:16 |
alexisb | looks like niedbalski has fixed it for you though | 20:17 |
perrito666 | and by natefinch I meant niedbalski | 20:17 |
natefinch | haha I was going to say... news to me | 20:17 |
alexisb | heh exactly | 20:17 |
perrito666 | natefinch: you should have seen your face | 20:17 |
wwitzel3 | natefinch frequently codes up patches and just keeps them in his back pocket, JIC | 20:17 |
perrito666 | lol | 20:17 |
alexisb | abentley, that bug will need to be discussed in the release call, so that xwwt and team can decide how/when the point release will go out | 20:19 |
abentley | alexisb: ACK. With 1.23 in beta, 1.22 may soon be obsolete anyway. | 20:21 |
alexisb | abentley, we will be pushing it to trusty | 20:21 |
niedbalski | abentley, thanks | 20:31 |
abentley | niedbalski: np | 20:36 |
ericsnow | dimitern: FYI, I wrote a patch to test systemd in containers/lxc: http://reviews.vapour.ws/r/1203/ | 20:48 |
bogdanteleaga | is there any way to debug go build hanging completely? | 21:35 |
thumper | bogdanteleaga: umm... best person to suggest stuff would be davecheney I think | 21:38 |
thumper | wallyworld: you up? | 21:41 |
wallyworld | thumper: yeah, in meeting, talk soon | 21:41 |
thumper | ack | 21:41 |
mup | Bug #1433615 changed: Manual provider fails to bootstrap: failed to check provisioned status ... /: Is a directory <bootstrap> <ci> <manual-provider> <regression> <juju-core:In Progress by ericsnowcurrently> <https://launchpad.net/bugs/1433615> | 22:01 |
wallyworld | thumper: zup | 22:03 |
thumper | wallyworld: quick hangout? | 22:07 |
wallyworld | sure | 22:07 |
=== urulama is now known as urulama__ | ||
ericsnow | bbl (running some errands) | 22:24 |
mup | Bug #1433384 changed: unit-test failure: TrackerSuite.TestWaitMinionBecomeMinion <ci> <i386> <regression> <test-failure> <utopic> <juju-core 1.23:Fix Committed by fwereade> <https://launchpad.net/bugs/1433384> | 22:46 |
mup | Bug #1433384 was opened: unit-test failure: TrackerSuite.TestWaitMinionBecomeMinion <ci> <i386> <regression> <test-failure> <utopic> <juju-core 1.23:Fix Committed by fwereade> <https://launchpad.net/bugs/1433384> | 22:55 |
mup | Bug #1433384 changed: unit-test failure: TrackerSuite.TestWaitMinionBecomeMinion <ci> <i386> <regression> <test-failure> <utopic> <juju-core 1.23:Fix Committed by fwereade> <https://launchpad.net/bugs/1433384> | 23:01 |
ericsnow | wallyworld: FYI, those failing tests on precise just passed: http://juju-ci.vapour.ws:8080/job/run-unit-tests-precise-amd64/2538/console | 23:06 |
wallyworld | ericsnow: awesome. i'm still waiting for the manual provider tests to pass also | 23:06 |
ericsnow | wallyworld: when you have a minute could you take another look at http://reviews.vapour.ws/r/1164/? | 23:33 |
ericsnow | wallyworld: I haven't done much manual testing on it yet (due to more pressing concerns) | 23:33 |
wallyworld | ericsnow: looking | 23:38 |
ericsnow | wallyworld: ta | 23:38 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!