| menn0 | davecheney: I just answered your question about why I didn't just use a 64-bit int | 00:16 |
|---|---|---|
| === anthonyf is now known as Guest55250 | ||
| thumper | wallyworld: I've just marked https://bugs.launchpad.net/juju-core/+bug/1433566 fixed released | 00:23 |
| thumper | ci jobs passed | 00:23 |
| mup | Bug #1433566: Precise unit test failure discoverySuite.TestDiscoverInitSystemScript <ci> <precise> <regression> <test-failure> <juju-core:Fix Released by ericsnowcurrently> <juju-core 1.23:Fix Released by ericsnowcurrently> <https://launchpad.net/bugs/1433566> | 00:23 |
| wallyworld | thumper: awesome, just need to wait for manual CI job now | 00:23 |
| wallyworld | oh, look like tha's gone too | 00:24 |
| thumper | wallyworld: https://bugs.launchpad.net/juju-core/+bugs?field.tag=ci+regression&field.tags_combinator=ALL is clear of critical | 00:24 |
| wallyworld | so unblocked | 00:24 |
| wallyworld | \o/ | 00:24 |
| wallyworld | gentlemen, start your engines | 00:24 |
| * thumper tries to land his branch | 00:24 | |
| thumper | while waiting for the bot, merge master and run all tests... | 00:25 |
| * thumper hopes no one added a test that'll break with his changes | 00:25 | |
| thumper | oh FFS | 00:25 |
| thumper | build fails | 00:26 |
| gsamfira | thumper: I find linden tea helps during merges :D | 00:27 |
| wallyworld | axw: i'll move the go-amz to propose against v3, not sure if you started looking yet | 00:27 |
| gsamfira | does not help the actual merge, but hey...its good tea :P | 00:28 |
| davecheney | menn0: that's an annoying issue with the mgo driver | 00:28 |
| thumper | davecheney: which annoying issue is that? | 00:29 |
| davecheney | thumper: menn0 's | 00:37 |
| thumper | ah | 00:39 |
| thumper | the db size issue | 00:39 |
| thumper | anyone know how to check the diff between a branch and master for just the changes the branch adds? | 00:43 |
| thumper | master is 5824 revisions ahead | 00:44 |
| thumper | and I wanted to see what this old branch of mine did | 00:44 |
| thumper | effectively what are the changes that would be merged in | 00:44 |
| mup | Bug #1433566 changed: Precise unit test failure discoverySuite.TestDiscoverInitSystemScript <ci> <precise> <regression> <test-failure> <juju-core:Fix Released by ericsnowcurrently> <juju-core 1.23:Fix Released by ericsnowcurrently> <https://launchpad.net/bugs/1433566> | 00:46 |
| ericsnow | wallyworld: \o/ | 00:47 |
| wallyworld | yeah | 00:47 |
| anastasiamac | wallyworld: gentlemen?.. :( | 00:49 |
| wallyworld | anastasiamac: it's a car racing term | 00:49 |
| anastasiamac | wallyworld: doesnt fly | 00:49 |
| wallyworld | no, cars drive | 00:49 |
| anastasiamac | wallyworld: m smiling in disappointment | 00:50 |
| wallyworld | :-) | 00:50 |
| thumper | heh | 00:50 |
| axw | damnit, had to unblock while I was afk :) | 00:53 |
| axw | wallyworld: you said there's a typo, I don't see one | 01:05 |
| axw | the "if when" is intentional, if that's what you were thinking of | 01:05 |
| wallyworld | axw: from memory "if when" | 01:05 |
| wallyworld | oh ok | 01:05 |
| axw | maybe not very common grammar, but I don't think it's incorrect | 01:06 |
| wallyworld | axw: when you are free, i've proposed against V3 https://github.com/go-amz/amz/pull/41 | 01:12 |
| axw | wallyworld: thanks, will look now | 01:12 |
| === kadams54 is now known as kadams54-away | ||
| axw | wallyworld: done | 01:35 |
| wallyworld | axw: ty, will look | 01:37 |
| === kadams54-away is now known as kadams54 | ||
| thumper | \o/ merge bot doing my branch now | 01:43 |
| thumper | axw: your one failed BTW | 01:44 |
| axw | doh, thanks thumper | 01:46 |
| axw | thumper: will be interested to hear how that goes, I've been thinking of trying a standing desk. my knees and back don't like all this sitting | 02:19 |
| natefinch | I wish ubuntu wouldn't reset my laptop's brightness to "staring directly at the sun" every time I reboot. | 02:19 |
| thumper | axw: I've been waking with a sore back for the last few weeks | 02:19 |
| axw | natefinch: heh yeah :( | 02:19 |
| thumper | axw: this morning, it was all good | 02:19 |
| thumper | and that was just after about using it four hours yesterday | 02:19 |
| perrito666 | ok, sleep, bye | 02:19 |
| thumper | o. perrito666 | 02:19 |
| axw | thumper: nice | 02:19 |
| natefinch | there's like a million studies out there that say that sitting all day is really bad for you, even if you work out regularly and are in shape. | 02:19 |
| thumper | natefinch: yeah, this is one driving force for me trying it | 02:20 |
| thumper | and I've been thinking about it for a while | 02:20 |
| axw | natefinch: yeah I know, just need to get my arse into gear and do it | 02:20 |
| thumper | and I decided to hack something up to trial it before I spent any money on a 'custom' solution | 02:20 |
| thumper | so laptop is on a step-stool thingy | 02:21 |
| natefinch | thumper: good plan, since most of those standing desks are crazy expensive | 02:21 |
| thumper | and keyboard is balanced on a few draws balanced on six books | 02:21 |
| axw | heh | 02:21 |
| thumper | not the most robust or stable | 02:21 |
| thumper | but enough to try it out | 02:21 |
| * thumper goes to make a coffee | 02:21 | |
| jw4 | thumper: I assume you found your answer about your old branch but: 'git checkout <old branch>; git log master..' (assuming old branch was off of master) | 02:25 |
| jw4 | or: git cherry -v master | 02:26 |
| === kadams54 is now known as kadams54-away | ||
| natefinch | anyone online any good with watchers? Wayne and I are trying to get one working for the HA --to feature working, but the state machine keeps giving an error: "unknown watcher id" (adding some logging shows the id is somehow an empty string) | 02:42 |
| dimitern | natefinch, do you have some code to look at? | 02:44 |
| jw4 | natefinch: sounds like the watcher wasn't registered ? | 02:45 |
| jw4 | is this on a private branch? | 02:45 |
| natefinch | dimitern: https://github.com/natefinch/juju/tree/nate-ww3-ha-to specifically https://github.com/natefinch/juju/blob/nate-ww3-ha-to/apiserver/converter/converter.go#L44 | 02:46 |
| dimitern | natefinch, looking | 02:47 |
| natefinch | jw4: quite possibly not registered. Not sure what I need to do to register one | 02:47 |
| dimitern | natefinch, where are you getting the error from? | 02:49 |
| natefinch | dimitern: apiserver/watcher.go newNotifyWatcher | 02:50 |
| wallyworld | axw: when did you see Attachment being remove from VolumeParams? we still doing that? | 02:51 |
| natefinch | dimitern: at least, that's where the error is returned by machine-0... it gets logged on machine-1 (the one calling the watcher) | 02:51 |
| menn0 | changes ready. now let's see if thumper's recent merge broke mine. | 02:52 |
| axw | wallyworld: not sure yet. why do you ask? | 02:52 |
| dimitern | natefinch, right, so I think I see the issue | 02:52 |
| wallyworld | axw: because i need to handle in in CreateVolume() to do the attaching there | 02:52 |
| wallyworld | if specified | 02:52 |
| natefinch | dimitern: oh good | 02:53 |
| axw | wallyworld: can you just ignore the VolumeParams.Attachment in your branch, and handle it in AttachVolumes please? | 02:53 |
| dimitern | natefinch, hmm.. no sorry - there's nothing apparently wrong with the apiserver code | 02:53 |
| wallyworld | axw: sure, i thought that might be the case, hence asking :-) | 02:53 |
| axw | wallyworld: nps. we'll need to change the existing providers before it gets removed | 02:53 |
| dimitern | natefinch, except maybe you don't need to call watcher.EnsureErr(watch) on line 66 | 02:54 |
| axw | wallyworld: i.e. so loop would create the file in CreateVolumes, and then losetup in AttachVolumes | 02:54 |
| wallyworld | yep, sounds good | 02:54 |
| dimitern | natefinch, this is it I think - comparing to other cases (e.g. uniter.WatchConfigSettings) if there's any error, just set the Error part of the result | 02:55 |
| jw4 | natefinch: are you running a specific test? | 02:59 |
| jw4 | go test ./apiserver/converter/... ? | 03:00 |
| jw4 | I guess not | 03:00 |
| natefinch | jw4: sorry, no, the test is "juju bootstrap && juju add-machine" and then watch the log for error messages | 03:01 |
| jw4 | kk | 03:01 |
| jw4 | natefinch: fwiw I see the call to resources .Register(watcher) | 03:03 |
| natefinch | jw4: right right, yeah I saw it too | 03:04 |
| menn0 | axw: thanks for the review | 03:13 |
| axw | menn0: nps | 03:14 |
| axw | menn0: what're the headers for btw? | 03:14 |
| menn0 | axw: the /log API (used by debuglog) and /logsink (new, used by agents to send logs) use HTTP basic auth | 03:15 |
| axw | menn0: ah, right. still using HTTPS, right? | 03:16 |
| menn0 | axw: they use TLS websockets but without the RPC layer that most of our API uses on top | 03:17 |
| jw4 | natefinch, dimitern fwiw I'm pretty sure the NotifyWatcherId on the params.NotifyWatchResult is an empty string somehow | 03:17 |
| axw | right, just wanted to know that the basic auth is encrypted | 03:17 |
| axw | menn0: thanks | 03:17 |
| menn0 | axw: definitely still encrypted | 03:18 |
| dimitern | jw4, no, I think you're mixing up the Id parameter of the RPC Request | 03:18 |
| dimitern | jw4, watchers are the only entities that actually use the Id | 03:18 |
| menn0 | axw: my recent changes in the api package are all about sharing as much of the connection setup code between normal API connections and lower level websocket only API connections | 03:18 |
| menn0 | axw: and that includes the TLS setup | 03:19 |
| axw | sounds good | 03:19 |
| jw4 | dimitern: yeah I think you're right | 03:20 |
| jw4 | exit | 03:30 |
| * jw4 in wrong window | 03:31 | |
| natefinch | jw4, dimitern: I don't k ow what is going wrong, but this code was supposed to be in over a week ago, and this is one of the main problems that's been tripping us up. | 03:33 |
| jw4 | natefinch: yeah - I'm still betting on either an RPC serialization issue or an unchecked param being sent down | 03:34 |
| dimitern | natefinch, ok, let me try that branch locally, might think of something | 03:35 |
| dimitern | natefinch, got a link? | 03:35 |
| natefinch | dimitern: I appreciate it | 03:35 |
| jw4 | dimitern: I can repro with the branch and steps natefinch gave in the scrollback | 03:35 |
| natefinch | dimitern: https://github.com/natefinch/juju/tree/nate-ww3-ha-to or just git remote add nate https://github.com/natefinch/juju branch nate-ww3-ha-to | 03:36 |
| dimitern | jw4, oh, yeah - I should've looked | 03:36 |
| * dimitern thinks it's still only 5:36 am | 03:36 | |
| jw4 | :) | 03:36 |
| dimitern | natefinch, thanks, pulling it now | 03:36 |
| jw4 | natefinch: bingo | 03:38 |
| jw4 | api/converter/converter.go | 03:38 |
| jw4 | line 41 | 03:38 |
| jw4 | (actually 38 or so, I added logging) | 03:39 |
| jw4 | result.NotifyWatcherId:"" | 03:39 |
| jw4 | gah | 03:40 |
| jw4 | ignore me | 03:40 |
| natefinch | jw4: heh | 03:40 |
| jw4 | natefinch, dimitern actually... | 03:42 |
| natefinch | jw4, dimitern: maybe resources.Register is somehow returning an empty string | 03:42 |
| natefinch | hmm.. that shouldn't be possible | 03:42 |
| jw4 | natefinch yeah - it must be a serialization issue? | 03:43 |
| jw4 | apiserver WatchForJobsChanges is certainly returning "" for the NotifyWatcherId | 03:45 |
| jw4 | and that's wrong | 03:45 |
| jw4 | whether it's an RPC issue or not we'll know in a minute when my new logging takes effect | 03:46 |
| jw4 | boom | 03:47 |
| jw4 | it's gotta be RPC serialization | 03:47 |
| jw4 | on the apiserver side it's populated | 03:47 |
| jw4 | on the api side its "" | 03:48 |
| natefinch | jw4: interesting | 03:48 |
| jw4 | but that doesn't make sense 'cause it's just a string | 03:48 |
| jw4 | natefinch, dimitern oooh | 03:50 |
| jw4 | api uses params.NotifyWatchResult, apiserver uses params.NotifyWatchResults | 03:51 |
| dimitern | natefinch, I see you're returning params.NotifyWatchResults but in the client-side api you're passing a single NotifyWatchResult | 03:51 |
| jw4 | the slice is getting lost | 03:51 |
| dimitern | jw4, ah :) you're faster | 03:51 |
| natefinch | OH FFS | 03:51 |
| jw4 | dimitern: well I was working on it longer and it's 9pm here not 6 am | 03:52 |
| dimitern | jw4, :) fair point | 03:52 |
| natefinch | thanks a lot, static typing :/ | 03:53 |
| dimitern | :D | 03:53 |
| dimitern | natefinch, well that part of the code is decisively not all static typing | 03:55 |
| dimitern | reflect magic | 03:55 |
| natefinch | dimitern: I know... it's totally all reflection BS | 03:55 |
| natefinch | dimitern: seems like we could be a little smarter about recognizing when we're deserializing into something completely wrong, though. Also, the whole "two types with the same name except for an S on the end" is pretty shit | 03:56 |
| natefinch | that fixed it | 03:56 |
| natefinch | thanks, guys, that's awesome | 03:56 |
| dimitern | natefinch, \o/ | 03:57 |
| jw4 | fun debugging | 03:57 |
| natefinch | wayne and I have been pulling our hair out for a couple days now | 03:57 |
| jw4 | fresh eyes usually help | 03:57 |
| dimitern | natefinch, well, i'll just add it to the growing list of beers for nuremberg *wink* | 03:57 |
| natefinch | dimitern: certainly :) | 03:58 |
| jw4 | yep confirmed it works here too nice | 03:58 |
| dimitern | jw4, indeed | 03:58 |
| * jw4 eod | 04:02 | |
| dimitern | jw4, have a good one! :) | 04:02 |
| natefinch | whelp bedtime. in 5 hours I can get up and try to get the rest of this working. Thanks guys. | 04:03 |
| jw4 | dimitern: thanks, you too - your day is off to a great start | 04:03 |
| dimitern | jw4, oh I hope so hehe | 04:03 |
| jw4 | lol | 04:03 |
| mup | Bug #1433116 changed: 386 compilation error: dblogpruner/worker.go:32: constant 4294967296 overflows int <i386> <test-failure> <juju-core:Fix Released by menno.smits> <https://launchpad.net/bugs/1433116> | 04:52 |
| menn0 | axw: review of a 2-line fix please: http://reviews.vapour.ws/r/1208/ | 05:11 |
| axw | looking | 05:11 |
| menn0 | axw: I just noticed that the tests were still failing on i386 | 05:11 |
| axw | menn0: was the state package already updated? | 05:12 |
| axw | to accept MB | 05:12 |
| menn0 | axw: yes | 05:12 |
| menn0 | axw: that const was there from when it worked in MB | 05:12 |
| menn0 | axw: it just need to be high enough that pruning by size doesn't come in to play for that test | 05:12 |
| menn0 | axw: sorry | 05:13 |
| menn0 | axw: I meant to say "when it worked in bytes" | 05:13 |
| axw | that makes more sense :) | 05:13 |
| axw | thanks | 05:13 |
| menn0 | axw: sorry. it's EOD and I'm feeling frazzled. | 05:13 |
| axw | menn0: nps :) LGTM | 05:14 |
| === urulama__ is now known as urulama | ||
| axw | wallyworld: when you have some time, http://reviews.vapour.ws/r/1209/ | 06:15 |
| axw | wallyworld: some bits required for watching filesystem attachments | 06:15 |
| wallyworld | axw: sure, will do it after scholl pickup soon | 06:15 |
| axw | cheers | 06:15 |
| wallyworld | axw: implementing DescribeVolumes() - we pass in provider ids, but there's no easy way to get the juju volume tags to populate the storage.Volume items with | 06:16 |
| axw | wallyworld: ah yeah, we should pass both in I guess. | 06:17 |
| axw | hmm | 06:17 |
| axw | brain fart | 06:17 |
| wallyworld | axw: for now, i'm just finishing off tests and will propose the working ebs volume source, i'll add a todo | 06:17 |
| * axw looks at interface | 06:18 | |
| axw | wallyworld: SGTM | 06:18 |
| wallyworld | axw: these sorts of things always happen writing infrastructre first :-) | 06:18 |
| axw | wallyworld: a couple of options; we could not require the Volume to have a VolumeTag, or we could pass it in with the volume ID | 06:19 |
| axw | wallyworld: probably the former -- we should really separate identify from other details | 06:19 |
| wallyworld | axw: of hand, i think we should always generate fully populated storage.Volume items in case they are passed around, hence we shuld pass in tags ? agree ? | 06:20 |
| axw | I've had in the back of my mind that we should have a storage.VolumeInfo, which describes properties of a volume without the tags and so on | 06:20 |
| wallyworld | VolumeInfo works too | 06:20 |
| axw | wallyworld: we don't need to implement Describe yet anyway | 06:20 |
| wallyworld | we could embed it in Volume | 06:20 |
| wallyworld | it's easy to implement, already done, i'll just add a todo | 06:20 |
| axw | ok | 06:21 |
| wallyworld | right, off to school pickup, bbiab | 06:21 |
| mattyw | morning all | 08:40 |
| dimitern | morning | 08:42 |
| wwitzel3 | morning | 08:43 |
| wallyworld | axw: i have to have dinner, i'll review your branch after, i've just finished this one http://reviews.vapour.ws/r/1210/ , i have a small tweak i need to propose for go-amz also, will do that after dinner | 08:45 |
| axw | wallyworld: nps. I may have to rethink this stuff again :/ I think either the diskformatter needs to be folded into the storageprovisioner, or otherwise we need to do the mounting in the diskformatter after all | 08:47 |
| axw | will take a look at yours | 08:47 |
| mramm | is there a link to online docs about what you can do with placement? | 08:59 |
| mramm | hey, anybody else getting bad gateway errors on the juju docs site? | 09:14 |
| mramm | urulama: ^^^ | 09:14 |
| wwitzel3 | mramm: for /docs yes | 09:15 |
| urulama | mramm: it's being fixed, deploy on a way | 09:15 |
| wwitzel3 | mramm: but https://jujucharms.com/docs/commands works | 09:15 |
| mramm | refreshing seems to help | 09:15 |
| urulama | mramm: getting started affected | 09:15 |
| urulama | mramm: getting started: aws, azure and testing your setup are broken currently | 09:16 |
| urulama | (and a bunch others) | 09:17 |
| urulama | mramm: sorry, didn't find any user oriented placement doc with examples :( | 09:22 |
| mramm | urulama: no problem thanks for looking | 09:24 |
| wallyworld | axw: did you still want that branch reviewed, or do you need to think about it? | 09:33 |
| axw | wallyworld: still review please. it needs to be there either way, it's just a question of how filesystems-on-volumes are handled | 09:35 |
| wallyworld | ok | 09:35 |
| axw | wallyworld: I'm thinking of chucking out the diskformatter, and creating a new filesystem provider. the storage provisioner will still need some special handling for that though, I think | 09:35 |
| wallyworld | ok | 09:36 |
| axw | wallyworld: I realised I didn't add tests for api/storageprovisioner... doing that now, at the same time as adding the rest of the filesystem methods | 09:37 |
| axw | wallyworld: I've updated the branch with the rest of the methods in api/storageprovisioner, and added tests to that package | 09:47 |
| wallyworld | ok, ta | 09:47 |
| axw | server-side will come in another branch | 09:47 |
| wallyworld | axw: +1, was fairly easy to review because there's so much similar boilerplate, not just in this stuff but everywhere | 09:58 |
| axw | wallyworld: which missing tests are you referring to in the message? | 09:59 |
| wallyworld | apiserver | 09:59 |
| wallyworld | unless i missed them | 09:59 |
| axw | wallyworld: ah yeah, that code isn't really exercised yet. will do | 10:00 |
| axw | thanks | 10:00 |
| wallyworld | sure | 10:00 |
| dooferlad | dimitern: hangout? | 10:03 |
| voidspace | dimitern: stdup? | 10:03 |
| wallyworld | axw: here's that small go-amz fix | 10:12 |
| wallyworld | https://github.com/go-amz/amz/pull/42 | 10:12 |
| axw | wallyworld: lgtm | 10:13 |
| wallyworld | ty | 10:13 |
| === urulama is now known as urulama|lunch | ||
| axw | wallyworld: if you're still around, another fairly straight forward one: http://reviews.vapour.ws/r/1211/ | 11:12 |
| wallyworld | sure | 11:13 |
| axw | wallyworld: I'm going to now focus on getting tmpfs working, so we can test filesystems. getting filesystems in volumes is probably another couple of days work, due to some required changes I hadn't thought about | 11:20 |
| axw | I mean, tmpfs invoked via dynamic storage provisioner | 11:21 |
| wallyworld | axw: sgtm | 11:21 |
| wallyworld | axw: lgtm on rb | 11:21 |
| wallyworld | just an import fix | 11:22 |
| axw | wallyworld: thanks | 11:22 |
| axw | wallyworld: last one for tonight http://reviews.vapour.ws/r/1212/ | 12:16 |
| wallyworld | ok | 12:16 |
| wallyworld | axw: done | 12:22 |
| axw | wallyworld: tyvm. good point about todo, will fix now | 12:22 |
| wallyworld | ta | 12:23 |
| axw | wallyworld: if you've got any ideas about how we can unify params and so on for volumes and filesystems, let me know... lots of very similar code in that package :/ | 12:27 |
| wallyworld | indeed, we need to step back and re-evalutate the model a bit | 12:28 |
| wallyworld | axw: last one if you're still around https://github.com/go-amz/amz/pull/43 | 12:49 |
| wallyworld | dimitern: if you had a few minutes, this is a small change to the amz test server ^^^^^ | 12:56 |
| dimitern | wallyworld, sure, will have a look | 12:58 |
| wallyworld | ty | 12:58 |
| dimitern | wallyworld, LGTM | 13:05 |
| wallyworld | ty :-) | 13:05 |
| mup | Bug #1433254 changed: manual provider on trusty/precise syntax error near unexpected token `then' <manual-provider> <ppc64el> <systemd> <juju-core:Fix Released by ericsnowcurrently> <juju-core 1.23:Fix Released by ericsnowcurrently> <https://launchpad.net/bugs/1433254> | 13:24 |
| mup | Bug #1434070 was opened: upgrades are broken in master 1.24-alpha1 <ci> <regression> <upgrade-juju> <juju-core:Triaged> <https://launchpad.net/bugs/1434070> | 13:24 |
| natefinch | wwitzel3: how goes? | 13:37 |
| === tvansteenburgh1 is now known as tvansteenburgh | ||
| ericsnow | fwereade: is this what you had in mind? http://reviews.vapour.ws/r/1206/ | 13:53 |
| ericsnow | fwereade: I waited to land it so that you could look it over first | 13:53 |
| mup | Bug #1434092 was opened: updateSeriesVersions() gets called too late in the initialization process <juju-core:New> <https://launchpad.net/bugs/1434092> | 13:54 |
| === urulama|lunch is now known as urulama_ | ||
| dimitern | jam, fwereade, I'd appreciate a review on this http://reviews.vapour.ws/r/1118/ when you have time | 14:10 |
| * dimitern needs to go out for a while, might not come back until late | 14:14 | |
| perrito666 | natefinch: ericsnow wwitzel3 that was intended to be unmute but I instead used hang | 14:27 |
| perrito666 | because my mouse does those things when running out of mem, sorry | 14:27 |
| natefinch | lol | 14:28 |
| natefinch | we just all hung up anyway | 14:28 |
| dooferlad | ericsnow: Could I have a very quick review? https://github.com/juju/testing/pull/56 | 15:06 |
| ericsnow | dooferlad: you bet | 15:06 |
| ericsnow | dooferlad: wrapping up another one first | 15:06 |
| dooferlad | ericsnow: thanks! | 15:06 |
| === urulama_ is now known as urulama | ||
| perrito666 | natefinch: we could go for a more explicit OneNotifyWatcherResult, ManyNotifyWatcherResults :p | 15:50 |
| natefinch | perrito666: I actually don't think that's a horrible idea. I was going to give suggestions in the email, but didn't really want to bike shed it | 15:51 |
| natefinch | perrito666: it doesn't help that they have to match up across files | 15:52 |
| perrito666 | we could make a test that checks that two variables on a same namespace have a certain levenstein distance :p | 15:52 |
| natefinch | perrito666: that's a very interesting linter rule... I kinda like it, actually. | 15:53 |
| perrito666 | uff, wfh is terrible at lunch time when you live in a neigborhood with too many old ladies | 15:53 |
| natefinch | ......explain? | 15:53 |
| perrito666 | natefinch: young people eat at work | 15:54 |
| perrito666 | old ladies cook from 11AM and a really tempting smell comes trough the window | 15:54 |
| perrito666 | natefinch: lunch here is quite a heavy meal since our breakfast is mostly tea/coffee and crackers | 15:55 |
| perrito666 | I dont even have breakfast,I only eat a couple of fruits | 15:55 |
| perrito666 | so I have to work for two hs thinking on my relatively poor lunch while smelling stew, roasted meat, pizza, etc | 15:56 |
| ericsnow | dooferlad: FYI, while we don't have hooks set up (yet) for the testing repo, you can still use rbt to post a review request | 15:57 |
| dooferlad | ericsnow: ack | 15:59 |
| perrito666 | omg, someone is doing a wine reduction... how cruel | 15:59 |
| natefinch | perrito666: lol | 16:07 |
| natefinch | wwitzel3: you around? | 16:16 |
| natefinch | anyone know if we already have something in machine agent that watches for changes to the machine? Seems like we would, but it's a little hard to figure out through all the levels of abstraction in this code | 16:26 |
| === kadams54 is now known as kadams54-away | ||
| === natefinch is now known as natefinch-afk | ||
| mup | Bug #1434092 changed: updateSeriesVersions() gets called too late in the initialization process <juju-core:New> <https://launchpad.net/bugs/1434092> | 17:54 |
| mup | Bug #1434092 was opened: updateSeriesVersions() gets called too late in the initialization process <juju-core:New> <https://launchpad.net/bugs/1434092> | 18:00 |
| mup | Bug #1434092 changed: updateSeriesVersions() gets called too late in the initialization process <juju-core:New> <https://launchpad.net/bugs/1434092> | 18:06 |
| === natefinch-afk is now known as natefinch | ||
| natefinch | oh my god, the watcher code... jesus | 18:29 |
| natefinch | there's like four levels of indirection that could get reduced to one or two lines of code in most cases :/ | 18:29 |
| mattyw | natefinch, I've just had my fingers in the watcher code - if there's anything I've done you don't like I love to learn :) | 18:33 |
| mattyw | natefinch, also, I'm pushing more changes to the meter status branch - I've marked it WIP in rb because there are still things to be cleaned up before its reviewed again... | 18:33 |
| mattyw | natefinch, but how does this test grab you? https://github.com/mattyw/juju/blob/metricsmanager-meterstatus/state/meterstatus_test.go#L266 | 18:34 |
| natefinch | mattyw: I don't actually know what the combinations mean, but it is nice and readable | 18:40 |
| natefinch | mattyw: you don't really need the var block, though, they can each just be := instead | 18:41 |
| mattyw | natefinch, if I did that gofmt made sure they were all nicely lines up for me :) | 18:41 |
| natefinch | mattyw: ahh, interesting point | 18:42 |
| natefinch | mattyw: that never would have occurred to me, but yes, I think that helps readability, so, cool, nice work. | 18:42 |
| mattyw | natefinch, I'm going to call it a day | 18:43 |
| mattyw | natefinch, but if you're around tomorrow I will pester you if you don't mind :) | 18:43 |
| natefinch | mattyw: have a good evening | 18:43 |
| natefinch | mattyw: I'll be around :) | 18:43 |
| === kadams54 is now known as kadams54-away | ||
| mup | Bug #1434246 was opened: Destroying environment takes down others with similar name <juju-core:New> <https://launchpad.net/bugs/1434246> | 19:25 |
| === tvansteenburgh is now known as tvan-afk | ||
| natefinch | hatch: on that bug about destroy-environment, how exactly did you invoke destroy environment? i.e. did you use -e or rely on the "current" environment? | 19:40 |
| hatch | natefinch: umm it was scripted, lemme take a peek | 19:41 |
| hatch | natefinch: I reproduced it once but I will do it again so I can capture the exact steps for the bug | 19:41 |
| natefinch | hatch: also please note if you used --force | 19:45 |
| hatch | natefinch: juju_env = lambda: os.getenv('JUJU_ENV') is the line it uses to get the environment | 19:45 |
| hatch | but I'll try manually as soon as this test run is done | 19:45 |
| hatch | probably 10m now or so | 19:45 |
| natefinch | hatch: I knew that if I asked if you did it way X or Y that you'd come back and say Z ;) | 19:45 |
| mup | Bug #1331505 changed: destroy-environment shuts down joyent machines <ci> <destroy-environment> <joyent-provider> <juju-core:Won't Fix> <https://launchpad.net/bugs/1331505> | 19:46 |
| hatch | natefinch: isn't that the way it goes? :D | 19:46 |
| natefinch | hatch: but, still... how does it use juju_env... to do -e? | 19:46 |
| === kadams54-away is now known as kadams54 | ||
| hatch | natefinch: the command executor adds -e to the commands using the value returned from the above line | 19:50 |
| natefinch | hatch: *shrug* works correctly for me | 19:52 |
| natefinch | I'm on master, of course, but I doubt we've changed that any time recently | 19:53 |
| hatch | yeah ok I'll try again one this run is done - these tests take a while :) | 19:53 |
| natefinch | hatch: no problem :) | 19:54 |
| thumper | sinzui: ping | 19:56 |
| sinzui | hi thumper | 20:02 |
| thumper | o/ | 20:02 |
| thumper | just talking with abentley about ci tests | 20:03 |
| thumper | in standup now | 20:03 |
| thumper | ping after | 20:03 |
| === kadams54 is now known as kadams54-away | ||
| === kadams54-away is now known as kadams54 | ||
| thumper | sinzui: do you have a few minutes to chat? | 20:16 |
| sinzui | I do | 20:18 |
| thumper | awesome | 20:18 |
| * thumper makes a hangout | 20:18 | |
| thumper | sinzui, waigani: https://plus.google.com/hangouts/_/canonical.com/core-ci | 20:19 |
| wallyworld | thumper: you seen blocker bug 1434070 which is suggested in a comment may be jes related? | 20:29 |
| mup | Bug #1434070: upgrades are broken in master 1.24-alpha1 <ci> <regression> <upgrade-juju> <juju-core:Triaged> <https://launchpad.net/bugs/1434070> | 20:29 |
| thumper | will look shortly, otp | 20:29 |
| wallyworld | ok | 20:29 |
| hatch | natefinch: so, sorry, I'm no longer able to reproduce that bug | 20:42 |
| hatch | I'm going to have to investigate a little further because I was definitely able to reproduce it before | 20:43 |
| thumper | wallyworld: looking now | 20:46 |
| natefinch | hatch: ok, let me know | 20:51 |
| hatch | curtis triaged it and linked it to a security group bug as well | 20:52 |
| hatch | so they may be related | 20:52 |
| thumper | wallyworld: I know what it is... | 20:54 |
| * thumper goes to fix | 20:54 | |
| wallyworld | \o/ | 20:54 |
| thumper | wallyworld: wouldn't have happened with 1.22 :) | 20:55 |
| thumper | too many assumptions | 20:55 |
| * thumper thinks | 20:56 | |
| thumper | man, this is harder than I thought... | 20:56 |
| wallyworld | must. not. comment | 20:56 |
| === kadams54 is now known as kadams54-away | ||
| ericsnow | anastasiamac: ping | 21:05 |
| thumper | wallyworld: got a minute? | 21:06 |
| thumper | wallyworld: I have a fix but unsure if or how to add a test for it | 21:07 |
| anastasiamac | ericsnow: hi? | 21:10 |
| thumper | wallyworld: http://reviews.vapour.ws/r/1215/diff/# | 21:10 |
| ericsnow | anastasiamac: just wanted to encourage you about your patch after leaving so many review comments :) | 21:11 |
| anastasiamac | ericsnow: k :D - encourage away :D | 21:11 |
| anastasiamac | ericsnow: 7am here, m about to drop off kids at school bbl :D | 21:12 |
| wallyworld | thumper: sorry, was dealing with C8H10N4O2 | 21:17 |
| wallyworld | looking | 21:17 |
| thumper | caffiene is my favourite drug | 21:17 |
| thumper | followed closely by C2H6O | 21:18 |
| thumper | although not in a pure form | 21:18 |
| wallyworld | indeed | 21:19 |
| wallyworld | thumper: you probably could or should write a test but it's an edge case and i want to get landings unblocked :-) | 21:19 |
| thumper | the thing is, you can't really tell | 21:19 |
| thumper | without log scraping | 21:20 |
| thumper | and that is truly horrible | 21:20 |
| * thumper thinks | 21:21 | |
| ericsnow | thumper: I'm looking at that agent login patch | 21:21 |
| wallyworld | thumper: i hit the big red button | 21:21 |
| ericsnow | thumper: is there a way for an upgrade step to handle that? | 21:21 |
| thumper | ericsnow: no, because the upgrade needs to log into the api first | 21:22 |
| wallyworld | thumper: as per policy, we need to unblock asap or revert, so if the current work unblocks, we can land and then revise later with a test if needed | 21:22 |
| ericsnow | thumper: ah, makes sense | 21:22 |
| thumper | ericsnow: the agents already handle the case which add the env uuid to the agent config | 21:22 |
| thumper | but it is in 1.23 | 21:23 |
| thumper | 1.24 now stops server the environment at the root of the api by default | 21:23 |
| thumper | so if you don't have an env uuid, you need to log in with an older version | 21:23 |
| thumper | agents NEVER want the root of the api | 21:23 |
| thumper | sorry | 21:23 |
| thumper | they NEVER want just user manager/ env manager | 21:23 |
| thumper | they always want to talk to an environment | 21:24 |
| thumper | so the place to force it is in the agent login connection | 21:24 |
| thumper | wallyworld: oh, you already added the merge line | 21:24 |
| thumper | ta | 21:24 |
| wallyworld | thumper: yeah, i need to land stuff for storage, so keen :-) | 21:25 |
| thumper | heh | 21:25 |
| thumper | also, if one of the upgrade ci tests pass, this fix will have worked | 21:25 |
| thumper | 'cause it broke all | 21:25 |
| wallyworld | yup | 21:25 |
| === urulama is now known as urulama__ | ||
| wwitzel3 | there is an error you can raise from a worker to restart jujud correct? | 21:50 |
| perrito666 | ErrTerminateAgent iirc | 21:52 |
| perrito666 | wwitzel3: ^ | 21:53 |
| wwitzel3 | perrito666: no, that calls uninstallAgent | 21:53 |
| perrito666 | ouch | 21:53 |
| wwitzel3 | perrito666: fwereade pointed that out to me the other day, I thought we had one for just restarting, but maybe not. | 21:53 |
| perrito666 | do you not have access to the tomb? | 21:54 |
| wwitzel3 | perrito666: somehow I'm sure | 21:57 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!