[05:57] <pitti> Good morning
[06:48] <didrocks> good morning
[06:51] <pitti> bonjour didrocks !
[06:52] <didrocks> hey pitti
[07:25] <happyaron> morning didrocks pitti :)
[07:27] <didrocks> hey happyaron
[07:33] <larsu> happy Friday every1
[07:34] <pitti> hey happyaron, hello larsu!
[07:59] <didrocks> pitti: yeah, confirmed on an installed system, I should just have tried on the live…
[08:00] <seb128> good morningg desktopers
[08:01] <didrocks> pitti: so, as this will stay a distro-patch anyway, I propose that I do the minimal workaround in systemd-machine-id-commit itself, meaning checking if there is an overlayfs mountpoint in /etc/machine-id or parent
[08:01] <didrocks> re seb128
[08:01] <didrocks> as*
[08:01] <didrocks> that way, the systemd binary isn't at risk, and the patch is smaller
[08:02] <pitti> bonjour seb128, comment vas-tu ?
[08:02] <pitti> didrocks: sounds good to me
[08:03] <didrocks> pitti: I don't know why the bigger patch hangs TBH, sounded sane enough to me, but maybe there is an evaluation of mount points too early or such…
[08:03] <didrocks> but let's go minimal as upstream wants a kernel fix
[08:07] <seb128> hey pitti, ca va bien ! et toi ?
[08:11] <pitti> seb128: ça va bien aussi, merci !
[08:12] <didrocks> waow, one run, two bugs discovered on ubuntu make, I guess this guy should apply for the QA team :p
[08:12]  * didrocks understands the first one, not yet the second though
[08:30] <pitti> haha
[08:56] <willcooke> yawn - morning
[08:57] <didrocks> morning willcooke
[08:58] <willcooke> TheMuso, still around?
[09:28] <willcooke> hey larsu - shall we meet?
[09:29] <larsu> willcooke: yep
[09:43] <Sweet5hark> seb128: So, I did an 4.4.1 update for the ppa including the breeze icons. Since this is FFes for kubuntu, it should be uploaded soonish. However, Friday uploads are bad, so lets target that for Monday?
[09:47] <Sweet5hark> seb128: FWIW, 4.4.2~rc2 has been tagged upstream today and likely will be 4.4.2 final. I will update the ppa as soon as this update is in -proposed. Likely still rather a 0-day SRU as it will get tight with timing otherwise.
[10:41] <didrocks> pitti: phew, I found an easy fix!
[10:41] <didrocks> for the machine-commit-id
[10:41] <didrocks> (the issue is when major(parent = 0) and major(child) != 0
[10:42] <didrocks> sorry, I meant, we only wait to fallback in that case
[10:42] <didrocks> (as it's overlayfs-like)
[10:42] <didrocks> but it seems we can get major(parent) = 0 and major(child) = 0
[10:42] <didrocks> we do not want to fallback in that case
[10:42] <didrocks> (case of tmpfs)
[10:43] <pitti> didrocks: oh, good! I sorted out the iscsi stuff, so I'd like to do a merge with Debian exp
[10:43] <pitti> so please poke me if/once you have a patch
[10:43] <didrocks> pitti: do you want me to repropose a patch with the fix? (I'm going to do a full suite of test with the package installed)
[10:43] <didrocks> pitti: I can give it to you if you want to run some tests in parallel
[10:44] <pitti> didrocks: sure!
[10:52] <didrocks> pitti: http://people.canonical.com/~didrocks/tmp/0001-Fix-mount-point-detection-on-overlayfs-and-similar-f.patch
[10:52] <didrocks> pitti: the only diff is replacing if (major(b.st_dev) == 0) by if (major(b.st_dev) == 0 && major(a.st_dev) != 0)
[10:53] <didrocks> pitti: I'm rebuilding the ubuntu package with this, now that I removed all my manual breaks and printf statements to ensure it's fine
[10:53] <willcooke> seb128, do we need to worry about this new glibc do you think?
[10:53] <didrocks> while it's building, going for a run (and then I guess it will be 20 minutes for a full test with vm, vm-iso, /etc/machine-id on ro…)
[10:54] <pitti> didrocks: ah, ok; thanks! I can test it on Debian exp on an installed system, if you want to test it on a live?
[10:55] <didrocks> pitti: sure, the installed system isn't the most difficult, but we can do like that
[10:57] <didrocks> pitti: ok, ubuntu package building, going for a run meanwhile :)
[10:57] <pitti> didrocks: enjoy! I'll test on Debian installed
[10:57] <didrocks> thanks!
[11:17] <pitti> didrocks: works fine on installed; let me know how it goes on live, then I'll push
[11:17] <pitti> didrocks: note that there was some noise with gbp-pq import/export
[11:18] <didrocks> pitti: oh right (yeah, failed to take a break, now waiting for it to finish to build)
[11:22] <tkamppeter> willcooke, hi
[11:23] <willcooke> hey tkamppeter!  Got your mail, just waiting to hear back from Rick
[11:38] <didrocks> pitti: no, forget about it, there is another use case I can't get working with this patch
[11:40] <didrocks> pitti: if only, I could get my printf to shows up while it's hanging…
[11:42] <pitti> didrocks: ah, meh -- you didn't go running?
[11:43] <didrocks> pitti: yeah, wanted to get a good news on this before going… :p
[11:43] <didrocks> efail
[12:12] <didrocks> pitti: ok, the issue is the call due to readlink_and_make_absolute when called on some /sys path
[12:16]  * happyaron sents out bunches of emails to gsoc prospective students
[12:17] <didrocks> pitti: ok, understood it, what happens is:
[12:17] <didrocks> -> /sys/<bla> is read
[12:17] <didrocks> then, we try to readlink_and_make_absolute
[12:17] <didrocks> this errors out
[12:17] <didrocks> errno != ENOENT
[12:18] <didrocks> we return -errno
[12:18] <didrocks> and so, systemd doesn't like it (I guess it prevents some execution with /sys setup)
[12:18] <didrocks> so, I guess instead of returning -errno, we can return a.st_dev != b.st_dev
[12:18] <didrocks> as it's the previous behavior
[12:25] <darkxst> hey seb128 did you see my comment on the schemas bug?
[12:30] <didrocks> pitti: recreated the patch, building now, going finally for a run, and then, I'll test installed, live and such…
[12:40] <seb128> Sweet5hark, monday is fine
[12:40] <seb128> willcooke, glibc shouldn't be an issue for us no
[12:41] <seb128> darkxst, yeah, I saw, I didn't think much about it yet though
[12:41] <Sweet5hark> seb128: great, thx
[12:41] <seb128> yw
[12:42] <Sweet5hark> also: c- c- c- c-combobreaker for sebs reply volley!
[12:43] <darkxst> seb128, ok, it doesn't really need thinking about now, just wasnt sure if re-assigned bugs would get back to you
[12:59] <didrocks> pitti: \o/ success (both permanent, live and temporary machine-id)
[13:00] <pitti> didrocks: yay! what was it?
[13:00] <didrocks> pitti: yeah, I couldn't resist to get this testing before taking a break :)
[13:00] <didrocks> pitti: basically on /sys path, readlink will return some errno
[13:00] <didrocks> and I guess that systemd stops going on with detecting if path is a mountpath if it returns < 0
[13:01] <didrocks> (so doesn't read some /sys content and such…)
[13:01] <didrocks> the fix is, instead of returning errno (not being able to read a symlink in a directory is a valid one anyway), use the major() comparison
[13:01] <didrocks> so basically, being a no-op for those cases
[13:02] <didrocks> I extended the same in case we are in error reading /proc/self/mounts btw
[13:02] <didrocks> (fallbacking to the previous comparison method)
[13:03] <didrocks> pitti: so, that should be it: http://people.canonical.com/~didrocks/tmp/0001-Fix-mount-point-detection-on-overlayfs-and-similar-f.patch
[13:03] <didrocks> Note the "return a.st_dev != b.st_dev;" if we fail in the fallback
[13:10] <didrocks> pitti: if that makes sense to you, taking my break now :)
[13:10] <pitti> didrocks: I won't say anything to you before you leave :)
[13:11]  * didrocks is gone thus :p
[13:11] <didrocks> (for real)
[13:28] <cyphermox> pitti: didrocks: this is an interesting patch. What bug is it fixing?
[13:29] <pitti> cyphermox: detecting mount points on overlayfs; the other two standard methods don't work due to kernel bugs
[13:30] <cyphermox> I'm dealing with the CD ejection and mountpoint when casper ends, it could be useful
[13:30] <cyphermox> though right now the problem appears to be more with plymouth and/or plymouth's systemd units
[13:32] <pitti> cyphermox: I'm not sure what util-linux' "mountpoint" program does, though
[13:32] <pitti> i. e. if it also just compares stat().st_dev, or falls back to parsing /proc/mounts
[13:32] <cyphermox> ok
[13:32] <cyphermox> I think most of casper is just looking at /proc/mounts
[14:48] <didrocks> pitti: so? :)
[14:49]  * didrocks back from running
[14:50] <didrocks> ah, seems you took it \o/
[14:52] <pitti> didrocks: just back from running as well :)
[14:52] <pitti> didrocks: yep, in exp and uploaded to vivid
[14:52] <didrocks> sweet!
[14:54] <pitti> hm, or did I? /me misses upload and rejection msg
[14:54] <didrocks> pitti: forgot to dput? :p
[14:54] <didrocks> (nothing in -changes)
[14:55]  * pitti dputs again *shrug*
[14:55] <pitti> no, I did have an .upload
[14:56]  * didrocks opens the black hole and looks into it… but nothing :)
[15:07] <seb128> hum, I wonder why gedit is the default handler for text/x-apport types
[15:17] <larsu> seb128: because it's the best
[15:17] <seb128> larsu, ?
[15:17] <larsu> seb128: look at the date
[15:18] <seb128> larsu, it's friday? ;-)
[15:18] <larsu> indeed
[15:18] <seb128> hehe
[15:18] <seb128> I was unsure if that was a real reply or a troll :p
[15:18] <larsu> it's remarkably silent here for a Friday
[15:19] <seb128> $ LC_ALL=C gvfs-mime --query text/x-apport
[15:19] <seb128> Default application for 'text/x-apport': gedit.desktop
[15:19] <seb128> ....
[15:19] <seb128> Recommended applications:
[15:19] <seb128> 	apport-gtk.desktop
[15:19] <seb128>  
[15:19] <seb128> I don't get why gedit is default if the recommended one is apport-gtk
[15:19] <seb128> it's the only .desktop matching the exact mime
[15:20] <larsu> did you override it acceidentally?
[15:20] <larsu> *accidentally
[15:20] <seb128> no, it's the same in a daily iso
[15:20] <seb128> in->on
[15:20] <larsu> weird
[15:22] <seb128> indeed
[15:22] <seb128> I wonder if that's a glib bug
[15:22]  * larsu summons desrt into the second channel in the last 10 minutes
[15:22] <seb128> lol
[15:24] <seb128> oh, look at that
[15:24] <seb128> works if I LD_LIBRARY_PATH glib 2.40
[15:24] <seb128> deeessssrtt
[15:27] <larsu> uh oh
[15:28] <seb128> https://bugzilla.gnome.org/show_bug.cgi?id=744282
[15:29] <seb128> so it's a desrt bug
[15:33] <pitti> seb128: oh, I noticed that gedit is quite greedy these days; it apparently wants to open pretty much anything :/
[15:33] <pitti> I think I even had it open a PDF or iso the other day
[15:33] <seb128> pitti, right, that's due to ^
[15:33] <seb128> the pdf maybe not
[15:33] <pitti> well, maybe not PDF, but something really strange
[15:33] <pitti> it's been a while
[15:34] <seb128> but apparently it prefers the specified handler for subtypes, e.g x-text, which is gedit, to an handle for the exact type
[17:29]  * willcooke -> EOD. 
[17:29] <willcooke> Have a good weekend all, I'm on holiday next week - don't touch my stuff