thumperdavecheney: you around?01:08
davecheneythumper: sorry i missed you02:00
davecheneyi thought the 1:1 was tuesday02:00
thumperah :)02:00
thumperjust last week02:00
thumperI have some time in an hour if that works for you02:01
davecheneythumper: i don't have anythig to talk about02:06
davecheneytomorrow is my last day02:06
davecheneythen i'm taking a few personal days02:06
davecheneythen off to vienna02:06
davecheneysee you in nuremberg02:06
thumperum... ok02:07
davecheneyor we can 1:102:10
davecheneyif you're free02:10
davecheneyif there is stuff you have to talk about02:10
anastasiamacwallyworld_: hi :D03:25
thumperjam: ping for when you are around03:33
anastasiamacwallyworld_: u keep dorpping from canonical ...03:38
anastasiamacwallyworld_: 1.23 and master forwards r up for review03:38
anastasiamacwallyworld_: also map-ordering milestone is 1.24 which is currnt trunk so no backporting is required :D03:38
wallyworld_ok, ta looking03:40
thumperjam: reping04:20
jamhey thumper04:31
thumperjam: just doing expense paperwork04:31
thumperjam: hangout in 5 minutes?04:31
jamthumper: as you'd like, what about?04:32
thumpercontainer stuff04:32
thumperjam https://plus.google.com/hangouts/_/canonical.com/containers04:35
=== JoshStrobl is now known as JoshStrobl-AFK
=== lp|sprint is now known as lazyPower
mattywmorning everyone07:00
dimiternmattyw, o/07:03
jamhey dimitern, want to meet up a bit early?07:05
dimiternjam, hey - yeah, that works for me07:05
jamdimitern: k, I'm there07:06
dimiternjam, omw07:06
TheMuemorning o/ ≋ (windy)07:37
dimiternTheMue, morning07:38
voidspacewallyworld: ping08:22
dimiternvoidspace, dooferlad, morning08:31
dooferladdimitern o/08:31
dimiterndooferlad, I have a PR for you to have a look - https://github.com/juju/juju/pull/1976/08:31
dooferladdimitern: looking08:31
dimiterndooferlad, in retrospect, I should've done that a week ago, but there it is08:32
dooferladdimitern: If you had, I would probably have done a lot less digging into the Juju code. It is all an education.08:33
dimiterndooferlad, that's my consolation :)08:33
dooferladdimitern: :-)08:33
voidspacedimitern: morning08:40
dimiternvoidspace, nice branch btw08:41
dimiternvoidspace, i'll approve it shortly I think08:42
voidspacedimitern: fixing the provisioner issue? cool.08:42
voidspacedimitern: wallyworld reviewed it, but he missed the test I think.08:42
dimiternvoidspace, the maas thing yeah08:42
voidspacedimitern: I have a trunk branch as well, but I haven't submitted it08:42
dimiternvoidspace, was it a diff mismatch on RB or it shows that test?08:42
voidspacedimitern: in case I need to make changes, when the first one lands I'll submit the second08:42
voidspacedimitern: it shows the test, but it's in container_test.go and wallyworld was expecting something in provisioner_test.go08:43
dimiternvoidspace, ah, right08:43
voidspacedimitern: I'm pretty sure that's it anyway, he's not around to ask :-)08:44
wallyworldvoidspace: hi, sorry as having dinner08:52
voidspacewallyworld: you're allowed to have dinner... :-)08:52
wallyworldvoidspace: sorry i missed the test, i'll take another loko08:52
voidspacewallyworld: np08:52
wallyworldvoidspace: actually, i gave you a shipit so go for it, was more of a question seeking clarification08:53
voidspacewallyworld: ah08:53
dimiternvoidspace, reviewed08:53
voidspacewallyworld: well, it was a "Fix it, then ship it!"" with an open issue. I wanted to check with you before just dropping the issue.08:54
wallyworldvoidspace: ah i see what you mean, thanks for asking08:54
voidspacedimitern: thanks08:54
voidspacewallyworld: I have some minor issues from dimitern to fix anyway...08:54
dimiternTheMue, standup?09:02
voidspace... value *errors.Err = &errors.Err{message:"", cause:(*errors.Err)(0xc2100790f0), previous:(*errors.Err)(0xc2100a50f0), file:"github.com/juju/juju/leadership/leadership.go", line:43} ("leadership claim denied")09:34
voidspacedimitern: util_test.go:1406:09:34
frankbanocr: is anyone available for reviewing http://reviews.vapour.ws/r/1324/ ? thank you!09:35
dimiterndooferlad, my branch landed btw10:07
dooferladdimitern: sweet.10:07
dimiterndooferlad, I'm starting on CLI for subnets following the same approach10:07
mattywnatefinch, morning10:37
mattywnatefinch, judging by twitter I'd say you've been watching the news/ reading a paper this morning ;)10:37
natefinchmattyw: been watching the news for a while, just finally figured out how to put my views into 140 characters :)10:37
* TheMue is out for lunch, bbiab10:58
TheMuedimitern: btw, found a nice way to simulate the error, it's pretty simple10:58
dimiternTheMue, yeah? let me know when you're back please11:00
=== JoshStrobl-AFK is now known as JoshStrobl
TheMuedimitern: sure, "select id, hostname from maasserver_node;" resolves the names, then you do a "select id, name from metadataserver_noderesult where node_id = ..." to find the right gathered datas.12:25
TheMuedimitern: interesting is the one named 00-maas-01-lshw.out12:25
dimiternTheMue, yes, indeed12:25
dimiternTheMue, so you managed to reproduce the bug and the error?12:25
TheMuedimitern: having its ids allows you to do a "update metadataserver_noderesult set data = '' where id = 43;"12:26
TheMuedimitern: in a first round the bootstrap funnily wanted exactly my corrupted node, yes, with a matching error like in lp12:26
TheMuedimitern: I then acquired the node to have a working bootstrap and then released it again to simulate the error during deploying12:27
TheMuedimitern: this currently hangs, so I now want to take a deeper look into the logs and await to find the same error there12:28
dimiternTheMue, btw you can specify which node to pick at bootstrap time with --to node.maas12:28
TheMuedimitern: ah, makes the next round a bit more simple12:29
dimiternTheMue, yeah :)12:29
TheMuedimitern: but so it is fine too, with currently only four nodes here you quickly get the right (corrupted) one12:30
dimiternTheMue, so if the error is reproduced, you should see it just before bootstrap outputs Lauching instance XYZ12:30
dimiternTheMue, and the bootstrap should fail12:30
dimiternTheMue, if it keeps going after the instance is started, then it's not reproduced12:31
TheMuedimitern: yeah, I had the same output like in the lp issue12:31
TheMuedimitern: same error message and bootstrapping failing12:31
dimiternTheMue, nice!12:33
voidspacebug 143703812:46
mupBug #1437038: 1.23b2 fails to get IP from MAAS for containers, falls back to lxcbr0 <addressability> <maas-provider> <network> <juju-core:Fix Committed by mfoord> <juju-core 1.23:Fix Committed by mfoord> <https://launchpad.net/bugs/1437038>12:46
mupBug #1438168 was opened: juju 1.23 doesn't release IP addresses for containers <juju-core:In Progress by mfoord> <https://launchpad.net/bugs/1438168>12:48
* dimitern steps out for a while12:56
natefinchperrito666: if you can tweet you can get on the hangout ;)14:03
* dimitern is back14:17
dimiternTheMue, thanks for updating bug 1427814, it's really useful to have the info about how to tweak lshw data in the maas db14:32
mupBug #1427814: juju bootstrap fails on maas with when the node has empty lshw output from commissioning <bootstrap> <maas> <maas-provider> <network> <juju-core:Triaged by themue> <https://launchpad.net/bugs/1427814>14:32
TheMuedimitern: yw14:32
ericsnowcherylj: would you mind updating #1435974 with where things are at with the LICENCE fixes?14:48
mupBug #1435974: Copyright information is not available for some files <juju-core:In Progress by cherylj> <juju-core 1.22:In Progress by cherylj> <juju-core 1.23:In Progress by cherylj> <https://launchpad.net/bugs/1435974>14:48
cheryljericsnow: sure.15:03
ericsnowcherylj: thanks :)15:03
cheryljericsnow: I do have questions about a couple repos.15:04
cheryljI'm guessing we don't need to modify the gojson* repos.15:05
cheryljand the same for syslog15:05
ericsnowcherylj: right15:06
ericsnowcherylj: (since they are slight adaptations of the Go stdlib code and retain that copyright/license)15:07
cheryljI just need to do the charm branches, and I think I'll be done.15:07
cheryljthen on to updating dependencies.tsv15:07
ericsnowdimitern, dooferlad: FWIW, "juju space" is pretty ambiguous; any chance we could name it something more clearly related to networking?15:08
ericsnowcherylj: awesome!  thanks for slogging through all that :)15:08
cheryljericsnow: np!  Although I did run into that unrelated test failure when trying to merge juju/testing 1.2215:09
cheryljthumper just manually merged it last time15:09
voidspacedimitern: can we add a new upgrade step in a bugfix release?15:09
dooferladericsnow: That is a discussion which has started several times and is currently on hold. I expect it will come up at the sprint.15:10
voidspacedimitern: as adding the addresser would require upgrading IP addresses to add a Life field15:10
voidspacedimitern: that seems unfortunate15:10
ericsnowdooferlad: cool, thanks15:10
voidspacedimitern: I have a bunch of patches but I'm not sure what to do about the upgrade step15:10
dimiternsorry guys - in a call15:12
voidspacedimitern: np15:12
cheryljericsnow, natefinch:  since the license is changing for charm, do I need to update all the branches?  Or just 1.22, v4 and v5?15:13
mupBug #1438258 was opened: error while destroying incomplete environment <juju-core:New> <https://launchpad.net/bugs/1438258>15:15
ericsnowcherylj: I'd say consider the branches that will be related to current or future juju releases15:15
natefinchcherylj: don't update old branches (other than 1.22 & v4)15:17
cheryljericsnow, natefinch:  Thanks!15:17
voidspaceericsnow: natefinch: if I want to prepare a binary for someone to try out, know how I should do it?15:17
voidspacewe have a script to do source releases but not binaries15:17
voidspaceI just need an amd64 build15:17
voidspacecan I just tart up juju* from $GOPATH/bin15:18
natefinchvoidspace: yeah, you just need juju and jujud15:18
voidspacenatefinch: cool, thanks15:18
ericsnowvoidspace: just "go install ./juju/..." and send them the file out of $GOPATH/bin, right?15:18
voidspaceericsnow: s/file/files/ but yeah - that's what I thought and natefinch seems to be confirming15:19
ericsnowvoidspace: yep :)15:19
ericsnowvoidspace: BTW, did you see my first-draft poster yet? :)15:19
natefinchyep... nice thing about go.  It's just copy and paste the binaries.  for us, we just need the client and the server15:19
ericsnownatefinch, voidspace: don't the tools also need to get copied (so they can be uploaded)15:20
ericsnownatefinch, voidspace: jujuc, etc.15:20
voidspaceericsnow: natefinch: jujud is "the tools"15:20
voidspaceah, maybe15:20
ericsnowvoidspace: yeah, the hook tools like set-relation15:21
natefinchjujud is the tools, the upload just symlinks jujud to jujuc15:21
natefincher vice versa15:21
ericsnownatefinch: ah15:21
natefinchericsnow: all that stuff, symlinks15:21
ericsnownatefinch: how funny15:21
cheryljokay, I need reviews for the charm license changes:  https://github.com/juju/charm/pull/10715:23
ericsnowjam: thanks (for the calender access) :)15:23
cheryljericsnow: Here's the update list of repos:  https://bugs.launchpad.net/juju-core/+bug/1435974/comments/1115:28
mupBug #1435974: Copyright information is not available for some files <juju-core:In Progress by cherylj> <juju-core 1.22:In Progress by cherylj> <juju-core 1.23:In Progress by cherylj> <https://launchpad.net/bugs/1435974>15:28
cheryljAre there any I missed?15:28
dimiternvoidspace, hey15:33
dimiternvoidspace, so what's the issue with the upgrade step?15:33
ericsnowcherylj: LGTM, thanks!15:37
cheryljyay!  thanks, ericsnow   :)15:37
voidspacedimitern: 1.23 has IP addresses in it15:38
dimiternvoidspace, yeah?15:38
voidspacedimitern: so if we backport "release IP addresses" to 1.23, we'll need an upgrade step from beta2 to beta315:38
voidspacedimitern: adding the Life field to IP addresses15:38
voidspacedimitern: is that ok?15:38
dimiternvoidspace, can we do that?15:40
dimiternvoidspace, aren't the steps based on major/minor versions?15:41
voidspacedimitern: well exactly15:41
voidspacedimitern: I don't think we *can* do it15:41
voidspacedimitern: that's exactly what I'm asking though :-)15:42
dimiternvoidspace, well15:42
voidspacedimitern: the other way is to backport the *original* approach15:42
dimiternvoidspace, I think you could still try to run the step - it shouldn't do any harm if Life is already there15:42
voidspacedimitern: do upgrade steps run at all? I'd have to look through the code to work it out15:43
voidspacedimitern: the original approach was with a Provisioner API instead of a worker15:43
voidspaceand no Life field15:43
voidspaceI still have that code15:43
dimiternvoidspace, hmm15:43
dimiternvoidspace, ok, let's think for a minute15:43
dimiternvoidspace, what's the worst that can happen if we omit this from 1.23?15:44
voidspaceit looks to me like upgrade steps for a version are run / re-run when you upgrade within a version15:44
dimiternvoidspace, addresses won't be released15:44
voidspacei.e. 1.23.1 to 1.23.2 will run 1.23 upgrade steps I believe15:44
dimiternvoidspace, ah - then it might work?15:44
voidspacedimitern: if I'm right15:44
voidspacePerformUpgrade and runUpgradeSteps in upgrades/upgrade.go15:45
mupBug #1438274 was opened: unit test failures: storeManagerStateSuite.TestStateWatcher <ci> <juju-core:New> <https://launchpad.net/bugs/1438274>15:45
dimiternvoidspace, it seems like a quick experiment is needed to verify this15:45
voidspacedimitern: I'll define a new upgrade step that dies horribly and see if it runs :-)15:46
dimiternvoidspace, e.g. start from the earliest possible version that has IP addresses collection, which is actually used15:46
dimiternvoidspace, which should be the 1.23-beta1 right?15:47
voidspacesounds right15:47
voidspacedimitern: but the upgrade step is only on trunk - so I'll either need to do the full port and test that15:48
voidspacedimitern: or just take trunk and change the version back to 1.23-beta3 or whatever15:48
dimiternvoidspace, the latter seems easier15:50
voidspacedimitern: that's what I'm doing15:51
voidspacedimitern: just bootstrapping 1.2315:51
dimiternvoidspace, yeah and deploy some lxc-s15:51
voidspacedimitern: hmm, there's still an issue. This will become a 1.22 upgrade step instead of 1.2315:51
voidspacedimitern: so the upgrade step needs to check if the ipaddress collection exists, and bail without error if it doesn't15:52
voidspaceand it needs to run if upgrading from 1.22 -> 1.2415:52
dimiternvoidspace, considering the steps are idempotent, it shouldn't be a problem to have the same step for 1.22 and 1.23 I guess15:52
voidspacedimitern: yep, true - that solves the problem of 1.23 beta 1 -> 1.2415:53
dimiternvoidspace, sweet!15:53
voidspaceand 1.22 -> 1.24 I think15:53
voidspacein fact 1.23 upgrade steps must run then anyway15:53
voidspaceall intermediate steps must run15:53
voidspacedeploying lxc15:54
cheryljericsnow, natefinch:  Can I get a review on the last license changes?    https://github.com/juju/charm/pull/10716:18
cheryljand the utils changes:  http://reviews.vapour.ws/r/1329/        http://reviews.vapour.ws/r/1328/16:19
voidspacedimitern: it looks like 1.22 steps don't get run when going from 1.23beta3 to 1.23beta416:25
voidspacewhich is odd16:25
voidspaceI'll try again16:25
voidspaceI'm only seeing steps121 in the logs though16:25
dimiternvoidspace, I wouldn't expect 1.22 steps to run for 1.23-beta3 -> 1.23-beta416:26
dimiternvoidspace, but the 1.23 should16:26
voidspacedimitern: well - I'm seeing 1.21 ones run - but neither 1.22 nor 1.23...16:27
dimiternvoidspace, how did you prepare your scenario?16:28
voidspacedimitern: http://pastebin.ubuntu.com/10707700/16:28
voidspacedimitern: juju bootstrap --upload-tools  (branch 1.23)16:28
voidspacedimitern: then "juju add-machine lxc:0" and wait for instance id16:28
voidspacedimitern: then checkout master and do the godeps / go install dance16:29
voidspacewell, after changing version/version.go to 1.23-beta3 (should have picked beta4 but it shouldn't matter)16:29
dimiternvoidspace, and before bootstrap you've rebuilt the juju binaries, right?16:29
voidspacethen "juju upgrade-juju --upload"16:29
voidspacedimitern: yep16:29
voidspacethen "juju upgrade-juju --upload-tools"16:30
voidspaceI mean16:30
voidspacedimitern: http://pastebin.ubuntu.com/10707700/16:30
voidspaceI will try again, with a better new version number and maybe some extra logging16:30
voidspacebut first - coffee16:30
dimiterntime to go16:35
thumpermramm: ping19:53

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!