[09:28] <voidspace> dimitern, ping
[09:28] <voidspace> dimitern, did you see my two branches? ericsnow reviewed them, so I'll try and land them later.
[09:28] <voidspace> dimitern, they're only short, so you may, or may not, want to look at them
[10:06] <voidspace> dimitern: thanks!
[10:16] <aznashwan> hey, could a couple of follow-ups on http://reviews.vapour.ws/r/1218, and, if you guys are really in the review spirit: http://reviews.vapour.ws/r/1330/
[10:49] <frankban> ocr, could you please take a look at http://reviews.vapour.ws/r/1383/ ? thanks!
[13:30] <cherylj> ericsnow: Can you ping me when you get a minute so we can talk about bug 1439447?
[13:30] <mup> Bug #1439447: tools download in cloud-init should not go through http[s]_proxy <cloud-installer> <landscape> <juju-core:Triaged> <juju-core 1.23:Triaged> <https://launchpad.net/bugs/1439447>
[14:02] <ericsnow> cherylj: OTP
[14:40] <ericsnow> cherylj: hangout?
[14:41] <cherylj> ericsnow: sure, let me get my headset on
[15:18] <alexisb> aznashwan, are those the centos support patches?
[15:32] <mup> Bug #1440097 was opened: unittest failure: apiserver/root_test.go:rootSuite.TestPingTimeout <ci> <juju-core:New> <juju-core 1.23:New> <https://launchpad.net/bugs/1440097>
[15:32] <alexisb> just so that folks know all of our scheduled all call reviewers are suppose to be on vacation today
[15:33] <jw4> woot - free for all
[15:35] <natefinch> or free for none ;)
[15:44] <mup> Bug #1440097 changed: unittest failure: apiserver/root_test.go:rootSuite.TestPingTimeout <ci> <juju-core:New> <juju-core 1.23:New> <https://launchpad.net/bugs/1440097>
[15:50] <mup> Bug #1440097 was opened: unittest failure: apiserver/root_test.go:rootSuite.TestPingTimeout <ci> <juju-core:New> <juju-core 1.23:New> <https://launchpad.net/bugs/1440097>
[15:54] <jw4> natefinch: such a downer ;)
[15:54] <natefinch> jw4: I try :)
[16:01] <katco> jw4: hey, wanna rewrite the project in python?
[16:01] <katco> jw4: i bet we can do it before anyone gets back
[16:04] <mgz> katco: you tested the original v4 code against s3 right?
[16:04] <mgz> I think the rest of aws just does it differently
[16:04] <katco> mgz: yes, live tests and all
[16:05] <katco> mgz: except it's passing the amazon test suite just fine
[16:06] <mgz> the region name is different as you pointed out yesterday, and some other stuff
[16:06] <mgz> their test suite is apparently just not as tight as their real auth
[16:07] <katco> hehe possibly
[16:07] <mgz> I'm looking at boto/auth.py HmacAuthV4Handler vs S3HmacAuthV4Handler
[16:10] <katco> mgz: wwitzel3 said he had worked on boto quite a bit, he's peeking at the issue as well. what are the main diffs you're seeing?
[16:12] <mgz> it's slightly annoying as the classes are written differently,
[16:12] <mgz> but the headers that get signed is different, the region format, and some of the sequencing
[16:13] <mgz> S3 signs all headers, general only signs Host and X-Amz-*
[16:13] <jw4> katco: lol
[16:13] <katco> if the headers are present, you must sign them
[16:13] <jw4> katco: we might even get hazmat back if we do
[16:13] <katco> jw4: hehe
[16:14] <mgz> katco: for s3, everything but the Auth itself, yeah, but not in general
[16:14] <aznashwan> alexisb: sorry, got a little distracted with work
[16:14] <aznashwan> alexisb: yes, those are both the CentOS patches
[16:14] <hazmat> katco: i'm listening ;-)
[16:14] <katco> mgz: no, i mean the algorithm requires that. you can't optionally sign headers; i don't think that's a mutable property of the algorithm based on which service
[16:14] <katco> hazmat: haha o/ :)
[16:15] <alexisb> aznashwan, ok, I have had a few folks comment re those patches, I am thinking we may need to do some pair reviewing when we are all in germany
[16:15] <mgz> S3 also doesn't do url path normalisation, whereas the other does
[16:16] <katco> mgz: i don't think we're doing that at all
[16:17] <mgz> which can me something as dumb as trailing slash would break it maybe
[16:17] <aznashwan> alexisb: we have slowly come to terms with the fact that those PR's won't get in until the sprint; but I still like to hope beyond hope :D
[16:17] <katco> mgz: yeah
[16:18] <mgz> like, our failed one was going a GET with a path
[16:19] <mgz> the one that worked was post to root and form-encode body
[16:19] <mgz> so it could be something as dumb as bad path
[16:19] <alexisb> aznashwan, the alternative is to have you break everything down as requested
[16:19] <mgz> katco: but you probably are going to need two versions to keep s3 working at the same time as fixing this
[16:23] <aznashwan> alexisb: as mentioned, the refactor, added CentOS userdata and package management changes are so inter-dependent that breaking them up would take a tone of re-work, writing temporary code which only gets overwritten in the following PR, and triple/quadruple the pain of maintaining the PR's rebased unto master
[16:24] <katco> awesome, my robot vacuum cleaner just unplugged my computer
[16:25] <katco> IoT ftw
[16:26] <mgz> ehehe
[16:26] <mgz> rise of the downtrodden robots!
[16:26] <katco> i definitely kicked it
[16:28] <aznashwan> alexisb: that would add an overall delay of at least a month whilst the PR as is now is merge-able with the exception of a handful of tests which are still not CentOS-ready
[16:28] <katco> this is when you discover the temporary work you were doing in /tmp is less temporary than you would have liked.
[16:28] <aznashwan> (...which we are working on as we speak)
[16:29] <natefinch> gah, stupid f'ing machiner... I don't know how the hell you're supposed to use this thing.  It hides everything under too many layers of abstraction.
[16:30] <alexisb> aznashwan, then I suggest we plan to have a dynamic review session in person
[16:32] <aznashwan> alexisb: would not be too bad if it comes to that. I would insist to still get a review here-and-there in the mean time so we get the small stuff ironed out before the sprint so we focus on the bigger picture there.
[17:04] <katco> mgz: i think i found the problem
[17:05] <katco> mgz: i vaguely recall removing default paths "/" from the canonical request string for S3 b/c that was causing an issue
[17:05] <katco> mgz: it looks like adding that in gets me a result
[17:06] <mgz> katco: ha, was paths :)
[17:06] <katco> mgz: i tip my hat to you, sir
[17:06] <mgz> :D
[17:06] <katco> mgz: and i then slap aws's collective faces with it.
[17:06] <katco> mgz: what an undocumented mess
[17:09] <katco> mgz: https://github.com/go-amz/amz/commit/3431a6c7dea296878e5efa2681e85e0b1a2f5a27#diff-5f72c79adc6ba80e9d4d6cf78433008eL151
[18:08] <katco> mgz: feel like a review? https://github.com/go-amz/amz/pull/47
[18:08] <mgz> katco: surething
[18:11] <katco> ah foo i broke a signing test. those things are so fragile
[18:11] <mgz> yeah, was wondering if more tests would need changing
[18:11] <katco> nah it's just a space
[18:12] <mgz> so if it works with s3 and ec2, I think this is basically good to go
[18:12] <mgz> this isn't super-robust, callers can still pass in stuff that will mess this up I'm pretty sure
[18:13] <katco> mgz: i think we're still broke on relative paths "/../.." or something
[18:13] <mgz> and I don't like the date-magic
[18:13] <katco> date magic?
[18:13] <mgz> katco: yeah, and probably double slashes as well
[18:13] <katco> yeah those tests fail
[18:13] <mgz> the pass in a x-amz-timestamp in nay random format and get it back out the right way code
[18:14] <mgz> I'd prefer we just demanded a sensible time object in the interface or something
[18:14] <katco> well, smallest change possible.
[18:14] <mgz> but that's not something that really needs changing right now
[18:14] <katco> right
[18:14] <mgz> right, I agree
[18:14] <katco> repushed with test fix
[18:14] <katco> just added some spaces
[18:16] <mgz> katco: lgtm
[18:17] <katco> mgz: do we have this behind a bot yet?
[18:19] <mgz> katco: it's got a funny pre-merge check thing instead, which passed
[18:21] <katco> mgz: ok, so merge manually?
[18:22] <mgz> yeah, oh, travis runs against both go 1.2 and go 1.4, interesting
[18:22] <mgz> only the unit tests obviously but fine
[18:43] <cherylj> natefinch: I heard you had some thoughts about bug 1439447.  Don't know if you wanted to weigh in before I make any code changes...
[18:43] <mup> Bug #1439447: tools download in cloud-init should not go through http[s]_proxy <cloud-installer> <landscape> <juju-core:In Progress by cherylj> <juju-core 1.23:In Progress by cherylj> <https://launchpad.net/bugs/1439447>
[18:53] <katco> mgz: so i'm trying to test this in 1.23
[18:54] <katco> mgz: and when i bootstrap i get a bootstrap failure
[18:54] <natefinch> cherylj: my thought was basically that we should have a configuration that lets the user decide whether juju uses the proxy to connect to other machines in the environment or not.
[18:54] <mgz> katco: as in, the machine doesn't come up?
[18:54] <katco> mgz: "ERROR failed to bootstrap environment: Juju cannot bootstrap because no tools are available for your environment."
[18:54] <mgz> katco: with --upload-tools?
[18:54] <natefinch> cherylj: since it seems to me that it's likely that no matter which way we decide to do it, someone's going to want it to work the other way
[18:54] <cherylj> natefinch: ha, too true
[18:55] <katco> mgz: i knew it was something dumb
[18:56] <katco> cherylj: looking forward to charming at the sprint. it would be nice if i actually got to work WITH juju more, and not just ON it :)
[18:56] <cherylj> katco: me too!  It should be fun and I think alexisb is working on some actual prizes for the teams :D
[18:58] <mgz> katco: ...that's just begging for a cheesy joke
[18:58] <mgz> why do all the things we work with have silly names
[18:58] <katco> mgz: please proceed :)
[18:59] <mgz> well, you're clearly charming already?
[18:59] <katco> LOLOLOLOL
[18:59] <katco> 10 points england.
[19:01] <katco> mgz: (et. al.) http://reviews.vapour.ws/r/1386/
[19:02] <katco> mgz: and it would be super awesome if you could try china again
[19:03] <katco> 1 line change btw
[19:03] <redelmann> hi, is safe to deploy block-storage-broker to machine0??
[19:03] <mgz> katco: lgtm, how to the multiple branches with go-amz work? change also needs to land on v4-unstable, or does v3 get merged up periodically?
[19:04] <redelmann> create one instance just to manage credential is overkilling
[19:04] <katco> mgz: i think dimiter merges changes to v3 up to v4 occasionally
[19:04] <mgz> katco: I'll merge that locally and see
[19:04] <katco> mgz: i don't know why we branch an unstable before we have unstable changes actually
[19:04] <katco> mgz: seems like it creates a lot of work
[19:04] <mgz> discourage people from landing features on an active verion I'm guessing
[19:04] <mgz> er... s/active/stable/
[19:06] <mgz> redelmann: that may be a better question for #juju - but gernally feel free to smoosh till something actually breaks
[19:06] <redelmann> mgz, thank!!
[19:07] <katco> mgz: and trunk: http://reviews.vapour.ws/r/1388/
[19:14] <mgz> whoops, used wrong key
[19:14] <mgz> well, it bootstrapped till the ssh step
[19:15] <katco> :)
[19:27] <katco> mgz: can i get a rq lgtm on http://reviews.vapour.ws/r/1388/?
[19:27] <mgz> I was trying to make sure it works first, but this ssh step hates me ;_;
[19:27] <katco> oh, no worries then
[19:27] <katco> take your time
[19:28] <mgz> I can ssh into the address fine, but juju refuses to for some reason
[19:28] <katco> weird...
[19:28] <mgz> but prints stuff out the first time I do on another console? bootstrap is too darn complicated these days
[19:29] <natefinch> these days? :)
[19:30] <mgz> get off my lawn!
[19:30] <natefinch> haha
[19:30] <mgz> okay, now it's running
[19:30] <katco> haha
[19:30] <mgz> I have no idea what was happening there
[19:31] <mgz> katco: so, basically, api queries do now work
[19:31] <mgz> and my china bootstrap is happily installing packages currently
[19:31] <katco> o/ <--- tiny lighter you can't see
[19:31] <natefinch> haha... I spent all day trying to debug an api connection problem and somehow forgot to look at the log for machine 0..... where it was evidently filling up with panics :/
[19:31] <mgz> stamped the trunk dep update too
[19:32] <mgz> joy
[19:32] <katco> mgz: so to sum things up
[19:32] <katco> mgz: i finally accomplished the first task i was given when i started canonical.
[19:32] <katco> mgz: and it only took me about a year. :)
[19:33] <mgz> https://pastebin.canonical.com/128953
[19:34] <katco> woohoo!
[19:34] <katco> that is great to see! :D
[19:35] <mgz> hey, getting it done is getting it done :)
[19:40] <mgz> katco: when the 1.23 branch goes through, I'll take the deb and set up a cloud-health job for the china region, hopefully later tonight
[19:40] <katco> mgz: :D
[19:41] <mgz> natefinch: juju running on az-cn is something we can talk about publically right (slightly late, wtv)
[19:42] <natefinch> dhah
[19:42] <natefinch> ¯\_(ツ)_/¯
[19:43] <natefinch> honestly no clue
[19:53] <alexisb> all, I have to go pick up kiddo realy from grandma's today, so I am will be out until james gets back from work
[19:53] <alexisb> so everyone have a very happy holiday weekend!
[19:58] <katco> alexisb: tc!
[19:58] <katco> alexisb: habe a great weekend
[21:18] <mup> Bug #1440199 was opened: api/uniter: Panic: stateSuite.TearDownTest <ci> <test-failure> <unit-tests> <juju-core:New> <https://launchpad.net/bugs/1440199>
[21:18] <mup> Bug #1440205 was opened: cmd/juju: PANIC: addrelation_test.go:11: SetUpTest.pN39_github_com_juju_juju_cmd_juju.UserSuite <ci> <test-failure> <unit-tests> <juju-core:New> <https://launchpad.net/bugs/1440205>
[21:18] <mup> Bug #1440209 was opened: juju action do doesn't accept non-string params on command line <juju-core:New> <https://launchpad.net/bugs/1440209>
[21:24] <mup> Bug #1440213 was opened: worker/uniter: TestLeadership.pN51_github_com_juju_juju_worker_uniter_test.UniterSuite <juju-core:New> <https://launchpad.net/bugs/1440213>
[21:30] <ericsnow> cmars: you have a minute to look over http://reviews.vapour.ws/r/1380/?
[21:31] <ericsnow> cmars: I've switched it over to YAML and am using the new cmd.FileVar.Open method
[21:36] <mup> Bug #1440213 changed: worker/uniter: TestLeadership.pN51_github_com_juju_juju_worker_uniter_test.UniterSuite <juju-core:New> <https://launchpad.net/bugs/1440213>
[21:48] <mup> Bug #1440213 was opened: worker/uniter: TestLeadership.pN51_github_com_juju_juju_worker_uniter_test.UniterSuite <juju-core:New> <https://launchpad.net/bugs/1440213>
[21:48] <mup> Bug #1440219 was opened: worker/uniter:TestLeadership.pN51_github_com_juju_juju_worker_uniter_test.UniterSuite <juju-core:New> <https://launchpad.net/bugs/1440219>