| robru | Hey release team, does this change need an FFe? https://ci-train.ubuntu.com/job/ubuntu-landing-006-2-publish/81/artifact/libqtdbusmock_packaging_changes.diff/*view*/ it technically adds new features but they're only used for testing as far as I can tell, shouldn't affect the image really | 01:30 |
|---|---|---|
| infinity | robru: I wonder what "futher" is. | 01:32 |
| robru | infinity: new NSA spying tools surely. | 01:33 |
| infinity | robru: Anyhow, that sure likes like features to me, but without seeing the actual diff, who can say how invasive it is. | 01:34 |
| robru | infinity: https://ci-train.ubuntu.com/job/ubuntu-landing-006-2-publish/lastSuccessfulBuild/artifact/libqtdbusmock_content.diff/*view*/ here's the full diff | 01:35 |
| infinity | robru: THat said, I assume from the package name that the whole thing is just a mocking tool, so if things that use it for tests don't all regress, it's probably fine. | 01:35 |
| robru | infinity: that's what I was thinking | 01:35 |
| infinity | robru: So, the output of "reverse-depends -b src:libqtdbusmock" is rather short. | 01:36 |
| infinity | robru: If there's any concern at all, copy all of those into the same silo, see if they build and pass their testsuites, then delete them before you publish. | 01:36 |
| robru | infinity: looks right to me (although I'm not intimiately familiar). it is a newish tool | 01:36 |
| robru | infinity: define concern? is it not ok to just publish this and let the regular proposed-migration decide whether it regresses or not? | 01:37 |
| infinity | robru: p-m won't notice this sort of regression, unless all those rdeps happen to have autopkgtests that rebuild the packages and rerun the testsuites. Which they might, but might not. | 01:37 |
| infinity | robru: I dunno, I'm not hugely concerned. It's the same upstreams (more or less) for all of this, so if they broke their own testing tool, they'll find out soon enough. :P | 01:38 |
| robru | infinity: well indicator-network is already part of the same silo and it passed the build & also went through qa already | 01:38 |
| infinity | robru: Did it pull in the new libqtdbusmock when it built, though? | 01:39 |
| robru | infinity: hm, let me check that... | 01:39 |
| * infinity looks for a build log. | 01:39 | |
| infinity | Yup, it did. | 01:40 |
| infinity | That satisfies me, then. | 01:40 |
| robru | infinity: yeah just grabbed the buildlog myself, looks legit | 01:40 |
| infinity | No further FFe faff needed, let 'er go. | 01:40 |
| robru | infinity: ok thanks | 01:40 |
| robru | infinity: seems libqtdbusmock got stuck in UNAPPROVED, can you poke that through? thx | 03:06 |
| infinity | robru: Was planning on it, just went out for a burger. :P | 03:53 |
| robru | infinity: ah, thanks | 03:59 |
| === adam_g is now known as adam_g_out | ||
| smoser | can i get someone to take a look at taht ^ | 15:19 |
| smoser | didrocks, are you able ? | 15:19 |
| ogra_ | no, he is french | 15:20 |
| ogra_ | :P | 15:20 |
| didrocks | smoser: I'm not in the release team, so I technically can, but can't :p | 15:58 |
| smoser | i didn't know if you were on release team. | 16:01 |
| smoser | so ogra_, it wasn't *just* because he's was french. | 16:02 |
| * smoser works on his english :) | 16:02 | |
| didrocks | ahah | 16:03 |
| smoser | pretty please, can someone on the release team ack that for me ? the bug has hopefully reasonable description of why the fix is ok. | 16:29 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!