[01:30] Hey release team, does this change need an FFe? https://ci-train.ubuntu.com/job/ubuntu-landing-006-2-publish/81/artifact/libqtdbusmock_packaging_changes.diff/*view*/ it technically adds new features but they're only used for testing as far as I can tell, shouldn't affect the image really [01:32] robru: I wonder what "futher" is. [01:33] infinity: new NSA spying tools surely. [01:34] robru: Anyhow, that sure likes like features to me, but without seeing the actual diff, who can say how invasive it is. [01:35] infinity: https://ci-train.ubuntu.com/job/ubuntu-landing-006-2-publish/lastSuccessfulBuild/artifact/libqtdbusmock_content.diff/*view*/ here's the full diff [01:35] robru: THat said, I assume from the package name that the whole thing is just a mocking tool, so if things that use it for tests don't all regress, it's probably fine. [01:35] infinity: that's what I was thinking [01:36] robru: So, the output of "reverse-depends -b src:libqtdbusmock" is rather short. [01:36] robru: If there's any concern at all, copy all of those into the same silo, see if they build and pass their testsuites, then delete them before you publish. [01:36] infinity: looks right to me (although I'm not intimiately familiar). it is a newish tool [01:37] infinity: define concern? is it not ok to just publish this and let the regular proposed-migration decide whether it regresses or not? [01:37] robru: p-m won't notice this sort of regression, unless all those rdeps happen to have autopkgtests that rebuild the packages and rerun the testsuites. Which they might, but might not. [01:38] robru: I dunno, I'm not hugely concerned. It's the same upstreams (more or less) for all of this, so if they broke their own testing tool, they'll find out soon enough. :P [01:38] infinity: well indicator-network is already part of the same silo and it passed the build & also went through qa already [01:39] robru: Did it pull in the new libqtdbusmock when it built, though? [01:39] infinity: hm, let me check that... [01:39] * infinity looks for a build log. [01:40] Yup, it did. [01:40] That satisfies me, then. [01:40] infinity: yeah just grabbed the buildlog myself, looks legit [01:40] No further FFe faff needed, let 'er go. [01:40] infinity: ok thanks [03:06] infinity: seems libqtdbusmock got stuck in UNAPPROVED, can you poke that through? thx [03:53] robru: Was planning on it, just went out for a burger. :P [03:59] infinity: ah, thanks === adam_g is now known as adam_g_out [15:19] can i get someone to take a look at taht ^ [15:19] didrocks, are you able ? [15:20] no, he is french [15:20] :P [15:58] smoser: I'm not in the release team, so I technically can, but can't :p [16:01] i didn't know if you were on release team. [16:02] so ogra_, it wasn't *just* because he's was french. [16:02] * smoser works on his english :) [16:03] ahah [16:29] pretty please, can someone on the release team ack that for me ? the bug has hopefully reasonable description of why the fix is ok.