tsdgeosautopilot still not passing when it's not hanging :/07:30
tsdgeosseems the card dednick and me did last sprint may need resurrection07:31
Saviqtsdgeos, FWIW two of those are new from dednick07:41
tsdgeosso we kind of fixed the olds and sneaked new wrong ones?07:41
=== marcusto_ is now known as marcustomlinson
Saviqtsdgeos, so yeah, "good" news confirmed, got it to crash with NO_REGALLOC07:43
SaviqI *think*, although the .crash's ProcEnviron doesn't list it :/07:44
Saviqah but apport actually strips the environ07:44
Saviqyup, job still has it07:45
tsdgeostsdgeos_work@xps:~$ du -hs /home/tsdgeos_work/.cache/ubuntuimages/07:48
tsdgeos14G     /home/tsdgeos_work/.cache/ubuntuimages/07:48
* tsdgeos recovers some easy space07:49
Saviqtsdgeos, `ubuntu-device-flash --clean-cache touch` FTW07:50
tsdgeosubuntu-device-flash is too obnoxious over the command line arguments order07:50
tsdgeoscouldn't get it to work07:51
tsdgeostsdgeos_work@xps:~$ ubuntu-device-flash --clean-cache07:51
tsdgeosDEPRECATED: Implicit 'touch' subcommand assumed07:51
tsdgeosunknown flag `clean-cache'07:51
tsdgeostsdgeos_work@xps:~$ ubuntu-device-flash touch --clean-cache07:51
tsdgeosunknown flag `clean-cache'07:51
Saviqtsdgeos, yeah, you need "touch" at the end07:53
Saviqtsdgeos, some args are pre-subcommand, others ar post-subcommand,  and the implicit "touch" subcommand is, as stated ↑ deprecated (even though in this case it should work)07:54
tsdgeosSaviq: so you basically start & stop until it crashes?08:32
tsdgeosi'm also a bit confused as to what the shellRotation branch does08:34
tsdgeosshould it actually rotate the shell08:34
tsdgeosbecause i can't get the dash nor the launcher to rotate08:35
tsdgeosor this is only for N7?08:35
Saviqtsdgeos, launch an app08:44
Saviqtsdgeos, dash is portrait08:44
Saviqtsdgeos, and yeah, it just dies on start 50% of the time or so08:44
tsdgeosit dies on stop here08:46
tsdgeosbut not on start :/08:47
Saviqtsdgeos, yeah, on stop reliably, on start less so08:55
Saviqtsdgeos, how you launching? upstart or trying to get it under gdb?08:55
tsdgeosi was trying upstart08:56
tsdgeosbut if you have better suggestions08:56
tsdgeosi just want it to crash once :D08:56
Saviqupstart's fine, but "kill -9 `pidof unity8`" instead of initctl stop08:56
Saviqtsdgeos, this way you won't need to fight with apport/whoopsie08:56
Saviqand probably stop unity8-dash and maliit-server to not crash08:57
tsdgeosSaviq: which phone are you using?09:11
Saviqtsdgeos, mako09:11
tsdgeosi can't still reproduce it not even once :/09:11
tsdgeossame here09:11
Saviqtsdgeos, you got unity8 from demo-stuff?09:12
tsdgeosi checked that the shell rotates when rotating the webbrowser09:12
tsdgeosthat's it, no?09:12
Saviqyou could try running the ap tests in a loop until it fails (but it also rarely fails without unity8 crashing)09:13
tsdgeosmy problem is09:13
tsdgeosi can get it to enter the "dbus deadlock" quite easily09:13
tsdgeosso any kind of looping is useless09:13
tsdgeossince it will get stuck in there09:13
Saviqtsdgeos, interesting, I'm not getting that so often ;)09:14
Saviqtsdgeos, maybe try with my screen+gdb upstart hack, gdb should be enough I think to kick the dbus lock away, and then when it happens you got it under gdb already09:16
Saviqsee my big comment in https://trello.com/c/lAudAZVp/40-13-shell-rotation-mp-review-iteration-on-feature-and-autopilot-tests09:17
tsdgeosand now suddenly i'm getting it more09:28
Cimimzanetti, I'm having a look at recency for the spread, how would you recommend storing the list of apps and storing screenshots?10:31
mzanettiCimi, in qtmir10:31
mzanettiCimi, ApplicationManager.cpp10:31
mzanettiCimi, basically what needs to happen is that on startup the ApplicationInfo objects are stuffed into the ApplicationManage again10:32
Cimimzanetti, ApplicationInfo is stored on the disk?10:33
mzanettiCimi, but with status "suspended" (or stopped - can't recall which one is for "not running" but still running)10:33
mzanettiCimi, no. they are not yet...10:33
mzanettiCimi, on shutdown you'd need to store the appids for all the existing applicationinfo objects10:34
mzanettiCimi, and on startup create new objects for each stored appid10:34
mzanettiCimi, there is already a branch that adds gsettings to the applicationmanager10:34
mzanettiCimi, in case you are going to use gsettings, you might want to build on top of that10:34
Cimimzanetti, want to use gsettings?10:35
Cimii'm fine with that10:35
mzanettimy first guess would be yes. I think Saviq said we should talk to cwayne if he's fine with that10:35
mzanettiin regard to customization10:35
Cimilauncher uses gsettings, right?10:36
mzanettiyeah, seems to be our standard mean of storing things... so...10:36
Cimimzanetti, I used it with gtk in the past too10:36
Cimiso is there probably for legacy, not sure the alternative qt has10:37
Cimimzanetti, btw, which is that branch? :)10:37
Cimimzanetti, https://code.launchpad.net/~mzanetti/qtmir/exception-settings/+merge/252921 ?10:38
mzanettiCimi, yep10:38
Saviqmzanetti, Cimi, I'm only worried gsettings could be too heavy, or that it can't store enough data when someone has 100 apps open10:39
mzanettiSaviq, are there limits?10:39
Saviqmzanetti, that's what I don't know :)10:39
CimiSaviq, we can limit those 100 anyway10:39
SaviqCimi, what if the limit is 10? :P10:40
=== marcusto_ is now known as marcustomlinson
mzanettiwell, it isn't 1010:40
mzanettiotherwise the launcher wouldn't work10:40
SaviqI know, shh!10:40
mzanettibut ok... Cimi I guess you'd need to find out if there are limits, and what they are10:40
Cimimzanetti, I was googling already10:41
mzanettialso some load test with storing/reading some 100 appids or so10:41
Saviqyeah, that's what I'm most worried10:42
Saviqhaving to construct/store a list on every focus change10:43
mzanettiCimi, ^10:43
SaviqCimi, mzanetti, and then there's looking forward towards desktop, this is basically a "restore session" feature, will we need to store more details, like window state/geometry, or do we rely on the current window geometry restore (or on Mir, for that matter?)10:45
Saviqgreyback_, FYI ↑ (this is about storing spread)10:45
Cimi"Reads and writes can be considered to be non-blocking. Reading settings with GSettings is typically extremely fast: on approximately the same order of magnitude (but slower than) a GHashTable lookup. Writing settings is also extremely fast in terms of time to return to your application, but can be extremely expensive for other threads and other processes. Many settings backends (including dconf) have lazy initialisation whi10:45
Cimich means in the common case of the user using their computer without modifying any settings a lot of work can be avoided. For dconf, the D-Bus service doesn't even need to be started in this case. For this reason, you should only ever modify GSettings keys in response to explicit user action."10:45
mzanettiCimi, I don't think the geometry settings should be in this place10:46
Saviqyeah, so gsettings/dconf is optimized for reading, not writing10:46
Saviqwhich is why I'm not totally sure this is the right thing to do10:47
Saviqwe can still read the default set from gsettings, but that's it10:47
greyback_Saviq: why save for every focus change? Why not just on shutdown?10:47
Cimigreyback_, if the phone dies/crashes10:47
Saviqgreyback_, yeah, ↑10:47
Cimimaybe not on focus change, maybe on app load/quit10:47
Cimibut then we want the ordering...10:48
Saviqwell, if we lose ordering then maybe that's not as bad10:48
Saviqif we at least have the correct set10:48
SaviqMacSlow, so... tsdgeos to the rescue... `rm -R ~/.cache/QML` and no crash any more...10:49
Saviqbug #144493710:49
ubot5bug 1444937 in qtdeclarative-opensource-src (Ubuntu) "QML cache gets stale too easily" [Undecided,Confirmed] https://launchpad.net/bugs/144493710:49
MacSlowSaviq, oh ha...10:49
MacSlowtsdgeos, how did you figure out that one?10:50
* MacSlow tries right away10:50
tsdgeosMacSlow: actually i didn't, the Qt guys kind of did10:50
tsdgeossaying "this is impossible to happen"10:50
tsdgeosand then i thought, "oh noes, the cache is making the impossible possible"10:51
MacSlowtsdgeos, haha... nothing is impossible :)10:51
CimiSaviq, what else can we use to store? remember we also want to store the application screenshots10:51
Mirvthat's why my script always clears QML cache before starting to test a PPA10:52
MacSlowMirv, tsdgeos: I'll put that in my ~/.bashrc or something like that10:52
SaviqMirv, please comment on bug above ↑ if you have something to add, I really think we need something that just does it, we'll be forgetting it otherwise10:53
greyback_Saviq: Cimi: well saving to gsettings for every focus change sounds heavy-handed to me, writing to a file might be just as good10:53
SaviqMacSlow, so yeah, 8 successful runs of the rotation tests in a row, but I did get http://pastebin.ubuntu.com/10832212/ at some point10:53
MirvSaviq: commented10:54
MacSlowSaviq, ah... that's new10:54
Saviqgreyback_, I'm thinking DB, updating just a focus timestamp10:54
Saviqgreyback_, we already have a DB for the geometry10:54
Mirvmy guess is that app upgrades are being taken care of, but better be sure10:54
Cimihow will the images be stored? hard drive?10:55
SaviqCimi, where else? printouts? :P10:55
CimiSaviq, in a db10:55
mzanettiSaviq, https://code.launchpad.net/~mzanetti/unity8/fix-dnd-cancelling/+merge/25646210:55
SaviqCimi, db not on hard drive? ;)10:55
CimiSaviq, at that point, we can use a naming conversion to store appId, screenshot, timestamp10:55
CimiSaviq, ouch, I meant file :D10:55
Mirvtsdgeos: FYI I'm doing another qtbase landing with arale workaround for black browser tabs, while waiting for the DBus one. after it has landed, we can start considering whether to land the current pile of patches to vivid-rtm PPA only. but we need the final upstream solution anyway sooner or later to w.10:56
Cimiif we save the images as files, we can name them in a way that we don't need anything else10:56
SaviqCimi, but you'd then have to rename them on focus changes10:57
SaviqCimi, and then either finding the file for display or sorting would be weird, because you either have to slap a timestamp at the front or the back10:58
mzanettigeez. all my launchers in a bad state right now :D10:58
Saviqmzanetti, let's just hope that's really the only reason this happens11:00
greyback_Saviq: sure, that works, but that db lives in unity8 atm, and I don't think it belongs in qtmir11:01
CimiSaviq, at the front, they are ordered, no?11:02
Cimiah but removing them is complicated, yeah11:02
CimiSaviq, but we care less about removing apps, if is slower11:02
SaviqCimi, well, unlinking a file isn't complicated11:03
CimiSaviq, is good to have fast app loading, less app killin11:03
SaviqCimi, the only bit that'd be weird is finding the screenshot file for an app, you'd need to glob it11:03
Cimiwe load an app, we store a screenshot with timestamp-appId.png11:03
tsdgeosMirv: yeah, at some point thiago convinced himself to try to install KDE Frameworks 5 on his heavily patched Qt and reproduce the problem directly instead of using me as a proxy11:04
Cimiwhen we close the appId, spread will remove *appId.png, no?11:04
tsdgeosso it may happen sooner than later11:04
Saviqgreyback_, did I say anything about qtmir? :)11:04
greyback_Saviq: ok so11:05
SaviqCimi, yeah, the * part is what worries me11:06
SaviqCimi, but more for loading than for removing11:06
Saviqlike I can imagine we'll be destroying the app delegates (if we're not already), would we then not lose the filename when we need to bring it back?11:08
Saviqmzanetti, greyback_, where are we storing the half-res screenshots now, for apps that got OOM-killed? in mem?11:08
greyback_Saviq: in memory11:09
Saviqok we need to offload those to disk too11:09
mzanettiand also on top of the surface. imo that should be baked into the mirsurfaceitem and be transparent to the shell11:09
SaviqGerry disagrees ↑ ;)11:10
mzanettiyeah :D11:10
mzanettiwell, don't think so11:10
SaviqMacSlow, some 20 successful runs now11:11
mzanettiat least some few weeks back he didn't11:11
greyback_darn ctrl+d and multimonitor11:11
SaviqMacSlow, (or my loop isn't doing a good job at detecting failures)11:11
davmor2Saviq: kgunn: we seem to be getting file:///usr/lib/arm-linux-gnueabihf/unity8/qml/Dash/createCardComponent:132:1: QML Label: Binding loop detected for property "height" on arale is this just because of the drivers or is it something else?11:12
Saviqdavmor2, we're getting this outisde of arale just as well11:12
Saviqdavmor2, has nothing to do with graphics11:12
SaviqMacSlow, in any case, it's time to give this all up for review11:12
davmor2Saviq: I've not seen it on krillin for a while11:12
Saviqdavmor2, it's just a warning11:13
Saviqdavmor2, and is timing-related, which might be why you're not seeing it always11:13
SaviqMacSlow, and you try and see if you can fix http://pastebin.ubuntu.com/10832212/11:13
davmor2Saviq: fair enough we have a regerssion test for it and it failed on arale is all11:13
Saviqdavmor2, you have a regression test for a warning line? :D11:14
MacSlowSaviq, +111:14
Saviqdavmor2, or is there an actual visual artefact of this?11:14
davmor2Saviq: it's more that it appears when the screen stutters between scopes11:14
SaviqMacSlow, just to be clear: you don't need silo 004, just demo-stuff11:14
davmor2swiping between scopes even11:14
MacSlowSaviq, sure... I'll MP it before lunch11:14
Saviqdavmor2, just to be clear: not a regression :)11:15
Saviqdavmor2, we've never "fixed" all the reasons for the stutter11:15
davmor2Saviq: that's fine then11:16
=== davidcalle_ is now known as davidcalle
MacSlowSaviq, will the demo-stuff bits also be moved into proper MPs, thus these can be states as prerequisites for the shellRotation MP?11:20
SaviqMacSlow, everything in there is MP'd afaict11:20
SaviqMacSlow, see description ↑11:22
MacSlowSaviq, ok11:24
Saviqok not everything is MP'd, will talk to dandrader when he shows up11:24
tsdgeos:D i did so many "wrong" patches to qt quick text item that the reviewer actually wrote the correct patch himself :D11:24
tsdgeosguess it's not that bad that my prodding got him to write it11:24
MacSlowtsdgeos, :)11:24
SaviqMacSlow, do you know where "unsupported orientation TOP-DOWN. skipped." comes from?11:25
Saviqwe should get rid of that print11:26
MacSlowSaviq, from the test itself... the fake-sensor/device does not allow the "top-down" orientation.11:27
MacSlowand I wanted that to show... so whoever happens to watch the test and wonders why only 3 of 4 possible cases were exercised sees at least some info11:28
SaviqMacSlow, interesting, anyway, it should not be a print() or whatever it is, but a log instead (see process_helpers.py for example of how to use the logger)11:28
MacSlowSaviq, ok... will change that11:28
=== alan_g is now known as alan_g|gone
SaviqCimi, mzanetti, so, since the screenshot bit should be disconnected from the spread memory bit, I'd say screenshots should be saved to $cacheDir/app_shots/$app_id.png, with the shell not knowing whether it's showing a harddrive screenshot, an in-memory one, or the app surface12:10
mzanettiIMO, yes12:11
SaviqCimi, mzanetti, spread set we should store in the shell's window geometry Db, as a {focus_timestamp, app_id} tuple12:11
mzanettibasicall the MirSurfaceItem paints a surface... wherever that comes from, it shouldn't care12:11
Saviqfalling back to a gsetting if Db is empty, for customization purposes12:12
Saviqmzanetti, will that work fine with splash screens though?12:12
mzanettiSaviq, doesn't really matter, does it?12:13
Saviqmzanetti, I'm just asking - as long as qtmir handles the screenshots (i.e. deletes them when user closes an app)12:13
mzanettiSaviq, well, the splash is a bit different anyways12:14
Saviqthen the first app frame might come from either shot or app for real12:14
Saviqand that will hide splash screen12:14
mzanettiSaviq, if the phone is rebooted, then you're saying the shell should look up it's settings and call ApplicationManager.startApplicationStopped(appId) for each one?12:17
mzanettiits, even12:17
Saviqmzanetti, I think we should add API to tell AppMan all of them at once12:18
mzanettiwhy not just keeping this inside the appmanager?12:18
Saviqmzanetti, I don't think greyback_ wants that in qtmir12:19
mzanettibut all the rest in this regard is in qtmir too12:19
mzanettiwell, in the applicationmanager model12:19
mzanettii.e. the shell says startApplication and qtmir transparently stops it. why should the shell then suddenly care about stopped/vs running?12:20
Saviqmzanetti, oh no, sure it shouldn't12:20
Saviqmzanetti, that's why I'm saying AppMan.restoreApps(list_of_apps) or something12:21
Saviqmzanetti, then appman will *really* only launch the topmost app, or even none, until it's focused12:21
Saviqbut it will populate the app model12:21
mzanettimhm... worksforme12:22
Saviqit's the list_of_apps I don't think greyback_ wants in qtmir, and I'm fine with that12:23
Saviqand we can relatively easily do AppMan.restoreApps(db.count > 0 ? db.list_of_apps : gsettings.default_list_of_apps)12:24
mzanettiyeah... fine with that too I guess...12:24
* Saviq writes down in description12:29
MacSlowSaviq, I've changed the shell-rotaion test to use logger instead of print and added description and commit-message. Before flipping the switch to "needs review" I'm now looking into the assertion-mismatch issue.12:30
=== MacSlow is now known as MacSlow|lunch
SaviqMacSlow|lunch, tx12:33
SaviqCimi, mzanetti, so the only remaining question, I think, is first boot screenshots12:44
=== MacSlow|lunch is now known as MacSlow
SaviqMacSlow, I wonder, could the failure just be a timing thing? you're using assertThat, you don't give any time for things to settle maybe?13:39
Saviqdandrader, hey, could you please make sure all shellRotation-related branches are MP'd and in Needs Review (and trunks merged for good measure)13:40
=== lool- is now known as lool
dandraderSaviq, ok. So cleaning the QML cache solves the crashes afterall?13:50
Saviqdandrader, yeah13:50
dandraderSaviq, is that ricmm's QML cache thingy?13:50
Saviqdandrader, yeah, it doesn't know when plugin ABI changes so doesn't invalidate atm13:51
dandraderSaviq, mzanetti, MacSlow, anything against squashing shellRotation's commit history?13:56
dandraderMacSlow, can I already merge you AP work into ~unity-team/shellRotation?13:57
Saviqdandrader, rebasing never a nice thing to do in bzr ;)13:57
mzanettiI don't see a reason *for* it13:57
Saviqdandrader, I just added it as a separate MP o top of yours13:57
Saviqdandrader, and thought it could remain like that13:58
dandradermzanetti, Saviq, ok, I will keep the history then.... For the record: I squashed shellRotation's history many times already. Otherwise it would be loooong and confusing list of commits and merges13:59
mzanettiI know you did that14:00
dandradermzanetti, :)14:00
mzanettiI was spending half an hour merging each time14:00
dandradermzanetti, it's fun, right? :)14:02
mzanettitotally :)14:02
dandraderhistory gets particularly messy every time a split part of shellRotation's diff onto a separate MP that gets merged to trunk14:03
MacSlowdandrader, basically yes...14:07
MacSlowdandrader, there's assert-mismatch failure still (happening ~ 1/15 times)14:07
MacSlowdandrader, which I'm currently looking into14:08
MacSlowdandrader, but I can do that against ~unity-team/shellRotation too14:08
MacSlowdandrader, cleaning up branches is always a good idea14:08
SaviqMacSlow, any reason why http://paste.ubuntu.com/10833276/ would be wrong?14:11
SaviqI'm up to 24 successful runs in a row of those two tests now14:12
MacSlowSaviq, nope... looks acceptable to me14:13
MacSlowSaviq, I'll add that to my branch for both tests...14:13
MacSlowSaviq, I got the mismatch for test_fake_sensor too14:14
dandraderthis patch improves readability that's for sure14:14
Saviqyeah not sure why the tmp_a, tmp_o...14:14
mzanettidandrader, btw. I was reading through the shellrotation branch today14:14
mzanettidandrader, only question I had was: is the Commandlineparser changes supposed to show up in there?14:14
mzanettior is that just a prereq missing to the other commandlineparser branch?14:14
dandradermzanetti, yes, working on it at this very moment14:15
MacSlowSaviq, dandrader: missing code-clean up14:15
mzanettidandrader, perfect. I think I'm good with the code then14:16
dandradermzanetti, just resubmitted. it now has lp:~dandrader/unity8/unityCommandLineParser as a prereq14:17
dandradermzanetti, tsdgeos, https://code.launchpad.net/~dandrader/unity8/ddaImprovements/+merge/255896 has been upated as well. The remaining Launcher jumpiness and the failing qmltests have been fixed14:26
MacSlowSaviq, current issue... http://pastebin.ubuntu.com/1083334914:26
mzanettidandrader, awesomes14:26
tsdgeosdandrader: k, i think i'll get to it later today14:27
SaviqMacSlow, not a problem in your branch, this happens from time to time still14:28
MacSlowSaviq, it's not a direct issue of the shell-rotation test itself, but...14:28
MacSlowah ok14:28
SaviqMacSlow, after 38 runs I got http://pastebin.ubuntu.com/10833372/ here, but wouldn't exclude some PEBKAC error like I touched the phone or something14:29
MacSlowSaviq, I've seen that once too today14:38
SaviqMacSlow, so basically IIUC that means the fake sensor data didn't cause it to switch orientations?14:49
MacSlowSaviq, I can take some time... sometimes...14:50
MacSlowbut the 15 sec timeout is already nasty14:50
MacSlowI don't think we should up that even more.14:51
MacSlowSaviq, at some point I wondered if we should even keep the isolated fake_sensor_test... it is used/exercised in the app-rotation test anyway14:53
MacSlowSaviq, and never seen it (fake-sensor) fail there yet14:53
dandradergreyback_, can you top-approve https://code.launchpad.net/~dandrader/qtmir/supportedOrientations/+merge/242213 ?15:04
greyback_dandrader:  - g++-4.9:native,    + g++-4.9,   <- why that change?15:06
Saviqbecause recipes hate it ;)15:06
tsdgeosdednick: there's a very weeeeeeeeeeeird thing15:11
tsdgeosthe first QDBusPendingCallWatcher of your branch seem to never be deleted15:11
tsdgeoseven if the subsequent ones are15:11
tsdgeosand deleteLater is just called fine on them15:11
tsdgeosdednick: is it possible that those are run before we have a qapplication ?15:12
tsdgeosor a loop running15:12
* tsdgeos checks15:13
dandradergreyback_, where?15:16
dandradergreyback_, it's a debug leftover15:16
dandradergreyback_, so I could build it in a PPA15:17
dandradergreyback_, but nowadays in the PPA recipe I merge a separate branch that does just that. So I don't have to pollute the main branch with this15:17
=== alan_g|gone is now known as alan_g
=== dandrader is now known as dandrader|afk
greyback_dandrader: I see it in the LP diff in https://code.launchpad.net/~dandrader/qtmir/supportedOrientations/+merge/24221315:28
greyback_it'll break my schroot builds15:28
Saviqdandrader|afk, you don't have a separate qtmir branch for that, just a unity8 one15:30
dednicktsdgeos: hm15:31
dednicktsdgeos: delete watcher?15:33
dednicktsdgeos: actually, can just call delete at that point i guess. If it's finished we won't be needing it anymore.15:38
tsdgeosdednick: sure15:38
tsdgeosdednick: isn't that what youwere saying?15:38
tsdgeosit's what i suggested in the MR15:38
dednicktsdgeos: you said add a "delete watcher" inside...15:39
dednicknot sure what that meant :)15:39
tsdgeos    if (!async) {15:40
tsdgeos        watcher->waitForFinished();15:40
tsdgeos        delete watcher;15:40
tsdgeos    }15:40
tsdgeosdednick: ↑15:40
dednicktsdgeos: yup. that's what i just added :)15:41
=== dandrader|afk is now known as dandrader
dandradergreyback_, fixed16:06
greyback_dandrader: ta16:06
dandradergreyback_, https://code.launchpad.net/~dandrader/unity-api/shellRotation/+merge/242212 should be ok now as well16:19
greyback_dandrader: another thought on https://code.launchpad.net/~dandrader/qtmir/supportedOrientations/+merge/242213 - the date in the debian/changelog is 201416:20
greyback_can you update that please16:21
dandraderheh, it's showing its age16:22
dandradergreyback_, done16:26
greyback_dandrader: same issue with unity-api branch, the datetime in debian/changelog needs bumping16:43
greyback_dandrader: any reason you don't declare copyright for 2014? :)16:44
dandradergreyback_, it wasn't changed in that year, I guess16:45
greyback_dandrader: only kidding, it's no big deal16:45
dandradergreyback_, update the changelog date&time16:47
dandraderSaviq, https://code.launchpad.net/~dandrader/qtmir/supportedOrientations/+merge/242213/comments/63891116:52
dandraderinline comments are terrible when you have a big diff16:55
dandraderSaviq, so you want to have lp:~saviq/qtmir/fix-application-api-deps as a prereq of lp:~dandrader/qtmir/supportedOrientations16:56
=== alan_g is now known as alan_g|EOD
Saviqdandrader, Ctrl+F, Saviq ;)17:21
Saviqdandrader, I'll tweak my branch then17:22
Saviqdandrader, and yeah, please resubmit based on mine17:23
dandraderSaviq, don't need to merge lp:~saviq/qtmir/fix-application-api-deps again into lp:~dandrader/qtmir/supportedOrientations. It applies cleanly now (no diff at all even)17:39
dandraderSaviq, can remove the "Needs Fixing"17:39
Saviqdandrader, right, prolly because it's the same ;)17:39
dandraderSaviq, yes17:39
=== dandrader is now known as dandrader|afk
=== Wellark_ is now known as Wellark
=== sil2100_ is now known as sil2100
=== dandrader|afk is now known as dandrader
=== dandrader is now known as dandrader|afk
=== dandrader|afk is now known as dandrader
=== attente_ is now known as attente

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!