[06:26] <mattyw> davecheney, lesson learned - never eat
[06:27] <mup> Bug #1445338 was opened: Win builds fail: cloudconfig/userdatacfg.go:65: undefined: unixConfigure <ci> <regression> <windows> <juju-core:Triaged> <https://launchpad.net/bugs/1445338>
[06:33] <mup> Bug #1445338 changed: Win builds fail: cloudconfig/userdatacfg.go:65: undefined: unixConfigure <ci> <regression> <windows> <juju-core:Triaged> <https://launchpad.net/bugs/1445338>
[06:39] <mup> Bug #1445338 was opened: Win builds fail: cloudconfig/userdatacfg.go:65: undefined: unixConfigure <ci> <regression> <windows> <juju-core:Triaged> <https://launchpad.net/bugs/1445338>
[07:51] <mup> Bug #1445369 was opened: Juju core freaks if /etc/os-release is not present <juju-core:New> <https://launchpad.net/bugs/1445369>
[07:57] <mup> Bug #1445369 changed: Juju core freaks if /etc/os-release is not present <juju-core:New> <https://launchpad.net/bugs/1445369>
[08:03] <mup> Bug #1445369 was opened: Juju core freaks if /etc/os-release is not present <juju-core:New> <https://launchpad.net/bugs/1445369>
[09:45] <mup> Bug #1445146 changed: juju run fails after upgrade to 1.23-beta4.1 <juju-core:Invalid> <https://launchpad.net/bugs/1445146>
[10:12] <wallyworld_> jam: looks like irc dropped out - the maas guys are in another meeting, did you want to chat about the error stuff?
[10:13] <jam> wallyworld_: I'm happy to chat if you'd like
[10:13] <jam> I'm in the hangout
[10:13] <wallyworld_> jam: ok, give me a sec and i'll change rooms
[13:01] <mup> Bug #1445369 changed: Juju core freaks if /etc/os-release is not present <juju-core:Invalid> <https://launchpad.net/bugs/1445369>
[13:13] <mup> Bug #1444537 was opened: Log files from units deployed in lxc containers are shared on the physical node <logging> <lxc> <juju-core:Triaged> <https://launchpad.net/bugs/1444537>
[13:22] <mup> Bug #1444537 changed: Log files from units deployed in lxc containers are shared on the physical node <logging> <lxc> <juju-core:Triaged> <https://launchpad.net/bugs/1444537>
[13:31] <mgz> menn0: I still need to ammend that branch so one sec on review
[13:31] <menn0> mgz: kk
[13:31] <mup> Bug #1444537 was opened: Log files from units deployed in lxc containers are shared on the physical node <logging> <lxc> <juju-core:Triaged> <https://launchpad.net/bugs/1444537>
[13:35] <mgz> menn0: it's okay, just wanted to run the unit test on vivid, they're good
[13:35] <jam> mgz: menn0: would it be reasonable to add a logger.Debugf to that code you landed ?
[13:36] <mgz> jam: yup, totally.
[13:36] <jam> (generally if you are suppressing an error it would be good to log it at least)
[13:36] <menn0> mgz:  ship it
[13:37] <menn0> jam: you mean regarding upstart detection?
[13:37] <jam> menn0: when you get the error that /sbin/initctl isn't there, just log at Debugf level
[13:37] <jam> then if we get it for weird reasons
[13:37] <jam> we can enable debug logging
[13:37] <mgz> he means a bit like we added when trying to debug, dump the actual error back from exec.Command
[13:37] <jam> and see what the error we're getting is
[13:37] <menn0> jam: yep, that's a good idea
[13:37] <mgz> I shall add now
[13:38] <menn0> as long as it's just at debug
[13:38] <jam> mgz: menn0: absolutely. But anytime you "add reporting to figure out what's going on", that's a good sign we may want a logger.Debugf for future use
[13:38] <menn0> for sure
[13:40] <mgz> logger.Debugf("exec %q failed: %v", initctlPath, err)
[13:40] <mgz> maybe?
[13:40] <mgz> anything else?
[13:40] <jam> mgz: looks good to me
[13:41] <menn0> maybe %#v so we see the field names for the error
[13:41] <mgz> okay, done
[13:41] <jam> mgz: can you test the output to confirm?
[13:42] <menn0> mgz: sorry that should be %+v
[13:42] <jam> (hard code a different /sbin/init, or make a test fail)
[13:42] <menn0> talk about backseat coding... :)
[13:42] <jam> menn0: well, %+v is just the field names for auto format, #v isthe go syntax which often includes field names
[13:43] <menn0> jam, mgz: whatever works
[13:52] <mgz> I pushed the log statement, will land shortly
[15:16] <mup> Bug #1445338 changed: Win builds fail: cloudconfig/userdatacfg.go:65: undefined: unixConfigure <ci> <regression> <windows> <juju-core:Fix Released by gabriel-samfira> <https://launchpad.net/bugs/1445338>
[15:45] <mgz> going to need re-check review
[15:45] <mgz> for test junk I missed
[15:49] <mgz> okay, have pushed new test-fixing revision
[20:56] <mup> Bug #1445658 was opened: juju fills logs with attempts to do work on implicitly removed containers <juju-core:New> <https://launchpad.net/bugs/1445658>