[02:10] <imgbot> [04:15] <imgbot> [04:15] <imgbot> [09:34] <dbarth> Laney: ping? i'm requesting a silo to land the fix for MSN/FB xmpp services going away
[09:34] <dbarth> https://bugs.launchpad.net/account-plugins/+bug/1432613
[09:34] <Laney> dbarth: oh, wait, mardy pinged me and I forgot to reply
[09:34] <dbarth> Laney: but to land, this would need a priority bump to make it
[09:34] <Laney> sorry mardy!
[09:34] <dbarth> Laney: do you think that's still open ?
[09:35] <Laney> dbarth: I don't know, since we're in final freeze now
[09:35] <mardy> Laney: np :-) I'll keep the packages alive, since they appear in empathy's Recommends
[09:35] <Laney> mardy: we can just fix that
[09:36] <mardy> Laney: you mean, "we can just fix that" = "we can remove the broken plugins from the Recommends line"?
[09:37] <Laney> nod
[09:37] <Laney> you might want a Conflicts to get it removed too
[09:38] <mardy> Laney: and this change (about the Recommends) could go in despite the freeze?
[09:38] <Laney> mardy: It's not up to me, but I would be okay with uploading it to see
[09:39] <Laney> worst case it could become a SRU
[09:39] <dbarth> Laney: let us know; we have the fix there, and can update the merge prop. in the way you prefer to release
[09:40] <Laney> mardy: what about removing the packages & Recommends from empathy, and putting a Conflicts on libaccount-plugin-generic-oauth?
[09:42] <Laney> hmm, they have an |ed depends on u-s-s-o-a so you may want to add one there too
[09:43] <mardy> Laney: just to clarify: the removal of the package is only for the windows-live plugin; the facebook one can't be removed, because it has other uses
[09:43] <Laney> yes
[09:43] <Laney> s/packages/package/ sorry
[09:45] <mardy> Laney: OK for the conflicts
[09:46] <mardy> Laney: maybe we should split the silo, to separate the branches that are for touch from those from the desktop, so that we can land them independently
[09:46] <mardy> dbarth: ^
[09:47] <Laney> I think for vivid we'd want to consider it all together
[09:55] <mardy> Laney: ok
[09:56] <Laney> but all we can do it put it in the queue and see if it's judged okay for release at this point
[10:03] <rvr> Mirv: ping
[10:08] <Mirv> rvr: pong
[10:09] <rvr> Mirv: I have tested the browser tabs, youtube, soundcloud, google maps, anything else worth checking?
[10:09] <Mirv> rvr: not that I can think of. it's a quite low-level change that prevents using (on arale chipset only) an OpenGL feature that arale doesn't really support at the moment
[10:10] <rvr> Mirv: Hmm... I'll check a webapp game.
[10:12] <rvr> Seems WebGL is disabled
[10:30] <Mirv> rvr: hmm, maybe a generic vivid thing? I've a vague memory of some bug.
[10:30] <rvr> Mirv: I'll check now in krillin, but I too guess it's a generic thing
[10:32] <Mirv> rvr: https://bugs.launchpad.net/ubuntu/+source/oxide-qt/+bug/1438902
[10:32] <rvr> Mirv: Interesting, thanks
[11:39] <rvr> Mirv: Bad news
[11:39] <rvr> Mirv: krillin is doing weird things with the silo packages
[11:42] <Mirv> rvr: hmm? the if clause is done so that there should be no code change if the gfx chipset isn't Arale's PowerVR G6200
[11:46] <bzoltan_> Mirv: is there a free silo for the UITK?
[11:47] <Mirv> bzoltan_: sure there is since you already have it
[11:53] <rvr> Mirv: http://people.canonical.com/~vrruiz/tab-gl-krillin.mp4
[11:53] <Mirv> rvr: add read rights
[11:54] <rvr> Mirv: Done
[11:55] <popey> alesage: could you please file bugs for your calendar issues? (without logs we can't identify what's going on)
[11:56] <Mirv> rvr: the flickering? wow. I don't see anything like that on mako. have you tried purging the PPA ie with/without comparison?
[11:56] <Mirv> kgunn: any reasonable explanation for rvr's video ^ on krillin with your patch?
[11:59]  * Mirv hangouts + dentist
[12:18] <mardy> Laney: https://code.launchpad.net/~mardy/empathy/lp1432613/+merge/256651
[12:18] <mardy> Laney: should I put that in our silo, or how do we proceed?
[12:18] <rvr> Mirv: I didn't see any flickering when I flashed the phone, before installing the silos
[12:19] <kgunn> Mirv: i would doubt that patch would effect the greeter/keyboard....
[12:19] <kgunn> and yeah it should only effect arale
[12:19] <kgunn> ....actually that bug looks just like one that alf is working on
[12:20] <kgunn> we just found it 2 days ago on krillin
[12:20] <kgunn> rvr: is that the packages from silo 2 ?
[12:20] <rvr> kgunn: Yes
[12:20] <kgunn> rvr: do you know what other changes Mirv has in those ?
[12:21] <rvr> kgunn: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/landing-002/+packages
[12:21] <rvr> "Sync with qtbase-opensource-src - 5.4.1+dfsg-1ubuntu5"
[12:22] <kgunn> rvr: did that problem survive reboot ?
[12:23] <rvr> kgunn: After silo packages are installed, the phone is rebooted
[12:23] <Mirv> rvr: -gles is not in use on the device. in the main package, the only change is this patch.
[12:23] <rvr> Rebooting again
[12:24] <kgunn> rvr: Mirv yeah...that is the same exact bug that alf's working
[12:24] <kgunn> https://bugs.launchpad.net/mir/+bug/1444047
[12:25] <rvr> kgunn: Interesting. On second reboot, problem is gone
[12:25] <kgunn> right...it's sporadic
[12:27] <Mirv> the patch in 002 is visible at http://bazaar.launchpad.net/~kubuntu-packagers/kubuntu-packaging/qtbase-opensource-src/revision/241 - ie same code path if gpu != PowerVR Rogue G6200
[12:30] <kgunn> yeah, it's not related to the patch
[12:30] <rvr> Ack
[12:34] <dbarth> rvr, Mirv: webgl is supported only on krillin right now; it will be re-enabled in the next release of oxide (1.7) for mako and other devices as well
[12:34] <rvr> dbarth: Ack
[12:39] <rvr> dbarth: But in https://get.webgl.org/ I don't see any spinning cube, as it says it should
[12:42] <dbarth> rvr: on krillin ?
[13:09] <rvr> dbarth: Yes, in RTM and in Vivid
[13:10] <Laney> mardy: you need to provide a changelog and then dput it to the silo
[13:10] <Laney> I can do that if you can't
[13:24] <mardy> Laney: yes, please do :-) I updated the changelog
[13:25] <Laney> okay, which silo is it?
[13:35] <dbarth> Laney: 006
[13:35] <Laney> thx, give me 10 minutes or so
[14:03] <boiko> jibel: hi, just curious: why is ubuntu-rtm/landing-003 marked as blocked in the QA board?
[14:03] <jibel> boiko, I have no idea
[14:04] <jibel> rvr, ^ do you know?
[14:09] <jibel> boiko, maybe because it is marked 'dirty'
[14:09] <jibel> ah rtm
[14:09] <boiko> jibel: yep, rtm
[14:11] <jibel> boiko, it looks good to me, so I don't know
[14:12] <boiko> jibel: ok, thanks :/
[14:17] <rvr> jibel: Yes, RTM
[14:19] <rvr> boiko: Is an app update intended for the Store?
[14:19] <boiko> rvr: dialer-app is not on store, it is part of the images
[14:20] <rvr> boiko: Right, and we are not getting new RTM updates
[14:21] <rvr> OTA3 is likely the last one
[14:21] <boiko> rvr: oh, ok, didn't know
[14:21] <boiko> bfiller: ^
[14:23] <jibel> boiko,rvr we'll maybe have a hotfix
[14:26] <sil2100> rvr: hey!
[14:26] <sil2100> rvr: you testing silo 002?
[14:26] <rvr> sil2100: Yes
[14:26] <sil2100> rvr: we would need a voulenteer to do the first landing to the overlay PPA
[14:26] <sil2100> rvr: so this is our first candidate then
[14:26] <sil2100> ;)
[14:27] <rvr> sil2100: What do I have to do?
[14:28] <sil2100> rvr: just sign it off normally
[14:28] <sil2100> rvr: I'll reconfigure it to target the PPA, but everything else stays exactly the same
[14:28] <sil2100> (no rebuilds happening, just some config changes)
[14:32] <rvr> sil2100: Do I need to recheck the packages?
[14:32] <sil2100> rvr: no no, no rebuilds will happen, just silo config changes
[14:32] <sil2100> Please continue ;)
[14:32] <rvr> sil2100: Ack :)
[14:40] <Laney> dbarth, mardy: uploaded
[14:41] <mardy> Laney: thanks!
[14:42] <mardy> dbarth: can you please build silo #6?
[14:51] <mardy> Laney: should I drop https://code.launchpad.net/~mardy/empathy/lp1432613/+merge/256651 then?
[14:54] <Laney> mardy: nein, I'll push it when the package is accepted
[14:54] <Laney> actually I can push to 375 now
[14:54] <Laney> done
[14:55] <dbarth> mardy: sure
[15:00] <robru> mandel: tvoss: no qa for silos 9 and 30?
[15:00] <tvoss> mandel, there should be for 30 at least
[15:00] <mandel> same for 9
[15:00] <tvoss> robru, there shouldbe for 30 at least, mybad
[15:00] <mandel> tvoss, I think we forgot to set it in the spreadsheet, is not longer by default, or so it looks
[15:01] <robru> mandel: tvoss: yeah it needs to be set, sorry, and thanks
[15:01] <mandel> tvoss, I took care of 30 already
[15:25] <rvr> Mirv: Finally could test in mako, seems good
[15:25] <rvr> sil2100: So, silo is ready from my part. Tell me when I can click to sign off.
[15:31] <sil2100> rvr: ok, thanks, one moment still - robru will handle it :)
[15:33] <pmcgowan> kgunn, Mirv whats the status on silo2, its back to ready to build
[15:33] <sil2100> pmcgowan: no worries, it's CI Train reconfig
[15:33] <sil2100> Don't worry, it's built and tested
[15:34] <sil2100> Will land soon
[15:34] <pmcgowan> ok ty
[15:51] <bzoltan_> sil2100:  May i ask for a silo4 reconf?
[15:52] <sil2100> bzoltan_: ok, let me do it quickly, but I'm almost in transit now
[15:52] <bzoltan_> sil2100:  have a good flight dude :) and a safe one
[15:53] <rvr> mandel: ping
[15:53] <mandel> rvr, hello
[15:53] <rvr> mandel: Hey
[15:55] <sil2100> bzoltan_: thanks and done :)
[15:58] <dbarth> Laney: silo 6 is ready; any news on landing clearance ?
[15:59] <Laney> ready as in you've tested it?
[16:02] <robru> rvr: hey. I have a branch ready that fixes a bug in the train. I'll push it to production shortly. then we can get this show on the road
[16:02] <Laney> dbarth: Check with infinity if you can upload it or if we should SRU after release
[16:03] <rvr> robru: Ack
[16:09] <robru> rvr: alright, can you throw your qa ack on silo 2? thanks!
[16:09] <rvr> robru: Let's go!
[16:10] <alesage> popey bugs in process, stepping over a crash en route to
[16:10] <popey> alesage: thanks!
[16:12] <dbarth> Laney: ok
[16:13] <dbarth> infinity: this is about landing a silo fixing https://bugs.launchpad.net/account-plugins/+bug/1432613
[16:13]  * Laney releases that bug title is overly alarming
[16:13] <dbarth> infinity: i think that's an sru, but wave if you want us to land that for the release
[16:13] <Laney> realises*
[16:13] <dbarth> yeah, that's FB & MSN *messaging* services shutting down
[16:26] <bzoltan_> does anybody know if the phablet-click-test-setup suppose to work these days?
[16:29] <infinity> dbarth: If it's auditable and testable, I don't mind getting it in before release.
[16:35] <bzoltan_> brendand:  do you know why the  phablet-click-test-setup  with ubuntu/15.04 ?
[16:38] <brendand> bzoltan_, question seems incomplete. is it failing?
[16:38] <bzoltan_> brendand:  yes it does .. in a spectacular way ... each time on different app
[16:39] <bzoltan_> brendand: http://pastebin.ubuntu.com/10839553/
[16:40] <brendand> bzoltan_, hmmm. unfortunately i can't look at it now. remind us on monday and someone will have a look
[16:40] <bzoltan_> brendand: Monday??? Uhh.. is anybody around who could help? I wish to test the UITK release candidate during the weekend
[16:41] <bzoltan_> brendand:  you know :) it is a full day process ... 18 hours at least ... given that these super quality tools work
[16:42] <bzoltan_> brendand:  and the gates close next week for RTM
[16:44] <brendand> bzoltan_, not many. elopio is finishing the sprint in austin
[16:44] <bzoltan_> brendand: shame ... but such as life
[16:45] <brendand> bzoltan_, i'll come back in a little while and either help fix it or find someone who can
[16:45] <brendand> bzoltan_, let me assume you try this on a freshly installed vivid image?
[16:45] <bzoltan_> brendand: Thank you
[16:45] <bzoltan_> brendand:  Yes
[16:47] <bzoltan_> brendand:  I constantly do wonder  how it is possible that these very important tools ar so unstable
[16:54] <bzoltan_> brendand:  it seems that most of the times it is the calculator app what makes the p-c-t fail... so I simple unregister that app... screw it :)
[17:07] <charles> trainguards, i need to make a change to ubuntu/landing-027, to change which indicator-location branch is included in the silo
[17:09] <charles> trainguards, this is on line 43 of the spreadsheet, basically I want to swap the current MP with a replacement
[17:10] <robru> charles: yep, you should have the power to do that yourself & reconfigure
[17:11] <charles> robru, cool, how do I do that wrt changing the MP?
[17:12] <robru> charles: just literally edit the spreadsheet cell to remove the MP you don't want then add the one you do want. once the spreadsheet looks right, find "Landing tools > Reconfigure" menu and follow the prompts.
[17:12] <charles> robru, thanks
[17:21] <robru> charles: http://people.canonical.com/~platform/citrain_dashboard/#?q=charles just confirm you got the right URL in your silo there, otherwise looks good, ready to build
[17:22] <robru> brb, lunch
[17:24] <brendand> bzoltan_, they are not well tested
[17:25] <bzoltan_> brendand: That one I figured out myself :) too
[17:25] <bzoltan_> brendand:  at least now that I have unregistered the terminal and the calculator app the tool works
[17:26] <brendand> bzoltan_, ok
[17:26] <brendand> bzoltan_, can you paste the version you're using?
[17:28] <bzoltan_> brendand:  the stock one from vivid
[17:28] <charles> renatu, what's the status of the eds branch in our shared silo 8? are you ready to land?
[17:28] <brendand> bzoltan_, mine is 1.1+15.04.20150330-0ubuntu1
[17:29] <bzoltan_> brendand: same here
[17:29] <renatu> charles, yes
[17:29] <bzoltan_> 1.1+15.04.20150330-0ubuntu1
[17:30] <brendand> bzoltan_, interesting, the error i get now is about uitk ;p
[17:31] <brendand> package ubuntu-ui-toolkit, version 1.2.1458+15.04.20150327bzr1485pkg0vivid407-0ubuntu1 not found in https://api.launchpad.net/devel/ubuntu/vivid
[17:31] <bzoltan_> brendand: :D nice try
[17:31] <bzoltan_> brendand:  for me the failing point was changing ... but calculator was the most typical
[17:32] <brendand> oh i know - i installed uitk from staging on this...
[17:32]  * brendand reflashes
[17:53] <brendand> bzoltan_, btw you might think about starting to convert to using adt-run for click tests rather than phablet-click-test
[17:53] <brendand> bzoltan_, *that's* well tested
[17:54] <brendand> bzoltan_, as simple as e.g. adt-run --click com.ubuntu.calculator --- ssh -s adb
[18:10] <brendand> bzoltan_, i see what happened
[18:11] <brendand> bzoltan_, calculator changed their layout and violated the expected layout of tests
[18:19] <brendand> bzoltan_, i would really switch to using adt-run, if you have any concerns or need help doing it then let me know
[18:19] <bzoltan_> brendand:  I suspected that... after sil2100 talked about that expectd layout
[18:20] <imgbot> [18:20] <bzoltan_> brendand:  I will evaluate adt-run, but to be hyper honest, I trust nothing else but my very own tool, what made possible dozens of regression free landings :)
[18:21] <bzoltan_> brendand:  all the non tested, non reliable, "works for me" tools wasted lots of my time. Since I use my own test plan executor I am more relaxed :)
[18:22] <brendand> bzoltan_, well adt-run is very much tested, so don't need to worry about that
[18:22] <bzoltan_> brendand:  I will check next week, but I do not risk this landing with anything. Thursday is the deadline to push out several critical fixes.
[18:22] <brendand> bzoltan_, and in fact phablet-test-run is semi-deprecated so unless you're using your own tool also to deploy/execute the tests (which would be crazy) then you should
[18:23] <bzoltan_> brendand:  :D I never considered the phablet-test-run as non deprecated .. it was born to be deprecated :)
[18:24] <bzoltan_> brendand:  I will check this tool next week. I am happy to hear that finally we have something more stable and reliable
[18:27] <bzoltan_> brendand: one question :) has anybody ever used (in documented way) these adt tool to run 8 (4 RTM and 4 Ubuntu) times all the available tests where eac tests are executed three times with reboots between them and flashing + setting up PPAs?
[18:29] <bzoltan_> brendand:  for example the browser tests just made the krilling hang ... nice
[18:30] <brendand> bzoltan_, well no - you're the only person doing that
[18:30] <brendand> bzoltan_, and it's not magic, so you will probably still have some of the same problems you do now, but i wouldn't say it would be worse than with phablet-test-run
[18:54] <bzoltan_> brendand: I am not doing that massive tests for fun :) I do it because many of the tools in the chain are unpredictable and single run of one test do not provide valuable result.  But to be fair, most of the problems are not caused or rooted to p-t-r ...
[18:57] <bzoltan_> brendand:  the problem is the combination of many small problems what do not come out if you run simple tests... like you never experience that not sleeping fior 2 minutes could be a problem if you run 20-30 tests in a row... or that you better wait 10 minutes after flashing :) because once out of  fifty runs you might see problems. That is why I trust my process... I have polished these details a lot... so I can leave my devices to run automatic tests
[18:57] <bzoltan_>  for the night.
[19:32] <jhodapp> robru, can you please reconfigure silo 28?
[19:34] <jhodapp> or rsalveti^
[19:35] <imgbot> [19:35] <imgbot> [19:39] <robru> jhodapp: one sec
[19:40] <jhodapp> thanks
[19:42] <robru> jhodapp: did you click build? I think you hit it too soon
[19:43] <robru> yeah
[19:43] <jhodapp> robru, I did, I think rsalveti reconfigured it in time though
[19:43] <jhodapp> but maybe not
[19:43] <jhodapp> can you kill the build and restart it then, rebuild everything
[19:43] <robru> jhodapp: I don't think so, check the dashboard, does it have the right merges?
[19:44] <jhodapp> let's just start over just in case
[19:44] <robru> jhodapp: k, needs to be reconfigured again, the premature build effectively undid the reconfigure.
[19:44] <rsalveti> yeah, ricmm_ asked me to reconfigure in parallel
[19:44] <rsalveti> so ended up doing that
[19:45] <jhodapp> robru, ok thanks
[19:46] <robru> rsalveti: heh, you did the wrong reconfigure, the unpriveleged one, it didn't work
[19:47] <robru> jhodapp: ok, this should be working: https://ci-train.ubuntu.com/job/ubuntu-landing-028-1-build/68/console
[19:48] <jhodapp> thanks robru
[19:48] <robru> jhodapp: you're welcome!
[20:24] <kenvandine> alesage, about silo 24, so when you turned wifi on, it turned itself back off again?
[20:25] <kenvandine> alesage, meaning the wifi switch is in the off position?
[20:26] <alesage> kenvandine, yes that's what I observed
[20:26] <kenvandine> alesage, your steps in your test case confuse me
[20:27] <kenvandine> you select "forget" for your AP
[20:27] <alesage> kenvandine, right
[20:27] <kenvandine> then step 3 says "WiFi switches to 'off'"
[20:27] <kenvandine> so you turned off wifi there?
[20:27] <kenvandine> or you mean it disconnected
[20:27] <alesage> kenvandine, disconnected
[20:28] <kenvandine> ok, when do you turn wifi off there?
[20:28] <alesage> kenvandine, I'll prep the silo to reproduce
[20:28] <kenvandine> the only change in the wifi plugin would be related to the actual wifi on/off switch
[20:29] <alesage> kenvandine, right that was the surprise IMO
[20:29] <kenvandine> not forget/connect.. etc
[20:29] <kenvandine> so i would expect to test this, you wouldn't forget, you would turn it off
[20:29]  * alesage needs a dashcam for this kind of thing
[20:29] <kenvandine> then switch it on again, it should connect
[20:30] <alesage> kenvandine, will attempt in trunk to begin, assuming I'm not going to see the weird 'forget' behavior
[20:30] <kenvandine> i would worry that the switch might have a race turning off/on
[20:30] <kenvandine> but i tested that a bunch of time
[20:31] <kenvandine> alesage, so to confirm, you moved the switch to "off" then moved it back to "on" then it changed itself to "off"?
[20:32] <alesage> kenvandine, switching WiFi to on, my home AP appeared, upon selecting it, the WiFi switch turned to 'off'
[20:32] <kenvandine> alesage, also confirm the switch stays the same between indicator-network and system-settings
[20:32] <kenvandine> ok, thanks for clarifying
[20:32] <kenvandine> wanted to make sure you weren't just talking about it not connecting
[20:32] <alesage> kenvandine, I'll be superverbose next round :)
[20:32]  * kenvandine follows same steps again
[20:33] <kenvandine> not about verbosity :)
[20:33] <kenvandine> just making sure using the same terms :)
[20:33] <alesage> makes me wish for BDD/cucumber adoption
[20:36] <kenvandine> alesage, i just reproduced that same problem on vivid-proposed without the silo
[20:36] <kenvandine> so not a regression in this silo
[20:36] <kenvandine> wtf though!
[20:37] <alesage> kenvandine, I lol
[20:37] <alesage> so Friday afternoon
[20:37] <kenvandine> ok, can't reproduce on rtm
[20:38] <kenvandine> so that's good :)
[20:38] <kenvandine> for now
[20:38] <alesage> kenvandine, feels like a settings bug no?
[20:38] <kenvandine> i'm betting the indicator
[20:38] <kenvandine> that menu is coming from indicator-network
[20:40] <alesage> kenvandine, I'll file and affect both
[20:40] <kenvandine> thx
[20:40] <alesage> kenvandine, if you want to re-propose I'll review again
[20:40] <kenvandine> alesage, can you double check that it isn't a new regression too?
[20:40] <alesage> kenvandine, back to last image, e.g.?
[20:41] <kenvandine> if you don't mind :)
[20:41] <alesage> kenvandine, with sprinkles pls
[20:41] <kenvandine> pretty please :)
[20:41] <alesage> ha
[20:43] <kenvandine>   Installed: 0.3+15.04.20150413-0ubuntu1
[20:43] <kenvandine> so i'm pretty sure my device isn't tainted
[20:43] <kenvandine> oh... that indicator-network port to qtdbus just landed the other day didn't it
[20:44] <kenvandine> i wonder if that broke something
[20:44] <alesage> good theory
[20:44] <alesage> although I thought that went to rtm too
[20:45] <kenvandine> oh it did
[20:45] <kenvandine> ok, rules that out :)
[20:45] <alesage> not certain, would need to verify
[20:45] <kenvandine> i verified
[20:48] <alesage> not seeing the same 'forget' behavior in trunk :/ , might need reinforcements here
[20:48] <kenvandine> oh really
[20:48] <kenvandine> maybe apt is lying about my version
[20:50] <alesage> wouldn't expect this to differ by device?  /me is on krillin
[20:50] <kenvandine> ok, confirmed
[20:51] <kenvandine> i did a reinstall of the package from vivid and couldn't repro it
[20:51]  * kenvandine hates when apt lies because i updated the image :)
[20:51] <kenvandine> alesage, sorry... i guess i need to reject the branch and have dednick fix it :)
[20:52] <kenvandine> weird though, because the menumodel stuff wasn't changed
[20:52] <kenvandine> just the on/off switch
[20:52] <kenvandine> alesage, thanks for being thorough!
[20:53] <alesage> I'll just reproduce with silo--I'm realizing now that it's weird that WiFi disappeared upon forgetting network, memory of this foggy though, will get a more precise description
[20:53] <alesage> kenvandine, ok
[21:04] <alesage> kenvandine, just doin' mah job :)