| tsdgeos | Mirv: are at we at the state of caring about new patches that fix the "desktop" use case for the dbus patchset? | 07:42 |
|---|---|---|
| tsdgeos | in case we are, there's updated https://codereview.qt-project.org/#/c/110325/ and https://codereview.qt-project.org/#/c/110643 that is new and should be applied before | 07:42 |
| Mirv | tsdgeos: well sure, since it'd be a bit unfortunate to land something to rtm that can't be landed to w, so if we have something that would be acceptable to both that'd be great. | 07:44 |
| tsdgeos | Mirv: so try applying those too please :) | 07:44 |
| Mirv | trying | 07:44 |
| Mirv | tsdgeos: 110325 has a new title but it's the one that replaces the older WIP-Deliver-events-in-threads-regardless-of-QCoreApp.patch, right? | 07:46 |
| tsdgeos | Mirv: i think so yes, that's probably why the new one is there, i think it was kind of spawned into two | 07:47 |
| Mirv | tsdgeos: 110325 now depends on adding something to qevdevtouchhandler_p.h that doesn't exist on 5.4 | 07:51 |
| tsdgeos | Mirv: it's fine, don't add it then | 07:52 |
| tsdgeos | that particular patch to the file i mean | 07:52 |
| tsdgeos | it's not a dependency, it's "fixing" the file, since we don't have it, nothing to fix | 07:53 |
| Mirv | ok | 07:53 |
| Mirv | tsdgeos: hmm. notifyInternal2 function in https://codereview.qt-project.org/#/c/110325/7/src/corelib/kernel/qcoreapplication.cpp,unified also doesn't exist in 5.4 (hunks 3 and 4). also regarding notify_helper it's quite different in 5.4 http://pastebin.ubuntu.com/10837225/ so I'm not sure if it needs changing (hunk 6) | 07:59 |
| tsdgeos | Mirv: that's why i said that https://codereview.qt-project.org/#/c/110643/1//ALL goes before | 08:00 |
| Mirv | tsdgeos: oh, right, I did that, then I had a previous error and tried switching it back. thanks :) | 08:01 |
| Mirv | ok, seems it's rebased again | 08:01 |
| Mirv | cleaned 018 from the old builds and pushing a new one | 08:04 |
| tsdgeos | :) | 08:18 |
| tsdgeos | Saviq: do you think we could do "a small landing" with what we have at the moment? to get 5.5 build out there and those small things? | 08:24 |
| Saviq | tsdgeos, we could, usre | 08:24 |
| Saviq | sure, even | 08:24 |
| Saviq | I *think* | 08:25 |
| tsdgeos | :D | 08:25 |
| Saviq | we're in Final Freeze since yesterday | 08:25 |
| tsdgeos | or well there's this release thing | 08:25 |
| tsdgeos | right | 08:25 |
| tsdgeos | i wonder when w is going to open | 08:25 |
| tsdgeos | we need a name! | 08:25 |
| Saviq | Mirv, what's the archive state atm, can we land anything? and will vivid accept anything before the release next week? | 08:26 |
| davmor2 | tsdgeos: as I understand it there will be like a standby ppa till w is open and the initial imports done | 08:26 |
| davmor2 | but I think that is just for phone | 08:27 |
| tsdgeos | dednick: are you adding the deletes to https://code.launchpad.net/~nick-dedekind/unity8/1436982.message-freeze/+merge/255702 ? | 08:38 |
| dednick | tsdgeos: i am. but i'm adding unit tests for the async calls. | 08:38 |
| tsdgeos | dednick: cool | 08:38 |
| Mirv | Saviq: archive is closed regarding us, we'll start landings to https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/stable-phone-overlay today | 08:45 |
| Mirv | devel-proposed will be built using that PPA too | 08:47 |
| dpm | could someone help a scope developer? -> http://askubuntu.com/questions/610196/scope-developing-how-to-change-scope-result-inside-perform-action | 08:48 |
| Saviq | Mirv, okies | 08:49 |
| Saviq | pstolowski, ↑ askubuntu for you guys | 08:49 |
| Mirv | tsdgeos: https://launchpadlibrarian.net/203564985/buildlog_ubuntu-vivid-amd64.qtbase-opensource-src_5.4.1%2Bdfsg-2ubuntu6~rtm~test1_BUILDING.txt.gz error: type 'QThread' is not a direct base of 'QEvdevTabletHandlerThread' | 09:15 |
| tsdgeos | hmmm | 09:16 |
| tsdgeos | let me check | 09:16 |
| pstolowski | dpm, Saviq, replied. btw that reminded me of https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1335761 cause he is likely to hit it; do you recall if we concluded anything about that bug? | 09:18 |
| ubot5 | Ubuntu bug 1335761 in unity8 (Ubuntu RTM) "[Dash] Activating a preview with a scope URI for the current scope doesn't send you back to the results view" [Medium,Confirmed] | 09:18 |
| pstolowski | also tsdgeos ^ | 09:18 |
| tsdgeos | Mirv: can you replace the QThread(parent) in there by QDaemonThread(parent) ? | 09:19 |
| tsdgeos | src/platformsupport/input/evdevtablet/qevdevtablet.cpp line 295 | 09:19 |
| tsdgeos | and i'll comment in the MR | 09:19 |
| dpm | thanks pstolowski! | 09:20 |
| Mirv | tsdgeos: ok | 09:20 |
| Mirv | adding to the patch | 09:23 |
| tsdgeos | pstolowski: have you tried this lately? maybe it was fixed when we made temp scopes open temp scopes? | 09:24 |
| tsdgeos | or has nothing to do? | 09:24 |
| pstolowski | tsdgeos, maybe, i'm not sure. no idea what what;s the best scope right now to exhibit this problem, the steps for youtube from the bug report don't seem to be applicable any,ore | 09:28 |
| pstolowski | pete-woods, hey, has 'Search' button been removed from youtube previews for channels? this is re https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1335761 ? | 09:29 |
| ubot5 | Ubuntu bug 1335761 in unity8 (Ubuntu RTM) "[Dash] Activating a preview with a scope URI for the current scope doesn't send you back to the results view" [Medium,Confirmed] | 09:29 |
| pete-woods | pstolowski: hmm. I haven't changed youtube in quite some time | 09:31 |
| pstolowski | pete-woods, i cannot follow the steps from this report, because there is no search button in previews.. | 09:33 |
| pete-woods | pstolowski: I think you had to preview a channel, or something like that | 09:34 |
| pete-woods | but I ended up taking all that out | 09:34 |
| pete-woods | obviously my bug description has now become junk | 09:34 |
| pete-woods | pstolowski: actually, it looks like it works now! | 09:37 |
| pstolowski | pete-woods, also some time ago we change the semantics of handling of scope:// uris in the shell; the are not preview-able, they just start a new search | 09:37 |
| pete-woods | yes | 09:37 |
| pete-woods | this is what I wanted! | 09:37 |
| pete-woods | so you can click through playlists | 09:37 |
| pete-woods | and it shows the contents | 09:37 |
| pstolowski | pete-woods, i suppose before you had an intermediate step of displaying a preview of a channel, now you don't have that | 09:37 |
| pete-woods | pstolowski: yeah, but you could't expand the playlist | 09:37 |
| pete-woods | as the search button URI didn't work | 09:38 |
| pstolowski | oh right | 09:38 |
| pete-woods | pstolowski: the navigation is a bit broken now, thouygh | 09:38 |
| pete-woods | when you hit back from inside in item in a playlist, you get dumped all the way out | 09:38 |
| pete-woods | but I guess that's the same in a lot of places in the dash | 09:38 |
| pstolowski | you get out of the youtube scope? | 09:38 |
| pete-woods | pstolowski: yeah | 09:39 |
| pete-woods | or if it's favourited, you get taken back to home | 09:39 |
| pstolowski | yeah i see it | 09:39 |
| pete-woods | pstolowski: I think we would really benefit from a history stack in the dash | 09:39 |
| pstolowski | yes | 09:40 |
| pstolowski | ok, to sum up, i'm not sure a Search button from the preview would work. what many scopes including youtube use is canned queries in search results, which always worked fine | 09:41 |
| pstolowski | tsdgeos, unfortunately changes to temp scopes didn't fix the issue; i've just commented on the bug report | 10:10 |
| tsdgeos | k | 10:10 |
| tsdgeos | pstolowski: what happens in that case signal wise? | 10:13 |
| tsdgeos | are we just getting a "search changed"? | 10:13 |
| pstolowski | tsdgeos, i havent' debugged it this time, but i think my comment #4 is still valid | 10:14 |
| tsdgeos | ok | 10:15 |
| tsdgeos | well i guess until noone really wants to do this | 10:15 |
| tsdgeos | it's no high prio :D | 10:15 |
| tsdgeos | mzanetti: https://code.launchpad.net/~mzanetti/unity8/fix-dnd-cancelling/+merge/256462/comments/639298 | 10:18 |
| mzanetti | tsdgeos, uh oh. thanks a lot for catching this | 10:18 |
| tsdgeos | mzanetti: honestly i think we should block clicks so you can't open an app while you're dragging an icon | 10:19 |
| pstolowski | tsdgeos, well, people do this, as the above ubuntuask question & comments to this bug show ;) | 10:19 |
| tsdgeos | pstolowski: then tell the powers that be to make it higher prio D: | 10:19 |
| tsdgeos | mzanetti: but still the cancellation should work fine in case it happens | 10:20 |
| pstolowski | tsdgeos, i think it's pretty useful for scopes to display a preview button that re-does the search with speicifc params | 10:20 |
| tsdgeos | pstolowski: agreed | 10:20 |
| mzanetti | tsdgeos, yeah, definitely... the canellation might happen for different reasons. also tapping outside with another finger to close the launcher | 10:21 |
| mzanetti | I guess notifications, exiting apps and whatnot can cause it too | 10:21 |
| mzanetti | tsdgeos, I can't launch another app while draggin one | 10:22 |
| tsdgeos | mzanetti: be in the app cscope | 10:23 |
| tsdgeos | mzanetti: you can click icons in the background | 10:23 |
| tsdgeos | it's kind of confusing | 10:23 |
| mzanetti | uh oh | 10:23 |
| * mzanetti tries | 10:23 | |
| mzanetti | indeed... that should not work | 10:24 |
| mzanetti | otoh... the fact that we both notice it now for the first time :D | 10:24 |
| tsdgeos | yaeh | 10:25 |
| tsdgeos | well it's not too often that you use two fingers | 10:25 |
| tsdgeos | mzanetti: i mean that's actually the other way i have to cancel the drag, hwo do you do it otherwise? | 10:26 |
| mzanetti | tsdgeos, when on the greeter, swipe the launcher away to the left | 10:26 |
| tsdgeos | ah it's on the greeter | 10:27 |
| mzanetti | well... doesn't matter... that's one way I found to repro a cancel | 10:27 |
| tsdgeos | right | 10:27 |
| tsdgeos | the other way i found was opnenig an app :D | 10:27 |
| mzanetti | right :) | 10:27 |
| mzanetti | tsdgeos, fixed | 10:55 |
| tsdgeos | k | 10:55 |
| MacSlow | mzanetti: Did you do any launcher-parity work already in a branch I should be picking up? | 11:15 |
| mzanetti | MacSlow, nope, don't have a branch. what would you start with? | 11:15 |
| MacSlow | mzanetti: I think the app-launching animation | 11:16 |
| mzanetti | ack | 11:16 |
| MacSlow | mzanetti: trello-card is also filled with the most current info from Design now | 11:17 |
| MacSlow | mzanetti: still need to pull all animation-spec info from Design | 11:18 |
| mzanetti | MacSlow, looking at that design picture I see conflicting specs with what they requested for the phone | 11:19 |
| mzanetti | MacSlow, for instance the quicklist was explicitly requested to not be next to the panel, but above/below the pressed icon | 11:19 |
| mzanetti | now in this one it's the old style again | 11:19 |
| MacSlow | mzanetti, I've seen the "above" version too | 11:20 |
| MacSlow | mzanetti: I'm expecting to do more details-info hunting in the coming days | 11:20 |
| mzanetti | MacSlow, so for things that are just not there yet, I guess whatever design comes up with is fine. but before changing existing things, please talk to me first | 11:21 |
| MacSlow | mzanetti: I want to keep asking question on a case-by-case/feature-by-feature basis | 11:21 |
| MacSlow | mzanetti: ack | 11:21 |
| === alan_g is now known as alan_g|lunch | ||
| MacSlow | mzanetti, do you know what "lockout capability" means wrt to launcher-feature-parity? Lockout as in "log out of session"?! | 12:04 |
| === MacSlow is now known as MacSlow|lunch | ||
| Saviq | MacSlow|lunch, no, always-show | 12:32 |
| === alan_g|lunch is now known as alan_g | ||
| tsdgeos | mzanetti: that's the other bug we found https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1445472 | 12:47 |
| ubot5 | Ubuntu bug 1445472 in unity8 (Ubuntu) "Can click on the Dash while dragging a Launcher icon" [Undecided,New] | 12:47 |
| tsdgeos | mzanetti: i'm on bug finding mode today https://code.launchpad.net/~mzanetti/unity8/fix-dnd-cancelling/+merge/256462/comments/639341 | 12:51 |
| dandrader | Saviq, will change to Super_L only after the change has landed. Otherwise people won't be able to test it: https://code.launchpad.net/~dandrader/unity8/homeKey/+merge/256658 | 12:54 |
| mzanetti | MacSlow|lunch, lockout: make the launcher stay on screen | 12:56 |
| mzanetti | instead of auto-hiding | 12:56 |
| Saviq | dandrader, sure | 12:58 |
| mzanetti | tsdgeos, can't repro | 12:59 |
| tsdgeos | it is a bit tricky | 12:59 |
| tsdgeos | i agree | 12:59 |
| mzanetti | ah, got it... but not sure what I did | 12:59 |
| tsdgeos | mzanetti: let me repeat what needs to be done | 12:59 |
| tsdgeos | basically you need to be moving the drag finger and the "cancel" finger at the same time | 13:00 |
| tsdgeos | and get lucky the drag finger would put it in the "next spot" i guess | 13:00 |
| mzanetti | yeah, that's how I understand the comment | 13:00 |
| mzanetti | right. the "lucky" part is a bit odd :D | 13:00 |
| tsdgeos | :D | 13:01 |
| mzanetti | tsdgeos, I think I found a way.... seems to happen if you get the cancel during a progressive autoscroll | 13:02 |
| === MacSlow|lunch is now known as MacSlow | ||
| MacSlow | Saviq, mzanetti: hm... ok, odd feature-name then :) | 13:05 |
| mzanetti | tsdgeos, can you give it another try? | 13:15 |
| * mzanetti goes friday labbing | 13:16 | |
| tsdgeos | mzanetti: sure, just after flashing stable finishes | 13:16 |
| mzanetti | tsdgeos, thanks | 13:16 |
| tsdgeos | uh oh | 13:30 |
| tsdgeos | my BQ is in an infinite reboot loop | 13:30 |
| tsdgeos | after flashing stable | 13:30 |
| tsdgeos | and disconnecting the usb cable fixed it | 13:37 |
| tsdgeos | :S | 13:37 |
| MacSlow | :) | 13:38 |
| Cimi | Saviq, design is ok if we just use art header horizontal for the configuration cards | 13:50 |
| MacSlow | mzanetti, we do already have badge-counters in the unity8-lauchner as far as I can tell. Only top-right or bottom-right corner is unclear. Right?! | 14:04 |
| mzanetti | MacSlow, I hear bottom-right for the first time right now | 14:05 |
| mzanetti | MacSlow, where does it say bottom-right? | 14:06 |
| MacSlow | mzanetti, we do have badge-counters for all I know... at least I see them in the settings-icon when updates arrive on the device... in mockups I've seen contradicting top-right and bottom-right variations... email to design regarding this (among other things) is on its way to them . | 14:07 |
| mzanetti | MacSlow, pretty sure the bottom-right is a mistake | 14:07 |
| mzanetti | MacSlow, on the bottom there is a progress bar | 14:07 |
| mzanetti | we already have that, just not used anywhere yet | 14:07 |
| MacSlow | mzanetti, hm... the progress-bar is meant to e i nthe middle o fthe icon... | 14:08 |
| MacSlow | mzanetti, the "available updates" counter on the settings-icon... is that not a badge-counter?! | 14:08 |
| mzanetti | MacSlow, do a "make tryShell" | 14:08 |
| mzanetti | there you'll see all the things | 14:09 |
| MacSlow | mzanetti, ok | 14:09 |
| mzanetti | MacSlow, yes, the settings thing is the badge-counter | 14:10 |
| MacSlow | mzanetti, general question... the spreadsheet "N/A" means "none available" or "not applicable" | 14:13 |
| mzanetti | yes | 14:13 |
| MacSlow | mzanetti, that was a this-or-that question... not yes-or-no :) | 14:14 |
| mzanetti | dunno... means it's not there | 14:15 |
| mzanetti | :D | 14:15 |
| MacSlow | mzanetti, ok :) | 14:15 |
| MacSlow | mzanetti, "blocked on design" this means to me then | 14:15 |
| mzanetti | MacSlow, if you refer to the ones in the "Visual Design" column, feel free to question that if you think there is a visual design needed | 14:15 |
| mzanetti | MacSlow, for example in row 17 I would disagree that a visual design is not applicable. becuase I already had one when I implemented that | 14:16 |
| mzanetti | anhow, as it's already implemented we probably don't *really* need it any more now | 14:17 |
| mzanetti | although it should be archived in that design website... | 14:17 |
| MacSlow | mzanetti, I'll focus first on really non-implemented pieces first, before I start polishing things... since I know that's far more design-feedback-intense | 14:18 |
| Saviq | Cimi, so no work for us yet, then? | 14:18 |
| Cimi | Saviq, I would say so | 14:18 |
| Saviq | Cimi, cool, DONE | 14:18 |
| Cimi | :D | 14:18 |
| Saviq | Cimi, ok, so to fix the visual effect, jump on the shape card then | 14:19 |
| Saviq | Cimi, or let's size it after standup | 14:19 |
| === dandrader is now known as dandrader|lunch | ||
| === dandrader|lunch is now known as dandrader | ||
| === alan_g is now known as alan_g|EOW | ||
| === dandrader is now known as dandrader|afk | ||
| === dandrader|afk is now known as dandrader | ||
| dandrader | is it just me or does it really take forever to download an image to flash | 19:30 |
| dandrader | ? | 19:31 |
| === dandrader is now known as dandrader|afk | ||
| === dandrader|afk is now known as dandrader | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!