| === MacSlow is now known as MacSlow|lunch | ||
| === MacSlow|lunch is now known as MacSlow | ||
| MacSlow | elopio, hey there... can you point me to a guide/example wrt to ap-fixtures (https://code.launchpad.net/~macslow/unity8/shellRotation/+merge/256493/comments/639107) | 14:05 |
|---|---|---|
| elopio | MacSlow: not specific to autopilot: https://pypi.python.org/pypi/fixtures | 14:06 |
| MacSlow | elopio, ah ok... looking | 14:06 |
| elopio | MacSlow: we can also pair if you need an extra hand on it, just ping us. | 14:07 |
| MacSlow | elopio, I probably will... this too is new ground for me | 14:07 |
| MacSlow | elopio, I didn't even write LaunchUnityWithFakeSensors in the first place | 14:08 |
| elopio | MacSlow: I wrote it :) | 14:11 |
| MacSlow | elopio, oh... and I'm meant to refactor it... :) | 14:13 |
| elopio | MacSlow: that probably shouldn't happen in this MP though, already too big. | 14:14 |
| MacSlow | elopio, I would welcome that... but Saviq suggested it... | 14:15 |
| MacSlow | elopio, by now i'm so worn out on that branch... I would really like to be able to put it to an end... I fixed all the other issues | 14:15 |
| elopio | Saviq: are you ok with filling a bug about turning the Unity launch into a fixture, a doing it in a following branch? | 14:15 |
| MacSlow | elopio, so if you would take another look | 14:15 |
| Saviq | elopio, MacSlow, sure, just file a bug for it and land as is | 14:16 |
| Saviq | but before we touch either that or the base UnityTestCase there, we need to factor it out | 14:16 |
| MacSlow | elopio, you file the fixture-refactor wishlist/bug? | 14:16 |
| Saviq | (again) | 14:16 |
| elopio | MacSlow: one second. | 14:19 |
| elopio | MacSlow: https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1447206 | 14:39 |
| ubot5 | Ubuntu bug 1447206 in unity8 (Ubuntu) "in autopilot tests, UnityTestCase setup is too big and complicated" [Undecided,New] | 14:39 |
| elopio | MacSlow: your branch looks good now. Only two minor details: | 14:40 |
| elopio | - I would rename main_win to main_window | 14:40 |
| elopio | - I would change | 14:40 |
| elopio | 438+ logger.info('unsupported orientation ' + self.action + ' skipped.') | 14:40 |
| elopio | to | 14:40 |
| elopio | self.skipTest('unsupported orientation ' + self.action) | 14:40 |
| MacSlow | elopio, wilco | 14:40 |
| MacSlow | elopio, that skipTest needs to happen at the beginning of test_rotation_with_webbrowser_app(), right? | 14:43 |
| elopio | MacSlow: would be good, yes. The earlier you discover that the test can't be run, the less wasted time you spend on it. | 14:44 |
| elopio | in this case I think you can't put it as the first step of the test, but certainly you can move it up a little. | 14:45 |
| MacSlow | I put it after self.shell_proxy = unity_with_sensors.main_win.select_single('Shell') before the app is launched... | 14:47 |
| MacSlow | that saves at least a bit of execution time I guess | 14:47 |
| MacSlow | elopio, pushed suggested fix... r1611 | 14:53 |
| elopio | MacSlow: ok, +1. Now, how do we confirm jenkins' tests are passing? | 14:56 |
| MacSlow | elopio, I added a further comment on the build-depencecies in the MP's description... it needs libunity-api-dev >= 7.97 which isn't released yet... all we can do is wait | 14:57 |
| elopio | MacSlow: awesome. Thanks for working on this. | 14:59 |
| elopio | when I proposed this to be in our previous sprint, I was expecting our team to help you more with the scenarios and the fixtures and all the python details. | 14:59 |
| elopio | but then I went on vacations, got drunk and forgot about work :) | 14:59 |
| elopio | I mentioned this in our retrospective, so next time we really help devs to get the tests done, not just point out the way to go. | 15:00 |
| MacSlow | elopio, well... at least I left the fixture-refactor for you to do :) | 15:22 |
| elopio | MacSlow: ah, well... I'm not sure I will be able to do it. That's a negotiation between your manager and my manager to see who does it. | 15:23 |
| elopio | I might some free time tomorrow though, I'll try to sneak it in this week. | 15:24 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!