/srv/irclogs.ubuntu.com/2015/04/27/#launchpad-dev.txt

wgrantcjwatson: the pack protocol we use internally is extensible with a dict of strings06:05
wgrantlike git's normal host field, but not restricted to host06:05
wgrantcjwatson: Morning.09:32
cjwatsonwgrant: Hi.  How's Malta?10:09
wgrantcjwatson: Cooler than last year, but sprint going well so far.10:11
wgrantcjwatson: I can't push to a locally mojo'd turnip today.10:11
wgrantturnipserver.py still works on my host, so I wonder if the split is buggy.10:11
wgrantI haven't debugged too fa yet.10:11
cjwatsonwgrant: Pushing to qas still works, and qas has the split ...10:13
cjwatson(e.g. https://code.qastaging.launchpad.net/~cjwatson/binfmt-support/+git/binfmt-support which I just pushed)10:13
wgrantHm10:13
wgrantcjwatson: I have a subordinate alternate branch proposed, and apparmor stuff working for git subproesses but won't propose that until I have turnip itself confined.10:15
cjwatsonwgrant: You definitely have all the listeners up?10:15
wgrantcjwatson: Yeah, it looks like git receive-pack --stateless-rpc just immediately dies for some reason.10:15
wgrantI can see it starting, and processEnded is called, but outReceived and errReceived are not :/10:16
wgrantI'll poke harder.10:16
cjwatsonThat's a peculiar failure mode for the stuff I was doing, unless I missed some detail in which the TACs differ from turnipserver.py.10:17
wgrantIndeed, but I think you caught it all.10:17
cjwatsonThe only one of those I noticed was that the backend server hadn't been updated to run hookrpc, but I fixed that.10:17
cjwatsonHopefully the logging is less hopelessly inconvenient to play with locally now :-)10:18
cjwatsonLike, timestamps.10:18
cjwatsonI stuffed a draft production stage into our mojo spec branch too, if you want to have a look.  Mostly the same as qas.10:18
cjwatsonwgrant: alternates: I wonder if we need to force receive.autogc to false before doing this10:53
cjwatsonwgrant: Otherwise branch removal + next push might corrupt cloned-from repositories.10:53
cjwatson(And we'll have to be very careful on repack, but we knew that.)10:54
wgrantcjwatson: How can it corrupt cloned-from?11:43
cjwatsonwgrant: Sorry, I mean corrupt cloned.11:47
cjwatsonI think my comment in the MP was clearer.11:47
cjwatsonwgrant: I've been trying to reproduce the behaviour from http://paste.ubuntu.com/10909945/ in the test suite and can't (if I .encode the URL I pass to test_traverse, something in the traversal machinery decodes it again for me.  Is there anything specific to the test suite you know about that would cause that?11:48
wgrantBut we're cloning the cloned-from, so even deletion of it won't affect anything.11:48
cjwatsonOh11:48
wgrantcjwatson: A GC in the cloned-from can't touch the packs that we've hardlinked into the alternate.11:48
cjwatsonYeah, OK, I'm confused then.11:48
wgrantThat's the entire reason we create the separate repo.11:49
cjwatsonDisabling autogc might be good for other reasons, but you're right.11:49
wgrantOtherwise, yes, disaster would strike.11:49
wgrantIndeed.11:49
cjwatsonwgrant: Have you had a chance to look at the couple of pending LP git branches I have?13:20
cjwatsonhttps://code.launchpad.net/~cjwatson/launchpad/git-mp-collection/+merge/257145, https://code.launchpad.net/~cjwatson/launchpad/git-mp-ref-proposals/+merge/25737413:21
wgrantcjwatson: Looking.13:23
cjwatsonAh.  So BasicLaunchpadRequest.__init__ decodes the PATH_INFO.  I wonder why that isn't done for API requests as well?13:29
cjwatsonOh, except it doesn't, it decodes and re-encodes.  Must be somewhere else.13:30
wgrantIsn't that all done in Zope?13:30
wgrantAre you seeing it as a bytestring somewhere?13:30
cjwatsonzope.publisher.http:sane_environment is the bunny.13:31
cjwatsonYes, in an API requesthttp://paste.ubuntu.com/10909945/13:31
cjwatsoner http://paste.ubuntu.com/10909945/13:31
cjwatsonI wonder if lazr.restful should be decoding the path to match.13:32
wgrant:/13:33
cjwatsonHow have we not come across this before?  Are there just lots of little model hacks to decode?13:34
cjwatsonI mean I know it's only pure-Storm stuff that's likely to care, but.13:34
wgrantIt's very odd.13:35
cjwatsonI had to handle this in GitTraverser, which is probably why.13:35
cjwatsonNever tracked it down properly at the time.13:35
cjwatsonI wonder if this is the else case of SimpleFieldMarshaller.marshall_from_request.13:39
cjwatsonIf it's posting a non-JSON-encoded bytestring there, that case doesn't decode it.13:41
wgrantAh, yes.13:43
cjwatsonWill have a go at that after lunch.13:44
cjwatsonAh, no, the problem is that lazr.uri returns bytestrings in URI.path (arguably reasonably) and we need to decode those in URLDereferencingMixin.dereference_url.14:37
cjwatsonAha.  I think lazr.uri 1.0.3 is the thing.16:05
cjwatsonFar be it from us to have upgraded to our own software released three years ago.16:05

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!