| wgrant | blr: Evening. | 07:00 |
|---|---|---|
| blr | wgrant: morning! | 07:09 |
| wgrant | blr: I saw that your default clone_from thing landed, testing it now. | 07:10 |
| wgrant | Did you make any progress on the init with alternates? | 07:10 |
| blr | wgrant: merged your recent changes into the alternates branch as well now, which is much better - only change in the view is docstrings for repo:repo | 07:10 |
| wgrant | Great. | 07:10 |
| blr | the only thing I'm a little uncertain about is that there is now obvious place to cleanup the ephemeral repo - I've added a repo_cleanup() method to both diff functions, but it might be better to have a sweeper do this later | 07:11 |
| blr | s/now/no/ | 07:11 |
| wgrant | I think that using a context manager makes sense. | 07:12 |
| wgrant | eg. "with open_repo(blahblah) as repo:" would ensure that it's always cleaned up at the end. | 07:13 |
| wgrant | The autocloning stuff works well, with one unforeseen issue. | 07:45 |
| wgrant | The connectivity check on push uses rev-list --not --all, but --all only looks in the local ref. | 07:45 |
| wgrant | s | 07:45 |
| wgrant | So my first push to ~wgrant/ubuntu/+source/linux took a bit over a minute, as it ended up walking the entire tree when it had no known-good refs. | 07:46 |
| wgrant | It may be worth patching git to let rev-list consider alternate refs as well. | 07:46 |
| wgrant | But it's just a bit slow on first push, not a serious problem. | 07:47 |
| wgrant | Particularly not for sensibly sized repos. | 07:47 |
| wgrant | blr: What d oyou think of the context manager approach to ensure the ephemeral repo is always cleaned up? | 07:50 |
| blr | wgrant: yep that sounds sensible, I'll have another pass | 07:56 |
| wgrant | Thanks. | 07:57 |
| wgrant | Let me know how it goes. | 07:57 |
| blr | wgrant: open_repo() is a contextmanager now, that should be ready for you | 10:14 |
| wgrant | blr: Let me see. | 10:15 |
| wgrant | lifeless: I think you can do away with repo.ephemeral and cleanup_repo now, since you only call cleanup_repo in the ephemeral case. | 10:16 |
| wgrant | Er | 10:17 |
| wgrant | blr: ^^ | 10:17 |
| wgrant | This ssh latency is really awful for typing. | 10:17 |
| blr | wgrant: quite, that's a fairly useless function now. | 10:19 |
| blr | ok pushed | 10:20 |
| wgrant | blr: Couple of other trivial comments, then I think it's all good. | 10:22 |
| blr | wgrant: hmm actually, in get_commit repo=None is used to prevent us re-initialising repositories in get_commits | 10:24 |
| wgrant | Ah, that's right. | 10:24 |
| blr | not certain how to perserve that nicely in the context of the context manager | 10:24 |
| wgrant | blr: Maybe get_commits and get_commit should call a private method which just takes a repo that must already be open. | 10:25 |
| blr | that sounds reasonable, I'll sort that out in the morning, getting late | 10:27 |
| blr | thanks wgrant | 10:27 |
| wgrant | Night. | 10:27 |
| cjwatson | wgrant: https://code.launchpad.net/~cjwatson/launchpad/git-fix-clone-from-owner-default/+merge/257622 if you get a minute, little bit of cleanup | 10:35 |
| cjwatson | wgrant: Creating MPs on the webservice now works, though https://code.qastaging.launchpad.net/~cjwatson/germinate/+git/germinate/+ref/exp/+merge/254302 will OOPS in the web UI for now. | 10:37 |
| wgrant | cjwatson: Nice, how's the testing of the remaining KLOC going? | 11:58 |
| cjwatson | wgrant: Making progress, just thinking about how to mangle TestRegisterBranchMergeProposalView suitably. | 12:11 |
| cjwatson | wgrant: Have you heard anything from IS? | 12:11 |
| wgrant | cjwatson: We're yellow. | 12:13 |
| cjwatson | Ah yes, thanks for the score bump. | 12:13 |
| cjwatson | wgrant: Is there any equivalent of SQLObjectVocabularyBase for Storm? | 12:48 |
| wgrant | cjwatson: I don't think so. | 12:55 |
| cjwatson | I wonder if I should write one. I just noticed that GitRepositoryVocabulary is wrong. | 12:57 |
| wgrant | It would not be a huge task. | 12:58 |
| cjwatson | https://code.launchpad.net/~cjwatson/launchpad/storm-vocabulary-base/+merge/257655 https://code.launchpad.net/~cjwatson/launchpad/git-mp-basic-browser/+merge/257674 https://code.launchpad.net/~cjwatson/launchpad/git-mp-register/+merge/257676 are all the MP stuff I have so far, except for my in-progress stuff on preview diffs. | 16:55 |
| cjwatson | Should be (barely) enough to go live with. | 16:56 |
| xnox | cjwatson: did you see recent discussions about git / merge proposal workflows on debian-devel et.al.? | 17:24 |
| xnox | cjwatson: it would be cool if launchpad would support emailing in git-bundle(1) to create mp just like one can with bzr bundles | 17:25 |
| cjwatson | xnox: I noticed the thread, but we have a fair bit still to do before getting to that kind of point | 17:25 |
| xnox | cjwatson: sure. plus i believe git-bundle has insufficient information as usual in the git world. E.g. bzr bundle encodes public/parent/submit branch locations, and git bundle does not as far as i remember.... | 17:26 |
| wgrant | bzr bundle slso hasn't worked since 2009 | 17:27 |
| xnox | wgrant: the email interface or the bundles themself?! | 17:28 |
| cjwatson | Yes, I wondered why I couldn't find any of this alleged-to-exist code | 17:29 |
| xnox | i sure used bundles as recent as 2013-2014 e.g. generate it somewhere throw into usb-stick or email and pull from it on the other end.... | 17:29 |
| wgrant | bundles never worked with 2a | 17:29 |
| wgrant | so the LP side was removed | 17:29 |
| xnox | wgrant: just tested works here.... created --unchanged commit, branched, created --unchanged commit, bzr bundle ../first-branch, then branch first branch again and pulled from the bundle | 17:34 |
| xnox | got matching revision-ids out of it.... | 17:34 |
| * xnox is sad =( | 17:34 | |
| wgrant | ah yes, the unchanged test :P | 17:43 |
| wgrant | that crestes little new 2a data | 17:43 |
| xnox | wgrant: well i did merges and the like... and it didn't fail me. | 18:15 |
| xnox | althoguht plenty of things are broken with ghost revisions | 18:16 |
| wgrant | hmmm | 18:24 |
| lifeless | wgrant: I can? thanks | 18:30 |
| wgrant | lifeless: 500ms sucks | 18:34 |
| lifeless | aye, where art thou? | 18:38 |
| wgrant | Malta | 18:38 |
| lifeless | nice | 18:38 |
| wgrant | after Austin and London | 18:38 |
| lifeless | I don't miss those trips | 18:38 |
| wgrant | it's certainly a new experimebt in blood caffeine content | 18:39 |
| blr | this looks like it might be useful https://github.com/libgit2/pygit2/pull/525 | 20:19 |
| cjwatson | blr: I thought about backporting it, but reckoned I could probably just reuse the stuff in LP (actually bzrlib I think) for now and no rush to backport. But I might change my mind if that turns out to be non-trivial :) | 20:39 |
| cjwatson | (That is, it looked like it'd be less work to reuse) | 20:39 |
| blr | right | 20:41 |
| cjwatson | We'll see - I'm going to try to finish the LP side of preview diffs tomorrow | 20:42 |
| lifeless | wgrant: whats em1.rapid.c.c ? | 22:51 |
| lifeless | cjwatson: ^ | 22:51 |
| lifeless | thomi: ^ | 22:51 |
| lifeless | blr: ^ | 22:52 |
| lifeless | any two-letter nicks around ? | 22:52 |
| cjwatson | lifeless: replacement for batuan, if you remember that | 22:57 |
| lifeless | cjwatson: no; I've just got hold of the ops VG so we're good | 22:57 |
| lifeless | cjwatson: thanks | 22:57 |
| cjwatson | VPN endpoint for misc crap | 22:57 |
| wgrant | lifeless: what was it spamming you with? | 23:01 |
| lifeless | wgrant: git requests. see #openstack-infra. blahdeblah is on it | 23:01 |
| thomi | hmmm? | 23:04 |
| * thomi makes whooshing motion above his head | 23:05 | |
| wgrant | hmm | 23:05 |
| lifeless | thomi: outbound NAT gateway for OIL it appears | 23:05 |
| cjwatson | not totally implausible | 23:05 |
| thomi | I know what some of those words mean, so yay! | 23:06 |
| wgrant | for moat of the weird non-IS-managee labs | 23:06 |
| thomi | wgrant: how's Malta? I'm surprised you're awake | 23:06 |
| wgrant | awake is pushing it | 23:06 |
| cjwatson | there's still a load of CI jenkins stuff behind rapid isn't there? | 23:07 |
| wgrant | the CI lab, all the ex-CTD stuff, servenab, hwcert | 23:07 |
| lifeless | contra-terrene devices? | 23:07 |
| wgrant | CTS, that is | 23:07 |
| cjwatson | right. not LP anyway :) | 23:08 |
| lifeless | no | 23:08 |
| lifeless | I was pinging clued up people in the most convenient channel :> | 23:08 |
| cjwatson | heh | 23:08 |
| wgrant | batuan has ll the stuff you don't want to think about | 23:08 |
| thomi | lol... and you pinged *me* :D | 23:08 |
| lifeless | thomi: penance for using the wrong channel :). Actually its the CI nature of it that led me to ping you | 23:09 |
| thomi | ahh | 23:09 |
| lifeless | non-CI doesn't need many many many accesses to the same git repos | 23:09 |
| wgrant | yep | 23:09 |
| thomi | blissfull ignornace is my motto... | 23:09 |
| lifeless | thomi: and I hear you've done some CI stuff | 23:09 |
| wgrant | anyway, night avain | 23:09 |
| lifeless | wgrant: night, thanks. cjwatson ditto | 23:10 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!