[07:58] wgrant: don't you love release bugs ;0 [07:59] wgrant: I've asked ttx to grab some timing data, it looks like milestone assignment on bugs may be rather slow - we'll try to create a decent bug report [08:00] wgrant: he's saying ~2s to dereference the bug, assign a milestone, and call lp_save() [08:00] lifeless: On OpenStack projects? Yes. [08:00] You have thousands of structsubs. [08:01] wgrant: still, should be deferrable work [08:01] I am aware. [08:01] wgrant: heh [08:01] wgrant: ok, well we'll gather the data [08:02] It's on the list for this year, as it's becoming quite unpleasant. [08:02] since assigning milestones is relatively rare I figure it doesn't show in the % failure rates much [08:02] Most other things are performing OK nowadays. [13:26] Re discussion from yesterday, Diff.generateDiffstat works just fine for git diffs; it just needs a small tweak to run in -p1 mode. [13:27] (We could change the diff format from turnip, but I'd rather leave that as close as possible to the default git style.) [13:29] Nice. [13:30] Yeah, let's notdiverge pointlessly. [13:35] wgrant: And it's just the format_diff stuff in lp.app.browser.stringformatter that should need to be tweaked otherwise, right? [13:38] In which case I'm nearly done with preview diffs, just need to have the alternate diffs stuff in place in turnip and to finish the job changes. [13:38] cjwatson: I think so. The rest is just bsed on the classes. [13:41] I'll get to your two remaining not-quite-mega-branches soonish. [13:41] https://code.qastaging.launchpad.net/~cjwatson/germinate/+git/germinate/+ref/exp/+merge/254302 renders now. [13:42] Thanks. [13:58] Ah excellent. [14:06] cjwatson: https://code.launchpad.net/~wgrant/launchpad/do-not-reject-ddebs/+merge/257758 [14:10] wgrant: r=me, thanks [14:42] wgrant: That's hopefully all the MP stuff proposed now. I'm moving on to see if I can sort out at least a little bit of repo listing display. [14:57] wgrant: Should I shove contextlib2 into turnip-dependencies and land Kit's branch? (Though, that's only worth it if you're going to get all the way up my review stack today, which may be a bit to ask ...) [15:01] cjwatson: Sounds reasonable to me. === Spads_ is now known as Spads [16:48] wgrant: This is basically awful: http://people.canonical.com/~cjwatson/tmp/git-target-listing.png [16:49] I think the best way to improve that would be to provide a list of branches in all associated repositories sorted by last-modified and privileging the default repository, or something [16:49] OTOH this was quick. Any suggestions that might be doable short-term? [17:32] Deploying Kit's turnip branch for cross-repo diffs now. [17:38] Had to "rm -r /srv/mojo/mojo-stg-ue-launchpad-git/trusty/qastaging/build/storage-ceph/" so that the new auto-repo stuff stopped being confused