| sinzui | waigani, oh, I understand. Yes i think so. I can confirm though that the "upgrade-charm --force" hack is a permanent fix, so envs/users can resolve the problem in minutes if they need too | 00:00 |
|---|---|---|
| sinzui | waigani, We cannot an an upgrade step to 1.22, since we cannot distribute that version any more. | 00:01 |
| sinzui | waigani, We need 1.23 to do the fix an 1.24 to do the fix. | 00:02 |
| waigani | sinzui: right, got it. perrito666 ^ | 00:02 |
| sinzui | waigani, one complicate is that our early adopters still believe odd numbered jujus are dangerous, so they only upgrade to even numbers | 00:03 |
| waigani | wallyworld: I bootstrapped on aws without issue: http://pastebin.ubuntu.com/10946635/. As I understand it: PrepareForCreateEnvironment is checking UnknownAttrs for control-bucket. configFields, which already had control-bucket, is used to determine what attrs are unknown, thus control-bucket will not be in the unknown attrs, it will be nil. The configDefault is only used to check Coercion of the value types of the attributes: | 00:26 |
| waigani | environs/config/config.go:1384 | 00:26 |
| waigani | wallyworld: this is the same for openstack | 00:29 |
| waigani | wallyworld: though if that is correct, and control-bucket will never be an unknownAttr, it begs the question - why check if it's set at all? | 00:30 |
| wallyworld | waigani: you are misunderstanding what UnknownAttrs are | 00:52 |
| wallyworld | they are attrs specific to different environment types | 00:52 |
| wallyworld | control bucket will always be there | 00:53 |
| wallyworld | there are other areas in the codebase that will fail if control bucket defaults to "" | 00:53 |
| wallyworld | are you sure you didn't have a value set in your env yaml for that bootstrap? | 00:53 |
| waigani | wallyworld: ah, sorry that makes sense. Let me check... | 00:54 |
| waigani | wallyworld: nothing set in environments.yaml let me read the code again and have another crack at understanding what's going on | 00:55 |
| wallyworld | waigani: also, if bucket name is "", bootstrap will not fail but errors will be logged (i haven't seen the code before but just checked then) | 00:58 |
| wallyworld | so the tl;dr; is we must not allow bucket name to be "" | 00:58 |
| waigani | wallyworld: no errors all-machines.log on machine 0 | 01:03 |
| wallyworld | waigani: does the jenv file have a control bucket attr? | 01:13 |
| waigani | wallyworld: not in .jenv I just bootstrapped again and dumped out the attrs - only access-key and secret-key are set, contol-bucket is not passed through. It is later set by the prepare func. It looks as though empty attrs are being removed. | 01:24 |
| mup | Bug #1450265 was opened: juju depends on google.golang.org/cloud/compute/metadata but is not included in dependencies.tsv <juju-core:New> <https://launchpad.net/bugs/1450265> | 01:28 |
| waigani | wallyworld: actually no. I still think configFields and configDefaults are used to validate the unknownAttributes - to make sure they are expected attrs for the provider and not typos and the values are of the right type. They are not being passed through as default values to prepare. The config values are being read from environments.yaml | 01:32 |
| wallyworld | waigani: when control bucket is generated, it should end up in jenv, if it's not there, that means there's an issue | 01:34 |
| waigani | wallyworld: after bootstrap it's there, before it's not. | 01:36 |
| wallyworld | correct, it will not be there until after | 01:37 |
| waigani | wallyworld: yep, that's whats happening | 01:37 |
| waigani | I bootstrapped again to double check that | 01:38 |
| wallyworld | hmm, i can't see how it's being generated then if it's in the map (but "") | 01:38 |
| wallyworld | not without the extra != "" check | 01:38 |
| mup | Bug #1450265 changed: juju depends on google.golang.org/cloud/compute/metadata but is not included in dependencies.tsv <juju-core:Invalid> <https://launchpad.net/bugs/1450265> | 02:28 |
| axw | wallyworld: can you please review https://github.com/juju/charm/pull/125 ? | 02:44 |
| wallyworld | syre | 02:44 |
| axw | ta | 02:47 |
| wallyworld | axw: you may have seen, 1.24 and master now have no storage ff and also have upgrade step for block devices | 02:47 |
| axw | wallyworld: I have, thank you | 02:47 |
| axw | had minor merge conflicts | 02:47 |
| wallyworld | just minor, that's good | 02:48 |
| natefinch | davecheney: constabulary is a terrible name for a github org | 02:50 |
| natefinch | anyone used the canonical VPN? I can't understand their directions... seems like they're missing a step | 02:52 |
| axw | natefinch: yes, what bit are you stuck on? | 02:53 |
| natefinch | axw: thanks. So, I installed network-manager-openvpn-gnome, restarted network manager, then the instructions say: | 02:55 |
| natefinch | Select network manager -> VPN Connections -> Configure VPN... | 02:55 |
| natefinch | ....select network manager from where? | 02:55 |
| natefinch | ....I think I just fdigured it out | 02:55 |
| natefinch | they mean the network icon in the top right there | 02:55 |
| axw | yep | 02:55 |
| natefinch | .. I had no idea that was called the network manager :/ | 02:55 |
| natefinch | axw: ok, another dumb question - how do I get the select file dialog to show dot files? it says to pick the file from the ~/.sesame directory, but the file picker isn't showing hidden directories. | 02:58 |
| menn0 | ericsnow: can you confirm that the fix for bug 1447446 made it into the 1.24 branch and master? (and update the ticket accordingly) | 02:58 |
| mup | Bug #1447446: 1.23.1: bootstrap failure, vivid, local provider <bootstrap> <landscape> <juju-core:Fix Committed by ericsnowcurrently> <juju-core 1.23:Fix Released by ericsnowcurrently> <juju-core 1.24:New> <https://launchpad.net/bugs/1447446> | 02:58 |
| axw | natefinch: you can use Ctrl+L to enter the location | 02:59 |
| axw | not sure if there's a better way, that's what I do | 02:59 |
| menn0 | ericsnow: it was one the tickets that was incorrectly targetted | 02:59 |
| axw | ah, right click has "show hidden files" | 02:59 |
| natefinch | OMG... why doesn't that show all the time :/ | 02:59 |
| natefinch | ahh yeah, I didn't think to right click there... much better | 03:00 |
| ericsnow | menn0: done | 03:02 |
| menn0 | ericsnow: cheers | 03:02 |
| mup | Bug #1447446 changed: 1.23.1: bootstrap failure, vivid, local provider <bootstrap> <landscape> <juju-core:Fix Committed by ericsnowcurrently> <juju-core 1.23:Fix Released by ericsnowcurrently> <juju-core 1.24:New> <https://launchpad.net/bugs/1447446> | 03:04 |
| natefinch | axw: Thanks for the help, got it working. . | 03:11 |
| natefinch | sinzui: you around? | 03:11 |
| axw | natefinch: cool | 03:11 |
| natefinch | axw, menn0: do you guys know how to make the JFDI thing on github work? I swear I got the syntax right, but it's not going through (still says "doesn't match fixes-blah") | 03:38 |
| axw | natefinch: $$__JFDI__$$ | 03:38 |
| natefinch | :/ did that | 03:38 |
| menn0 | natefinch: that's what I would have said | 03:39 |
| natefinch | wonder if the functionality got broken at somepoint (or maybe it just doesn't like me) | 03:39 |
| natefinch | hahaha ... or maybe I mispelled jfdi... :/ | 03:39 |
| axw | natefinch: hum, not sure what's up with that. I've been doing that today, so it's not broken in general | 03:39 |
| natefinch | JDFI is not gonna work | 03:40 |
| axw | heh | 03:40 |
| axw | that'll do it :) | 03:40 |
| menn0 | natefinch: maybe check one of axw's uses of it today? | 03:40 |
| jw4 | menn0: I'm pretty sure that change went in before 1.24 was cut... I'll verify | 04:08 |
| menn0 | jw4: thanks! i'm not saying it make it I just wanted to be sure. the ticket wasn't targetted correctly so it could have been missed. just update the ticket once you've checked. | 04:09 |
| jw4 | menn0: will do | 04:09 |
| mup | Bug #1450299 was opened: api/client: test fails on ppc64le <ppc64el> <juju-core:In Progress by dave-cheney> <https://launchpad.net/bugs/1450299> | 04:10 |
| waigani | wallyworld: the bucket val is being set because it's not in the map. the validation (which would set the default) happens later. | 04:14 |
| waigani | wallyworld: I've sent an email with the details | 04:14 |
| wallyworld | ok, ty, will look | 04:15 |
| wallyworld | waigani: thanks for explanation. i just wanted to be 100% sure that setting the default to "" wouldn't accidentally fail to generate a control bucket if one were not specified, and that config stuff is a bit of a mess which we've managed to break before :-( | 04:21 |
| waigani | wallyworld: no, I appreciate it. I now understand what's going on much more, so thanks :) | 04:22 |
| wallyworld | waigani: i did too 2 years back but have since only vaugue recollections (nightmares?) about config | 04:23 |
| waigani | haha | 04:23 |
| wallyworld | the schema default vs omit stuff is really hard to get right | 04:23 |
| wallyworld | and it really is a convoluted web | 04:23 |
| wallyworld | and we have relased juju which broke set ups in the wild | 04:24 |
| waigani | yeah, it would be good to see if there is a better design pattern that could be used to clear things up a bit | 04:25 |
| waigani | until then, comments are really important! | 04:25 |
| waigani | wallyworld: so is that a shipit? (not that we can land anything) | 04:28 |
| wallyworld | waigani: yeah, but if it's a bug fix for 1.24, feel free to jfdi at this point | 04:28 |
| waigani | wallyworld: thanks | 04:29 |
| wallyworld | axw: this fixes the critical blocker http://reviews.vapour.ws/r/1532/ | 07:26 |
| wallyworld | hopefully | 07:26 |
| TheMue | morning o/ | 07:49 |
| TheMue | hmm, got a fix for 1.24 but CI doesn't accept it *sigh* | 07:50 |
| axw | wallyworld: reviewed | 08:00 |
| wallyworld | ty | 08:00 |
| mgz | TheMue: if the bug you're fixing is actually urgent, you have discretion - but it seems that issue doesn't actually break our bundle test on maas (it probably should) | 08:06 |
| TheMue | mgz: it's a port that of a critical bug in 1.23 to 1.24, where it is only high. don't know why. | 08:07 |
| TheMue | mgz: the bug is #1445063 | 08:08 |
| mup | Bug #1445063: addressable containers cannot resolve non-FQDN in maas <addressability> <cloud-installer> <kvm> <landscape> <lxc> <maas-provider> <network> <oil> | 08:08 |
| mup | <openstack> <uosci> <juju-core:Triaged> <juju-core 1.23:Fix Released by dimitern> <juju-core 1.24:In Progress by themue> <https://launchpad.net/bugs/1445063> | 08:08 |
| mgz | TheMue: that actually makes some sense - we couldn't release a 1.23 with it, but we have time before we're putting out 1.24 so a | 08:08 |
| mgz | and it's not actually stopping any of *us* doing work | 08:08 |
| TheMue | ic | 08:09 |
| mgz | whereas the deployer stuff being borked prevents us improving our tests to catch issues like lxc networking problems :) | 08:09 |
| TheMue | mgz: just saw that dimiter commented is with JFDI | 08:09 |
| mgz | yeah, it's fine | 08:09 |
| mgz | we don't gain anything from doing it but it's not really harmful | 08:10 |
| TheMue | that's great, thx | 08:11 |
| wallyworld | axw: updated, i also added an index, i think it may help with the sorts | 08:13 |
| axw | wallyworld: you didn't explain the change from updated to created though. is it for performance? | 08:15 |
| wallyworld | axw: oh, i see what you're asking, sorry missed the point | 08:15 |
| wallyworld | updated is only to the nearest second | 08:16 |
| wallyworld | we need much finer grained to get the order right | 08:16 |
| wallyworld | most timestamps we store in mongo for juju are to the nearest second | 08:16 |
| axw | wallyworld: so why not store a number somewhere and just increment it each time you need to create an entry? using time is fragile, whatever the resolution | 08:18 |
| wallyworld | could do, but creating a sequence seems overhead for what is being done here, it's just charm status entries, hardly expected to change even a few times per second | 08:19 |
| wallyworld | and the sort is done after filtering for the unit | 08:20 |
| axw | wallyworld: if you're confident with that, okay. I would just like to point out that it's trivial to do, and you could drop the additional index. you could just use State.sequence(), and use the result as the _id field | 08:22 |
| axw | anyway | 08:22 |
| * axw takes a final look | 08:22 | |
| wallyworld | ok, i'll do that | 08:22 |
| mgz | wallyworld: if you get a mo, can I have a stamp on <http://reviews.vapour.ws/r/1473/> | 08:26 |
| mgz | (thanks for the status info) | 08:26 |
| wallyworld | sure give me a sec | 08:26 |
| mgz | it is sadly much larger now, but the commit history should make sense to you | 08:28 |
| wallyworld | axw: sequence number used | 08:44 |
| axw | wallyworld: thanks | 08:45 |
| axw | shipit | 08:45 |
| wallyworld | np, thanks for pointing it out | 08:45 |
| wallyworld | mgz: i need dinner, i'll look at branch after | 08:46 |
| mgz | wallyworld: no probs, won't be landing till this evening I guess | 08:55 |
| perrito666 | Wallyworld: nice catch on the legacy status | 09:37 |
| wallyworld | perrito666: yeah. also found issues with history, incl tests not wired up :-) | 09:37 |
| perrito666 | The test for legacy was long due (which test was not wired I just briefly went trough the diff and didn't notice them) | 09:42 |
| wallyworld | perrito666: status_test.go - the status history tests | 09:42 |
| wallyworld | so they were never run nd hence missed picking up bugs | 09:43 |
| perrito666 | Duh, just saw it dang | 09:48 |
| perrito666 | Btw | 09:48 |
| perrito666 | +c.Assert(len(history), gc.Equals, 100) c.Assert(history, gc.HasLen, 100) | 09:48 |
| perrito666 | You are checking twice the same | 09:48 |
| wallyworld | oh i added that to make the failures easier to debug | 09:48 |
| wallyworld | i'll remove thanks | 09:48 |
| perrito666 | Sorry for that not being a comment I am in the phone | 09:49 |
| wallyworld | np :-) | 09:49 |
| perrito666 | And getoldesttimetokeep no longer gets time so it might need a name change and comment correction :) | 09:50 |
| wallyworld | perrito666: yeah true, same sentiment though :-) | 09:51 |
| natefinch | mgz: you around? | 09:51 |
| mgz | natefinch: I am here | 09:53 |
| natefinch | mgz: I;m trying to connect to stilson-7, but even connected to the VPN, I can't even ping the server, and ssh never connects... any ideas? | 09:57 |
| natefinch | mgz: also, does it matter if I use the US or UK VPN? | 09:57 |
| mgz | natefinch: shouldn't | 10:03 |
| mgz | natefinch: I can get in via our ssh bouncer | 10:06 |
| mgz | if the vpn isn't playing ball for you | 10:07 |
| mgz | natefinch: also ssh -vv is useful for general debugging | 10:08 |
| natefinch | mgz: that might be a good option. I don't know what's up with the VPN... but if all I'm supposed to need to do is connect to it, and then ssh... yeah, it's not working. | 10:08 |
| natefinch | mgz: yeah, it just gets stuck at connecting to the IP..... verifying, stilson-07 is 10.245.67.135 ? | 10:08 |
| mgz | natefinch: yup - you should see that ip via either the vpn or the bouncer | 10:19 |
| mgz | lunching now | 10:32 |
| TheMue | lunch, afk | 10:56 |
| === liam_ is now known as Guest24325 | ||
| mup | Bug #1450437 was opened: Juju bootstrap fails with sub error code 1 <juju-core:New> <https://launchpad.net/bugs/1450437> | 11:38 |
| perrito666 | sinzui: ping me when you are around please | 13:00 |
| sinzui | perrito666, I have just arrived, though a little low on caffeine | 13:00 |
| perrito666 | I sadly have been awake for too much already | 13:01 |
| perrito666 | so, I have a fix for https://bugs.launchpad.net/juju-core/+bug/1447853 that should go into 1.22, 1.23 and 1.24 and master :p can I do that? I mean push a fix to 1.22 | 13:02 |
| mup | Bug #1447853: Local charms are not added to storage on upgrade to 1.22.x <charms> <regression> <storage> <upgrade-juju> <juju-core:Triaged> <juju-core 1.24:In Progress by hduran-8> <https://launchpad.net/bugs/1447853> | 13:02 |
| sinzui | mgz, r=me for joyent, but you conflict with my changes in check_blockers | 13:13 |
| sinzui | katco, can you ask someone to read the new comment on bug 1437266. Do we need this fixed in 1.24 or 1.25? | 13:21 |
| mup | Bug #1437266: Bootstrap node occasionally panicing with "not a valid unit name" <deploy> <destroy-machine> <destroy-service> <juju-core:Triaged> <https://launchpad.net/bugs/1437266> | 13:21 |
| sinzui | natefinch, Are bug 1340749 and bug 1450437 the same as bug 1412621. Can I make them dupes? | 13:30 |
| mup | Bug #1340749: Replicaset initiation failure reports wrong error <mongodb> <juju-core:Triaged> <https://launchpad.net/bugs/1340749> | 13:30 |
| mup | Bug #1450437: Juju bootstrap fails with sub error code 1 <juju-core:New> <https://launchpad.net/bugs/1450437> | 13:30 |
| mup | Bug #1412621: replica set EMPTYCONFIG MAAS bootstrap <bootstrap> <maas-provider> <mongodb> <juju-core:Triaged> <juju-core 1.24:Triaged> <https://launchpad.net/bugs/1412621> | 13:30 |
| voidspace | dooferlad: TheMue: alexisb: I'm off to the dentist | 13:32 |
| voidspace | bbiab | 13:32 |
| dooferlad | voidspace: enjoy! | 13:32 |
| TheMue | voidspace: just a check or more? have to do that the next days too ;) | 13:33 |
| TheMue | voidspace: yes, enjoy | 13:33 |
| voidspace | a check, but for all the family... | 13:33 |
| perrito666 | sinzui: dont forget my question now that you are caffeinated :p | 13:34 |
| sinzui | perrito666, 1.22 is superseded in our PPAs by 1.23. and the packaging rules know it is an error to try to release a lower version | 13:35 |
| perrito666 | soo, 1.23, 1.24, master? | 13:36 |
| sinzui | perrito666, alexisb, mramm, and xwwt to agree to purge our ppa and rush a 1.22 fix out...which means 1.23 will be released next week, not today | 13:38 |
| sinzui | perrito666, yes. I will add the 1.23 task to the bug | 13:43 |
| mup | Bug #1450437 changed: Juju bootstrap fails with sub error code 1 <juju-core:New> <https://launchpad.net/bugs/1450437> | 13:57 |
| katco | sinzui: i don't know whether or not bug 1437266 need be fixed in 1.24 or 1.25. it looks like it only affects a few people, so probably 1.25? we should discuss in the release call | 14:00 |
| mup | Bug #1437266: Bootstrap node occasionally panicing with "not a valid unit name" <deploy> <destroy-machine> <destroy-service> <juju-core:Triaged> <https://launchpad.net/bugs/1437266> | 14:00 |
| katco | ericsnow: stand up | 14:02 |
| natefinch | ericsnow: stup? | 14:03 |
| natefinch | sinzui: I'll take a look at those bugs in a few minutes | 14:04 |
| === kadams54 is now known as kadams54-away | ||
| perrito666 | question about upgrades, when upgrading to a minor, are the steps for that whole mayor rerun? | 14:48 |
| natefinch | perrito666: not sure. I would hope not. | 14:53 |
| perrito666 | natefinch: they are supposed to be idempotent | 14:53 |
| natefinch | perrito666: then why do you care? :) | 14:54 |
| perrito666 | natefinch: I need them to | 14:56 |
| fwereade | perrito666, we *should* run any steps that haven't already been run, but I'm pretty we shouldn't rerun them (ok, if we do by accident they should be idempotent... but still) | 14:58 |
| fwereade | perrito666, why do you need them? | 14:58 |
| === kadams54-away is now known as kadams54 | ||
| perrito666 | can anyone stamp this oneliner? http://reviews.vapour.ws/r/1536/ | 15:42 |
| perrito666 | natefinch: | 15:43 |
| perrito666 | katco: ericsnow ? | 15:44 |
| * ericsnow takes a look | 15:44 | |
| natefinch | perrito666: looking... are there no tests for this stuff? | 15:44 |
| ericsnow | perrito666: nice 6 line oneliner :) | 15:45 |
| natefinch | right? | 15:45 |
| perrito666 | natefinch: there are but the migration step was already there in the wrong version | 15:45 |
| perrito666 | ericsnow: I meant another work but since I dont know it in english my brain replaced with oneliner | 15:45 |
| perrito666 | sorry | 15:45 |
| perrito666 | word* | 15:45 |
| ericsnow | perrito666: no worries :) | 15:45 |
| perrito666 | natefinch: or you mean tests for the contents of the step? | 15:45 |
| natefinch | perrito666: I mean... this code was wrong before, and obviously no test was failing because of it. It would be nice if there were a test that would fail if your addition was not there. | 15:46 |
| ericsnow | natefinch: I expect the testing is already there in state/upgrades_test.go | 15:46 |
| ericsnow | natefinch, perrito666: ah, there should be a test that checks that the step was run | 15:46 |
| perrito666 | ericsnow: yes, I should have committed it :p | 15:47 |
| perrito666 | sorry I had all these changes in patches that a testing script applied after checkout | 15:48 |
| ericsnow | perrito666: looks like the test is missing in steps122_test.go | 15:49 |
| ericsnow | (or the step, rather) | 15:49 |
| ericsnow | perrito666: so TestStateStepsFor122 should be failing | 15:49 |
| * perrito666 looks why his unstaged changes checker did not fail | 15:50 | |
| perrito666 | fixed | 15:52 |
| perrito666 | ericsnow: can I consider you a holy reviewer or do I need a signature on that stamp? | 15:52 |
| ericsnow | perrito666: I wasn't going to bring it up <wink> | 15:52 |
| katco | perrito666: i trust ericsnow's judgement | 15:53 |
| katco | perrito666: go with it | 15:53 |
| natefinch | perrito666: me too | 15:54 |
| perrito666 | so do I it is the burocratic weight of the stamp what I was looking for, but this is heavy enough for me to let it pass | 15:54 |
| natefinch | perrito666: I rubber stamped it | 15:55 |
| perrito666 | natefinch: I already hit merge anyway :p | 15:55 |
| perrito666 | I am hurried enough | 15:55 |
| natefinch | wow, those are some... ummm.... high level tests | 15:57 |
| perrito666 | natefinch: ?? | 15:57 |
| perrito666 | there is a separate test for the function being run :) if that is what worries you | 15:58 |
| natefinch | sorry, high level isn't the right word..... what's the opposite of comprehensive? | 15:58 |
| natefinch | perrito666: ahh, ok | 15:58 |
| natefinch | perrito666: just with the changes, it looks like all we're testing is that the upgrade step has the right description | 15:58 |
| perrito666 | natefinch: but again, htat was already there, only in the wrong version, the merge of the patch got delayed until 1.22 so the steps where added in a place where they would never run | 15:59 |
| perrito666 | natefinch: well there is no way to test that the upgrade function does what it says | 15:59 |
| perrito666 | we check that the steps are the right ones based on their description, we know that at least that is what we want to run | 16:00 |
| natefinch | perrito666: I'm sure there's a way to test that the upgrade function at least calls AddEnvUUIDToCharms.... | 16:18 |
| natefinch | mgz, sinzui: I'm trying to connect to stilson, but can't seem to make the connection no matter how I do it. pure VPN doesn't work for me, I just never can get a response from the IP address. Martin told me about the CI bouncer, and I can connect to it, but I think I must be messing up the proxy command, because it never hops to stilson from the bouncer. | 16:25 |
| sinzui | natefinch, I will get you a ssh config stanza | 16:30 |
| natefinch | sinzui: thank you. I'll be afk for an hour-ish, so no rush | 16:31 |
| === natefinch is now known as natefinch-afk | ||
| katco | ericsnow: nttac meeting | 16:34 |
| katco | nttca | 16:34 |
| katco | ericsnow: hey can you join the nttca meeting again? | 17:32 |
| === natefinch-afk is now known as natefinch | ||
| mup | Bug #1450573 was opened: HA and backup recovery tests failed <backup-restore> <blocker> <ci> <ec2-provider> <ensure-availability> <regression> <juju-core:Triaged> <https://launchpad.net/bugs/1450573> | 17:45 |
| TheMue | anyone willing for a review of a forward port of a fix from 1.23 and 1.24 to now master? see http://reviews.vapour.ws/r/1538/. thx | 17:49 |
| natefinch | TheMue: you should reference the original PR so that it's easy to check that the port is the same as the original | 17:51 |
| katco | natefinch: running a little behind, may be slightly late | 17:55 |
| natefinch | katco: no worries. I know how it is. | 17:55 |
| TheMue | natefinch: will add it | 17:56 |
| TheMue | natefinch: done | 18:00 |
| === cmars` is now known as cmars | ||
| natefinch | TheMue: ship it! | 18:02 |
| TheMue | natefinch: thx | 18:02 |
| natefinch | TheMue: seems like we should be able to have an automated check that a forward port is identical to an existing PR on another branch and skip the second review. obviously, if changes needed to be made to the PR for the forward port, then it needs human eyes, but for ones like this where it's identical... would be nice to skip that. | 18:07 |
| TheMue | natefinch: sounds like a good idea. but now also the fix doesn't match the listed fixes, so I've got to use JNDI | 18:08 |
| TheMue | hmm, my CI output shows "Extant directories unknown: gopkg.in/juju/charm.v6-unstable". any idea what this means? | 19:05 |
| TheMue | natefinch: any idea here ^^ | 19:11 |
| natefinch | TheMue: no idea. sinzui? ^ | 19:11 |
| sinzui | natefinch, are you using the make-release-tarball script? | 19:13 |
| sinzui | natefinch, That error looks like the checks that ensure every package in the tarball is documented. | 19:13 |
| TheMue | sinzui: it's me, and I'm only trying to merge a PR into master. | 19:14 |
| TheMue | sinzui: only 5 files changes, dependencies are unchanged | 19:14 |
| sinzui | TheMue, I think one of things you are trying to merge is injecting charm.v6-unstable. either we document that it is needed, or fix the code to not get it | 19:16 |
| TheMue | sinzui: strange, I only ported a fix, a few code lines | 19:19 |
| perrito666 | TheMue: if you brought charm v6 definitely its a bigger change, we where using v5 yesterday | 19:20 |
| TheMue | perrito666: no, I haven't. no change of imports. and I just scanned the code here, no where found | 19:21 |
| sinzui | abentley, jog, something in CI is very wrong. it is trying to upgrade from 1.23.2 to 1.22.2. I think the upgrade-jenkins script was run a few hours too early | 19:24 |
| * sinzui looks for downgrade options | 19:24 | |
| abentley | sinzui: on the bright side, upgrade-jenkins-branches ran to completion without errors :-/ | 19:25 |
| sinzui | yep Ci is on the new 1.23.2, but we weren't ready for it | 19:25 |
| sinzui | abentley, I will take this opportunity to downgrade to 1.21.1 to watch the upgrade | 19:26 |
| sinzui | I just got a tax bill for $326,000 for the sale of my home 2 years. ago. I think I am going to pieces right now | 19:28 |
| abentley | sinzui: Wow. Ugh. | 19:29 |
| abentley | sinzui: Yeah, you might want to take some time out. | 19:29 |
| TheMue | ok, I'll retry then tomorrow | 19:29 |
| sinzui | abentley, I think I need an account to explain to the IRS that I did pay tax, on the sale of my house, not the sale of a business under different tax lass | 19:30 |
| sinzui | law | 19:30 |
| === kadams54 is now known as kadams54-away | ||
| sinzui | perrito666, We had a misfire with the release of the new juju. all the CI machines got upgraded during the test. So it tried an impossible upgrade of 1.23.2 to 1.22.3 :( | 19:51 |
| sinzui | perrito666, But CI has a cache of all the old jujus. I installed 1.21.3, then reset all the upgrade tests. All is well! The logs show after upgrade we could set new charms configs with and juju did the right thing \o/ | 19:52 |
| sinzui | I will update CI to the real stable when we are finished testing 1.22.3 | 19:53 |
| sinzui | wow, and we just got a bless | 19:53 |
| katco | ericsnow: running just a little late brt | 20:00 |
| ericsnow | katco: k | 20:00 |
| perrito666 | Sinzui cool can i fwport now? | 20:02 |
| sinzui | perrito666, yep. | 20:03 |
| perrito666 | Sweet | 20:04 |
| sinzui | perrito666, should I make CI wait for your 1.23 merge? if it will be several hours, I would test 1.24 | 20:09 |
| perrito666 | I am at the dentist currently so it should be 1.5h from now :p | 20:12 |
| perrito666 | There is a limit to the things you can do with a phone | 20:16 |
| sinzui | natefinch, thank you! | 20:23 |
| sinzui | natefinch, maybe I should also grab the old broken package and run in there too | 20:24 |
| natefinch | sinzui: certainly seems like a good idea. I wish I knew more of how the packaging process worked, I might be of more help. But I'm glad I was able to at least do this much. | 20:24 |
| sinzui | natefinch, the container doesn't have our build deps ppa attached, so it is pure trusty, but I don't see anything in the ppa that could uncouple: https://launchpad.net/~juju/+archive/ubuntu/golang/+packages | 20:28 |
| sinzui | regardless, natefinch you have given me something I can work with | 20:28 |
| natefinch | sinzui: I am really glad it's useful. | 20:31 |
| sinzui | TheMue, CI s broken as you described in your own branch. I think an upstream change to a repo has broken all builds | 20:36 |
| sinzui | TheMue, mgz discovered some months ago that Go will always get all the deps in the git master branch even when they will not be used. It pollutes the tree. mgz's fix was to fix the upstream repo. | 20:37 |
| === \b is now known as benonsoftware | ||
| menn0 | davecheney: morning | 21:06 |
| sinzui | katco, wallyworld: we need to form an angry mob and address bug 1450631. | 21:09 |
| mup | Bug #1450631: Something is injecting gopkg.in/juju/charm.v6-unstable into the tree <blocker> <ci> <packaging> <juju-core:Triaged> <juju-release-tools:Triaged> <https://launchpad.net/bugs/1450631> | 21:09 |
| sinzui | I will send an email to the list since it break all merges and CI testing | 21:09 |
| katco | sinzui: sorry i was in a meeting... TAL now | 21:19 |
| mup | Bug #1450631 was opened: Something is injecting gopkg.in/juju/charm.v6-unstable into the tree <blocker> <ci> <packaging> <juju-core:Triaged> <juju-release-tools:Triaged> <https://launchpad.net/bugs/1450631> | 21:22 |
| jw4 | sinzui: it looks like it may be the github.com/juju/jujusvg repo that has a reference to gopkg.in/juju/charm.v6-unstable | 21:24 |
| katco | jw4: ty | 21:25 |
| jw4 | sinzui, katco: I wonder if referring to jujusvg through gopkg.in would resolve this? | 21:25 |
| sinzui | jw4, uhg, we didn't change our dep of github.com/juju/jujusvg to get it though. | 21:25 |
| sinzui | jw4, maybe | 21:25 |
| sinzui | ps jw4, did you get credentials to see test results? | 21:26 |
| jw4 | sinzui: not yet | 21:26 |
| jw4 | sinzui: alexisb is still working on that :) | 21:26 |
| sinzui | okay, I will see If I can get that to you tommorow jw4 | 21:26 |
| jw4 | sinzui: very likely the trigger: https://github.com/juju/jujusvg/pull/28 | 21:28 |
| jw4 | sinzui: we could ask jujusvg folks to tag our revision 28683402583926ce903491c14a07cdc5cb371adb as v1 maybe | 21:29 |
| jw4 | sinzui: then we might be able to use gopkg.in | 21:29 |
| jw4 | s/our revision/their revision/ | 21:29 |
| sinzui | jw4, katco: while changing our dep to jujusvg in every branch might work around this issue, we cannot go back and change branches we aren't developing. Since we did an unplanned build of 1.22.3 today, I worry that we will not be able to respond to emergencys in older jujus | 21:30 |
| jw4 | sinzui: jujusvg is not in dependencies.tsv for 1.22 | 21:31 |
| sinzui | oh, I see what you are saying jw4. I think you are right. and this means that older branches are probably not affected | 21:31 |
| sinzui | jw4, jobs that make the tree will always reject when a package is not documented appears in the tree. | 21:32 |
| jw4 | sinzui: yeah... I'm hoping that using gopkg.in it will pull in only the tagged versions and not the master revisions | 21:33 |
| jw4 | sinzui: I haven't verified that yet though | 21:33 |
| katco | jw4: i think you are correct | 21:33 |
| jw4 | sinzui: but we can't use gopkg.in on jujusvg until it's tagged | 21:33 |
| jw4 | (otherwise we just get the default v0 which is master) | 21:34 |
| sinzui | Makyo, ^ maybe you can help tag jujusvg so that we can build juju again | 21:35 |
| jw4 | Makyo: if we could tag revision | 21:35 |
| jw4 | 28683402583926ce903491c14a07cdc5cb371adb as v1 | 21:35 |
| jw4 | in jujusvg that might help us with this CI issue | 21:36 |
| sinzui | Makyo, or someone you know. We are getting gopkg.in/juju/charm.v6-unstable pulled into the juju tree. since it is not documented, the merge and build jobs break | 21:36 |
| jw4 | Makyo: it might even be better if v1 was a branch vs. a tag | 21:36 |
| sinzui | jw4, I might have permission to tag it! | 21:38 |
| jw4 | sinzui: woot! | 21:38 |
| sinzui | well yes I can tag, lets see if I can push tags | 21:38 |
| sinzui | jw4, is this what you expect for the tag command? | 21:42 |
| sinzui | git tag -a v1 -m "Version 1 for gopkg.in." 28683402583926ce903491c14a07cdc5cb371adb | 21:42 |
| sinzui | just "v1" | 21:42 |
| katco | what branch is this being triggered on? 1.24? | 21:42 |
| sinzui | katco, every branch! | 21:42 |
| jw4 | katco: 1.24 and master | 21:42 |
| katco | godeps -u dependencies.tsv && cat dependencies.tsv |awk '{print $1}' |xargs -I % grep -r "charm.v6" $GOPATH/src/% | 21:42 |
| katco | this is not giving me anything useful | 21:42 |
| sinzui | 1.23 1.24 and all the feature branches | 21:42 |
| jw4 | katco: it's a transitive dependency | 21:42 |
| sinzui | katco, hence we know something happened outside of juju | 21:43 |
| jw4 | katco: github.com/juju/jujusvg master refers to charm.v6 | 21:43 |
| katco | jw4: right, so i am searching all of juju-core dependencies for charm.v6 | 21:43 |
| katco | and i'm not finding anything? | 21:43 |
| jw4 | katco: exactly | 21:43 |
| jw4 | katco: that's why CI is complaining | 21:43 |
| sinzui | katco, that is the error, you will not find it because it is not supposed to be there.. | 21:43 |
| jw4 | CI compares what go get builds against dependencies.tsv | 21:43 |
| katco | jw4: no as in, none of juju-core's dependencies are referencing charm.v6-unstable | 21:44 |
| jw4 | katco: that's the problem jujusvg does | 21:44 |
| sinzui | katco, and all merging branches, not just ci | 21:44 |
| jw4 | but not in the version that's pinned | 21:44 |
| sinzui | jw4, is the tag just "v1" | 21:44 |
| jw4 | sinzui: yeah I think so | 21:44 |
| katco | jw4: but if not in the version that's pinned, why is it causing problems? effectively juju is not utilizing a version of jujusvg that is referencing charm.v6? | 21:45 |
| jw4 | katco: so "go get" pulls down jujusvg master which refers to charm.v6, causing charm.v6 to be pulled down | 21:45 |
| Makyo | sinzui, jw4 Will gladly tag, but I'm a little curious, why is jujusvg showing up in core? | 21:45 |
| katco | jw4: so the ci server is doing a go get, and not a godeps? | 21:46 |
| jw4 | katco: even go deps does a go get first before syncing to the right revision | 21:46 |
| jw4 | Makyo: good question | 21:47 |
| sinzui | katco, merge might be, but the rules to make the tar ball don't besides, I think godeps is still calling git to do something which is still the problem | 21:47 |
| katco | jw4: so the issue is that charm.v6 exists at all on the CI server? | 21:47 |
| Makyo | jw4, jujusvg's only consumer should be charmstore | 21:47 |
| katco | jw4: not that juju-core uses it? | 21:47 |
| jw4 | katco: exactly | 21:47 |
| katco | jw4: thx for walking me around the block on that | 21:47 |
| jw4 | katco: because CI checks that all dependencies downloaded are accounted for | 21:47 |
| sinzui | katco, not at all | 21:47 |
| jw4 | Makyo: it's in our dependencies.tsv, but it's not actually referred to in code... I think it's a transitive dependency | 21:48 |
| jw4 | Makyo: gimme a sec to figure out the third level up :) | 21:48 |
| sinzui | katco, anyone who tries to get juju using go get or godeps is getting a tree witn unised deps because Go's use of git is to always checkout master. | 21:48 |
| Makyo | jw4, ack, thanks. I'll work on tagging. | 21:49 |
| jw4 | Makyo: it's charmstore.v4 that's using it | 21:49 |
| sinzui | katco, There are jobs owned by Core to do merging, and jobs owned by QA to make release tarballs for testing. Both jobs fail because the tree contains a package that us not Used. Ubuntu requires us to abort. We cannot accept a unused an undocumented dep | 21:49 |
| jw4 | Makyo: so it's a legitimate transitive dependency | 21:49 |
| katco | sinzui: i understand now. ty | 21:50 |
| sinzui | I might be a minute from fixing this if someone can config the tag is just "v1" | 21:50 |
| Makyo | jw4, alright, thanks | 21:50 |
| jw4 | sinzui: Makyo will tag for us... (thanks Makyo) | 21:50 |
| katco | well it sounds like you guys have this under control, and i'm well past eod and need to get dinner going | 21:51 |
| katco | i'll see you all around | 21:51 |
| jw4 | katco: control is an illusion | 21:51 |
| jw4 | katco: ttyl | 21:51 |
| katco | jw4: later morpheus ;0 | 21:51 |
| katco | ;) | 21:52 |
| jw4 | haha | 21:52 |
| sinzui | I think my main dislike of Christmas is lack of control. I don't like surprises, even if they are gift wrapped. | 21:53 |
| jw4 | sinzui: I'm so there... I hate surprises :) | 21:53 |
| Makyo | jw4, sinzui gopkg.in/juju/jujusvg.v1 should now work. I went with 890de36 because that's the commit before charm.v6 was added, but after the NewFromBundle() api solidified. | 21:57 |
| Makyo | jw4, sinzui if need be, I can roll it back. I went with a branch for v1 | 21:57 |
| jw4 | Makyo: actually I preferred a branch | 21:57 |
| jw4 | Makyo: that should be fine | 21:58 |
| jw4 | Makyo: thanks@! | 21:58 |
| Makyo | jw4, np, ping if anything else comes up around that. | 21:58 |
| jw4 | sinzui: now for the test | 21:58 |
| jw4 | Makyo: will do | 21:58 |
| sinzui | jw4, shall I just ask CI to start again? | 21:58 |
| jw4 | sinzui: we have to update dependencies.tsv... but I just realized... charmstore will have to use the gopkg version | 21:59 |
| sinzui | :? | 21:59 |
| sinzui | Well this is a pickle | 21:59 |
| jw4 | sinzui: because it's charmstore that actually causes the transitive download of jujusvg | 21:59 |
| jw4 | sinzui: a veritable dilly of a pickle | 22:00 |
| * sinzui ponders a hack to just purge undocumented deps | 22:01 | |
| jw4 | sinzui: the good news is, it looks like the gopkg.in version works without pulling in charm.v6 | 22:01 |
| sinzui | :) | 22:02 |
| jw4 | sinzui: so now we just need to get a PR in to charmstore... | 22:02 |
| wallyworld | sinzui: i'm back now, catching up on irc croll back | 22:03 |
| Makyo | jw4, sinzui will +1 it | 22:04 |
| Makyo | I will, that is. Vague. | 22:04 |
| jw4 | Makyo: hehe | 22:04 |
| sinzui | wallyworld, jw4: My family insists we celebrate the mixed news my son got into advanced academics and the IRS sent me a $326,000 bill. When I might hack the scripts to ignore the bad package so that we can test what we have. We are not planning to releasing any of th development branches this week | 22:11 |
| jw4 | sinzui: that's crazy - congrats on one of those bits of news | 22:11 |
| sinzui | :) | 22:12 |
| jw4 | sinzui: okay - it looks like I'll need at least 2 PR's to convert to gopkg.in anyway | 22:12 |
| wallyworld | sinzui: oh wow | 22:14 |
| wallyworld | go have fun and drown your sorrows | 22:14 |
| wallyworld | surely that bill is a mistake | 22:14 |
| jw4 | Makyo: I think we're going to need the v1 branch to start right at 28683402583926ce903491c14a07cdc5cb371adb, and then I'll do a PR to update internal references to github.com/juju/jujusvg to use gopkg.in/juju/jujusvg.v1 | 22:37 |
| jw4 | Makyo: the problem is the head of the v1 branch has some breaking API changes (IconFetcher interface) that would cascade out | 22:38 |
| Makyo | jw4, ack, sounds good. | 22:39 |
| Makyo | jw4, otp, will do after | 22:39 |
| jw4 | Makyo: thanks... | 22:39 |
| jw4 | Makyo: I'll be in and out the next few hours, but appreciate it whenever you get that change in | 22:39 |
| Makyo | jw4, np, will do | 22:39 |
| Makyo | jw4, git's amazing and now that's done, I think. | 22:41 |
| jw4 | suh-weet! | 22:41 |
| jw4 | Makyo: thanks again | 22:41 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!