| === blahdeblah_ is now known as blahdeblah | ||
| blahdeblah | Morning all - what do I need to do to get https://code.launchpad.net/~paulgear/charms/trusty/ntp/fix-divide-by-zero/+merge/255660 moving? | 00:31 |
|---|---|---|
| === menn0 is now known as Guest93369 | ||
| === menn0_ is now known as menn0 | ||
| lazyPower | jrwren: ping | 10:07 |
| lazyPower | blahdeblah: diff on this MP looks pretty significant compared to what was merged | 10:08 |
| lazyPower | blahdeblah: ping me when you circle back around. The changes look related to the test suite vs the hook code - just want to verify intent of this MP | 10:09 |
| jrwren | lazyPower: pong | 11:51 |
| lazyPower | jrwren: hey dude, hi5 on this logstash charm | 11:52 |
| lazyPower | I added a UDP ruleset, and things are magical | 11:52 |
| jrwren | lazyPower: cool. | 11:52 |
| lazyPower | its using like, 40-60% fewer resources than what i have in /TRUNK as well | 11:52 |
| lazyPower | http://i.imgur.com/bTk01BM.png | 11:53 |
| jrwren | lazyPower: yes, I like small things | 11:53 |
| jrwren | lazyPower: oooh... I Love seeing that logstash icon there. :) | 11:53 |
| lazyPower | With UOS being this week - think you'll have time later on like thurs/fri to do a sync on how we can reconcile the divergence? | 11:53 |
| lazyPower | i think its just a minor patch to rules inc. from IS, + some UDP rulesets to make this charm robust in receiving from jsut about anything. | 11:54 |
| jrwren | lazyPower: yes. Thurs/Fri sounds good | 11:54 |
| lazyPower | the TCP works - but not for my application :) | 11:54 |
| lazyPower | awesome. Lets get it on the calendar so i dont flake on you. ping me with an invite when you've got an opening and i'll work around it | 11:54 |
| jrwren | i think I have some incomplete filter changes myself. | 11:54 |
| jrwren | lazyPower: my calendar is wide open, it may be easier for you to pick, but if you don't, I will :) | 11:55 |
| nevermam | when deploying a charm, I want to know the service name and the charm name, inside the hook | 12:26 |
| nevermam | LIke for eg, | 12:26 |
| nevermam | juju deploy mysql myapp-db | 12:26 |
| nevermam | I want to know the service name, inside the install hook | 12:26 |
| nevermam | is there any environment variable for the same ? | 12:27 |
| blahdeblah | lazyPower: pong | 12:35 |
| blahdeblah | lazyPower: I'm about to turn into a pumpkin, so I'll leave you some explanation here, and hopefully that will be enough; otherwise I'll try to catch you at the end of your day today. | 12:40 |
| lazyPower | nevermam: when you're in a hook context, run 'env | grep JUJU` and that will give you everything thats available to you | 12:40 |
| blahdeblah | lazyPower: I merged the current trunk into the patch to minimise the diffs from my perspective; apologies if that makes it trickier to read the diff. | 12:41 |
| lazyPower | blahdeblah: no worries - teh lions share of the changes appear to be in a test file , i spent a good 15 minutes staring at it before i moved on -but i will circle back and get you another review. | 12:41 |
| blahdeblah | lazyPower: which test file is that? I didn't think I had added that, but I could be wrong. | 12:42 |
| * blahdeblah looks again | 12:42 | |
| lazyPower | files/nagios/check_ntpmon.py | 12:42 |
| blahdeblah | That's not a test file; that's a Nagios check | 12:43 |
| blahdeblah | That is the problem component against which the bug was reported | 12:43 |
| blahdeblah | Bug #1441704 | 12:43 |
| lazyPower | ah, explains why i thought that :) I thought you were doing a health-check in a test | 12:43 |
| mup | Bug #1441704: check_ntpmon.py tries to divide by 0 if there is no peer in sync <ntp (Juju Charms Collection):Fix Committed by paulgear> <https://launchpad.net/bugs/1441704> | 12:43 |
| lazyPower | I'll deploy + validate this later and get feedback on it. Thanks for confirming intent | 12:44 |
| blahdeblah | lazyPower: Short backstory: I wrote the Nagios check for NTP because we couldn't find any existing ones that actually were useful, plus I wanted something to work on to improve my python. | 12:45 |
| blahdeblah | lazyPower: And axino is pretty good finding bugs in my python, so I've been fixing them and adding tests for them as we find new issues when we deploy it. | 12:46 |
| blahdeblah | lazyPower: The diff is a bit bleh to read; you may find it easier to just read the upstream code (I've just updated the link to it in the MP) and take my word for it that it's a verbatim copy of upstream. :-) | 12:47 |
| * blahdeblah ejects for the evening | 12:47 | |
| === kadams54 is now known as kadams54-away | ||
| === kadams54-away is now known as kadams54 | ||
| === kadams54 is now known as kadams54-away | ||
| === mhall119 is now known as mhall119|afk | ||
| === mhall119|afk is now known as mhall119 | ||
| === kadams54 is now known as kadams54-away | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
