=== blahdeblah_ is now known as blahdeblah [00:31] Morning all - what do I need to do to get https://code.launchpad.net/~paulgear/charms/trusty/ntp/fix-divide-by-zero/+merge/255660 moving? === menn0 is now known as Guest93369 === menn0_ is now known as menn0 [10:07] jrwren: ping [10:08] blahdeblah: diff on this MP looks pretty significant compared to what was merged [10:09] blahdeblah: ping me when you circle back around. The changes look related to the test suite vs the hook code - just want to verify intent of this MP [11:51] lazyPower: pong [11:52] jrwren: hey dude, hi5 on this logstash charm [11:52] I added a UDP ruleset, and things are magical [11:52] lazyPower: cool. [11:52] its using like, 40-60% fewer resources than what i have in /TRUNK as well [11:53] http://i.imgur.com/bTk01BM.png [11:53] lazyPower: yes, I like small things [11:53] lazyPower: oooh... I Love seeing that logstash icon there. :) [11:53] With UOS being this week - think you'll have time later on like thurs/fri to do a sync on how we can reconcile the divergence? [11:54] i think its just a minor patch to rules inc. from IS, + some UDP rulesets to make this charm robust in receiving from jsut about anything. [11:54] lazyPower: yes. Thurs/Fri sounds good [11:54] the TCP works - but not for my application :) [11:54] awesome. Lets get it on the calendar so i dont flake on you. ping me with an invite when you've got an opening and i'll work around it [11:54] i think I have some incomplete filter changes myself. [11:55] lazyPower: my calendar is wide open, it may be easier for you to pick, but if you don't, I will :) [12:26] when deploying a charm, I want to know the service name and the charm name, inside the hook [12:26] LIke for eg, [12:26] juju deploy mysql myapp-db [12:26] I want to know the service name, inside the install hook [12:27] is there any environment variable for the same ? [12:35] lazyPower: pong [12:40] lazyPower: I'm about to turn into a pumpkin, so I'll leave you some explanation here, and hopefully that will be enough; otherwise I'll try to catch you at the end of your day today. [12:40] nevermam: when you're in a hook context, run 'env | grep JUJU` and that will give you everything thats available to you [12:41] lazyPower: I merged the current trunk into the patch to minimise the diffs from my perspective; apologies if that makes it trickier to read the diff. [12:41] blahdeblah: no worries - teh lions share of the changes appear to be in a test file , i spent a good 15 minutes staring at it before i moved on -but i will circle back and get you another review. [12:42] lazyPower: which test file is that? I didn't think I had added that, but I could be wrong. [12:42] * blahdeblah looks again [12:42] files/nagios/check_ntpmon.py [12:43] That's not a test file; that's a Nagios check [12:43] That is the problem component against which the bug was reported [12:43] Bug #1441704 [12:43] ah, explains why i thought that :) I thought you were doing a health-check in a test [12:43] Bug #1441704: check_ntpmon.py tries to divide by 0 if there is no peer in sync [12:44] I'll deploy + validate this later and get feedback on it. Thanks for confirming intent [12:45] lazyPower: Short backstory: I wrote the Nagios check for NTP because we couldn't find any existing ones that actually were useful, plus I wanted something to work on to improve my python. [12:46] lazyPower: And axino is pretty good finding bugs in my python, so I've been fixing them and adding tests for them as we find new issues when we deploy it. [12:47] lazyPower: The diff is a bit bleh to read; you may find it easier to just read the upstream code (I've just updated the link to it in the MP) and take my word for it that it's a verbatim copy of upstream. :-) [12:47] * blahdeblah ejects for the evening === kadams54 is now known as kadams54-away === kadams54-away is now known as kadams54 === kadams54 is now known as kadams54-away === mhall119 is now known as mhall119|afk === mhall119|afk is now known as mhall119 === kadams54 is now known as kadams54-away